* [PATCH] BaseTools: Fix python error with --genfds-multi-thread. [not found] <20180509085932.1032-1-derek.lin2@hpe.com> @ 2018-05-09 9:03 ` Lin, Derek (HPS UEFI Dev) 2018-05-11 0:15 ` Zhu, Yonghong 0 siblings, 1 reply; 3+ messages in thread From: Lin, Derek (HPS UEFI Dev) @ 2018-05-09 9:03 UTC (permalink / raw) To: edk2-devel@lists.01.org; +Cc: yonghong.zhu@intel.com, Lin, Derek (HPS UEFI Dev) When self.Alignment is None, it ran into python error since there is no strip() in None. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Derek Lin <derek.lin2@hpe.com> --- BaseTools/Source/Python/GenFds/GuidSection.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/GenFds/GuidSection.py b/BaseTools/Source/Python/GenFds/GuidSection.py index 1105689e0d..6cadff0bd2 100644 --- a/BaseTools/Source/Python/GenFds/GuidSection.py +++ b/BaseTools/Source/Python/GenFds/GuidSection.py @@ -2,7 +2,7 @@ # process GUIDed section generation # # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR> -# +# Copyright (c) 2018, Hewlett Packard Enterprise Development, L.P.<BR> # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License # which accompanies this distribution. The full text of the license may be found at @@ -273,7 +273,7 @@ class GuidSection(GuidSectionClassObject) : self.Alignment = None self.IncludeFvSection = False self.ProcessRequired = "TRUE" - if IsMakefile and self.Alignment.strip() == '0': + if IsMakefile and self.Alignment is not None and self.Alignment.strip() == '0': self.Alignment = '1' return OutputFileList, self.Alignment -- 2.15.1.windows.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] BaseTools: Fix python error with --genfds-multi-thread. 2018-05-09 9:03 ` [PATCH] BaseTools: Fix python error with --genfds-multi-thread Lin, Derek (HPS UEFI Dev) @ 2018-05-11 0:15 ` Zhu, Yonghong 0 siblings, 0 replies; 3+ messages in thread From: Zhu, Yonghong @ 2018-05-11 0:15 UTC (permalink / raw) To: Lin, Derek (HPS UEFI Dev), edk2-devel@lists.01.org Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> Best Regards, Zhu Yonghong -----Original Message----- From: Lin, Derek (HPS UEFI Dev) [mailto:derek.lin2@hpe.com] Sent: Wednesday, May 09, 2018 5:03 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Lin, Derek (HPS UEFI Dev) <derek.lin2@hpe.com> Subject: [PATCH] BaseTools: Fix python error with --genfds-multi-thread. When self.Alignment is None, it ran into python error since there is no strip() in None. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Derek Lin <derek.lin2@hpe.com> --- BaseTools/Source/Python/GenFds/GuidSection.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/GenFds/GuidSection.py b/BaseTools/Source/Python/GenFds/GuidSection.py index 1105689e0d..6cadff0bd2 100644 --- a/BaseTools/Source/Python/GenFds/GuidSection.py +++ b/BaseTools/Source/Python/GenFds/GuidSection.py @@ -2,7 +2,7 @@ # process GUIDed section generation # # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR> -# +# Copyright (c) 2018, Hewlett Packard Enterprise Development, L.P.<BR> # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License # which accompanies this distribution. The full text of the license may be found at @@ -273,7 +273,7 @@ class GuidSection(GuidSectionClassObject) : self.Alignment = None self.IncludeFvSection = False self.ProcessRequired = "TRUE" - if IsMakefile and self.Alignment.strip() == '0': + if IsMakefile and self.Alignment is not None and self.Alignment.strip() == '0': self.Alignment = '1' return OutputFileList, self.Alignment -- 2.15.1.windows.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <20180509073901.15208-1-derek.lin2@hpe.com>]
* [PATCH] BaseTools: Fix python error with --genfds-multi-thread. [not found] <20180509073901.15208-1-derek.lin2@hpe.com> @ 2018-05-09 7:49 ` Lin, Derek (HPS UEFI Dev) 0 siblings, 0 replies; 3+ messages in thread From: Lin, Derek (HPS UEFI Dev) @ 2018-05-09 7:49 UTC (permalink / raw) To: edk2-devel@lists.01.org; +Cc: yonghong.zhu@intel.com, Lin, Derek (HPS UEFI Dev) From: Lin, Derek (HPS UEFI Dev) Sent: Wednesday, May 9, 2018 3:39 PM To: Lin, Derek (HPS UEFI Dev) <derek.lin2@hpe.com> Subject: [PATCH] BaseTools: Fix python error with --genfds-multi-thread. When self.Alignment is None, it ran into python error since there is no strip() in None. --- BaseTools/Source/Python/GenFds/GuidSection.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/GenFds/GuidSection.py b/BaseTools/Source/Python/GenFds/GuidSection.py index 1105689e0d..6cadff0bd2 100644 --- a/BaseTools/Source/Python/GenFds/GuidSection.py +++ b/BaseTools/Source/Python/GenFds/GuidSection.py @@ -2,7 +2,7 @@ # process GUIDed section generation # # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR> -# +# Copyright (c) 2018, Hewlett Packard Enterprise Development, L.P.<BR> # This program and the accompanying materials # are licensed and made available under the terms and conditions of the BSD License # which accompanies this distribution. The full text of the license may be found at @@ -273,7 +273,7 @@ class GuidSection(GuidSectionClassObject) : self.Alignment = None self.IncludeFvSection = False self.ProcessRequired = "TRUE" - if IsMakefile and self.Alignment.strip() == '0': + if IsMakefile and self.Alignment is not None and self.Alignment.strip() == '0': self.Alignment = '1' return OutputFileList, self.Alignment -- 2.15.1.windows.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-11 0:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180509085932.1032-1-derek.lin2@hpe.com>
2018-05-09 9:03 ` [PATCH] BaseTools: Fix python error with --genfds-multi-thread Lin, Derek (HPS UEFI Dev)
2018-05-11 0:15 ` Zhu, Yonghong
[not found] <20180509073901.15208-1-derek.lin2@hpe.com>
2018-05-09 7:49 ` Lin, Derek (HPS UEFI Dev)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox