From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Neutral (access neither permitted nor denied) identity=mailfrom; client-ip=104.47.40.130; helo=nam03-co1-obe.outbound.protection.outlook.com; envelope-from=paulo@hp.com; receiver=edk2-devel@lists.01.org Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0130.outbound.protection.outlook.com [104.47.40.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D441321F3B3FB for ; Fri, 27 Oct 2017 11:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=HP.onmicrosoft.com; s=selector1-hp-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ufDzD2cLHHqWoHDQqGaythxnJIljtKl6oyzhPqLptMo=; b=e/5n1XiKMF7kWrgNenT1Crmeqlencogu7mc9aK5SKK3Gav6uhFXqQYjfQe032MTcCgdrXyTX1XmoaZApWqGAJYSfdI4d7cCxBPHgaC1NJ+IrmlARAxjDdQhMiWcE/+SHP4EFBE5eswpiS3bEKm0xN1oNMgzL2nHNZoyTg5Fis00= Received: from CS1PR8401MB0711.NAMPRD84.PROD.OUTLOOK.COM (10.169.15.20) by CS1PR8401MB0712.NAMPRD84.PROD.OUTLOOK.COM (10.169.15.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.156.4; Fri, 27 Oct 2017 18:50:39 +0000 Received: from CS1PR8401MB0711.NAMPRD84.PROD.OUTLOOK.COM ([fe80::7114:3500:ad18:c859]) by CS1PR8401MB0711.NAMPRD84.PROD.OUTLOOK.COM ([fe80::7114:3500:ad18:c859%17]) with mapi id 15.20.0156.006; Fri, 27 Oct 2017 18:50:39 +0000 From: "Alcantara, Paulo" To: "Carsey, Jaben" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" Thread-Topic: [PATCH] ShellPkg: Fix type mismatch with GCC Thread-Index: AQHTT0Ai4yw6kLAQ60Kzk0atpazDV6L4Ba2AgAAAnCw= Date: Fri, 27 Oct 2017 18:50:38 +0000 Message-ID: References: , In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=paulo@hp.com; x-originating-ip: [2804:7f4:c480:c753::1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CS1PR8401MB0712; 6:28FNht1pWQg0gZc/DJIQ5w2wVPJ//hx+aQ4AcQmNPJ4C0sJQ3yrmdfDrg2BROwZxYoN6JrCGcy/b1cTwcxKPC67p/gdY2a+ehsmHspYhQMv6Gr8kZqjM6fvJB9GZSeRfEIQdqA08kvU6PMrjumv6fgNgf0Q7nMOy3mAQMNwbJdqLcXRBt5qpOB0sOTuzyORYsjeT/SzsiqChRtN66Jg2WVfjQVonpzFCN8Puavr+WMvR3yTq5XsihYQ0Woils/aSP6keDS6l7DPKIU2bbPgbUbB4aFbbBSXs3q5MBvcMi3HstaD394T3tkuRX9TfW2jxiuhFx/aQd9vAHhYoLvrztw==; 5:8jN0UFy9CKPQ/PVF0FH2e1e/RdLchUrN9MDM3qOk+29b/GVSkWqwimCWspslAcM73x0DUo5ZTBtoN/rvjkhnFYiJ/McNI4aAgQ2pcoRbw1cNqpWBDR/vacHtglEKM+b7228pAd2xyZHIlh2aAAjUJA==; 24:gMxT+4t8NARTAI5Zq2cct+Iyf+2xkieWumc1kSVcEbpcdFDqpVJu0/Qw+ptuyHz+4IUFeInE7QWGZip3D3gQb5CS3TuzRvOYQSj/0Np7EKg=; 7:87cUVqgfwU+x0JFU4OYcCRSALR3naygri9B6prcxjcMiz4fFiCNsQst4PVMUMBfZK62jRhYm4vX0gCpzNDwUt9qRl0t7D+J5KXuwZ959t/dwYwN/P78/RyKIBy9b0VzlmAC5T4GyXDp4Ymr8GPsi3jiHzH5n9wLAx1n9MWUolcOIz1a6/FWJm7J4mtmAzlLAhAHJYxywkaMLGcG+9kgshD2PXlbBJedQeBbUK6c5Y8w= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: dc1eafd8-898a-4d0b-ca4e-08d51d6b9de0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(2017052603199); SRVR:CS1PR8401MB0712; x-ms-traffictypediagnostic: CS1PR8401MB0712: x-exchange-antispam-report-test: UriScan:(162533806227266)(228905959029699)(73583498263828); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(3231020)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123562025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CS1PR8401MB0712; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CS1PR8401MB0712; x-forefront-prvs: 0473A03F3F x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(346002)(39860400002)(376002)(189002)(13464003)(199003)(6602003)(14454004)(189998001)(102836003)(2950100002)(8676002)(55016002)(5250100002)(3660700001)(6116002)(316002)(5660300001)(478600001)(50986999)(105586002)(54356999)(110136005)(3280700002)(8936002)(101416001)(81156014)(4326008)(106356001)(76176999)(81166006)(6436002)(53936002)(74316002)(305945005)(33656002)(25786009)(9686003)(86362001)(7736002)(2900100001)(6506006)(53546010)(7696004)(97736004)(68736007)(2501003)(2906002)(229853002)(6246003)(19627235001); DIR:OUT; SFP:1102; SCL:1; SRVR:CS1PR8401MB0712; H:CS1PR8401MB0711.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: hp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: hp.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc1eafd8-898a-4d0b-ca4e-08d51d6b9de0 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2017 18:50:38.9004 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: ca7981a2-785a-463d-b82a-3db87dfc3ce6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0712 Subject: Re: [PATCH] ShellPkg: Fix type mismatch with GCC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 18:46:54 -0000 Content-Language: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Hi Jaben, No, we can't. InternalCharToUpper() is declared internally in BaseLib and u= nexported. The comment above the declaration in UefiShellLevel2CommandsLib.c explains = it: /** Be lazy and borrow from baselib. @param[in] Char The character to convert to upper case. @return Char as an upper case character. **/ Thanks, Paulo ________________________________________ From: Carsey, Jaben Sent: Friday, October 27, 2017 4:33 PM To: Alcantara, Paulo; edk2-devel@lists.01.org Cc: Ni, Ruiyu Subject: RE: [PATCH] ShellPkg: Fix type mismatch with GCC Are we redefining a function from BaseLib? Why not remove the redundant de= finition instead of making it match? -Jaben > -----Original Message----- > From: Paulo Alcantara [mailto:paulo@hp.com] > Sent: Friday, October 27, 2017 9:24 AM > To: edk2-devel@lists.01.org > Cc: Paulo Alcantara ; Carsey, Jaben > ; Ni, Ruiyu > Subject: [PATCH] ShellPkg: Fix type mismatch with GCC > Importance: High > > This patch fixes the following warning reported by GCC 6.3: > > /home/pcacjr/src/edk2.git/ShellPkg/Library/UefiShellLevel2CommandsLib/U > efiShellLevel2CommandsLib.c:271:1: > warning: type of =91InternalCharToUpper=92 does not match original decl > aration [-Wlto-type-mismatch] > InternalCharToUpper ( > ^ > /home/pcacjr/src/edk2.git/MdePkg/Library/BaseLib/String.c:555:1: note: > =91InternalCharToUpper=92 was previously declared here > InternalCharToUpper ( > ^ > > Cc: Jaben Carsey > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Paulo Alcantara > --- > > ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib > .c | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands > Lib.c > b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands > Lib.c > index 7948e53cfc..bab6631e15 100644 > --- > a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands > Lib.c > +++ > b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands > Lib.c > @@ -268,6 +268,7 @@ VerifyIntermediateDirectories ( > @return Char as an upper case character. > **/ > CHAR16 > +EFIAPI > InternalCharToUpper ( > IN CONST CHAR16 Char > ); > -- > 2.11.0