Re: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset

["Abner Chang" <abner.chang@hpe.com>]

Hi Maciej,
Could you please help to merge this patch? Thanks!
Abner

> -----Original Message-----
> From: Rabeda, Maciej [mailto:maciej.rabeda@linux.intel.com]
> Sent: Tuesday, September 29, 2020 9:47 PM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> devel@edk2.groups.io
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>; Fu Siyuan <siyuan.fu@intel.com>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> Subject: Re: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared
> when reset
> 
> Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> 
> On 28-Sep-20 08:29, Abner Chang wrote:
> > BZ #2909,
> > INVALID URI REMOVED
> > e.org_show-5Fbug.cgi-3Fid-
> 3D2909&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_
> >
> SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=gVilLut38Vw51w0YX
> bkL2XI7A
> > ieZI7M-
> u7_bYls4zQo&s=eavHqEkeSVmQnn5EYDmq9TnEyjp8MS3_hdpPDgG9hSY&e=
> >
> > When Http->Configure() is invoked with HttpConfigData set to NULL to
> > reset the EFI HTTP instance, TLS child instance is destroyed but
> > HttpInstance->TlsChildHandle is not set to NULL. After reconfiguring
> > HTTP through Http->Configure() and sending the HTTP request to HTTPS
> > URL, TLS child instance is not recreated because
> > HttpInstance->TlsChildHandle is not NULL.
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >
> > Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> > Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> > Cc: Fu Siyuan <siyuan.fu@intel.com>
> > Cc: Nickle Wang <nickle.wang@hpe.com>
> > ---
> >   NetworkPkg/HttpDxe/HttpProto.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/NetworkPkg/HttpDxe/HttpProto.c
> > b/NetworkPkg/HttpDxe/HttpProto.c index 3c7c6ff9f0c..afc7db5a726
> 100644
> > --- a/NetworkPkg/HttpDxe/HttpProto.c
> > +++ b/NetworkPkg/HttpDxe/HttpProto.c
> > @@ -873,6 +873,7 @@ HttpCleanProtocol (
> >       // Destroy the TLS instance.
> >       //
> >       HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb,
> > HttpInstance->TlsChildHandle);
> > +    HttpInstance->TlsChildHandle = NULL;
> >     }
> >
> >     if (HttpInstance->Tcp4ChildHandle != NULL) {