From: "Abner Chang" <abner.chang@hpe.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"hao.a.wu@intel.com" <hao.a.wu@intel.com>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
Andrew Fish <afish@apple.com>, Laszlo Ersek <lersek@redhat.com>,
Leif Lindholm <leif@nuviainc.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Wang, Nickle (HPS SW)" <nickle.wang@hpe.com>,
"O'Hanley, Peter (EXL)" <peter.ohanley@hpe.com>
Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
Date: Tue, 24 Nov 2020 01:30:30 +0000 [thread overview]
Message-ID: <CS1PR8401MB1144071621FB87F85FD7E8E3FFFB0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <BN8PR11MB36660DAF64A579E4CD0177D3CAFB0@BN8PR11MB3666.namprd11.prod.outlook.com>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Tuesday, November 24, 2020 9:20 AM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Andrew Fish <afish@apple.com>;
> Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Wang, Nickle (HPS SW)
> <nickle.wang@hpe.com>; O'Hanley, Peter (EXL) <peter.ohanley@hpe.com>
> Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port
>
> > -----Original Message-----
> > From: Abner Chang <abner.chang@hpe.com>
> > Sent: Monday, November 23, 2020 9:47 PM
> > To: devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> > <hao.a.wu@intel.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek
> > <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; Kinney,
> > Michael D <michael.d.kinney@intel.com>; Nickle Wang
> > <nickle.wang@hpe.com>; Peter O'Hanley <peter.ohanley@hpe.com>
> > Subject: [PATCH 0/3] JsonLib: jansson edk2 port
> >
> > This set of pactehs is sent for the comments on edk2 JSON library.
> > edk2 JSON library is based on jansson open source
> > (https://github.com/akheron/jansson) and wrapped as an edk2 library.
> > edk2 JsonLib will be used by edk2 Redfish feature drivers (not
> > contributed yet)
>
>
> Hello,
>
> Sorry for possibly missing previous discussions on the Redfish feature.
> I am wondering is it more straight-forward to put the JsonLib together with
> the Readfish codes under RedfishPkg?
Hi Hao,
The idea is JSON is not the representation of data payload for Redfish only and JsonLib could be not only for Redfish neither. Any applications which use JSON as data payload can leverage JsonLib.
Thanks
Abner
>
> Best Regards,
> Hao Wu
>
>
> > and the edk2 port of libredfish library (not contributed yet) based on
> > DMTF GitHub (https://github.com/DMTF/libredfish).
> >
> > You will encounterred the build error with the jansson library pointed
> > in submoudle (v2.13.1) and the fix is already submitted to jansson
> > open source (https://github.com/akheron/jansson/pull/558).
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Nickle Wang <nickle.wang@hpe.com>
> > Cc: Peter O'Hanley <peter.ohanley@hpe.com>
> >
> > Abner Chang (3):
> > edk2: jansson submodule of JSON library
> > MdeModulePkg/library: EDK2 port jansson library
> > MdeModulePkg: Add EDK2 port jansson library
> >
> > .gitmodules | 3 +
> > MdeModulePkg/Include/Library/JsonLib.h | 596 +++++++++++++
> > .../Library/JsonLib/JanssonCrtLibSupport.c | 705 +++++++++++++++
> > .../Library/JsonLib/JanssonCrtLibSupport.h | 198 +++++
> > MdeModulePkg/Library/JsonLib/JsonLib.c | 805
> ++++++++++++++++++
> > MdeModulePkg/Library/JsonLib/JsonLib.inf | 81 ++
> > MdeModulePkg/Library/JsonLib/JsonUtilities.c | 417 +++++++++
> > MdeModulePkg/Library/JsonLib/JsonUtilities.h | 69 ++
> > MdeModulePkg/Library/JsonLib/assert.h | 11 +
> > MdeModulePkg/Library/JsonLib/errno.h | 11 +
> > MdeModulePkg/Library/JsonLib/jansson | 1 +
> > MdeModulePkg/Library/JsonLib/jansson_config.h | 57
> > ++ .../Library/JsonLib/jansson_private_config.h | 19 +
> > MdeModulePkg/Library/JsonLib/limits.h | 11 +
> > MdeModulePkg/Library/JsonLib/math.h | 11 +
> > MdeModulePkg/Library/JsonLib/stdarg.h | 11 +
> > MdeModulePkg/Library/JsonLib/stddef.h | 11 +
> > MdeModulePkg/Library/JsonLib/stdio.h | 11 +
> > MdeModulePkg/Library/JsonLib/stdlib.h | 11 +
> > MdeModulePkg/Library/JsonLib/string.h | 11 +
> > MdeModulePkg/Library/JsonLib/sys/time.h | 11 +
> > MdeModulePkg/Library/JsonLib/sys/types.h | 10 +
> > MdeModulePkg/Library/JsonLib/time.h | 11 +
> > MdeModulePkg/MdeModulePkg.dec | 7 +-
> > MdeModulePkg/MdeModulePkg.dsc | 4 +-
> > ReadMe.rst | 1 +
> > 26 files changed, 3092 insertions(+), 2 deletions(-) create mode
> > 100644 MdeModulePkg/Include/Library/JsonLib.h
> > create mode 100644
> > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.c
> > create mode 100644
> > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.h
> > create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.c
> > create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.inf
> > create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.c
> > create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.h
> > create mode 100644 MdeModulePkg/Library/JsonLib/assert.h
> > create mode 100644 MdeModulePkg/Library/JsonLib/errno.h
> > create mode 160000 MdeModulePkg/Library/JsonLib/jansson
> > create mode 100644 MdeModulePkg/Library/JsonLib/jansson_config.h
> > create mode 100644
> > MdeModulePkg/Library/JsonLib/jansson_private_config.h
> > create mode 100644 MdeModulePkg/Library/JsonLib/limits.h
> > create mode 100644 MdeModulePkg/Library/JsonLib/math.h
> > create mode 100644 MdeModulePkg/Library/JsonLib/stdarg.h
> > create mode 100644 MdeModulePkg/Library/JsonLib/stddef.h
> > create mode 100644 MdeModulePkg/Library/JsonLib/stdio.h
> > create mode 100644 MdeModulePkg/Library/JsonLib/stdlib.h
> > create mode 100644 MdeModulePkg/Library/JsonLib/string.h
> > create mode 100644 MdeModulePkg/Library/JsonLib/sys/time.h
> > create mode 100644 MdeModulePkg/Library/JsonLib/sys/types.h
> > create mode 100644 MdeModulePkg/Library/JsonLib/time.h
> >
> > --
> > 2.17.1
>
>
>
>
>
next prev parent reply other threads:[~2020-11-24 1:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 13:47 [PATCH 0/3] JsonLib: jansson edk2 port Abner Chang
2020-11-23 13:47 ` [PATCH 1/3] edk2: jansson submodule of JSON library Abner Chang
2020-11-23 23:32 ` Laszlo Ersek
2020-11-24 1:13 ` [edk2-devel] " Abner Chang
2020-11-23 13:47 ` [PATCH 2/3] MdeModulePkg/library: EDK2 port jansson library Abner Chang
2020-11-23 13:47 ` [PATCH 3/3] MdeModulePkg: Add " Abner Chang
2020-11-24 1:19 ` [PATCH 0/3] JsonLib: jansson edk2 port Wu, Hao A
2020-11-24 1:30 ` Abner Chang [this message]
2020-11-24 1:50 ` [edk2-devel] " Wu, Hao A
2020-11-24 2:02 ` Abner Chang
2020-11-25 3:19 ` 回复: " gaoliming
2020-11-26 0:40 ` Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CS1PR8401MB1144071621FB87F85FD7E8E3FFFB0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox