From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web10.10272.1618390686558827396 for ; Wed, 14 Apr 2021 01:58:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=JesCQ9MV; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0738e09fff=abner.chang@hpe.com) Received: from pps.filterd (m0134420.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13E8hf3S000540; Wed, 14 Apr 2021 08:52:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=uLnMT9eooDc1KDhnKtR/lp6NNlwQOCnYINm2+nM/CuM=; b=JesCQ9MVLrIfHedvVX8tJEl8v92eM5In1jx9dZG3XGSkJolq+0BvPLEOkx+y9IOoXKiC lgl8lLKIi7/PcTYlwTeo+P/7tW/VAl5kqJN8o3EERDiCQD8hPOsCp67/yBflbM970qrO 8iaskjxbgh9GLzSEyyVs96yl+IxPpkiaDhyn4i5OSoNAe5k1m8BCEBMDKxgpaJH4tOOo QQJ6jqId52H5hNluFW5Z5D9+MXvYfAnqRurpiQNFuU3haTzNlfGFRBgvB9NQhQ6WjO5W 0SvW+6T95kWYqZLkVv7mIJEut/V7WdW6rfy1ioRs+8tK3ZGLzcDHyAptwPfMhfxmxoGM Sg== Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 37wrcb236w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Apr 2021 08:52:51 +0000 Received: from G4W9120.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.210.21.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id 18D7571; Wed, 14 Apr 2021 08:52:50 +0000 (UTC) Received: from G2W6310.americas.hpqcorp.net (2002:10c5:4034::10c5:4034) by G4W9120.americas.hpqcorp.net (2002:10d2:150f::10d2:150f) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 14 Apr 2021 08:52:49 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (15.241.52.11) by G2W6310.americas.hpqcorp.net (16.197.64.52) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 14 Apr 2021 08:52:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HroKxE5AfEafoRFKImTGlSKXQY6fpDEo5Nqt3dLlrApCKzWuwk0dNxGcpiBlXBqtGB7qbQJDMXtMKBoZPwuJxBsFrOVFWHBIaW4wBumiJJF3dLsYSZyLJOK50wZt53F7dPVhkGxSodO3Btvg/f5CNoWgmXY5UK74NKhB+fq+G8Od1ODrCHxgF0wAS+5HKfcbmVqVRE8mfzojHfeGbNcifl9IIES250EjARsOCjApY+3o2Bdf1TWkHbSg827RbcviIGRX4tte4ep26LfiSbCmB0Ojm+B8wGrSAzatzc+5LQTGm0MZ60Tlqkf4ug8vNY4HY8r4A4AnhK43M4+zG/nbiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gi6y/NrBVtyBqw1vLGua3+r4JF7mihf+MHdIj+t7W6w=; b=b+St694WKgSYmwWeh5KCnUNjut5r3uVfOr0+/bNjuhhGVNBQYjeCUIedeLDt0My4RNawa6Ben67SILCfFGJXl2FkbCRjq/qh66MEUIkiJCUNyKRksWplMvdBpi7f4erClQwYKPGhm98vytL4q302+OillpuflMIiRyUg3R5Onv3viO6mreZEVg/vCIK99JRZ0N7bMssgufZ2j4se00E/LrM0zFxjFVvpfKRLzhyqlYg97vkToaimIivPXTQgfvgjU2K5mHiD+YvQlCs1W7ys5J3ggWHIc4maEKqfbkzPOZ1NpMh5YDD6JQ2+04hdUzP8GoDitU0xDYJbH14q3bIl+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB0997.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7510::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.20; Wed, 14 Apr 2021 08:52:47 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::28f5:3e45:17cf:9231]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::28f5:3e45:17cf:9231%10]) with mapi id 15.20.4020.022; Wed, 14 Apr 2021 08:52:47 +0000 From: "Abner Chang" To: Michael D Kinney , "devel@edk2.groups.io" CC: Liming Gao , Zhiguang Liu , Andrew Fish Subject: Re: [Patch v2 1/4] MdePkg/Include: Allow CPU specific defines to be predefined Thread-Topic: [Patch v2 1/4] MdePkg/Include: Allow CPU specific defines to be predefined Thread-Index: AQHXMN4yM83y34+xJU6zQ/FcSUMaxKqztTrw Date: Wed, 14 Apr 2021 08:52:47 +0000 Message-ID: References: <20210414032758.1818-1-michael.d.kinney@intel.com> <20210414032758.1818-2-michael.d.kinney@intel.com> In-Reply-To: <20210414032758.1818-2-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 11948038-8bc6-45a3-d4e2-08d8ff22ad87 x-ms-traffictypediagnostic: CS1PR8401MB0997: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6qx+CKxKB58EbdK/fpaQ8yJIHZZ57q5wuHv5YBOo2/Yn5rMnkjV8WPoi/W4q8r9D7Cj0RxEpCnXwykZlJkj15Ji2NaFRBSvsH/OEn+3Yb2znanrI9IMY57gUqAoUhqPVV0ybaitMCNyRd+411d7xLaPTBcChrz9fZyX8WGCL7UaAhNPIuVPFBrpj8HKmqzjjOw+oLe1KqwaG089UQH25V5SeFH4dpR/B821tXSj0GeQx50GpBxcZ+NyQ1c8UvlmRqXWmzobr9zQCdDDhp3hDUPzaJ+GVBVDNj01ZWdQFOHyNRbCxWh5D9JZiPVeKPHAOQRdCd/S3uVfcswzeqXL2z3wbpjTSRhhzYzFWA/VKYD5JZ9Kuti91kpdhSihcK6tlEg93z/29nPAot6oY+5Th2/jQ6PXyjE16z1KWpziyOytdbpGXWvsGPTSqeTDQqJ5OpNfPDZ/eS2MLRSmqmeTfP3TnvoxpS9P1AnBILMqonV3CsvFWoeceuxnFo7UQ7dzbKbpFU5XIn9E+5NiiRnCmKc+l0QExXoFrRD9OGN9C4GPdcCBOB8ZQTpdMsYTJDiDlon7GkGbolIED6JzFgalH/VHb12lVYumf/rITIKAO3hkuNgzZVCDd+PBnCP6W8VqPscO50S7/3KgrxxE4tCZZPaNwPpt/OcPV9ZHK8Mv82h/MVccuqXvaZvm2hl5jKt5P x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(396003)(366004)(136003)(39860400002)(346002)(376002)(26005)(4326008)(71200400001)(33656002)(122000001)(52536014)(66556008)(2906002)(5660300002)(966005)(55016002)(66476007)(6506007)(38100700002)(478600001)(66446008)(8676002)(54906003)(83380400001)(186003)(76116006)(64756008)(110136005)(316002)(8936002)(86362001)(9686003)(66946007)(7696005)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?CMK/YXBFDCBT6zp7M2p6VamFz0vp8inwhH4T0n/j5YDuMGHKa1//CzppJAwO?= =?us-ascii?Q?OGnkcdxumIbPZWdt1/aHkfzAVrFPbyNwFKTnxNpLmNPOW78ad/Hm6K32GkGH?= =?us-ascii?Q?kcZeOUh6xj3GfzMFwHjtSxuAoOwLFGh3UKoNSmaegu3jXbfqDC2PVyfeGOiK?= =?us-ascii?Q?1oA/+toznZQNKIveJT89qp/6VDZslAn7Qqq51ziPKqd+tzvPxNnpLRYAKslG?= =?us-ascii?Q?EF6dg94DPUxfblcV3vkIYPb2HRc55/R/UChtJv93A9Y8NIPtFaL5VvQMfwcy?= =?us-ascii?Q?vnagOsNg1IxXkD2c9O/wQkAoLAKMg7AAFYyP3wTC2P/dhG/yHn6L5mAkswPm?= =?us-ascii?Q?07afynspDOSUWS5ILSlkSLQCCYdq1R2RY/VwaVUKY9kq8j4saJ8Ro2kG2hNZ?= =?us-ascii?Q?/nPA6qHZJmpSn/X8/QLMuQoiBmcD8MD2mB2Gg2HKy+4p1pxL4xLG5ZZNHERp?= =?us-ascii?Q?c39VrubXERjzNwFzKPcN15D9KOaAiB9JoxNIih6IbT3ZdjB1VL6XmGe/c6hF?= =?us-ascii?Q?LRkdIhM5OZEMPyJE3JPX6eIfgiXPuiZZ7PL2TlcLg/U0xDQJPuFjWakfdEqS?= =?us-ascii?Q?8e7TUzAfS0eIIhaTO1q6t29EkgRgEZJc0quG92H46gElFIP0orxI0LZed5xb?= =?us-ascii?Q?XeM8UHFwNu+82e56Yxez1wNweCOcxabBsKSFKm2Sf5/zRLOWz8YZTUZUwAfx?= =?us-ascii?Q?uBr1/tFceYWE10iBjyqZsZaeJLHtSfeW/3oYl9tRTSLs/ZaVTfg/HVJNeukn?= =?us-ascii?Q?Xth9s6gKxRKar/PPqKM2XGbCiifgdwXZshNCXHdSUts2k2/MoSts0vpah9l8?= =?us-ascii?Q?td72iId/vuDg3uyuS/IxpCl034/6WIUSb3WaeWPEPx07lSBuOMPEswYXWMrc?= =?us-ascii?Q?JHwguuNhK2t6H5WetD1Pxdb8Hysr9PchZy3bsFEdaUtbB6Jx1fxoOes2lHMT?= =?us-ascii?Q?uJa1KQS5mLAm3CddTndiROwl+fzAMVDH//LrnZALza1T818noRxNlQUkEXr6?= =?us-ascii?Q?TwgU0RHy0VDM8pS5DxtLUimmSsu635yKXCTGJpz+nKUczidflRXx29VOmpi7?= =?us-ascii?Q?VSz9ECRI2ZTYJ7uLVEvffODimUYWKwFxg1WwcqucPCb3R5rSPYzC6hYO8EMG?= =?us-ascii?Q?Y3iqkbSVMYh8u3NavL0Ysy4KRK1Yz0jdXfIW9qZEAxmjHGIzh7TbfdwCWv0V?= =?us-ascii?Q?3l4ajm2tL3nnryt7CDAHefL2P85pAIpR/tBD7kIljhszPProZfiab8JVZxDe?= =?us-ascii?Q?+sRqH7Du/nDWZANZ5z4qQqseJL9yzeFJzJ+EM4yiplc/TeS39EDCHOELn+r/?= =?us-ascii?Q?SlZiIqUaJ7gOVUf/hpH67z2T?= x-ms-exchange-transport-forked: True X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 11948038-8bc6-45a3-d4e2-08d8ff22ad87 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2021 08:52:47.6577 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oQwC9jsa/2hBbFZVQfcmMpiBQBWeIY1fx2EYoTxjl82OSy5j1pGhVj7Ey58CT3r8nuj5poxD8FWWL7UNmigLgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0997 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: xYJFc_zHX82sk91yClgRqp-12b_sZexT X-Proofpoint-GUID: xYJFc_zHX82sk91yClgRqp-12b_sZexT X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-04-14_03:2021-04-14,2021-04-14 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 mlxscore=0 mlxlogscore=562 impostorscore=0 priorityscore=1501 adultscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104140061 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Abner Chang > -----Original Message----- > From: Michael D Kinney [mailto:michael.d.kinney@intel.com] > Sent: Wednesday, April 14, 2021 11:28 AM > To: devel@edk2.groups.io > Cc: Liming Gao ; Zhiguang Liu > ; Andrew Fish ; Chang, Abner > (HPS SW/FW Technologist) > Subject: [Patch v2 1/4] MdePkg/Include: Allow CPU specific defines to be > predefined >=20 > REF: > INVALID URI REMOVED > d=3D3308__;!!NpxR!1Qj2WKf6yVi0SVvkJR8sf50oGmisS2iAsV7eybhBjfs_lt0- > 3X4rfKLfGiwvv78$ >=20 > The EDK II Build Specifications do not restrict the set of > CPU architectures that can be supported. Remove places in > the EDK II that assumes a fixed set of CPU architectures. >=20 > Update EFI_REMOVABLE_MEDIA_FILE_NAME to allow it to be > predefined in tools_def.txt or a DSC file [BuildOptions] > section using a *_*_*_CC_FLAGS statement. >=20 > Add support for the following two defines. If neither are > defines, then preserve the current behavior. If either is > defined, then compare these 16-bit values to Machine in the > EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) and > EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) macros. >=20 > * EFI_IMAGE_MACHINE_TYPE_VALUE > * EFI_IMAGE_MACHINE_CROSS_TYPE_VALUE >=20 > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Andrew Fish > Cc: Abner Chang > Signed-off-by: Michael D Kinney > --- > MdePkg/Include/Uefi/UefiBaseType.h | 15 ++++++++++++++- > MdePkg/Include/Uefi/UefiSpec.h | 4 +++- > 2 files changed, 17 insertions(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Include/Uefi/UefiBaseType.h > b/MdePkg/Include/Uefi/UefiBaseType.h > index 934fc07285d9..45e2aa63bb34 100644 > --- a/MdePkg/Include/Uefi/UefiBaseType.h > +++ b/MdePkg/Include/Uefi/UefiBaseType.h > @@ -1,7 +1,7 @@ > /** @file > Defines data types and constants introduced in UEFI. >=20 > -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.
> Portions copyright (c) 2011 - 2016, ARM Ltd. All rights reserved.
> Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights > reserved.
>=20 > @@ -248,6 +248,7 @@ typedef union { > #define EFI_IMAGE_MACHINE_RISCV64 0x5064 > #define EFI_IMAGE_MACHINE_RISCV128 0x5128 >=20 > +#if !defined(EFI_IMAGE_MACHINE_TYPE_VALUE) > && !defined(EFI_IMAGE_MACHINE_CROSS_TYPE_VALUE) > #if defined (MDE_CPU_IA32) >=20 > #define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) \ > @@ -294,5 +295,17 @@ typedef union { > #else > #error Unknown Processor Type > #endif > +#else > +#if defined (EFI_IMAGE_MACHINE_TYPE_VALUE) > +#define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) ((Machine) =3D=3D > EFI_IMAGE_MACHINE_TYPE_VALUE) > +#else > +#define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) (FALSE) > +#endif > +#if defined (EFI_IMAGE_MACHINE_CROSS_TYPE_VALUE) > +#define EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) > ((Machine) =3D=3D EFI_IMAGE_MACHINE_CROSS_TYPE_VALUE) > +#else > +#define EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED(Machine) (FALSE) > +#endif > +#endif >=20 > #endif > diff --git a/MdePkg/Include/Uefi/UefiSpec.h > b/MdePkg/Include/Uefi/UefiSpec.h > index 2b1b72d86286..8aeaebc44fd8 100644 > --- a/MdePkg/Include/Uefi/UefiSpec.h > +++ b/MdePkg/Include/Uefi/UefiSpec.h > @@ -5,7 +5,7 @@ > If a code construct is defined in the UEFI 2.7 specification it must be > included > by this include file. >=20 > -Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.
> Portions Copyright (c) 2020, Hewlett Packard Enterprise Development LP. = All > rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -2211,6 +2211,7 @@ typedef struct { > #define EFI_REMOVABLE_MEDIA_FILE_NAME_AARCH64 > L"\\EFI\\BOOT\\BOOTAA64.EFI" > #define EFI_REMOVABLE_MEDIA_FILE_NAME_RISCV64 > L"\\EFI\\BOOT\\BOOTRISCV64.EFI" >=20 > +#if !defined(EFI_REMOVABLE_MEDIA_FILE_NAME) > #if defined (MDE_CPU_IA32) > #define EFI_REMOVABLE_MEDIA_FILE_NAME > EFI_REMOVABLE_MEDIA_FILE_NAME_IA32 > #elif defined (MDE_CPU_X64) > @@ -2225,6 +2226,7 @@ typedef struct { > #else > #error Unknown Processor Type > #endif > +#endif >=20 > // > // The directory within the active EFI System Partition defined for deli= very of > capsule to firmware > -- > 2.31.1.windows.1