From: "Abner Chang" <abner.chang@hpe.com>
To: gaoliming <gaoliming@byosoft.com.cn>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: 'Dandan Bi' <dandan.bi@intel.com>,
'Eric Dong' <eric.dong@intel.com>,
"'Gao, Liming'" <liming.gao@intel.com>
Subject: Re: [edk2-devel] [VFR support REST_STYLE PATCH v3 3/4] MdeModulePkg/Library: Revise HiiLib to support REST_STYLE
Date: Fri, 6 Nov 2020 03:36:03 +0000 [thread overview]
Message-ID: <CS1PR8401MB1144133674F6C3BEC7AF6462FFED0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <002301d6b314$e2016b70$a6044250$@byosoft.com.cn>
Fixed in v4 patch set.
thanks
> -----Original Message-----
> From: gaoliming [mailto:gaoliming@byosoft.com.cn]
> Sent: Thursday, November 5, 2020 9:42 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Cc: 'Dandan Bi' <dandan.bi@intel.com>; 'Eric Dong' <eric.dong@intel.com>;
> 'Gao, Liming' <liming.gao@intel.com>
> Subject: 回复: [edk2-devel] [VFR support REST_STYLE PATCH v3 3/4]
> MdeModulePkg/Library: Revise HiiLib to support REST_STYLE
>
> This patch is to check REST_STYLE flag. I think the commit message may be
> check REST_STYLE flag.
>
> > -----邮件原件-----
> > 发件人: bounce+27952+66976+4905953+8761045@groups.io
> > <bounce+27952+66976+4905953+8761045@groups.io> 代表 Abner Chang
> > 发送时间: 2020年11月4日 16:21
> > 收件人: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang@hpe.com>
> > 抄送: 'Dandan Bi' <dandan.bi@intel.com>; 'Eric Dong'
> <eric.dong@intel.com>;
> > Gao, Liming <liming.gao@intel.com>
> > 主题: Re: [edk2-devel] [VFR support REST_STYLE PATCH v3 3/4]
> > MdeModulePkg/Library: Revise HiiLib to support REST_STYLE
> >
> > Sorry, forget to CC reviewers.
> >
> > Abner
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > > Of Abner Chang
> > > Sent: Wednesday, November 4, 2020 2:36 PM
> > > To: devel@edk2.groups.io
> > > Subject: [edk2-devel] [VFR support REST_STYLE PATCH v3 3/4]
> > > MdeModulePkg/Library: Revise HiiLib to support REST_STYLE
> > >
> > > Add REST_STYLE support
> > >
> > > Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
> > > Signed-off-by: Ting Ye <ting.ye@intel.com>
> > > Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
> > > Signed-off-by: Fan Wang <fan.wang@intel.com>
> > > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > > ---
> > > MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 14 +++++++-------
> > > 1 file changed, 7 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> > > b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> > > index 564169bc14..57602828fe 100644
> > > --- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> > > +++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c
> > > @@ -3605,7 +3605,7 @@ HiiCreateCheckBoxOpCode (
> > > EFI_IFR_CHECKBOX OpCode;
> > > UINTN Position;
> > >
> > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) == 0);
> > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_REST_STYLE))) == 0);
> > >
> > > ZeroMem (&OpCode, sizeof (OpCode));
> > > OpCode.Question.QuestionId = QuestionId;
> > > @@ -3674,7 +3674,7 @@ HiiCreateNumericOpCode (
> > > UINTN Position;
> > > UINTN Length;
> > >
> > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) == 0);
> > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_REST_STYLE))) == 0);
> > >
> > > Length = 0;
> > > ZeroMem (&OpCode, sizeof (OpCode)); @@ -3773,7 +3773,7 @@
> > > HiiCreateStringOpCode (
> > > EFI_IFR_STRING OpCode;
> > > UINTN Position;
> > >
> > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) == 0);
> > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_REST_STYLE))) == 0);
> > >
> > > ZeroMem (&OpCode, sizeof (OpCode));
> > > OpCode.Question.Header.Prompt = Prompt;
> > > @@ -3841,7 +3841,7 @@ HiiCreateOneOfOpCode (
> > > UINTN Length;
> > >
> > > ASSERT (OptionsOpCodeHandle != NULL);
> > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_OPTIONS_ONLY))) == 0);
> > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_REST_STYLE | EFI_IFR_FLAG_OPTIONS_ONLY))) == 0);
> > >
> > > ZeroMem (&OpCode, sizeof (OpCode));
> > > OpCode.Question.Header.Prompt = Prompt;
> > > @@ -3912,7 +3912,7 @@ HiiCreateOrderedListOpCode (
> > > UINTN Position;
> > >
> > > ASSERT (OptionsOpCodeHandle != NULL);
> > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_OPTIONS_ONLY))) == 0);
> > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_REST_STYLE | EFI_IFR_FLAG_OPTIONS_ONLY))) == 0);
> > >
> > > ZeroMem (&OpCode, sizeof (OpCode));
> > > OpCode.Question.Header.Prompt = Prompt;
> > > @@ -4009,7 +4009,7 @@ HiiCreateDateOpCode (
> > > EFI_IFR_DATE OpCode;
> > > UINTN Position;
> > >
> > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) == 0);
> > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_REST_STYLE))) == 0);
> > > ASSERT ((DateFlags & (~(EFI_QF_DATE_YEAR_SUPPRESS |
> > > EFI_QF_DATE_MONTH_SUPPRESS | EFI_QF_DATE_DAY_SUPPRESS |
> > > EFI_QF_DATE_STORAGE))) == 0);
> > >
> > > ZeroMem (&OpCode, sizeof (OpCode)); @@ -4074,7 +4074,7 @@
> > > HiiCreateTimeOpCode (
> > > EFI_IFR_TIME OpCode;
> > > UINTN Position;
> > >
> > > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) == 0);
> > > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY |
> > > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED |
> > > EFI_IFR_FLAG_REST_STYLE))) == 0);
> > > ASSERT ((TimeFlags & (~(QF_TIME_HOUR_SUPPRESS |
> > > QF_TIME_MINUTE_SUPPRESS | QF_TIME_SECOND_SUPPRESS |
> > > QF_TIME_STORAGE))) == 0);
> > >
> > > ZeroMem (&OpCode, sizeof (OpCode));
> > > --
> > > 2.17.1
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
>
>
next prev parent reply other threads:[~2020-11-06 3:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 6:35 [VFR support REST_STYLE PATCH v3 0/4] VFR support REST_STYLE Abner Chang
2020-11-04 6:35 ` [VFR support REST_STYLE PATCH v3 1/4] MdePkg: Add GUID for REST Style Formset Abner Chang
2020-11-04 6:35 ` [VFR support REST_STYLE PATCH v3 2/4] BaseTools/VfrCompile: VFR compiler supports REST_STYLE in HII option Abner Chang
2020-11-04 6:35 ` [VFR support REST_STYLE PATCH v3 3/4] MdeModulePkg/Library: Revise HiiLib to support REST_STYLE Abner Chang
2020-11-04 6:35 ` [VFR support REST_STYLE PATCH v3 4/4] MdeModulePkg/DriverSampleDxe: Add HII sample options Abner Chang
2020-11-05 1:45 ` 回复: [edk2-devel] " gaoliming
2020-11-06 3:38 ` Abner Chang
[not found] ` <16443D0E1EA9DC18.19640@groups.io>
2020-11-04 8:20 ` [edk2-devel] [VFR support REST_STYLE PATCH v3 3/4] MdeModulePkg/Library: Revise HiiLib to support REST_STYLE Abner Chang
2020-11-05 1:42 ` 回复: " gaoliming
2020-11-06 3:36 ` Abner Chang [this message]
[not found] ` <16444047FB902DE3.7719@groups.io>
2020-11-04 8:27 ` Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CS1PR8401MB1144133674F6C3BEC7AF6462FFED0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox