public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Abner Chang" <abner.chang@hpe.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Chang, Abner (HPS SW/FW Technologist)" <abner.chang@hpe.com>,
	"spbrogan@outlook.com" <spbrogan@outlook.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	"Wang, Nickle (HPS SW)" <nickle.wang@hpe.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Leif Lindholm <leif@nuviainc.com>
Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build
Date: Thu, 8 Oct 2020 03:56:57 +0000	[thread overview]
Message-ID: <CS1PR8401MB1144137534A7DDA3AB6E38D1FF0B0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <163BDF0D4D469E1C.12039@groups.io>

Add Laszlo and Leif to aware of this conversation.

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Thursday, October 8, 2020 9:09 AM
> To: devel@edk2.groups.io; spbrogan@outlook.com
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v6
> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
> 
> Ok thanks for clarifying this!
> 
> I think the entire series of patch for the initial version of RedfishPkg is all
> good now. I will push my part (1/4) and please help to push 2/4 and 3/4, with
> your feedback tag is better because v6 has updates on pr-gate-build-job.yml.
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Sean
> > Sent: Thursday, October 8, 2020 9:01 AM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang@hpe.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> > Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 3/4]
> > .azurepipelines/templates: Add RedfishPkg to target build
> >
> > thats correct.  The grouping in the "matrix" is just to load balance
> > the servers when CI/PR gates run.
> >
> >
> >
> > On 10/7/2020 5:59 PM, Abner Chang wrote:
> > > Hi Sean and Bret,
> > > The v6 update for .azurepiplines is to put RedfishPkg together with
> > Network in the TARGET_NETWORK? Is that ok RedfishPkg is involved in
> > TARGET_NETWORK CI test? I think it should be fine right? They don't
> > impact each other when developers are working on these two packages
> separately.
> > >
> > >> -----Original Message-----
> > >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > >> Of Abner Chang
> > >> Sent: Wednesday, October 7, 2020 10:16 AM
> > >> To: devel@edk2.groups.io
> > >> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > >> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > >> <michael.d.kinney@intel.com>; Liming Gao
> > >> <gaoliming@byosoft.com.cn>; Wang, Nickle (HPS SW)
> > >> <nickle.wang@hpe.com>
> > >> Subject: [edk2-devel] [RedfishPkg PATCH v6
> > 3/4] .azurepipelines/templates:
> > >> Add RedfishPkg to target build
> > >>
> > >> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > >> Cc: Sean Brogan <sean.brogan@microsoft.com>
> > >> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > >> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > >> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > >> Cc: Nickle Wang <nickle.wang@hpe.com>
> > >> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > >> ---
> > >>   .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
> > >>   1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > >> b/.azurepipelines/templates/pr-gate-build-job.yml
> > >> index 2683687a1c..89c632c0a7 100644
> > >> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > >> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > >> @@ -31,7 +31,7 @@ jobs:
> > >>           Build.Pkgs: 'MdeModulePkg'
> > >>           Build.Targets: 'RELEASE,NO-TARGET'
> > >>         TARGET_NETWORK:
> > >> -        Build.Pkgs: 'NetworkPkg'
> > >> +        Build.Pkgs: 'NetworkPkg,RedfishPkg'
> > >>           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > >>         TARGET_OTHER:
> > >>           Build.Pkgs: 'PcAtChipsetPkg,ShellPkg'
> > >> --
> > >> 2.17.1
> > >>
> > >>
> > >>
> > >>
> > >>
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> 
> 
> 
> 
> 


  parent reply	other threads:[~2020-10-08  3:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07  2:15 [RedfishPkg PATCH v6 0/4] Inital RedfishPkg Abner Chang
2020-10-07  2:15 ` [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of RedfishPkg Abner Chang
2020-10-07  9:30   ` Leif Lindholm
2020-10-07 16:29   ` Michael D Kinney
2020-10-08  1:44     ` Abner Chang
     [not found]     ` <163BE1007D20ADD8.22371@groups.io>
2020-10-08 12:58       ` [edk2-devel] " Abner Chang
2020-10-07  2:15 ` [RedfishPkg PATCH v6 2/4] .pytool: Add CI on RedfishPkg Abner Chang
2020-10-07  2:15 ` [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
2020-10-07 10:54   ` [edk2-devel] " Laszlo Ersek
2020-10-07  2:15 ` [RedfishPkg PATCH v6 4/4] edk2: Add maintainers to RedfishPkg Abner Chang
2020-10-07 16:28   ` [edk2-devel] " Michael D Kinney
2020-10-07 10:49 ` [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg Laszlo Ersek
2020-10-07 11:23   ` Abner Chang
2020-10-07 15:00     ` Abner Chang
2020-10-07 15:48     ` Laszlo Ersek
     [not found] ` <163B968D94C2410C.25576@groups.io>
2020-10-08  0:59   ` [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
2020-10-08  1:00     ` Sean
2020-10-08  1:08       ` Abner Chang
     [not found]       ` <163BDF0D4D469E1C.12039@groups.io>
2020-10-08  3:56         ` Abner Chang [this message]
2020-10-14 13:30           ` Abner Chang
     [not found]           ` <163DDF075C4BB2E8.14646@groups.io>
2020-10-15  1:19             ` Abner Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CS1PR8401MB1144137534A7DDA3AB6E38D1FF0B0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox