From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web10.3205.1618279002849751231 for ; Mon, 12 Apr 2021 18:56:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=BtuKsp56; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0737d9f25c=abner.chang@hpe.com) Received: from pps.filterd (m0150242.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13D1sItX030705; Tue, 13 Apr 2021 01:56:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=MjixxuWz+1oT9k2EcUQHXZXj2Dof0DLXn7o4q1eBtcc=; b=BtuKsp565nXBp1jQRSyQSKoYVFKksJvYO05jYwy6e7Y4LTouNYSUJGF7dOVHj2zF0Rw3 uXEi/a9DoSoq+noENERTleipzTWFiqKdHdWEy1gfinhwr4d47Ni0chPw77wcwCWsiJWd GB/7PabBYmfZeRalLCSDyZUUf56CvKLRhfALjykpti/+DSEf/PrusewEqVWDxNvTrGot A5VCBQA9jUIpcTJtq4BCNKrH61r3I2jxjxXz+4Ts1wR/8hBASJq5hZuI9cwjMriux+XD hWuEHcwJ6vUpwipkRKd27WjhBW9T50+464muRGb5srM1R/DwUl+w6XqLZGd2MHb2FXSh RA== Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0a-002e3701.pphosted.com with ESMTP id 37vr1q447e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Apr 2021 01:56:32 +0000 Received: from G9W8455.americas.hpqcorp.net (g9w8455.houston.hp.com [16.216.161.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5009.houston.hpe.com (Postfix) with ESMTPS id C7D8D55; Tue, 13 Apr 2021 01:56:31 +0000 (UTC) Received: from G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) by G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 13 Apr 2021 01:56:31 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (15.241.52.13) by G9W8455.americas.hpqcorp.net (16.216.161.94) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 13 Apr 2021 01:56:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dKXU+eEsNAcQZr6cEho56vNG8FUOploMyMi2jeikrV33Ewtnv1Q6HTENiO8EFQq6HWU77U3h/sC/5nEYtFB1YiM1TCwUifyOuj5a2YvBY2hAQtOTElleUR8kJX0Hsb1FaYDWuAVgq5ezhbtcamDUXlMn8iAffTu0adYOsHayvz+bALVUqC8C4HSF7qfiQ0n2FpcnZUC4nyFkEAHSmear0LUe9E8hXDyKFImq9F5kbEvgJAIqaL0WNcAmkP61+/lB7eODax26jvfQuPsIM7o+BZFLcV2+Na0NfY6dbGB5DrO3iTqyB95Hu4OMezreAOkp3vhgGXV9qBpqffTVFMJY1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZAHOp9zKSZVxBXE4c1up1q9YOtUcT1Twg9FSKft7/YY=; b=g3xgDKcEz6yhJNKMg5A+9ya1i4ovJa2i/LmtvDaLSdcJaGMPaiRRTmt4UdN18Eyfu7Fb4/zRK2/8QpA51H/G652XmMOI7z+Ybp8hWIZ/yludHs4CinSxPSvtfWNJ5Llkp63+IYrkPSjOliYZ9HhqrRZrdr2sbO6/SHhb9agl5VewJs47YKZeK/te00WTnyQTZ2H3/JO90rr6CF5zC8kRAJOD8J/nPUYYl82ePD1kjTtIyhJTIxMCLD6N8jp+5B+qZUfxDIAASieIwsnqEG5r4wy3AfZQ2+KsfCdxGOb3deyUUQ67YpleL4BP4aC9vwo6YNRF8XMGYmF3MKHBsx4mqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB0469.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7507::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Tue, 13 Apr 2021 01:56:30 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::28f5:3e45:17cf:9231]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::28f5:3e45:17cf:9231%10]) with mapi id 15.20.4020.022; Tue, 13 Apr 2021 01:56:30 +0000 From: "Abner Chang" To: Michael D Kinney , "devel@edk2.groups.io" CC: Liming Gao , Zhiguang Liu , Andrew Fish Subject: Re: [Patch 1/3] MdePkg/Include: Allow CPU specific defines to be predefined Thread-Topic: [Patch 1/3] MdePkg/Include: Allow CPU specific defines to be predefined Thread-Index: AQHXLEEJCGT0KH9Bf0yaFJWCbyGHoaqxttlA Date: Tue, 13 Apr 2021 01:56:30 +0000 Message-ID: References: <20210408063240.877-1-michael.d.kinney@intel.com> <20210408063240.877-2-michael.d.kinney@intel.com> In-Reply-To: <20210408063240.877-2-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8dab9308-f658-4c08-d70b-08d8fe1f5b60 x-ms-traffictypediagnostic: CS1PR8401MB0469: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ys25jX2T33sGWgJSd8aoZ3WISjYR+i7cxVvSgIQic5yvoewGcE2Rhx7QH+w3M1vHIaowR2j8ne0bEDg8jf4vStJpVznSJ+9w1IujbmEKrr82ogO5qZDXW+2J0EU7vWU38rGs1VIKVeHZHedhn1SxIq+ggxzP3cpYTgJqvrR9BqOl5/TS/8s84DKiwuuu5is+XKKHboPuGUaqfl4FoffDAPCcMsgO9hH+zEdKwJ9pDssOPpvEckpdEipeuU1N/Wq3R+5dcsudzD+23btm/YMkbQLmaYXUbsCEp4niypc4ftZ/JFTfCmFOHgAr19wQvvUIZOd/94lfnlCcubomv3Rs+5zF1aunsVMulZqXf96S7rpVtp2RP3QbEy4XbVyT7zJrPbN7agLunmrd64GjjVhuSexChzBh+1Ic4m9D/Ek9IMClWZU++fLmgGlagvMqLWh5hFMh45TObk4UpQFfHOCs3bF1gbeeWo6ELtsAyW/jni0bHezofFueDSIDVsGfVSEFs8jAsE5wEBw0vUXe5WrB3m2KTEKoIWQyYLq8Wu/34w5lIIZaokgv0lKSm1GDezHoo3UFUlizeNRJqX2+9gtC3yBrNtEXXSAwsTLftWsv+zjJ+XJc4ZXakSMW24UobDvyjV/vRdflAlFxDBxQS/oxUBi8bN8oEhIxvbzZXcs/EcrblRYhg+RInzGVeqN4s0xY x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(346002)(39860400002)(396003)(366004)(136003)(376002)(2906002)(6506007)(4326008)(52536014)(38100700002)(478600001)(53546011)(7696005)(64756008)(122000001)(86362001)(110136005)(54906003)(66446008)(966005)(76116006)(71200400001)(316002)(186003)(66946007)(8676002)(83380400001)(8936002)(26005)(66556008)(9686003)(33656002)(66476007)(55016002)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?BoxBaiuLi0yWvWAwg3d7NjjnzufW0pJ2knGzjTI9jF/lEYVle5cJtg3UBnHg?= =?us-ascii?Q?HPdntGxt/i+MG0kYjRi67pX+g5FLwc+zigLBxk2zOcUqbQJyNcBT8TKjRD4r?= =?us-ascii?Q?ELpdFovYw2+yFaRFdj0bUtaKNjyDVS2JB2dvE7+e2IHS2M59c15cIN9wAajj?= =?us-ascii?Q?4AaEfbOkHyic6FCwCp/nhWcBjkJRpUmpINW3oBynzhg809hSNetLgJ8taduF?= =?us-ascii?Q?+cI8oZ9Wclwu55XPmSbqkKh/ImIF5ofApJctSlcBrHKztK6CU/girNWH4L1j?= =?us-ascii?Q?LVJfUl42CK+wqxE85kzt8gtXUZqpDi85yGKbTEusXIien9Eq+Eej0BbkFzK3?= =?us-ascii?Q?T6JfL+Fe1852Ppt0eyw/QdGeBAeowFKgb5MzhdpBQRlPmNLKLQ7xuUEG6i0w?= =?us-ascii?Q?G4Tcx4TUxakCORG3IrlsFbq+nUoE7e03JG7uSNHsH04sAMWW5tCndUFSxHiv?= =?us-ascii?Q?klQ5Kbf8nBh4G/Ww7YrhGor7NaFUhVaplC9Pey/RgOc/x9F0NimdZNZcZr2v?= =?us-ascii?Q?Uf+PBqdTdKibyzS5G2zyOezz7qZeQDIFk6AvyhZqf1wTa8BJ/ELWWarqCuXU?= =?us-ascii?Q?xq+0KvQmO2vAVjYXck04evotHX7eHNi1a9imAcdWQrh3ONQN9DKQSzq3SDwp?= =?us-ascii?Q?QCCwydI4IqerVJT04u9u0ABPDzW4UBqehf2sajoSs71QFpZzLBwZnAE/x5ng?= =?us-ascii?Q?meDZFq0CDfs7f4hiCS1yiO0PwdbdY5eGyWXVhrudsvn9kdQPSF2fo3erl8Sb?= =?us-ascii?Q?8R7hZBdRkh80LpMHqd4uckg/VMWtwLi3pxfM39BrwacdihmDT+Fjp0XzhI5o?= =?us-ascii?Q?W+8wlUwJ7//QxlBxcfb9X66u3nwzF1NA1AbNZgt7t03suzDwT1OUpduOpFfB?= =?us-ascii?Q?+tfXr9Eb5JDL7pQZkfxH5b2Up17hmpLraerXf6kXyUUiI6riDKUuM9XfOjbW?= =?us-ascii?Q?Ff30AD+/BZtnWZvoXsm8fTRM5QC+xMzo7ohSFQN5uiR4yY81soc1GNp4/bAQ?= =?us-ascii?Q?QzzvObbjoQrKlg8PNr1D6nhnzymeHAMY38HnHSrt9vlihmOKrqORWO0Oug+9?= =?us-ascii?Q?evj0XafhDmE5v7JblxSxBG5MvZFO9W3d2sx76dUPFlmfKCz07pQoM3m7x1c0?= =?us-ascii?Q?5ReQICetwz2xK0A5DNaXf34wIHe4bcalz1khTDgCpL9ln04i7/7NIyL9Der4?= =?us-ascii?Q?nxI5CpzS+7a6btBqXBv2+aHQwlKBvVRNCunNEMi9wj+ilLKf1nvxh1bfNbzG?= =?us-ascii?Q?CfgMosIL3MEH5wGUc/j0I+gnm4sYXs7IMYMhTZaHUvNtSeJgQJRIfFp3EJyf?= =?us-ascii?Q?c1HQ28kiSNLHZGfeLXTNV1zn?= x-ms-exchange-transport-forked: True X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 8dab9308-f658-4c08-d70b-08d8fe1f5b60 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2021 01:56:30.1420 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1SBc8imTngu46FF1j9WpDlsl6ltDf8NVvI1/diPj/iozon8DJHYS1pWS4BmK+5KlZlOzOcjjOCy+4IrJdbFBTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0469 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: RujmtoJ9b04MDwzaVbYEv8Mg1RnUfD1V X-Proofpoint-ORIG-GUID: RujmtoJ9b04MDwzaVbYEv8Mg1RnUfD1V X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-04-12_15:2021-04-12,2021-04-12 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=872 bulkscore=0 clxscore=1015 impostorscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 mlxscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104130011 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Michael D Kinney [mailto:michael.d.kinney@intel.com] > Sent: Thursday, April 8, 2021 2:33 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Zhiguang Liu > ; Andrew Fish ; Chang, Abner > (HPS SW/FW Technologist) > Subject: [Patch 1/3] MdePkg/Include: Allow CPU specific defines to be > predefined >=20 > REF: > INVALID URI REMOVED > d=3D3308__;!!NpxR!2tD2XaYHZQmaFB9Nkxl0iin7W5JxSmdDV0VxeaVsY76lOFR > nfql_W6kvYXu66fA$ >=20 > The EDK II Build Specifications do not restrict the set of > CPU architectures that can be supported. Remove places in > the EDK II that assume a fixed set of CPU architectures. >=20 > Update the following 3 DEFINES to allow them to be predefined > on the EDK II build command line using /D flags or in DSC file > [BuildOptions] sections. >=20 > * EFI_IMAGE_MACHINE_TYPE_SUPPORTED > * EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED > * EFI_REMOVABLE_MEDIA_FILE_NAME >=20 > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Andrew Fish > Cc: Abner Chang > Signed-off-by: Michael D Kinney > --- > MdePkg/Include/Uefi/UefiBaseType.h | 4 +++- > MdePkg/Include/Uefi/UefiSpec.h | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Include/Uefi/UefiBaseType.h > b/MdePkg/Include/Uefi/UefiBaseType.h > index 934fc07285d9..92ffeb4c63d5 100644 > --- a/MdePkg/Include/Uefi/UefiBaseType.h > +++ b/MdePkg/Include/Uefi/UefiBaseType.h > @@ -1,7 +1,7 @@ > /** @file > Defines data types and constants introduced in UEFI. >=20 > -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.
> Portions copyright (c) 2011 - 2016, ARM Ltd. All rights reserved.
> Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights > reserved.
>=20 > @@ -248,6 +248,7 @@ typedef union { > #define EFI_IMAGE_MACHINE_RISCV64 0x5064 > #define EFI_IMAGE_MACHINE_RISCV128 0x5128 >=20 > +#if !defined(EFI_IMAGE_MACHINE_TYPE_SUPPORTED) What if EFI_IMAGE_MACHINE_TYPE_SUPPORTED is predefined in /D but EFI_IMAGE_= MACHINE_CROSS_TYPE_SUPPORTED is not? Throw a warning message or just fix it when build error happens? Abner > #if defined (MDE_CPU_IA32) >=20 > #define EFI_IMAGE_MACHINE_TYPE_SUPPORTED(Machine) \ > @@ -294,5 +295,6 @@ typedef union { > #else > #error Unknown Processor Type > #endif > +#endif >=20 > #endif > diff --git a/MdePkg/Include/Uefi/UefiSpec.h > b/MdePkg/Include/Uefi/UefiSpec.h > index 2b1b72d86286..8aeaebc44fd8 100644 > --- a/MdePkg/Include/Uefi/UefiSpec.h > +++ b/MdePkg/Include/Uefi/UefiSpec.h > @@ -5,7 +5,7 @@ > If a code construct is defined in the UEFI 2.7 specification it must be > included > by this include file. >=20 > -Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.
> Portions Copyright (c) 2020, Hewlett Packard Enterprise Development LP. = All > rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -2211,6 +2211,7 @@ typedef struct { > #define EFI_REMOVABLE_MEDIA_FILE_NAME_AARCH64 > L"\\EFI\\BOOT\\BOOTAA64.EFI" > #define EFI_REMOVABLE_MEDIA_FILE_NAME_RISCV64 > L"\\EFI\\BOOT\\BOOTRISCV64.EFI" >=20 > +#if !defined(EFI_REMOVABLE_MEDIA_FILE_NAME) > #if defined (MDE_CPU_IA32) > #define EFI_REMOVABLE_MEDIA_FILE_NAME > EFI_REMOVABLE_MEDIA_FILE_NAME_IA32 > #elif defined (MDE_CPU_X64) > @@ -2225,6 +2226,7 @@ typedef struct { > #else > #error Unknown Processor Type > #endif > +#endif >=20 > // > // The directory within the active EFI System Partition defined for deli= very of > capsule to firmware > -- > 2.31.1.windows.1