Re: [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build

["Abner Chang" <abner.chang@hpe.com>]

Just learned that from Liming, one of the maintainers can just create PR for the reviewed-by patch set and merge the patches even he/she is just one of maintainers in that set of patches.
I will recreate a PR those this two CI changes and merge it.

Thanks

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Wednesday, October 14, 2020 9:31 PM
> To: devel@edk2.groups.io; spbrogan@outlook.com
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Laszlo Ersek
> <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v6
> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
> 
> Hi Sean and Bret,
> I picked up patch 2/4 and 3/4 from v6 and created a PR.
> https://github.com/tianocore/edk2/pull/1013
> Are you able to take a look and set Push label to merge it? However the PR
> was closed.
> 
> Thanks
> Abner
> 
> 
> > -----Original Message-----
> > From: Chang, Abner (HPS SW/FW Technologist)
> > Sent: Thursday, October 8, 2020 11:57 AM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang@hpe.com>; spbrogan@outlook.com
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Laszlo Ersek
> > <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>
> > Subject: RE: [edk2-devel] [RedfishPkg PATCH v6 3/4]
> > .azurepipelines/templates: Add RedfishPkg to target build
> >
> > Add Laszlo and Leif to aware of this conversation.
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > > Of Abner Chang
> > > Sent: Thursday, October 8, 2020 9:09 AM
> > > To: devel@edk2.groups.io; spbrogan@outlook.com
> > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > > <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > > <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>;
> > > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> > > Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 3/4]
> > > .azurepipelines/templates: Add RedfishPkg to target build
> > >
> > > Ok thanks for clarifying this!
> > >
> > > I think the entire series of patch for the initial version of
> > > RedfishPkg is all good now. I will push my part (1/4) and please
> > > help to push 2/4 and 3/4, with your feedback tag is better because
> > > v6 has
> > updates on pr-gate-build-job.yml.
> > >
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > > > Of Sean
> > > > Sent: Thursday, October 8, 2020 9:01 AM
> > > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > > > <abner.chang@hpe.com>
> > > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > > > <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > > > <michael.d.kinney@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>;
> > > > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> > > > Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 3/4]
> > > > .azurepipelines/templates: Add RedfishPkg to target build
> > > >
> > > > thats correct.  The grouping in the "matrix" is just to load
> > > > balance the servers when CI/PR gates run.
> > > >
> > > >
> > > >
> > > > On 10/7/2020 5:59 PM, Abner Chang wrote:
> > > > > Hi Sean and Bret,
> > > > > The v6 update for .azurepiplines is to put RedfishPkg together
> > > > > with
> > > > Network in the TARGET_NETWORK? Is that ok RedfishPkg is involved
> > > > in TARGET_NETWORK CI test? I think it should be fine right? They
> > > > don't impact each other when developers are working on these two
> > > > packages
> > > separately.
> > > > >
> > > > >> -----Original Message-----
> > > > >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On
> > > > >> Behalf Of Abner Chang
> > > > >> Sent: Wednesday, October 7, 2020 10:16 AM
> > > > >> To: devel@edk2.groups.io
> > > > >> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > > > >> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > > > >> <michael.d.kinney@intel.com>; Liming Gao
> > > > >> <gaoliming@byosoft.com.cn>; Wang, Nickle (HPS SW)
> > > > >> <nickle.wang@hpe.com>
> > > > >> Subject: [edk2-devel] [RedfishPkg PATCH v6
> > > > 3/4] .azurepipelines/templates:
> > > > >> Add RedfishPkg to target build
> > > > >>
> > > > >> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > > > >> Cc: Sean Brogan <sean.brogan@microsoft.com>
> > > > >> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > > >> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > >> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > > >> Cc: Nickle Wang <nickle.wang@hpe.com>
> > > > >> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > > >> ---
> > > > >>   .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
> > > > >>   1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >>
> > > > >> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > > > >> b/.azurepipelines/templates/pr-gate-build-job.yml
> > > > >> index 2683687a1c..89c632c0a7 100644
> > > > >> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > > > >> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > > > >> @@ -31,7 +31,7 @@ jobs:
> > > > >>           Build.Pkgs: 'MdeModulePkg'
> > > > >>           Build.Targets: 'RELEASE,NO-TARGET'
> > > > >>         TARGET_NETWORK:
> > > > >> -        Build.Pkgs: 'NetworkPkg'
> > > > >> +        Build.Pkgs: 'NetworkPkg,RedfishPkg'
> > > > >>           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > > > >>         TARGET_OTHER:
> > > > >>           Build.Pkgs: 'PcAtChipsetPkg,ShellPkg'
> > > > >> --
> > > > >> 2.17.1
> > > > >>
> > > > >>
> > > > >>
> > > > >>
> > > > >>
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> 
> 
> 
> 
>