Re: [edk2-devel] [BaseTools PATCH v1] BaseTools: Add OpenSBI external definitions for RISC-V assembly build

["Abner Chang" <abner.chang@hpe.com>]

Sure YuWei,  v2 patch is sent.

Thanks
Abner

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Yuwei Chen
> Sent: Wednesday, June 17, 2020 4:51 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Schaefer, Daniel (DualStudy)
> <daniel.schaefer@hpe.com>; Leif Lindholm <leif.lindholm@linaro.org>
> Subject: Re: [edk2-devel] [BaseTools PATCH v1] BaseTools: Add OpenSBI
> external definitions for RISC-V assembly build
> 
> Hi, abner
> 
> I have a little suggestion for the patch format, it would be better if the length
> of each commit line is less than 70 characters.
> You can follow the Commit Message Format in the wiki of tianocore.
> 
> Thanks,
> Yuwei
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner
> > Chang
> > Sent: Friday, June 12, 2020 9:57 AM
> > To: devel@edk2.groups.io
> > Cc: abner.chang@hpe.com; Feng, Bob C <bob.c.feng@intel.com>; Gao,
> > Liming <liming.gao@intel.com>; Daniel Schaefer
> > <daniel.schaefer@hpe.com>; Leif Lindholm <leif.lindholm@linaro.org>
> > Subject: [edk2-devel] [BaseTools PATCH v1] BaseTools: Add OpenSBI
> > external definitions for RISC-V assembly build
> >
> > Add opensbi external definitions to RISC-V build for assembly code.
> > Use GCC5_RISCV_OPENSBI_TYPES to refer to edk2 data type for assembly
> > files instead of using opensbi data type.
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> >  BaseTools/Conf/tools_def.template | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/BaseTools/Conf/tools_def.template
> > b/BaseTools/Conf/tools_def.template
> > index 923517b5c2..8aeb8a2a64 100755
> > --- a/BaseTools/Conf/tools_def.template
> > +++ b/BaseTools/Conf/tools_def.template
> > @@ -2037,6 +2037,7 @@ DEFINE GCC5_RISCV64_CC_FLAGS               =
> > DEF(GCC5_RISCV_ALL_CC_FLAGS) DEF(GC
> >  DEFINE GCC5_RISCV64_DLINK_FLAGS            =
> > DEF(GCC5_RISCV_ALL_DLINK_FLAGS) -Wl,-melf64lriscv,--oformat=elf64-
> > littleriscv,--no-relax DEFINE GCC5_RISCV64_DLINK2_FLAGS           =
> > DEF(GCC5_RISCV_ALL_DLINK2_FLAGS) DEFINE
> GCC5_RISCV64_ASM_FLAGS =
> > DEF(GCC5_RISCV_ALL_ASM_FLAGS) -march=DEF(GCC5_RISCV64_ARCH) -
> > mcmodel=medany -mabi=lp64+DEFINE GCC_PP_FLAGS                        = -E -x
> > assembler-with-cpp -include AutoGen.h DEF(GCC5_RISCV_OPENSBI_TYPES)
> >
> ##########################################################
> > ########################## #--
> > 2.25.0
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> >
> > View/Reply Online (#61183):
> > INVALID URI REMOVED
> 3A__edk2.groups.io_g_
> >
> devel_message_61183&d=DwIFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN
> 6FZBN4Vgi4U
> >
> lkskz6qU3NYRO03nHp9P7Z5q59A3E&m=HQziIqz4xGRFswhRjSdNcWvHjUyN5
> ERpayXlIA
> > wzXVQ&s=zErLdJ3LY3S3GTWvOAUkqNPWIFoCzpYBs1z5cDrsVCY&e=
> > Mute This Topic:
> > INVALID URI REMOVED
> 3A__groups.io_mt_7483
> >
> 2499_4546272&d=DwIFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4V
> gi4Ulkskz6q
> >
> U3NYRO03nHp9P7Z5q59A3E&m=HQziIqz4xGRFswhRjSdNcWvHjUyN5ERpayXl
> IAwzXVQ&s
> > =UG89s-i8w3cuIc12SggVYjjyUFkm-qVV0jHf1QBpgJc&e=
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe:
> > INVALID URI REMOVED
> 3A__edk2.groups.io_g_
> >
> devel_unsub&d=DwIFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi
> 4Ulkskz6qU
> >
> 3NYRO03nHp9P7Z5q59A3E&m=HQziIqz4xGRFswhRjSdNcWvHjUyN5ERpayXlI
> AwzXVQ&s=
> > fL7a3sHzOxEGfYK7Nw8RAwRqQhjuOfNdhjyiGAlamyc&e=
> > [yuwei.chen@intel.com] -=-=-=-=-=-=
> 
> 
>