public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Abner Chang" <abner.chang@hpe.com>
To: Laszlo Ersek <lersek@redhat.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg
Date: Wed, 7 Oct 2020 15:00:57 +0000	[thread overview]
Message-ID: <CS1PR8401MB114433BA0538A95E2892A0A7FF0A0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CS1PR8401MB114440E9706ABEB5F2518FAAFF0A0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM>

Sorry, it's typo. Below question is to Laszlo not Leif,

>>>If the patches get the new tag from reviewers, shall I have to send the new
>>> version of patches to the mailing list which includes all of reviewer's tag?

I mean there is no more feedbacks on patches itself but just get new feedback tags from reviewers. Can we just add those tags to patches when merge it?
Or as you mentioned in the previous email "...it helps maintainers if they don't need to go back to earlier versions to hunt down feedback tags."

Thanks

> -----Original Message-----
> From: Chang, Abner (HPS SW/FW Technologist)
> Sent: Wednesday, October 7, 2020 7:24 PM
> To: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io
> Subject: RE: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg
> 
> Thanks for that information, I never read through that guidance... and I
> should.
> 
> One question Leif,
> If the patches get the new tag from reviewers, shall I have to send the new
> version of patches to the mailing list which includes all of reviewer's tag?
> 
> > -----Original Message-----
> > From: Laszlo Ersek [mailto:lersek@redhat.com]
> > Sent: Wednesday, October 7, 2020 6:49 PM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang@hpe.com>
> > Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg
> >
> > Abner,
> >
> > On 10/07/20 04:15, Abner Chang wrote:
> > > Note for v6: In patch 3/4, move RedfishPkg to TARGET_NETWORK to
> > >              save time on CI test.
> > >              In patch 1/4, add NOOPT back to RedfishPkg.dsc becasue
> > >              this change is not required in v4 pacth set.
> >
> > you really need to collect the CC's from *all* the commit messages
> > across the entire series, and manually add those to your cover letter.
> >
> > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-
> > unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23
> >
> > "This will ensure that even if a maintainer is involved in reviewing
> > one or two of your patches across the series, he or she will get a
> > copy of your cover letter, which outlines the full feature or bugfix"
> >
> > No need to repost this, but please remember it in the future.
> >
> > Thanks
> > Laszlo
> >
> > >
> > > Note for v5: Add reviewers's tags.
> > >
> > > Note for v4: NOOPT is removed from RedfishPkg.dsc and
> > >              pr-gate-build-job.yml because we don't have host-based
> > >              unit test on Redfish yet. We keep NO-TARGET for the
> > >              non build CI test on RedfishPkg.
> > >
> > > Initial version of RedfishPkg and the CI test on RedfishPkg.
> > >
> > > CI Test result:
> > > https://github.com/tianocore/edk2/pull/986
> > >
> > > There is no components in RedfishPkg in this commit, the further
> > > edk2 Redfish components will be committed base on this version.
> > >
> > > Abner Chang (4):
> > >   RedfishPkg: Initial commit of RedfishPkg.
> > >   .pytool: Add CI on RedfishPkg
> > >   .azurepipelines/templates: Add RedfishPkg to target build
> > >   edk2: Add maintainers to RedfishPkg
> > >
> > >  .../templates/pr-gate-build-job.yml           |  2 +-
> > >  .pytool/CISettings.py                         |  3 +-
> > >  Maintainers.txt                               |  5 ++
> > >  RedfishPkg/RedfishPkg.ci.yaml                 | 67 +++++++++++++++++++
> > >  RedfishPkg/RedfishPkg.dec                     | 18 +++++
> > >  RedfishPkg/RedfishPkg.dsc                     | 40 +++++++++++
> > >  6 files changed, 133 insertions(+), 2 deletions(-)  create mode
> > > 100644 RedfishPkg/RedfishPkg.ci.yaml  create mode 100644
> > > RedfishPkg/RedfishPkg.dec  create mode 100644
> > > RedfishPkg/RedfishPkg.dsc
> > >


  reply	other threads:[~2020-10-07 15:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07  2:15 [RedfishPkg PATCH v6 0/4] Inital RedfishPkg Abner Chang
2020-10-07  2:15 ` [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of RedfishPkg Abner Chang
2020-10-07  9:30   ` Leif Lindholm
2020-10-07 16:29   ` Michael D Kinney
2020-10-08  1:44     ` Abner Chang
     [not found]     ` <163BE1007D20ADD8.22371@groups.io>
2020-10-08 12:58       ` [edk2-devel] " Abner Chang
2020-10-07  2:15 ` [RedfishPkg PATCH v6 2/4] .pytool: Add CI on RedfishPkg Abner Chang
2020-10-07  2:15 ` [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
2020-10-07 10:54   ` [edk2-devel] " Laszlo Ersek
2020-10-07  2:15 ` [RedfishPkg PATCH v6 4/4] edk2: Add maintainers to RedfishPkg Abner Chang
2020-10-07 16:28   ` [edk2-devel] " Michael D Kinney
2020-10-07 10:49 ` [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg Laszlo Ersek
2020-10-07 11:23   ` Abner Chang
2020-10-07 15:00     ` Abner Chang [this message]
2020-10-07 15:48     ` Laszlo Ersek
     [not found] ` <163B968D94C2410C.25576@groups.io>
2020-10-08  0:59   ` [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
2020-10-08  1:00     ` Sean
2020-10-08  1:08       ` Abner Chang
     [not found]       ` <163BDF0D4D469E1C.12039@groups.io>
2020-10-08  3:56         ` Abner Chang
2020-10-14 13:30           ` Abner Chang
     [not found]           ` <163DDF075C4BB2E8.14646@groups.io>
2020-10-15  1:19             ` Abner Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CS1PR8401MB114433BA0538A95E2892A0A7FF0A0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox