From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web08.6639.1616672161074291558 for ; Thu, 25 Mar 2021 04:36:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=PnfDWwzB; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0718a92a40=abner.chang@hpe.com) Received: from pps.filterd (m0134422.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12PBYLZN022387; Thu, 25 Mar 2021 11:35:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=vXwa3F72tlkGfV8T8b//i1w4YlMkFORbxyvVXQ2igCQ=; b=PnfDWwzB9Ofg+lVs6HIPv3YOx4rnsHa8pxFBLp6GtCSphp7lOreAS9v6nz6NhN4X20b1 Io8T4N63Jw6hcK411JsC9sGYDgdOxSRiEaaGxhPzuxEXK1rvGfLogKG1f9S+2Ff7bUM9 0Mvg6/neGXMwWIjf7dj2d8m2l7SIwvzAq0KcQuP91FQTBondGjp/Pcir3HfiWvgGHhy5 +MF4uak7iFY49MjzxJOeGqDrY9a/dp1yqR/iLrISA0XgwDJQNby4NscuZAZJl4UPvk53 U6oNyevIdo5849JttkZ5F78NeyDSaGDlUYtNeg1k8Qidzz843ehOqjKcEKGcCL7y6Rp0 kA== Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) by mx0b-002e3701.pphosted.com with ESMTP id 37gpstscv1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Mar 2021 11:35:53 +0000 Received: from G9W8454.americas.hpqcorp.net (g9w8454.houston.hp.com [16.216.161.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5008.houston.hpe.com (Postfix) with ESMTPS id 19C9956; Thu, 25 Mar 2021 11:35:52 +0000 (UTC) Received: from G9W8453.americas.hpqcorp.net (2002:10d8:a0d3::10d8:a0d3) by G9W8454.americas.hpqcorp.net (2002:10d8:a104::10d8:a104) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 25 Mar 2021 11:35:53 +0000 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (15.241.52.10) by G9W8453.americas.hpqcorp.net (16.216.160.211) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 25 Mar 2021 11:35:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=laBe/j1wnWpEuKnDE3eUMSoiAriScWIGjd+uJvX48j+C0YPa39PeLp2EceDGZ306MCeEPKz3+TRBaVzd2VuxwaPFdLaOMK6rP38+5NpNrU3CFgrqVEvsJTsOXL1dJlAZLC/xDE/2qRq49l+CMW/jIXPwmdMcbulfuEMVJw408TPsbW7fE3jhvW4IvpS7gdz3eoBtR9VwP5CEaUl+gNWQtiz2z7XkO3iq9aiJB9ImxOrKBABsEZ8TK6wKGokD2YK5SwcVF0L549KuURRJJgs2i88EMYDR4ofe3byehw7PLKe8rVDBgRBOgIKlxyaNeX9jFGuOhJpnQpdE/f9+1OpT/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vXwa3F72tlkGfV8T8b//i1w4YlMkFORbxyvVXQ2igCQ=; b=UalImqjDVw25+sWzRfcM99c6nyk6yQkTlL08OQTJfBC5m1MfjEtgG4VN+6ZksFJxbEOOsYdyAwjQSc0jWsWoSAniNbsX+Ei8mpUj/vJE1Kaq7vZozg/6WzSeUQ9oCNZhxq0wXhKkl8VILBVcMAoX9gtXcVbQUQ/mP2Bl43OQo3l/AwgvFu9BhPG+13e8Nmi149TURadOJW/sH9jDIxVTyIMi78xfar0M00KdTT44s2AkEapqNFuYECmHPKcM/hMs5KKH/ewjj8N9RA29ySl2T+Jh9P9sh+rYaJGT6fYxugDSF4pTqvdzCJoH9eSon67ihix9lWCX2aesd5+hBO3xpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB1285.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:750a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.26; Thu, 25 Mar 2021 11:35:51 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::28f5:3e45:17cf:9231]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::28f5:3e45:17cf:9231%10]) with mapi id 15.20.3977.026; Thu, 25 Mar 2021 11:35:51 +0000 From: "Abner Chang" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Wang, Nickle (HPS SW)" , "O'Hanley, Peter (EXL)" , Liming Gao Subject: Re: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols Thread-Topic: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI Redfish protocols Thread-Index: AQHXITnZv6DhdOSedEi8BecKFHm5DaqUX6vwgAAy1eA= Date: Thu, 25 Mar 2021 11:35:51 +0000 Message-ID: References: <20210325045236.344-1-abner.chang@hpe.com> <20210325045236.344-3-abner.chang@hpe.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [1.34.113.40] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a57c82ef-999d-4804-7bf3-08d8ef8224bd x-ms-traffictypediagnostic: CS1PR8401MB1285: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: P52XScfXHiMgLyPxvkLLW+kK72Sac9UrYK+rcAU/ouU4a4UDB19BUjGI9+mjq0t+mDJyHxJavsxVKYBmrVDpAzJ6WsmLbxs3js43WzAQ293+Ejip0Fk16HAhNpIi1n4MOIlTEQnDZF42ImLa0mrC3zcl+SArDEAbB9cwCiUqBE3MkegcDseanORtSsLqaz0ZxajSnoMgeNiVufnMWfLVDebt5rTb/tSijZVvzj6aZ0CWsqpzOCNB8gUVSnbWpMyFkvVTjjO7o3L1FQBDaQW1id8BKc7qkSzwjQVMdSW887juTaFGgipE7W2pUo+U63izMxytoN4J9Ted1yMdZveq0OXxCcDwMJwG4rJX69iRlrC8k9zjr8CEWxZDNvwzn7CajALLFO+rkd5je8fd1yeVyd2VuVwlv/TXLmXgzLytBZrnWuTL4SRQzFptmMG2ay4JnJvXcW1AazhG2GAgnF35QZeEU+94F7kXTRz4a4+xxNAY2O5ACL/XTpMPhG8x7PemDgc/+4XW8zp+cBam3PiIBWLdda5G9tAMQ77DRcrMxtUrFNANa2rpJbcuB/xU/nfOdZPos64CG05NvcvZY/qNQnEnSfKNhEiyrZkiiHvt7mjbEhv7HDodcfhncPFBcTOvghGZPirvBXMCEDO4jadV9u7N2/RY2P+PrCLwba8Rwnc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(396003)(346002)(376002)(39860400002)(366004)(136003)(6506007)(7696005)(478600001)(316002)(71200400001)(8936002)(8676002)(4326008)(53546011)(52536014)(55016002)(86362001)(38100700001)(83380400001)(64756008)(66946007)(66556008)(66446008)(76116006)(33656002)(2906002)(9686003)(26005)(5660300002)(66476007)(110136005)(54906003)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?yGcX5ERVQjVa63AFSphJKwbLtjD0Z+Qf61QgS4DpIY01WseUK5OROI2pli/c?= =?us-ascii?Q?Hk3Bk1LLvJPCAOZrylKAhd/uMKCXP+6qBS/h2+WTCDdzDNF0iLwXn0jsV5e8?= =?us-ascii?Q?NmRHl37I10z+yA2HAau4bc6BIfUaRu2eOx2JqwSDjlGVy7CzNtx4BL91pJnL?= =?us-ascii?Q?Iv4JBJyPNwPe0iHFZsskReVCCKeO1NiLuzF/qipsihMruG/QACP8xkSw1qtW?= =?us-ascii?Q?p/ueN+j6ndPk3rXcTKigkQZxUEImAE/GHaKa2Yzu8FI5NjTeTALcZDZms6If?= =?us-ascii?Q?fZ4rRhGtI4cFiPijt7WLMs4nOkYYnmh5zV4yiLcw7JIK3kjTG+ncr9yEWK7p?= =?us-ascii?Q?jYqHREzgO+Fo/paKLRrgWsxPzNqHE0li4+Pv2ePpkxEEK+PpWRhurg+mofKW?= =?us-ascii?Q?sm/gN0tloZZVBPXIcqXQRYefwlHnUZpvs4fhOUmfSKnXrCVzXHxL0cYDt9Ao?= =?us-ascii?Q?evydhsklCwws5vPE5KRZM4f7QQJjzA6yPgeO7hE8Dr2a4GpjZo2O7qyuNdnS?= =?us-ascii?Q?kyRXDPTGPTv+whepxUZjctHIB4Nbda1G7t8DdXAlAjV0cTEXXEghFnYW9J0N?= =?us-ascii?Q?3EDYGMFLaMUW+DdAVhznynhv7l4N52Pwx5OtxZycxUQkWsMZoMpv2tweBPWo?= =?us-ascii?Q?Ad8zCpj23vyX5OjdvFuKEJVYto2vk+TgW4kJM6Lwqe1r7Ml+TFZpYgnYQ8RR?= =?us-ascii?Q?FdK/Lh1wBK637ev2NlCIdTA99ZYyFiREBALFVKww9sknnnbpRvB/sgxQaGAe?= =?us-ascii?Q?yOTJToQgptUdl43OoLxW5McOuqR3nWkvaar7VYMJPmY30GC2DQZB1vDIo5kb?= =?us-ascii?Q?b6+GMGW4RssyBp754d4Vde8ymmIQNiARUrM8ukyrF+izC8xYBxtN1100ZRer?= =?us-ascii?Q?kxfqxPkPxj2ONFk+hpCKTAm6p7n6meNlUixTyA3JLcTuDoj+Bj43irILPVGn?= =?us-ascii?Q?EMaFbYi6TUZgfcBIvk3uE2ndk6mZg1OApFBlf3Ok2/MmETdtEG9m0cu5e5Hz?= =?us-ascii?Q?iPq5y6+tl+gRLnyPnwK39ihpEzZnE5mN/pf6StC9rYYi3EXNK6hqSlwOtIo6?= =?us-ascii?Q?xh2VnyeQoxqaIV3FscD7fnHOSpXUhMia8GBPSi1kO0LinK97MVKfql19GfDh?= =?us-ascii?Q?6daZi2kCE5vyc+FKTUxIYJC5OClCPnClmstW0fbSYJ4t1lQFO0CoZFUTzqAd?= =?us-ascii?Q?iMPKD5q/w7C30kdQ5dTIEpZUaWf7W0wYBtCz4OAm9hONa7fWLiXbm0oy6l4O?= =?us-ascii?Q?9OCt/J+pOtghcqsDNRc3Z4LLI3aJRW7BemxxCdzUS7q+cP8hkWi7xOi3LBlu?= =?us-ascii?Q?aFg=3D?= X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: a57c82ef-999d-4804-7bf3-08d8ef8224bd X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2021 11:35:51.2170 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iPmY3RxeBUS4nN7iNxG9e14RLgZFGVdzW8ouior2Ecn/AO1fbsccUcdCnx/VLGd7bIH/6b5fzTzwVuCy36DC5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB1285 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-03-25_02:2021-03-24,2021-03-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 suspectscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103250086 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Zhichao, I resend v4 patch, in which your R-B to the previous patch is removed and L= iming is added to CC list. No others changes were made in this patches. I will send v5 with the correction on copyright. Or can I just push to mast= er with the correction and your R-B? Thanks Abner > -----Original Message----- > From: Gao, Zhichao [mailto:zhichao.gao@intel.com] > Sent: Thursday, March 25, 2021 5:09 PM > To: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io > Cc: Ni, Ray ; Wang, Nickle (HPS SW) > ; O'Hanley, Peter (EXL) ; > Liming Gao > Subject: RE: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI > Redfish protocols >=20 > First, thanks Liming's catch. >=20 > Abner, >=20 > The patch has been updated, you should remove my R-B for the V4 version. > Otherwise the reviewers/maintainers may treated it as reviewed one. > And please add the one who already gave the comment for your patch to the > Cc list. They care about the about the change and this would help them to > know the update and have a chance to view your patch in an early time. >=20 > For this patch, the copyright should be updated to 2021. With this update= d, > Reviewed-by: Zhichao Gao >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: Abner Chang > > Sent: Thursday, March 25, 2021 12:53 PM > > To: devel@edk2.groups.io > > Cc: Ni, Ray ; Gao, Zhichao ; > > Nickle Wang ; Peter O'Hanley > > > > Subject: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI > Redfish > > protocols > > > > Add handle parsing for EFI Redfish Discover protocol. > > Add handle parsing for EFI RestEx protocol. > > > > Signed-off-by: Abner Chang > > Cc: Ray Ni > > Cc: Zhichao Gao > > Cc: Nickle Wang > > Cc: Peter O'Hanley > > Reviewed-by: Zhichao Gao > > --- > > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +++- > > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 8 +++++++- > > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 4 +++- > > 3 files changed, 13 insertions(+), 3 deletions(-) > > > > diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib= .inf > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > index 93b69cd8e9..446cd8d609 100644 > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > @@ -2,7 +2,7 @@ > > # Provides interface to advanced shell functionality for parsing both > handle > > and protocol database. > > # Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved. =
# > (C) > > Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
-# > > (C) Copyright 2015 Hewlett Packard Enterprise Development LP
> > +# (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > > +LP
> > # > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -269,6 +269,8 @@ > > gEfiHttpProtocolGuid ## UNDEFINED > > gEfiHttpUtilitiesProtocolGuid ## UNDEFINED > > gEfiRestProtocolGuid ## UNDEFINED > > + gEfiRestExProtocolGuid ## UNDEFINED > > + gEfiRedfishDiscoverProtocolGuid ## UNDEFINED > > gEfiMmEndOfDxeProtocolGuid ## UNDEFINED > > gEfiMmIoTrapDispatchProtocolGuid ## UNDEFINED > > gEfiMmPowerButtonDispatchProtocolGuid ## UNDEFINED > > diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib= .c > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > index 500a95a89a..e34cefd7b4 100644 > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > @@ -3,7 +3,7 @@ > > > > Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. > > (C) Copyright 2013-2015 Hewlett-Packard Development Company, > L.P.
> > - (C) Copyright 2015-2016 Hewlett Packard Enterprise Development > LP
> > + (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > LP
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -2250,6 +2250,12 @@ STATIC CONST GUID_INFO_BLOCK > > mGuidStringList[] =3D { > > {STRING_TOKEN(STR_PARTITION_INFO), > > &gEfiPartitionInfoProtocolGuid, > > PartitionInfoProtocolDumpInformation}, > > {STRING_TOKEN(STR_HII_POPUP), &gEfiHiiPopupProtocolGuid, > > NULL}, > > > > +// > > +// UEFI 2.8 > > +// > > + {STRING_TOKEN(STR_REST_EX), &gEfiRestExProtocolGuid, > > NULL}, > > + {STRING_TOKEN(STR_REDFISH_DISCOVER), > > &gEfiRedfishDiscoverProtocolGuid, NULL}, > > + > > // > > // PI Spec ones > > // > > diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib= .uni > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > index 9c8028d0d5..69fcbdfe0e 100644 > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > @@ -2,7 +2,7 @@ > > // > > // Copyright (c) 2010 - 2017, Intel Corporation. All rights reserved. =
// > (C) > > Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
-// > > (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP
> > +// (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > > +LP
> > // SPDX-License-Identifier: BSD-2-Clause-Patent // // Module Name: > > @@ -308,6 +308,8 @@ > > #string STR_NET_HTTP #language en-US "Http" > > #string STR_NET_HTTP_U #language en-US "HttpUtilities" > > #string STR_REST #language en-US "Rest" > > +#string STR_REST_EX #language en-US "RestEx" > > +#string STR_REDFISH_DISCOVER #language en-US "RedfishDiscover" > > > > #string STR_MM_EOD #language en-US "MmEndOfDxe" > > #string STR_MM_ITD #language en-US "MmIoTrapDispatch" > > -- > > 2.17.1