Soft Feature Freeze starts now for edk2-stable202008

Soft Feature Freeze starts now for edk2-stable202008

[Liming Gao]

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

Hi, all
  We will enter into Soft Feature Freeze phase. In this phase, the feature under review will not be allowed to be pushed. The feature passed review can still be merged. Now, two features have passed code review. If no other comments, I will merge them into this stable tag. They are: https://edk2.groups.io/g/devel/message/64176 SEV-ES guest support, https://edk2.groups.io/g/devel/message/64283 Add a plugin to check Ecc issues for edk2 on open ci.

The patch review can continue without break in edk2 community. If the patch is sent before Soft Feature Freeze, and plans to catch this stable tag, the patch contributor need reply to his patch and notify edk2 community. If the patch is sent after Soft Feature Freeze, and plans to catch this stable tag, please add edk2-stable202008 key words in the patch title and BZ, so the community know this patch target and give the feedback.

Below is edk2-stable202008 tag planning https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning Proposed Schedule
Date (00:00:00 UTC-8) Description
2020-06-03  Beginning of development
2020-08-07  Feature Planning Freeze
2020-08-14  Soft Feature Freeze
2020-08-21  Hard Feature Freeze
2020-08-28  Release

Thanks
Liming

[-- Attachment #2: Type: text/html, Size: 4117 bytes --]

Re: Soft Feature Freeze starts now for edk2-stable202008

[Bret Barkelew]

[-- Attachment #1: Type: text/plain, Size: 3067 bytes --]

I would like Variable Policy to be considered for this feature freeze. I have a couple of documentation things to respond to, but no serious functionality questions (that I know of).

- Bret
________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Liming Gao via groups.io <liming.gao=intel.com@groups.io>
Sent: Friday, August 14, 2020 1:16:41 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; announce@edk2.groups.io <announce@edk2.groups.io>
Cc: Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>; afish@apple.com <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Guptha, Soumya K <soumya.k.guptha@intel.com>
Subject: [EXTERNAL] [edk2-devel] Soft Feature Freeze starts now for edk2-stable202008


Hi, all

  We will enter into Soft Feature Freeze phase. In this phase, the feature under review will not be allowed to be pushed. The feature passed review can still be merged. Now, two features have passed code review. If no other comments, I will merge them into this stable tag. They are: https://edk2.groups.io/g/devel/message/64176<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F64176&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C7c39b12ae32b4ea2fa8608d8402a648f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637329898132143799&sdata=Y25ZFmHxvCwp9uyWUSXapth2vgBHd3QL1b6N9oEBP%2Fk%3D&reserved=0> SEV-ES guest support, https://edk2.groups.io/g/devel/message/64283<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F64283&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C7c39b12ae32b4ea2fa8608d8402a648f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637329898132143799&sdata=AwuFLW5ppYmMSZDV99TB1w64X3K8NSfJ3PazkpoCktk%3D&reserved=0> Add a plugin to check Ecc issues for edk2 on open ci.



The patch review can continue without break in edk2 community. If the patch is sent before Soft Feature Freeze, and plans to catch this stable tag, the patch contributor need reply to his patch and notify edk2 community. If the patch is sent after Soft Feature Freeze, and plans to catch this stable tag, please add edk2-stable202008 key words in the patch title and BZ, so the community know this patch target and give the feedback.



Below is edk2-stable202008 tag planning https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FEDK-II-Release-Planning&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C7c39b12ae32b4ea2fa8608d8402a648f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637329898132153791&sdata=mBza%2B9zvE7beZTFsmnkCr2vp6CSRFO1e93F%2F8hB1Uiw%3D&reserved=0> Proposed Schedule

Date (00:00:00 UTC-8) Description

2020-06-03  Beginning of development

2020-08-07  Feature Planning Freeze

2020-08-14  Soft Feature Freeze

2020-08-21  Hard Feature Freeze

2020-08-28  Release



Thanks

Liming



[-- Attachment #2: Type: text/html, Size: 6008 bytes --]

Re: Soft Feature Freeze starts now for edk2-stable202008

[Laszlo Ersek]

Hi Bret,

On 08/17/20 20:14, Bret Barkelew wrote:
> I would like Variable Policy to be considered for this feature freeze. I have a couple of documentation things to respond to, but no serious functionality questions (that I know of).

Has review completed on the series (before entering the soft feature
freeze)?

https://github.com/tianocore/tianocore.github.io/wiki/SoftFeatureFreeze

(Please note that I don't insist on this particular definition of the
SFF; it's what we have modeled on the QEMU soft feature freeze
definition. It's not carved in stone. It's just what we have for now.)

Thanks
Laszlo

Re: [EXTERNAL] Re: Soft Feature Freeze starts now for edk2-stable202008

[Bret Barkelew]

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]

Not yet, which is also why I’m raising the note ASAP. I’ll respond to the other feedback today to get that moving.

- Bret

From: Laszlo Ersek<mailto:lersek@redhat.com>
Sent: Monday, August 17, 2020 1:46 PM
To: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; liming.gao<mailto:liming.gao@intel.com>; announce@edk2.groups.io<mailto:announce@edk2.groups.io>
Cc: Leif Lindholm<mailto:leif@nuviainc.com>; afish@apple.com<mailto:afish@apple.com>; Kinney, Michael D<mailto:michael.d.kinney@intel.com>; Guptha, Soumya K<mailto:soumya.k.guptha@intel.com>
Subject: [EXTERNAL] Re: Soft Feature Freeze starts now for edk2-stable202008

Hi Bret,

On 08/17/20 20:14, Bret Barkelew wrote:
> I would like Variable Policy to be considered for this feature freeze. I have a couple of documentation things to respond to, but no serious functionality questions (that I know of).

Has review completed on the series (before entering the soft feature
freeze)?

https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FSoftFeatureFreeze&amp;data=02%7C01%7Cbret.barkelew%40microsoft.com%7C39b20e742dff4f810fa708d842eea26a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637332939979144622&amp;sdata=%2BsSEmkhvkuzZqSUxNbK9cWWWnweRVmN0SG7HheLAIPc%3D&amp;reserved=0

(Please note that I don't insist on this particular definition of the
SFF; it's what we have modeled on the QEMU soft feature freeze
definition. It's not carved in stone. It's just what we have for now.)

Thanks
Laszlo


[-- Attachment #2: Type: text/html, Size: 3912 bytes --]

Re: [EXTERNAL] Re: Soft Feature Freeze starts now for edk2-stable202008

[Laszlo Ersek]

On 08/17/20 23:33, Bret Barkelew wrote:
> Not yet, which is also why I’m raising the note ASAP. I’ll respond to the other feedback today to get that moving.

During the SFF, only such feature sets may be merged whose review
completed *before* the SFF. In other words, for a feature series, only
the merging part may slip into the SFF; the review part must not.

(Again, I'm just explaining the current SFF definition. If we want to
change the SFF definition, that's a different discussion -- I'm not
particularly vested in the current one, I had just suggested it
following the pattern that QEMU had set. The edk2 community is free to
choose different definitions.)

Thanks!
Laszlo

> 
> - Bret
> 
> From: Laszlo Ersek<mailto:lersek@redhat.com>
> Sent: Monday, August 17, 2020 1:46 PM
> To: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; liming.gao<mailto:liming.gao@intel.com>; announce@edk2.groups.io<mailto:announce@edk2.groups.io>
> Cc: Leif Lindholm<mailto:leif@nuviainc.com>; afish@apple.com<mailto:afish@apple.com>; Kinney, Michael D<mailto:michael.d.kinney@intel.com>; Guptha, Soumya K<mailto:soumya.k.guptha@intel.com>
> Subject: [EXTERNAL] Re: Soft Feature Freeze starts now for edk2-stable202008
> 
> Hi Bret,
> 
> On 08/17/20 20:14, Bret Barkelew wrote:
>> I would like Variable Policy to be considered for this feature freeze. I have a couple of documentation things to respond to, but no serious functionality questions (that I know of).
> 
> Has review completed on the series (before entering the soft feature
> freeze)?
> 
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FSoftFeatureFreeze&amp;data=02%7C01%7Cbret.barkelew%40microsoft.com%7C39b20e742dff4f810fa708d842eea26a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637332939979144622&amp;sdata=%2BsSEmkhvkuzZqSUxNbK9cWWWnweRVmN0SG7HheLAIPc%3D&amp;reserved=0
> 
> (Please note that I don't insist on this particular definition of the
> SFF; it's what we have modeled on the QEMU soft feature freeze
> definition. It's not carved in stone. It's just what we have for now.)
> 
> Thanks
> Laszlo
> 
> 

Re: [EXTERNAL] Re: Soft Feature Freeze starts now for edk2-stable202008

[Bret Barkelew]

[-- Attachment #1: Type: text/plain, Size: 2960 bytes --]

I agree with the process and withdraw my request, replacing it instead with a disapproving head shake and deep sigh. I’ll go back to pushing on this after the tag.

- Bret
________________________________
From: Laszlo Ersek <lersek@redhat.com>
Sent: Tuesday, August 18, 2020 3:29:19 AM
To: Bret Barkelew <Bret.Barkelew@microsoft.com>; devel@edk2.groups.io <devel@edk2.groups.io>; liming.gao <liming.gao@intel.com>; announce@edk2.groups.io <announce@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>; afish@apple.com <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Guptha, Soumya K <soumya.k.guptha@intel.com>
Subject: Re: [EXTERNAL] Re: Soft Feature Freeze starts now for edk2-stable202008

On 08/17/20 23:33, Bret Barkelew wrote:
> Not yet, which is also why I’m raising the note ASAP. I’ll respond to the other feedback today to get that moving.

During the SFF, only such feature sets may be merged whose review
completed *before* the SFF. In other words, for a feature series, only
the merging part may slip into the SFF; the review part must not.

(Again, I'm just explaining the current SFF definition. If we want to
change the SFF definition, that's a different discussion -- I'm not
particularly vested in the current one, I had just suggested it
following the pattern that QEMU had set. The edk2 community is free to
choose different definitions.)

Thanks!
Laszlo

>
> - Bret
>
> From: Laszlo Ersek<mailto:lersek@redhat.com>
> Sent: Monday, August 17, 2020 1:46 PM
> To: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; liming.gao<mailto:liming.gao@intel.com>; announce@edk2.groups.io<mailto:announce@edk2.groups.io>
> Cc: Leif Lindholm<mailto:leif@nuviainc.com>; afish@apple.com<mailto:afish@apple.com>; Kinney, Michael D<mailto:michael.d.kinney@intel.com>; Guptha, Soumya K<mailto:soumya.k.guptha@intel.com>
> Subject: [EXTERNAL] Re: Soft Feature Freeze starts now for edk2-stable202008
>
> Hi Bret,
>
> On 08/17/20 20:14, Bret Barkelew wrote:
>> I would like Variable Policy to be considered for this feature freeze. I have a couple of documentation things to respond to, but no serious functionality questions (that I know of).
>
> Has review completed on the series (before entering the soft feature
> freeze)?
>
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FSoftFeatureFreeze&amp;data=02%7C01%7Cbret.barkelew%40microsoft.com%7C7ff8e944ced74925aade08d8436195f3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637333433692184517&amp;sdata=Z8nsDP5gMm9YR%2BFTr0sYIslXZXUA9sYgvyGH8CBKlJM%3D&amp;reserved=0
>
> (Please note that I don't insist on this particular definition of the
> SFF; it's what we have modeled on the QEMU soft feature freeze
> definition. It's not carved in stone. It's just what we have for now.)
>
> Thanks
> Laszlo
>
>


[-- Attachment #2: Type: text/html, Size: 4716 bytes --]

Re: [EXTERNAL] Re: Soft Feature Freeze starts now for edk2-stable202008

[Laszlo Ersek]

On 08/18/20 17:10, Bret Barkelew wrote:
> I agree with the process and withdraw my request, replacing it instead with a disapproving head shake and deep sigh.

We as a community definitely deserve your disapproval, as our review
response times have been abysmal. :(

> I’ll go back to pushing on this after the tag.

Thanks for your persistence!
Laszlo

Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008

[Abner Chang]

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

Hmm.. I had a one commit (which is not the feature) just reviewed by Leif but not pushing yet. Is that possible to push before the Hard Feature freeze and also be included in 202008 stable tag? I guess it gets the chance according to the article of SoftFeatureFreeze on Wiki page.
Patch attached FYR

Abner

> -----Original Message-----
> From: announce@edk2.groups.io [mailto:announce@edk2.groups.io] On
> Behalf Of Laszlo Ersek
> Sent: Wednesday, August 19, 2020 5:59 PM
> To: Bret Barkelew <Bret.Barkelew@microsoft.com>; devel@edk2.groups.io;
> liming.gao <liming.gao@intel.com>; announce@edk2.groups.io
> Cc: Leif Lindholm <leif@nuviainc.com>; afish@apple.com; Kinney, Michael D
> <michael.d.kinney@intel.com>; Guptha, Soumya K
> <soumya.k.guptha@intel.com>
> Subject: Re: [edk2-announce] [EXTERNAL] Re: Soft Feature Freeze starts
> now for edk2-stable202008
> 
> On 08/18/20 17:10, Bret Barkelew wrote:
> > I agree with the process and withdraw my request, replacing it instead with
> a disapproving head shake and deep sigh.
> 
> We as a community definitely deserve your disapproval, as our review
> response times have been abysmal. :(
> 
> > I’ll go back to pushing on this after the tag.
> 
> Thanks for your persistence!
> Laszlo
> 
> 
> 


[-- Attachment #2: 0001-EmbeddedPkg-libfdt-Add-strncmp-macro-to-use-AsciiStr.patch --]
[-- Type: application/octet-stream, Size: 1984 bytes --]

From e6531052d0185569065239087c82cec4dfc926a1 Mon Sep 17 00:00:00 2001
From: Abner Chang <abner.chang@hpe.com>
Date: Tue, 4 Aug 2020 17:06:39 +0800
Subject: [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp

For the implementation which utilizes libfdt provided in EmbeddedPkg
however it uses strncmp function in the libfdt helper library,
libfdt_env.h should provide the macro implied with edk2 strncmp
implementation.

The example is RISC-V OpenSBI library. edk2 RISC-V port uses OpenSBI
library and incorporate with edk2 libfdt. edk2 libfdt_env.h provides
the necessary macros to build OpenSBI which uses fdt functions in edk2
environment. However, OpenSBI also has libfdt helper library that uses
strncmp function which is not defined in edk2 libfdt_env.h. This commit
addresses the build issue caused by missing strncmp macro in
libfdt_env.h.

Check below three commits for the corresponding changes on OpenSBI,
https://github.com/riscv/opensbi/commit/8e47649eff96c303e02fbd58cdc6c4ed341066ec
https://github.com/riscv/opensbi/commit/2845d2d2cf4fb74a89452ba223995aa4a118c07e
https://github.com/riscv/opensbi/commit/2cfd2fc9048806353298a1b967abf985901e36e8

Signed-off-by: Abner Chang <abner.chang@hpe.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
---
 EmbeddedPkg/Include/libfdt_env.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/EmbeddedPkg/Include/libfdt_env.h b/EmbeddedPkg/Include/libfdt_env.h
index 11a9764733..7feff52bc0 100644
--- a/EmbeddedPkg/Include/libfdt_env.h
+++ b/EmbeddedPkg/Include/libfdt_env.h
@@ -76,4 +76,8 @@ static inline size_t strnlen (const char* str, size_t strsz ) {
   return AsciiStrnLenS (str, strsz);
 }
 
+static inline size_t strncmp (const char* str1, const char* str2, size_t strsz ) {
+  return AsciiStrnCmp (str1, str2, strsz);
+}
+
 #endif /* _LIBFDT_ENV_H */
-- 
2.25.0

Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008

[Leif Lindholm]

(Slightly trimmed recipient list due to different patch being discussed.)

So, I can't make this call, because I'm the one who messed up.

This patch does exactly what I had requested Abner to do some time
back (off-list, unfortunately), and I was *convinced* I gave it an R-b
as soon as it hit my inbox - until Abner nudged me about it yesterday.

The patch in question is
https://edk2.groups.io/g/devel/topic/76021725

/
    Leif

On Wed, Aug 19, 2020 at 11:29:52 +0000, Chang, Abner (HPS SW/FW Technologist) wrote:
> Hmm.. I had a one commit (which is not the feature) just reviewed by
> Leif but not pushing yet. Is that possible to push before the Hard
> Feature freeze and also be included in 202008 stable tag? I guess it
> gets the chance according to the article of SoftFeatureFreeze on
> Wiki page.
>
> Patch attached FYR
> 
> Abner
> 
> > -----Original Message-----
> > From: announce@edk2.groups.io [mailto:announce@edk2.groups.io] On
> > Behalf Of Laszlo Ersek
> > Sent: Wednesday, August 19, 2020 5:59 PM
> > To: Bret Barkelew <Bret.Barkelew@microsoft.com>; devel@edk2.groups.io;
> > liming.gao <liming.gao@intel.com>; announce@edk2.groups.io
> > Cc: Leif Lindholm <leif@nuviainc.com>; afish@apple.com; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Guptha, Soumya K
> > <soumya.k.guptha@intel.com>
> > Subject: Re: [edk2-announce] [EXTERNAL] Re: Soft Feature Freeze starts
> > now for edk2-stable202008
> > 
> > On 08/18/20 17:10, Bret Barkelew wrote:
> > > I agree with the process and withdraw my request, replacing it instead with
> > a disapproving head shake and deep sigh.
> > 
> > We as a community definitely deserve your disapproval, as our review
> > response times have been abysmal. :(
> > 
> > > I’ll go back to pushing on this after the tag.
> > 
> > Thanks for your persistence!
> > Laszlo
> > 
> > 
> > 
> 

Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008

[Laszlo Ersek]

On 08/19/20 13:48, Leif Lindholm wrote:
> (Slightly trimmed recipient list due to different patch being discussed.)
> 
> So, I can't make this call, because I'm the one who messed up.
> 
> This patch does exactly what I had requested Abner to do some time
> back (off-list, unfortunately), and I was *convinced* I gave it an R-b
> as soon as it hit my inbox - until Abner nudged me about it yesterday.
> 
> The patch in question is
> https://edk2.groups.io/g/devel/topic/76021725

My understanding is:

(1) there is an external project that consumes the FDT library in
EmbeddedPkg, meaning the lib class header "EmbeddedPkg/Include/libfdt.h"
and the lib instance "EmbeddedPkg/Library/FdtLib/FdtLib.inf",

(2) the lib class header pulls in "fdt.h" and "libfdt_env.h",

(3) the external project is not edk2-platforms,

(4) the external project wants -- for some strange reason -- edk2's
"libfdt_env.h" to provide an strncmp() function (or function-like
macro), with that particular stncmp() implementation not being needed in
either edk2-platforms or edk2 itself,

(5) the patch for adding said strncmp() was posted on Aug 6th (at least
when viewed from my time zone), i.e., before the SFF,

(6) it was reviewed 12 days later (within the SFF)

If my understanding is correct, then I don't see how this patch could be
considered a bugfix -- even as a feature addition, it seems hardly
justified to me --, and there would have been ~8 days before the SFF to
review it.

I think we should postpone the patch until after the stable tag.

Thanks
Laszlo


> On Wed, Aug 19, 2020 at 11:29:52 +0000, Chang, Abner (HPS SW/FW Technologist) wrote:
>> Hmm.. I had a one commit (which is not the feature) just reviewed by
>> Leif but not pushing yet. Is that possible to push before the Hard
>> Feature freeze and also be included in 202008 stable tag? I guess it
>> gets the chance according to the article of SoftFeatureFreeze on
>> Wiki page.
>>
>> Patch attached FYR
>>
>> Abner
>>
>>> -----Original Message-----
>>> From: announce@edk2.groups.io [mailto:announce@edk2.groups.io] On
>>> Behalf Of Laszlo Ersek
>>> Sent: Wednesday, August 19, 2020 5:59 PM
>>> To: Bret Barkelew <Bret.Barkelew@microsoft.com>; devel@edk2.groups.io;
>>> liming.gao <liming.gao@intel.com>; announce@edk2.groups.io
>>> Cc: Leif Lindholm <leif@nuviainc.com>; afish@apple.com; Kinney, Michael D
>>> <michael.d.kinney@intel.com>; Guptha, Soumya K
>>> <soumya.k.guptha@intel.com>
>>> Subject: Re: [edk2-announce] [EXTERNAL] Re: Soft Feature Freeze starts
>>> now for edk2-stable202008
>>>
>>> On 08/18/20 17:10, Bret Barkelew wrote:
>>>> I agree with the process and withdraw my request, replacing it instead with
>>> a disapproving head shake and deep sigh.
>>>
>>> We as a community definitely deserve your disapproval, as our review
>>> response times have been abysmal. :(
>>>
>>>> I’ll go back to pushing on this after the tag.
>>>
>>> Thanks for your persistence!
>>> Laszlo
>>>
>>>
>>> 
>>
> 
> 

Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008

[Abner Chang]

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Wednesday, August 19, 2020 9:19 PM
> To: Leif Lindholm <leif@nuviainc.com>; Chang, Abner (HPS SW/FW
> Technologist) <abner.chang@hpe.com>
> Cc: devel@edk2.groups.io; liming.gao <liming.gao@intel.com>;
> announce@edk2.groups.io; afish@apple.com; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-
> stable202008
> 
> On 08/19/20 13:48, Leif Lindholm wrote:
> > (Slightly trimmed recipient list due to different patch being
> > discussed.)
> >
> > So, I can't make this call, because I'm the one who messed up.
> >
> > This patch does exactly what I had requested Abner to do some time
> > back (off-list, unfortunately), and I was *convinced* I gave it an R-b
> > as soon as it hit my inbox - until Abner nudged me about it yesterday.
> >
> > The patch in question is
> > https://edk2.groups.io/g/devel/topic/76021725
> 
> My understanding is:
> 
> (1) there is an external project that consumes the FDT library in
> EmbeddedPkg, meaning the lib class header
> "EmbeddedPkg/Include/libfdt.h"
> and the lib instance "EmbeddedPkg/Library/FdtLib/FdtLib.inf",
[Chang, Abner] Yes
> 
> (2) the lib class header pulls in "fdt.h" and "libfdt_env.h",
[Chang, Abner] yes
> 
> (3) the external project is not edk2-platforms,
[Chang, Abner] yes
> 
> (4) the external project wants -- for some strange reason -- edk2's
> "libfdt_env.h" to provide an strncmp() function (or function-like macro), with
> that particular stncmp() implementation not being needed in either edk2-
> platforms or edk2 itself,
[Chang, Abner] yes, at least so far
> 
> (5) the patch for adding said strncmp() was posted on Aug 6th (at least when
> viewed from my time zone), i.e., before the SFF,
[Chang, Abner] Yes
> 
> (6) it was reviewed 12 days later (within the SFF)
[Chang, Abner] yes.
> 
> If my understanding is correct, then I don't see how this patch could be
> considered a bugfix -- even as a feature addition, it seems hardly justified to
> me --, and there would have been ~8 days before the SFF to review it.
> 
> I think we should postpone the patch until after the stable tag.
This patch is important because the edk2-stable202008 would be the stable tag (if this patch is accepted) for booting RISC-V platform to Linux kernel with EFI Runtime service on either real platform and QEMU. We can publish this information in RISC-V community which is considered as a valuable milestone for RISC-V edk2 port.

> 
> Thanks
> Laszlo
> 
> 
> > On Wed, Aug 19, 2020 at 11:29:52 +0000, Chang, Abner (HPS SW/FW
> Technologist) wrote:
> >> Hmm.. I had a one commit (which is not the feature) just reviewed by
> >> Leif but not pushing yet. Is that possible to push before the Hard
> >> Feature freeze and also be included in 202008 stable tag? I guess it
> >> gets the chance according to the article of SoftFeatureFreeze on Wiki
> >> page.
> >>
> >> Patch attached FYR
> >>
> >> Abner
> >>
> >>> -----Original Message-----
> >>> From: announce@edk2.groups.io [mailto:announce@edk2.groups.io]
> On
> >>> Behalf Of Laszlo Ersek
> >>> Sent: Wednesday, August 19, 2020 5:59 PM
> >>> To: Bret Barkelew <Bret.Barkelew@microsoft.com>;
> >>> devel@edk2.groups.io; liming.gao <liming.gao@intel.com>;
> >>> announce@edk2.groups.io
> >>> Cc: Leif Lindholm <leif@nuviainc.com>; afish@apple.com; Kinney,
> >>> Michael D <michael.d.kinney@intel.com>; Guptha, Soumya K
> >>> <soumya.k.guptha@intel.com>
> >>> Subject: Re: [edk2-announce] [EXTERNAL] Re: Soft Feature Freeze
> >>> starts now for edk2-stable202008
> >>>
> >>> On 08/18/20 17:10, Bret Barkelew wrote:
> >>>> I agree with the process and withdraw my request, replacing it
> >>>> instead with
> >>> a disapproving head shake and deep sigh.
> >>>
> >>> We as a community definitely deserve your disapproval, as our review
> >>> response times have been abysmal. :(
> >>>
> >>>> I’ll go back to pushing on this after the tag.
> >>>
> >>> Thanks for your persistence!
> >>> Laszlo
> >>>
> >>>
> >>> 
> >>
> >
> >

Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008

[Laszlo Ersek]

On 08/19/20 15:34, Chang, Abner (HPS SW/FW Technologist) wrote:
> 
> 
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Wednesday, August 19, 2020 9:19 PM
>> To: Leif Lindholm <leif@nuviainc.com>; Chang, Abner (HPS SW/FW
>> Technologist) <abner.chang@hpe.com>
>> Cc: devel@edk2.groups.io; liming.gao <liming.gao@intel.com>;
>> announce@edk2.groups.io; afish@apple.com; Kinney, Michael D
>> <michael.d.kinney@intel.com>
>> Subject: Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-
>> stable202008
>>
>> On 08/19/20 13:48, Leif Lindholm wrote:
>>> (Slightly trimmed recipient list due to different patch being
>>> discussed.)
>>>
>>> So, I can't make this call, because I'm the one who messed up.
>>>
>>> This patch does exactly what I had requested Abner to do some time
>>> back (off-list, unfortunately), and I was *convinced* I gave it an R-b
>>> as soon as it hit my inbox - until Abner nudged me about it yesterday.
>>>
>>> The patch in question is
>>> https://edk2.groups.io/g/devel/topic/76021725
>>
>> My understanding is:
>>
>> (1) there is an external project that consumes the FDT library in
>> EmbeddedPkg, meaning the lib class header
>> "EmbeddedPkg/Include/libfdt.h"
>> and the lib instance "EmbeddedPkg/Library/FdtLib/FdtLib.inf",
> [Chang, Abner] Yes
>>
>> (2) the lib class header pulls in "fdt.h" and "libfdt_env.h",
> [Chang, Abner] yes
>>
>> (3) the external project is not edk2-platforms,
> [Chang, Abner] yes
>>
>> (4) the external project wants -- for some strange reason -- edk2's
>> "libfdt_env.h" to provide an strncmp() function (or function-like macro), with
>> that particular stncmp() implementation not being needed in either edk2-
>> platforms or edk2 itself,
> [Chang, Abner] yes, at least so far
>>
>> (5) the patch for adding said strncmp() was posted on Aug 6th (at least when
>> viewed from my time zone), i.e., before the SFF,
> [Chang, Abner] Yes
>>
>> (6) it was reviewed 12 days later (within the SFF)
> [Chang, Abner] yes.
>>
>> If my understanding is correct, then I don't see how this patch could be
>> considered a bugfix -- even as a feature addition, it seems hardly justified to
>> me --, and there would have been ~8 days before the SFF to review it.
>>
>> I think we should postpone the patch until after the stable tag.
> This patch is important because the edk2-stable202008 would be the stable tag (if this patch is accepted) for booting RISC-V platform to Linux kernel with EFI Runtime service on either real platform and QEMU. We can publish this information in RISC-V community which is considered as a valuable milestone for RISC-V edk2 port.

Let's move out the dates for the stable tag then, by one week:

- let the SFF start on 2020-08-21
- let the HFF start on 2020-08-28
- let's release edk2-stable202008 on 2020-09-04

Release slips are permitted and there have been examples.

What doesn't make sense is making rules and then breaking them
opportunistically, whenever they're uncomfortable. If that's a frequent
occurrence, we should pick different rules, or -- again -- if this is a
very important patch, we should delay the release for it.

BTW what about reverting the OpenSBI change? You could still call
sbi_strncmp() -- rather than strncmp() -- in the "helper" lib.

Thanks
Laszlo

Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008

[Abner Chang]

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Wednesday, August 19, 2020 10:30 PM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; Leif
> Lindholm <leif@nuviainc.com>
> Cc: devel@edk2.groups.io; liming.gao <liming.gao@intel.com>;
> announce@edk2.groups.io; afish@apple.com; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-
> stable202008
> 
> On 08/19/20 15:34, Chang, Abner (HPS SW/FW Technologist) wrote:
> >
> >
> >> -----Original Message-----
> >> From: Laszlo Ersek [mailto:lersek@redhat.com]
> >> Sent: Wednesday, August 19, 2020 9:19 PM
> >> To: Leif Lindholm <leif@nuviainc.com>; Chang, Abner (HPS SW/FW
> >> Technologist) <abner.chang@hpe.com>
> >> Cc: devel@edk2.groups.io; liming.gao <liming.gao@intel.com>;
> >> announce@edk2.groups.io; afish@apple.com; Kinney, Michael D
> >> <michael.d.kinney@intel.com>
> >> Subject: Re: [edk2-announce] Re: Soft Feature Freeze starts now for
> >> edk2-
> >> stable202008
> >>
> >> On 08/19/20 13:48, Leif Lindholm wrote:
> >>> (Slightly trimmed recipient list due to different patch being
> >>> discussed.)
> >>>
> >>> So, I can't make this call, because I'm the one who messed up.
> >>>
> >>> This patch does exactly what I had requested Abner to do some time
> >>> back (off-list, unfortunately), and I was *convinced* I gave it an
> >>> R-b as soon as it hit my inbox - until Abner nudged me about it yesterday.
> >>>
> >>> The patch in question is
> >>> https://edk2.groups.io/g/devel/topic/76021725
> >>
> >> My understanding is:
> >>
> >> (1) there is an external project that consumes the FDT library in
> >> EmbeddedPkg, meaning the lib class header
> >> "EmbeddedPkg/Include/libfdt.h"
> >> and the lib instance "EmbeddedPkg/Library/FdtLib/FdtLib.inf",
> > [Chang, Abner] Yes
> >>
> >> (2) the lib class header pulls in "fdt.h" and "libfdt_env.h",
> > [Chang, Abner] yes
> >>
> >> (3) the external project is not edk2-platforms,
> > [Chang, Abner] yes
> >>
> >> (4) the external project wants -- for some strange reason -- edk2's
> >> "libfdt_env.h" to provide an strncmp() function (or function-like
> >> macro), with that particular stncmp() implementation not being needed
> >> in either edk2- platforms or edk2 itself,
> > [Chang, Abner] yes, at least so far
> >>
> >> (5) the patch for adding said strncmp() was posted on Aug 6th (at
> >> least when viewed from my time zone), i.e., before the SFF,
> > [Chang, Abner] Yes
> >>
> >> (6) it was reviewed 12 days later (within the SFF)
> > [Chang, Abner] yes.
> >>
> >> If my understanding is correct, then I don't see how this patch could
> >> be considered a bugfix -- even as a feature addition, it seems hardly
> >> justified to me --, and there would have been ~8 days before the SFF to
> review it.
> >>
> >> I think we should postpone the patch until after the stable tag.
> > This patch is important because the edk2-stable202008 would be the stable
> tag (if this patch is accepted) for booting RISC-V platform to Linux kernel with
> EFI Runtime service on either real platform and QEMU. We can publish this
> information in RISC-V community which is considered as a valuable milestone
> for RISC-V edk2 port.
> 
> Let's move out the dates for the stable tag then, by one week:
> 
> - let the SFF start on 2020-08-21
> - let the HFF start on 2020-08-28
> - let's release edk2-stable202008 on 2020-09-04
> 
> Release slips are permitted and there have been examples.
Appreciate for this.

> 
> What doesn't make sense is making rules and then breaking them
> opportunistically, whenever they're uncomfortable. If that's a frequent
> occurrence, we should pick different rules, or -- again -- if this is a very
> important patch, we should delay the release for it.
> 
> BTW what about reverting the OpenSBI change? You could still call
> sbi_strncmp() -- rather than strncmp() -- in the "helper" lib.
I replied this in another thread.
> 
> Thanks
> Laszlo

Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008

[Liming Gao]

> -----Original Message-----
> From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> Sent: Wednesday, August 19, 2020 10:59 PM
> To: Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>
> Cc: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; announce@edk2.groups.io; afish@apple.com; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008
> 
> 
> 
> > -----Original Message-----
> > From: Laszlo Ersek [mailto:lersek@redhat.com]
> > Sent: Wednesday, August 19, 2020 10:30 PM
> > To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; Leif
> > Lindholm <leif@nuviainc.com>
> > Cc: devel@edk2.groups.io; liming.gao <liming.gao@intel.com>;
> > announce@edk2.groups.io; afish@apple.com; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-
> > stable202008
> >
> > On 08/19/20 15:34, Chang, Abner (HPS SW/FW Technologist) wrote:
> > >
> > >
> > >> -----Original Message-----
> > >> From: Laszlo Ersek [mailto:lersek@redhat.com]
> > >> Sent: Wednesday, August 19, 2020 9:19 PM
> > >> To: Leif Lindholm <leif@nuviainc.com>; Chang, Abner (HPS SW/FW
> > >> Technologist) <abner.chang@hpe.com>
> > >> Cc: devel@edk2.groups.io; liming.gao <liming.gao@intel.com>;
> > >> announce@edk2.groups.io; afish@apple.com; Kinney, Michael D
> > >> <michael.d.kinney@intel.com>
> > >> Subject: Re: [edk2-announce] Re: Soft Feature Freeze starts now for
> > >> edk2-
> > >> stable202008
> > >>
> > >> On 08/19/20 13:48, Leif Lindholm wrote:
> > >>> (Slightly trimmed recipient list due to different patch being
> > >>> discussed.)
> > >>>
> > >>> So, I can't make this call, because I'm the one who messed up.
> > >>>
> > >>> This patch does exactly what I had requested Abner to do some time
> > >>> back (off-list, unfortunately), and I was *convinced* I gave it an
> > >>> R-b as soon as it hit my inbox - until Abner nudged me about it yesterday.
> > >>>
> > >>> The patch in question is
> > >>> https://edk2.groups.io/g/devel/topic/76021725
> > >>
> > >> My understanding is:
> > >>
> > >> (1) there is an external project that consumes the FDT library in
> > >> EmbeddedPkg, meaning the lib class header
> > >> "EmbeddedPkg/Include/libfdt.h"
> > >> and the lib instance "EmbeddedPkg/Library/FdtLib/FdtLib.inf",
> > > [Chang, Abner] Yes
> > >>
> > >> (2) the lib class header pulls in "fdt.h" and "libfdt_env.h",
> > > [Chang, Abner] yes
> > >>
> > >> (3) the external project is not edk2-platforms,
> > > [Chang, Abner] yes
> > >>
> > >> (4) the external project wants -- for some strange reason -- edk2's
> > >> "libfdt_env.h" to provide an strncmp() function (or function-like
> > >> macro), with that particular stncmp() implementation not being needed
> > >> in either edk2- platforms or edk2 itself,
> > > [Chang, Abner] yes, at least so far
> > >>
> > >> (5) the patch for adding said strncmp() was posted on Aug 6th (at
> > >> least when viewed from my time zone), i.e., before the SFF,
> > > [Chang, Abner] Yes
> > >>
> > >> (6) it was reviewed 12 days later (within the SFF)
> > > [Chang, Abner] yes.
> > >>
> > >> If my understanding is correct, then I don't see how this patch could
> > >> be considered a bugfix -- even as a feature addition, it seems hardly
> > >> justified to me --, and there would have been ~8 days before the SFF to
> > review it.
> > >>
> > >> I think we should postpone the patch until after the stable tag.
> > > This patch is important because the edk2-stable202008 would be the stable
> > tag (if this patch is accepted) for booting RISC-V platform to Linux kernel with
> > EFI Runtime service on either real platform and QEMU. We can publish this
> > information in RISC-V community which is considered as a valuable milestone
> > for RISC-V edk2 port.
> >
> > Let's move out the dates for the stable tag then, by one week:
> >
> > - let the SFF start on 2020-08-21
> > - let the HFF start on 2020-08-28
> > - let's release edk2-stable202008 on 2020-09-04
> >
> > Release slips are permitted and there have been examples.
> Appreciate for this.

Previous stable tags (202005/202002/201905) extended SFF or HFF period to let the critical bug fix catch the stable tag. 
Today case is like a new feature. According to Abner comment, it is important to RISC-V community.
If SFF start time is changed, more features may catch this stable, such as VariableLock feature.
> 
> >
> > What doesn't make sense is making rules and then breaking them
> > opportunistically, whenever they're uncomfortable. If that's a frequent
> > occurrence, we should pick different rules, or -- again -- if this is a very
> > important patch, we should delay the release for it.

I suggest to define the process on delay the release. The initial process is specified here.
The requestor provides the justification why his patch needs to catch the stable tag after SFF phase. 
All stewards make the decision whether delay the stable tag to include his patch.  
If stewards agree to delay the stable tag, and there is no objection from the community, 
the release maintainer will update edk2 release planning with new date. 
If stewards rejects to this request, there is no change in stable tag release. 

Thanks
Liming
> >
> > BTW what about reverting the OpenSBI change? You could still call
> > sbi_strncmp() -- rather than strncmp() -- in the "helper" lib.
> I replied this in another thread.
> >
> > Thanks
> > Laszlo
> 

Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008

[Laszlo Ersek]

On 08/19/20 18:20, Gao, Liming wrote:
> 
>> -----Original Message-----
>> From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
>> Sent: Wednesday, August 19, 2020 10:59 PM
>> To: Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>
>> Cc: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com>; announce@edk2.groups.io; afish@apple.com; Kinney, Michael D
>> <michael.d.kinney@intel.com>
>> Subject: RE: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008
>>
>>
>>
>>> -----Original Message-----
>>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>>> Sent: Wednesday, August 19, 2020 10:30 PM
>>> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; Leif
>>> Lindholm <leif@nuviainc.com>
>>> Cc: devel@edk2.groups.io; liming.gao <liming.gao@intel.com>;
>>> announce@edk2.groups.io; afish@apple.com; Kinney, Michael D
>>> <michael.d.kinney@intel.com>
>>> Subject: Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-
>>> stable202008
>>>
>>> On 08/19/20 15:34, Chang, Abner (HPS SW/FW Technologist) wrote:
>>>>
>>>>
>>>>> -----Original Message-----
>>>>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>>>>> Sent: Wednesday, August 19, 2020 9:19 PM
>>>>> To: Leif Lindholm <leif@nuviainc.com>; Chang, Abner (HPS SW/FW
>>>>> Technologist) <abner.chang@hpe.com>
>>>>> Cc: devel@edk2.groups.io; liming.gao <liming.gao@intel.com>;
>>>>> announce@edk2.groups.io; afish@apple.com; Kinney, Michael D
>>>>> <michael.d.kinney@intel.com>
>>>>> Subject: Re: [edk2-announce] Re: Soft Feature Freeze starts now for
>>>>> edk2-
>>>>> stable202008
>>>>>
>>>>> On 08/19/20 13:48, Leif Lindholm wrote:
>>>>>> (Slightly trimmed recipient list due to different patch being
>>>>>> discussed.)
>>>>>>
>>>>>> So, I can't make this call, because I'm the one who messed up.
>>>>>>
>>>>>> This patch does exactly what I had requested Abner to do some time
>>>>>> back (off-list, unfortunately), and I was *convinced* I gave it an
>>>>>> R-b as soon as it hit my inbox - until Abner nudged me about it yesterday.
>>>>>>
>>>>>> The patch in question is
>>>>>> https://edk2.groups.io/g/devel/topic/76021725
>>>>>
>>>>> My understanding is:
>>>>>
>>>>> (1) there is an external project that consumes the FDT library in
>>>>> EmbeddedPkg, meaning the lib class header
>>>>> "EmbeddedPkg/Include/libfdt.h"
>>>>> and the lib instance "EmbeddedPkg/Library/FdtLib/FdtLib.inf",
>>>> [Chang, Abner] Yes
>>>>>
>>>>> (2) the lib class header pulls in "fdt.h" and "libfdt_env.h",
>>>> [Chang, Abner] yes
>>>>>
>>>>> (3) the external project is not edk2-platforms,
>>>> [Chang, Abner] yes
>>>>>
>>>>> (4) the external project wants -- for some strange reason -- edk2's
>>>>> "libfdt_env.h" to provide an strncmp() function (or function-like
>>>>> macro), with that particular stncmp() implementation not being needed
>>>>> in either edk2- platforms or edk2 itself,
>>>> [Chang, Abner] yes, at least so far
>>>>>
>>>>> (5) the patch for adding said strncmp() was posted on Aug 6th (at
>>>>> least when viewed from my time zone), i.e., before the SFF,
>>>> [Chang, Abner] Yes
>>>>>
>>>>> (6) it was reviewed 12 days later (within the SFF)
>>>> [Chang, Abner] yes.
>>>>>
>>>>> If my understanding is correct, then I don't see how this patch could
>>>>> be considered a bugfix -- even as a feature addition, it seems hardly
>>>>> justified to me --, and there would have been ~8 days before the SFF to
>>> review it.
>>>>>
>>>>> I think we should postpone the patch until after the stable tag.
>>>> This patch is important because the edk2-stable202008 would be the stable
>>> tag (if this patch is accepted) for booting RISC-V platform to Linux kernel with
>>> EFI Runtime service on either real platform and QEMU. We can publish this
>>> information in RISC-V community which is considered as a valuable milestone
>>> for RISC-V edk2 port.
>>>
>>> Let's move out the dates for the stable tag then, by one week:
>>>
>>> - let the SFF start on 2020-08-21
>>> - let the HFF start on 2020-08-28
>>> - let's release edk2-stable202008 on 2020-09-04
>>>
>>> Release slips are permitted and there have been examples.
>> Appreciate for this.
> 
> Previous stable tags (202005/202002/201905) extended SFF or HFF period to let the critical bug fix catch the stable tag. 
> Today case is like a new feature. According to Abner comment, it is important to RISC-V community.
> If SFF start time is changed, more features may catch this stable, such as VariableLock feature.

Yes, exactly.

We must apply the same deadline to all features. If one feature is
important enough for delaying the SFF, then patch review for other
pending features is resumed as well.

>>
>>>
>>> What doesn't make sense is making rules and then breaking them
>>> opportunistically, whenever they're uncomfortable. If that's a frequent
>>> occurrence, we should pick different rules, or -- again -- if this is a very
>>> important patch, we should delay the release for it.
> 
> I suggest to define the process on delay the release. The initial process is specified here.
> The requestor provides the justification why his patch needs to catch the stable tag after SFF phase. 
> All stewards make the decision whether delay the stable tag to include his patch.  
> If stewards agree to delay the stable tag, and there is no objection from the community, 
> the release maintainer will update edk2 release planning with new date. 
> If stewards rejects to this request, there is no change in stable tag release. 

I'm OK with delaying the release by one or two weeks, for any feature(s)
currently pending review on the list. (If we go for two weeks, we should
likely change the name of the upcoming stable tag.)

(Some projects don't even propose cut-off dates, they say "we'll make a
release when we have enough stuff to release, and when all of those
things are complete". That's another approach to consider.)

Thanks
Laszlo

>>> BTW what about reverting the OpenSBI change? You could still call
>>> sbi_strncmp() -- rather than strncmp() -- in the "helper" lib.
>> I replied this in another thread.
>>>
>>> Thanks
>>> Laszlo
>>
> 

Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008

[Laszlo Ersek]

On 08/19/20 15:19, Laszlo Ersek wrote:
> On 08/19/20 13:48, Leif Lindholm wrote:
>> (Slightly trimmed recipient list due to different patch being discussed.)
>>
>> So, I can't make this call, because I'm the one who messed up.
>>
>> This patch does exactly what I had requested Abner to do some time
>> back (off-list, unfortunately), and I was *convinced* I gave it an R-b
>> as soon as it hit my inbox - until Abner nudged me about it yesterday.
>>
>> The patch in question is
>> https://edk2.groups.io/g/devel/topic/76021725
> 
> My understanding is:
> 
> (1) there is an external project that consumes the FDT library in
> EmbeddedPkg, meaning the lib class header "EmbeddedPkg/Include/libfdt.h"
> and the lib instance "EmbeddedPkg/Library/FdtLib/FdtLib.inf",
> 
> (2) the lib class header pulls in "fdt.h" and "libfdt_env.h",
> 
> (3) the external project is not edk2-platforms,
> 
> (4) the external project wants -- for some strange reason -- edk2's
> "libfdt_env.h" to provide an strncmp() function (or function-like
> macro), with that particular stncmp() implementation not being needed in
> either edk2-platforms or edk2 itself,
> 
> (5) the patch for adding said strncmp() was posted on Aug 6th (at least
> when viewed from my time zone), i.e., before the SFF,
> 
> (6) it was reviewed 12 days later (within the SFF)
> 
> If my understanding is correct, then I don't see how this patch could be
> considered a bugfix -- even as a feature addition, it seems hardly
> justified to me --, and there would have been ~8 days before the SFF to
> review it.
> 
> I think we should postpone the patch until after the stable tag.

Regarding OpenSBI, as of commit 9d56961b2314, the sbi_strncmp() function
has not been removed, and it seems that sbi_strncmp() is still used /
called in at least some build configurations (where the

lib/utils/libfdt/libfdt_env.h:#define strncmp           sbi_strncmp

definition is supposed to be in effect).

This means that the codebase can not rid itself of sbi_strncmp().

To me this indicates that OpenSBI commit 2cfd2fc90488 ("lib: utils: Use
strncmp in fdt_parse_hart_id()", 2020-07-29) was wrong. It should have
replaced sbi_strcmp() with sbi_strncmp(), not strncmp().

After all, the size limit seems to be the motivation for the entire
change -- put a size limit on the string comparison in
fdt_parse_hart_id(). Commit 2cfd2fc90488 did two things at the same
time: replace the size-unbounded comparison with the size-bounded one,
*and* switch to the standard C function name from the self-contained
function. The former goal looks justifiable, the latter I don't understand.

Now: I realize that, going back to edk2 commit fa4a70633868
("EmbeddedPkg: Added support to libfdt", 2012-09-27), we already have a
bunch of wrappers in "EmbeddedPkg/Include/libfdt_env.h". So I guess
adding "one more" is not inconsistent with those -- even though the lib
instance within edk2 doesn't need the new function.

But it's still a micro-feature whose review should have completed before
the SFF.

Thanks
Laszlo

Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008

[Abner Chang]

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Wednesday, August 19, 2020 9:37 PM
> To: Leif Lindholm <leif@nuviainc.com>; Chang, Abner (HPS SW/FW
> Technologist) <abner.chang@hpe.com>
> Cc: devel@edk2.groups.io; liming.gao <liming.gao@intel.com>;
> announce@edk2.groups.io; afish@apple.com; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-
> stable202008
> 
> On 08/19/20 15:19, Laszlo Ersek wrote:
> > On 08/19/20 13:48, Leif Lindholm wrote:
> >> (Slightly trimmed recipient list due to different patch being
> >> discussed.)
> >>
> >> So, I can't make this call, because I'm the one who messed up.
> >>
> >> This patch does exactly what I had requested Abner to do some time
> >> back (off-list, unfortunately), and I was *convinced* I gave it an
> >> R-b as soon as it hit my inbox - until Abner nudged me about it yesterday.
> >>
> >> The patch in question is
> >> https://edk2.groups.io/g/devel/topic/76021725
> >
> > My understanding is:
> >
> > (1) there is an external project that consumes the FDT library in
> > EmbeddedPkg, meaning the lib class header
> "EmbeddedPkg/Include/libfdt.h"
> > and the lib instance "EmbeddedPkg/Library/FdtLib/FdtLib.inf",
> >
> > (2) the lib class header pulls in "fdt.h" and "libfdt_env.h",
> >
> > (3) the external project is not edk2-platforms,
> >
> > (4) the external project wants -- for some strange reason -- edk2's
> > "libfdt_env.h" to provide an strncmp() function (or function-like
> > macro), with that particular stncmp() implementation not being needed
> > in either edk2-platforms or edk2 itself,
> >
> > (5) the patch for adding said strncmp() was posted on Aug 6th (at
> > least when viewed from my time zone), i.e., before the SFF,
> >
> > (6) it was reviewed 12 days later (within the SFF)
> >
> > If my understanding is correct, then I don't see how this patch could
> > be considered a bugfix -- even as a feature addition, it seems hardly
> > justified to me --, and there would have been ~8 days before the SFF
> > to review it.
> >
> > I think we should postpone the patch until after the stable tag.
> 
> Regarding OpenSBI, as of commit 9d56961b2314, the sbi_strncmp() function
> has not been removed, and it seems that sbi_strncmp() is still used / called in
> at least some build configurations (where the
> 
> lib/utils/libfdt/libfdt_env.h:#define strncmp           sbi_strncmp
> 
> definition is supposed to be in effect).
> 
> This means that the codebase can not rid itself of sbi_strncmp().
The code base doesn't have to get rid of using sbi_strncmp function (the code base defines bunch of sbi_strxxx functions) which may be used in other non-fdt related OpenSBI code and it is out of fdt library scope.

> 
> To me this indicates that OpenSBI commit 2cfd2fc90488 ("lib: utils: Use
> strncmp in fdt_parse_hart_id()", 2020-07-29) was wrong. It should have
> replaced sbi_strcmp() with sbi_strncmp(), not strncmp().
We don’t use libfdt_env.h from OpenSBI, we use libfdt_env.h from EmbeddedPkg which is impossible to define a macro to replace "sbi_strncmp" with  AsciiStrnCmp in Edk2 libfdt_env.h. We definitely can include sbi_string.h somewhere in EDK2 RISC-V header file (this is the temp solution I use now  before edk2 upstream has this fix), so it won't pop up build error. But this temp solution looks ugly and specifically. Furthermore, OpenSBI fdt helper lib is sort of a partial fdtlib code, use C API keeps the consistency with fdtlib makes sense to me.
> 
> After all, the size limit seems to be the motivation for the entire change --
> put a size limit on the string comparison in fdt_parse_hart_id(). Commit
> 2cfd2fc90488 did two things at the same
> time: replace the size-unbounded comparison with the size-bounded one,
> *and* switch to the standard C function name from the self-contained
> function. The former goal looks justifiable, the latter I don't understand
Actually the major motivation is not for the bounded comparison, that is to use C API and leverage edk2 libfdt_env.h.
> 
> Now: I realize that, going back to edk2 commit fa4a70633868
> ("EmbeddedPkg: Added support to libfdt", 2012-09-27), we already have a
> bunch of wrappers in "EmbeddedPkg/Include/libfdt_env.h". So I guess
> adding "one more" is not inconsistent with those -- even though the lib
> instance within edk2 doesn't need the new function.
> 
> But it's still a micro-feature whose review should have completed before the
> SFF.
> 
> Thanks
> Laszlo

Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008

[Abner Chang]

...and I didn’t aware that announcement of Soft Feature freeze because [edk2-annnounce] never went to my inbox and end up with I missed it, I should set the rule for it. :(

> -----Original Message-----
> From: Leif Lindholm [mailto:leif@nuviainc.com]
> Sent: Wednesday, August 19, 2020 7:49 PM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> Cc: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; liming.gao
> <liming.gao@intel.com>; announce@edk2.groups.io; afish@apple.com;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-
> stable202008
> 
> (Slightly trimmed recipient list due to different patch being discussed.)
> 
> So, I can't make this call, because I'm the one who messed up.
> 
> This patch does exactly what I had requested Abner to do some time back
> (off-list, unfortunately), and I was *convinced* I gave it an R-b as soon as it
> hit my inbox - until Abner nudged me about it yesterday.
> 
> The patch in question is
> INVALID URI REMOVED
> 3A__edk2.groups.io_g_devel_topic_76021725&d=DwIDaQ&c=C5b8zRQO1mi
> GmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=
> aIPVzq25kdyKl8jdl_OJcSuym6rNT7xSGICexWHc8UY&s=vVeUUfgQDUnjWzqh
> YpCiNqNHDScByiwJzFiUZ4kx4TU&e=
> 
> /
>     Leif
> 
> On Wed, Aug 19, 2020 at 11:29:52 +0000, Chang, Abner (HPS SW/FW
> Technologist) wrote:
> > Hmm.. I had a one commit (which is not the feature) just reviewed by
> > Leif but not pushing yet. Is that possible to push before the Hard
> > Feature freeze and also be included in 202008 stable tag? I guess it
> > gets the chance according to the article of SoftFeatureFreeze on Wiki
> > page.
> >
> > Patch attached FYR
> >
> > Abner
> >
> > > -----Original Message-----
> > > From: announce@edk2.groups.io [mailto:announce@edk2.groups.io] On
> > > Behalf Of Laszlo Ersek
> > > Sent: Wednesday, August 19, 2020 5:59 PM
> > > To: Bret Barkelew <Bret.Barkelew@microsoft.com>;
> > > devel@edk2.groups.io; liming.gao <liming.gao@intel.com>;
> > > announce@edk2.groups.io
> > > Cc: Leif Lindholm <leif@nuviainc.com>; afish@apple.com; Kinney,
> > > Michael D <michael.d.kinney@intel.com>; Guptha, Soumya K
> > > <soumya.k.guptha@intel.com>
> > > Subject: Re: [edk2-announce] [EXTERNAL] Re: Soft Feature Freeze
> > > starts now for edk2-stable202008
> > >
> > > On 08/18/20 17:10, Bret Barkelew wrote:
> > > > I agree with the process and withdraw my request, replacing it
> > > > instead with
> > > a disapproving head shake and deep sigh.
> > >
> > > We as a community definitely deserve your disapproval, as our review
> > > response times have been abysmal. :(
> > >
> > > > I’ll go back to pushing on this after the tag.
> > >
> > > Thanks for your persistence!
> > > Laszlo
> > >
> > >
> > > 
> >
>