From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web11.4710.1602039884653805802 for ; Tue, 06 Oct 2020 20:04:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=ZNANPZGL; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=0549998768=abner.chang@hpe.com) Received: from pps.filterd (m0150245.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0972weSW031218; Wed, 7 Oct 2020 03:04:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : date : message-id : references : in-reply-to : content-type : mime-version : subject; s=pps0720; bh=H4ykiMROPnDAqhuZTDDUvNQxAoocDOfyCDjwUaRNSS8=; b=ZNANPZGL54Jn0hecIWra0Do3nJTh/kfoR5cL1UT/AaAYscIE2/0IhRNbesS99r64xQG/ k3yponmtqAo4JtqMAGHlJgfhD+jxezNYQTqZ19j3yCag3c84u+wDULOJVEThSGZ0pr8x hYUUaIl+7ziOLFNUZCv7/MhlljKctt1UWiAl48W23LcdPLWE3aHVmIue6U06PeOLme5S +0NFGFoIKXgRsm+gN14BxcK5BYmLc4FN3i+B5UtYOIow/UmQUV7tZB15bebg1+/4vZie v5ebDl4L9nOqKbaHGgjz27Rz7O15PGDMPAuJqPxsR+JjzxILJRgLWtLt/dTgcpU0FT+S Rw== Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 33xjge6xnw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Oct 2020 03:04:08 +0000 Received: from G4W9121.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.210.21.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id 13FB157; Wed, 7 Oct 2020 03:04:08 +0000 (UTC) Received: from G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) by G4W9121.americas.hpqcorp.net (2002:10d2:1510::10d2:1510) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 7 Oct 2020 03:04:08 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (15.241.52.12) by G9W8455.americas.hpqcorp.net (16.216.161.94) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 7 Oct 2020 03:04:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iQfNZp/v5jZYDypSUPgIZscSZC5XiadAdiqDxCTguF2yUXQ+eX2rO1hRvCf670qmwpBwoFGslMPDkXsaxdQ9NNDIbheuTZf6/IET8DFxkqJjQDgNI2Jocv6H82Vh98pLx0rGi8pktUuGi+yXQhhJp92cVzVKriZYQeEDsP+ocRgglmzgHjSJOdSoOyzHynSV11m69/pVtwQJi9D1RANYWyV5NI/Z+HTPsjIbeDij/BZy7FXABvJsyvYDhhwjAqmFCT1jH8C3pVGeWDtAk2Hm00MNJSzc7glrNNHhQPNcUrTB6XbnkAL4KAdxi3ew4Cup94oQDnQoTC60jDXy86Bc9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BPpnqnldC/YDN2U7Z/uoxQBfWFgh2LHfU5a+LQjGIx4=; b=oGpL80WDW43ExQKsLmhjBnQFQ5BeirGg3A/2zKQ72RB6g+h4mVqxXv4sxMV/m9hdLGEorBxjBSBBCAzRHH2vAdry0unw8OyLk57EHN8gZ/koJ4Z8hNOAVXbdD94PtJpE2WhXqbPCbbOuBFYEiXUuw1p8Fq3JWYm1Xd8vd4P6tZQlJp1ZRiKNj3924Gg5jGtK1I2E8dnKQcAou3rn5jC8xmrW+54eTmNjlwKyG+X2q7b0B/hdx+NSE/RmEEwTtXhKmgGoIV14fEHPrc5HlS8fQSNgbp2xngM5k6mSMF0Ou13gX7jVOqsJyidSg6m8Lmycp0JThX8DDxdTBC71inOHHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (10.169.13.16) by CS1PR8401MB0582.NAMPRD84.PROD.OUTLOOK.COM (10.169.14.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.22; Wed, 7 Oct 2020 03:04:03 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d111:132b:4b87:a9ea]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d111:132b:4b87:a9ea%3]) with mapi id 15.20.3433.045; Wed, 7 Oct 2020 03:04:03 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "bret.barkelew@microsoft.com" , Sean Brogan CC: Sean Brogan , "Kinney, Michael D" , Liming Gao , "Wang, Nickle (HPS SW)" , Leif Lindholm , Laszlo Ersek Thread-Topic: [EXTERNAL] Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build Thread-Index: AQHWnDUgF3+Gfy/yYEq+82trQGjfG6mLOAUggAAFLICAAAQ4gIAAMuPQ Date: Wed, 7 Oct 2020 03:04:03 +0000 Message-ID: References: <20201006104804.14724-1-abner.chang@hpe.com> <20201006104804.14724-4-abner.chang@hpe.com> , In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=hpe.com; x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 95f272ed-a8aa-4038-8124-08d86a6da5a0 x-ms-traffictypediagnostic: CS1PR8401MB0582: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:255; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xnuvTV+Bj+U4q3Ea13Z2EzrqWsLvg2NHEncyWwgKKo8t8lmrXPkThcN3tFR7sY9Vkgcjwfl18G2TsyPpgq3a3tNVkRPysOmK7Dwj6rg9LITRLlKmbTaw07jB7wieoPQDetAOGYKRRWtocPQ2igMp6Jt9rTiY04u35diku+nGecyKHnOzDlB+m/h2d7i1+SU98Qbsn/V2+9jIF8aRu4G8K+rPjaGUWX3LS4Dl9AIVm6d3L3N9/+rJParCcYZe0ac+Ndsmgn0BuBsngqjT3qHkZTKkXcEEJ1QcJIk+SjrIz2aGkEhsTgRhqD0OJdkOL3TzzbR2R0huIcOZzIZtp4Ww8SdkD4v2teDyqDpFGK5nYq4tgOLJSFLrt0iT1O9vKQe3C8PBwiaz1HdY0S8M3HkEEg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(376002)(39860400002)(366004)(346002)(396003)(136003)(26005)(6506007)(52536014)(316002)(7696005)(186003)(53546011)(54906003)(55016002)(110136005)(2906002)(71200400001)(966005)(8676002)(9686003)(8936002)(86362001)(478600001)(5660300002)(45080400002)(4326008)(83080400001)(66476007)(76236003)(66556008)(166002)(33656002)(66446008)(64756008)(83380400001)(66946007)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: UcDdIIbGB19OAAh8rFvjo47AQEWpujUlMLhXNfTjGDrK9PC8Ce67LERXPBdjttRtQb1FlF1s8xOg33dyeOoCyhIQamgSlwBf5cJMNYgeE4xiG+8fdzmotkNZQZ8ile1OTTx5e3YP9GIIAW4JIOPcfTxmcKfcBqpMEd5pNCIBO3RmCSXdQmzK3LtwWURGDR/saZLQLXy1znyjknNk2/maxvOX5mj7UgcAfveRXSmUWNDZMjq67Y2U6+HMgaLceVrtPD38QHEbLHC60b883DbA4tJTa4kpampgy23lwSZPuts+P4ER9nKiugXJU+U22ILySX46WadNfP8za5uYfCoIexEc+n1YvObQ1Rojy9LU12Ifl1W/Oe1199o8o9hansPziCLALpvmzwH7FU0DUAMqVeAzPjXNPkCLj73PVxjtMZgGOuT/CfCV/YPgk4J5Mn2q+8oys8r6n3V9Jn62HedydxPhZOiDIkHmUZvkt+MGHAl2htsa9zdhn0u5gXBOtGxiwzYAyDQivf5qJ0oqj2cFnAyGqtQui+51qRrB8YO7f2tbQXpIvYPvm5lMFAN4NpYU9JtloqQNxOdtg6pKwCe/+4dmig3gLrqcxJx/11/BaBql9NDE+PzIhG8caStfxU3alnokn6oAq5XyFian1MPpXw== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 95f272ed-a8aa-4038-8124-08d86a6da5a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2020 03:04:03.4924 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NLyRPZHDcDxEFuPQ/M5MNTqn5CinL3QNhkDowpXvqOxpKwcx0R6F2gyp3u6ZuTnfyqyzxHfpLfNlWLQir+H+Zg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0582 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 12 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 Subject: Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-10-07_03:2020-10-06,2020-10-07 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 priorityscore=1501 adultscore=0 spamscore=0 suspectscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010070019 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CS1PR8401MB11443A3DB5A589AE82B9E4E3FF0A0CS1PR8401MB1144_" --_000_CS1PR8401MB11443A3DB5A589AE82B9E4E3FF0A0CS1PR8401MB1144_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ok, v6 sent. Should be the perfect one, I hope so. From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bret= Barkelew via groups.io Sent: Wednesday, October 7, 2020 8:01 AM To: Sean Brogan ; Chang, Abner (HPS SW/FW Technologi= st) ; devel@edk2.groups.io Cc: Sean Brogan ; Kinney, Michael D ; Liming Gao ; Wang, Nickle (HPS= SW) Subject: Re: [EXTERNAL] Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurep= ipelines/templates: Add RedfishPkg to target build Ah, yes. Good catch. Agree with Sean. - Bret From: Sean Brogan Sent: Tuesday, October 6, 2020 4:45 PM To: Chang, Abner (HPS SW/FW Technologist); dev= el@edk2.groups.io Cc: Sean Brogan; Bret Barkelew; Kinney, Michael D; Liming Gao; Wang, Nickle (HPS SW) Subject: [EXTERNAL] Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipel= ines/templates: Add RedfishPkg to target build I am just suggesting that for CI you should put redfishpkg into an existing matrix item rather than create a new matrix item. Each one of those is a build that spins up when CI/PR is invoked. instead of this (your patch) diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml index 2683687a1c..b5b09c2cca 100644 --- a/.azurepipelines/templates/pr-gate-build-job.yml +++ b/.azurepipelines/templates/pr-gate-build-job.yml @@ -45,6 +45,9 @@ jobs: TARGET_SECURITY: Build.Pkgs: 'SecurityPkg' Build.Targets: 'DEBUG,RELEASE,NO-TARGET' + TARGET_REDFISH: + Build.Pkgs: 'RedfishPkg' + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' TARGET_PLATFORMS: # For Platforms only check code. Leave it to Platform CI # to build them. I would just do something like below. (i hand edited the diff so might not be perfect but hopefully you get the idea). @@ -45,6 +45,9 @@ jobs: - TARGET_SECURITY: + TARGET_SECURITY_REDFISH: - Build.Pkgs: 'SecurityPkg' + Build.Pkgs: 'SecurityPkg,RedfishPkg' Build.Targets: 'DEBUG,RELEASE,NO-TARGET' Thanks Sean On 10/6/2020 4:39 PM, Chang, Abner (HPS SW/FW Technologist) wrote: > > >> -----Original Message----- >> From: Sean Brogan [mailto:spbrogan@outlook.com] >> Sent: Wednesday, October 7, 2020 7:05 AM >> To: devel@edk2.groups.io; Chang, Abner (HP= S SW/FW Technologist) >> > >> Cc: Sean Brogan >; Bret Barkelew >> >; Mich= ael D Kinney >> >; Liming= Gao >; >> Wang, Nickle (HPS SW) > >> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5 >> 3/4] .azurepipelines/templates: Add RedfishPkg to target build >> >> On this change i would recommend that you add RedFishPkg to another in >> the list as i don't think the time it takes to compile and test this re= latively >> small package makes it worth spinning up another machine, syncing sourc= es, >> installing tools, etc. > > Sean, do you mean to add RedFishPkg to another package? Or move drivers = (currently is none) under RedFishPkg to another package? > This is the initial commit of RedFishPkg, more drivers will added to thi= s package later on. > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith= ub.com%2Ftianocore%2Fedk2-staging%2Fblob%2FUEFI_Redfish%2FReadme.md&dat= a=3D02%7C01%7CBret.Barkelew%40microsoft.com%7C064c677f2cad4197e11608d86a51f= 2ab%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637376247502227698&sda= ta=3DL4wOv4IxFdOEoUV2IjBG3kUHlBW1Z%2FsQvTQGe67W980%3D&reserved=3D0 > > That doesn't make sense to put RedFishPkg to any of another to save CI t= ime, but what we can do now is remove RedFishPkg from CI test for the time = being. Says don't add RedfishPkg to GetPackageSupported for now. > > >> >> Looking at the current matrix it looks like the SecurityPkg only takes = 8 >> minutes and CRYPTO only takes ~9 minutes. I also see FMP and FAT is fa= ster >> than the slowest entry. We generally try to load balance this so that = CI >> completes quickly. >> >> vs2019 >> INVALID URI REMOVED >> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId- >> 3D12811-26view- >> 3Dresults&d=3DDwICaQ&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN6FZBN4Vgi4Ul >> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DQmpPMx5HlLf978P4ICsd- >> D4sw4IjDO8v_OJ74lDlU0M&s=3D3XIQ_TF_f0Ck_fkywiGXKd- >> 2a23G5fMyOkEFrZgBz5M&e=3D >> >> gcc >> INVALID URI REMOVED >> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId- >> 3D12810-26view- >> 3Dresults&d=3DDwICaQ&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN6FZBN4Vgi4Ul >> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DQmpPMx5HlLf978P4ICsd- >> D4sw4IjDO8v_OJ74lDlU0M&s=3D4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ6 >> XbXB9yt4&e=3D >> >> >> Thanks >> Sean >> >> >> >> On 10/6/2020 3:48 AM, Abner Chang wrote: >>> Signed-off-by: Abner Chang > >>> Cc: Sean Brogan > >>> Cc: Bret Barkelew > >>> Cc: Michael D Kinney > >>> Cc: Liming Gao > >>> Cc: Nickle Wang > >>> Reviewed-by: Bret Barkelew > >>> --- >>> .azurepipelines/templates/pr-gate-build-job.yml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml >>> b/.azurepipelines/templates/pr-gate-build-job.yml >>> index 2683687a1c..b5b09c2cca 100644 >>> --- a/.azurepipelines/templates/pr-gate-build-job.yml >>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml >>> @@ -45,6 +45,9 @@ jobs: >>> TARGET_SECURITY: >>> Build.Pkgs: 'SecurityPkg' >>> Build.Targets: 'DEBUG,RELEASE,NO-TARGET' >>> + TARGET_REDFISH: >>> + Build.Pkgs: 'RedfishPkg' >>> + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' >>> TARGET_PLATFORMS: >>> # For Platforms only check code. Leave it to Platform CI >>> # to build them. >>> --_000_CS1PR8401MB11443A3DB5A589AE82B9E4E3FF0A0CS1PR8401MB1144_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Ok, v6 sent. Should b= e the perfect one, I hope so.

 

From: devel@edk2.groups.io [mailto:devel@edk= 2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Wednesday, October 7, 2020 8:01 AM
To: Sean Brogan <spbrogan@outlook.com>; Chang, Abner (HPS SW/= FW Technologist) <abner.chang@hpe.com>; devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>; Kinney, Michael = D <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.= cn>; Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
Subject: Re: [EXTERNAL] Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] = .azurepipelines/templates: Add RedfishPkg to target build

 

Ah, yes. Good catch. Agree with Sean.

 

- Bret

 

From: Sean Brogan
Sent: Tuesday, October 6, 2020 4:45 PM
To: Chang, Abner (HPS SW/FW = Technologist); devel@edk2.groups.io
Cc: Sean Brogan; <= a href=3D"mailto:Bret.Barkelew@microsoft.com">Bret Barkelew; Kinney, Michael D; Liming Gao; Wang, Nickle (HPS SW)
Subject: [EXTERNAL] Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azu= repipelines/templates: Add RedfishPkg to target build

 

I am just suggesting that for CI you should put red= fishpkg into an
existing matrix item rather than create a new matrix item.  Each one = of
those is a build that spins up when CI/PR is invoked.


instead of this (your patch)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
b/.azurepipelines/templates/pr-gate-build-job.yml
index 2683687a1c..b5b09c2cca 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -45,6 +45,9 @@ jobs:
         TARGET_SECURITY:
           Build.Pkgs: '= SecurityPkg'
           Build.Targets= : 'DEBUG,RELEASE,NO-TARGET'
+      TARGET_REDFISH:
+        Build.Pkgs: 'RedfishPkg'
+        Build.Targets: 'DEBUG,RELEASE,= NO-TARGET'
         TARGET_PLATFORMS:
           # For Platfor= ms only check code. Leave it to Platform CI
           # to build th= em.

I would just do something like below.  (i hand edited the diff so mig= ht
not be perfect but hopefully you get the idea).


@@ -45,6 +45,9 @@ jobs:
-        TARGET_SECURITY:
+        TARGET_SECURITY_REDFISH:
-          Build.Pkgs: 'Secur= ityPkg'
+          Build.Pkgs: 'Secur= ityPkg,RedfishPkg'
           Build.Targets= : 'DEBUG,RELEASE,NO-TARGET'



Thanks
Sean


On 10/6/2020 4:39 PM, Chang, Abner (HPS SW/FW Technologist) wrote:
>
>
>> -----Original Message-----
>> From: Sean Brogan [mailto= :spbrogan@outlook.com]
>> Sent: Wednesday, October 7, 2020 7:05 AM
>> To: devel@edk2.groups.io<= /a>; Chang, Abner (HPS SW/FW Technologist)
>> <
abner.chang@hpe.com>
>> Cc: Sean Brogan <
= sean.brogan@microsoft.com>; Bret Barkelew
>> <Bret.Barkelew@= microsoft.com>; Michael D Kinney
>> <michael.d.kinne= y@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
>> Wang, Nickle (HPS SW) <= nickle.wang@hpe.com>
>> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5
>> 3/4] .azurepipelines/templates: Add RedfishPkg to target build >>
>> On this change i would recommend that you add RedFishPkg to anoth= er in
>> the list as i don't think the time it takes to compile and test t= his relatively
>> small package makes it worth spinning up another machine, syncing= sources,
>> installing tools, etc.
>
> Sean, do you mean to add RedFishPkg to another package? Or move drive= rs (currently is none) under RedFishPkg to another package?
> This is the initial commit of RedFishPkg, more drivers will added to = this package later on.
> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2= F%2Fgithub.com%2Ftianocore%2Fedk2-staging%2Fblob%2FUEFI_Redfish%2FReadme.md= &amp;data=3D02%7C01%7CBret.Barkelew%40microsoft.com%7C064c677f2cad4197e= 11608d86a51f2ab%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63737624750222= 7698&amp;sdata=3DL4wOv4IxFdOEoUV2IjBG3kUHlBW1Z%2FsQvTQGe67W980%3D&a= mp;reserved=3D0
>
> That doesn't make sense to put RedFishPkg to any of another to save C= I time, but what we can do now is remove RedFishPkg from CI test for the ti= me being. Says don’t add RedfishPkg to GetPackageSupported for now. >
>
>>
>> Looking at the current matrix it looks like the SecurityPkg only = takes 8
>> minutes and CRYPTO only takes ~9 minutes.  I also see FMP an= d FAT is faster
>> than the slowest entry.  We generally try to load balance th= is so that CI
>> completes quickly.
>>
>> vs2019
>> INVALID URI REMOVED
>> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-=
>> 3D12811-26view-
>> 3Dresults&d=3DDwICaQ&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_= SN6FZBN4Vgi4Ul
>> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DQmpPMx5HlLf978P4ICsd-
>> D4sw4IjDO8v_OJ74lDlU0M&s=3D3XIQ_TF_f0Ck_fkywiGXKd-
>> 2a23G5fMyOkEFrZgBz5M&e=3D
>>
>> gcc
>> INVALID URI REMOVED
>> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-=
>> 3D12810-26view-
>> 3Dresults&d=3DDwICaQ&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_= SN6FZBN4Vgi4Ul
>> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DQmpPMx5HlLf978P4ICsd-
>> D4sw4IjDO8v_OJ74lDlU0M&s=3D4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ= 6
>> XbXB9yt4&e=3D
>>
>>
>> Thanks
>> Sean
>>
>>
>>
>> On 10/6/2020 3:48 AM, Abner Chang wrote:
>>> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Nickle Wang <ni= ckle.wang@hpe.com>
>>> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
>>> ---
>>>    .azurepipelines/templates/pr-gate-build-job= .yml | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml<= br> >>> b/.azurepipelines/templates/pr-gate-build-job.yml
>>> index 2683687a1c..b5b09c2cca 100644
>>> --- a/.azurepipelines/templates/pr-gate-build-job.yml
>>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
>>> @@ -45,6 +45,9 @@ jobs:
>>>          TARGET_= SECURITY:
>>>          &n= bsp; Build.Pkgs: 'SecurityPkg'
>>>          &n= bsp; Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>>> +      TARGET_REDFISH:
>>> +        Build.Pkgs: 'Redf= ishPkg'
>>> +        Build.Targets: 'D= EBUG,RELEASE,NO-TARGET'
>>>          TARGET_= PLATFORMS:
>>>          &n= bsp; # For Platforms only check code. Leave it to Platform CI
>>>          &n= bsp; # to build them.
>>>

 

--_000_CS1PR8401MB11443A3DB5A589AE82B9E4E3FF0A0CS1PR8401MB1144_--