From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web09.7183.1604634989832313238 for ; Thu, 05 Nov 2020 19:56:29 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=POwm7vsD; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=057929b778=abner.chang@hpe.com) Received: from pps.filterd (m0134420.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0A63r5dA002016; Fri, 6 Nov 2020 03:56:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=msyLrJDgryxI2rkCWpRhAlRG0Lsok7kFVj9541EZS0E=; b=POwm7vsD5Hw2hZaWV/hPRWuzFTfQP0c7KF7v4UUoRJNV0Fs6i3q7zwEDRoOuZjOnYPsr njam+kEYENpASfcXGsu1++1e/C+RPeob/YgZHks+nbcvuIQV2pzG9Ba0b9btCFsPeHCh y1K2+gxzCyxfdaTO9mk5gXwdkQ8E3U4XrsR7IV29DEKcS2irX1VRw0PSXc3vXdivVCkc kWlc4OFzNvxp/eEDSKyITpBui9Wanw9EMX4eRb+EPaZaNUnEU6Eycb3y839+93/oDuKe UVE0iuLZVabhoBcaQYZtLGzW/RSCa6gxaWjLQIku7pS1CWNUL1aBSO0FNVK4Gr/bQTCf lA== Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 34kc8dxu1s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Nov 2020 03:56:27 +0000 Received: from G4W9120.americas.hpqcorp.net (g4w9120.houston.hp.com [16.210.21.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id D35DD7E; Fri, 6 Nov 2020 03:56:26 +0000 (UTC) Received: from G2W6310.americas.hpqcorp.net (2002:10c5:4034::10c5:4034) by G4W9120.americas.hpqcorp.net (2002:10d2:150f::10d2:150f) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 6 Nov 2020 03:56:26 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (15.241.52.13) by G2W6310.americas.hpqcorp.net (16.197.64.52) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 6 Nov 2020 03:56:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eOln6tLzZ7ZO6/O8juOzyJdCfuDlHIYi1nHc2/i9KRtqR+xXzuOLb0nOeZyG6QOyBDIUomrxN9ZWhoN7BmWofQ64fJPfxQoR2SQISJgFSzbjqn70R2tVz0TM5SFfB1BkkMCakmYptAdZLspVcA7MeG6aCNa8DPUJYSAPXiDZEEHVTmEJabAdUkfQaKqNvWIBeDfxzBt0dGsEWanyKgTeT1dwvUxFPUSNoSTWLceAFCnga2T4etr7HjqSnhXoab6T4TykWAQnfOwvk0kSFkmTOIAMQjzlix4jr9xI3jPaeBE0WfSexsBsKzdUQfRWsXnpeeqeBosfImWlMJqrcc/yEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AgHRoGdkLv7omRganXLF2LkTSLOHBLdcd8PPmFMeZlQ=; b=NL0cB3lmvC7ThMRr4LgS4NmVPf66r0whuNj53AHRda+P+bsFhifahzVr0vO2RS6uYBXuxafG/WkKM1Lpd9wlA3203gbzC5o2GqZLNXfrKJ72kV/xM4eSBpBHLfEUa8VY8yDBgQa8E3ygWp1sRRYx90eBm1m5BirC6wK+MZb26G0aujAOt+h04kFK7cv9hGNB+bn5e1BVh7xwODBx1KnlhLgMY4NgdYDOFx4x/0r4sHZAfGtxIKMLYfreAfhLliLpQUv+czpr1bgho7w2YXA1B71K6BCwqeilSG96Dz4c1nIESy9tGnjJmdoSXAPIJsPzNRszyvomCv1zZbBtFfxkzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB0999.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:750f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.28; Fri, 6 Nov 2020 03:56:24 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5160:2077:988c:5e76]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5160:2077:988c:5e76%11]) with mapi id 15.20.3541.021; Fri, 6 Nov 2020 03:56:24 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "Chang, Abner (HPS SW/FW Technologist)" CC: Jiaxin Wu , Siyuan Fu , Fan Wang , Jiewen Yao , Dandan Bi , Eric Dong , "Wang, Nickle (HPS SW)" , gaoliming Subject: Re: [edk2-devel] [VFR support REST_STYLE PATCH v4 4/4] MdeModulePkg/DriverSampleDxe: Add HII sample options Thread-Topic: [edk2-devel] [VFR support REST_STYLE PATCH v4 4/4] MdeModulePkg/DriverSampleDxe: Add HII sample options Thread-Index: AQHWs+3n0Joe2Td+YESdmd0JXyoaZam6eZzQ Date: Fri, 6 Nov 2020 03:56:24 +0000 Message-ID: References: <20201106024939.17761-1-abner.chang@hpe.com> <1644CDDF508612CA.7247@groups.io> In-Reply-To: <1644CDDF508612CA.7247@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=hpe.com; x-originating-ip: [1.34.113.40] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e197ad6f-1bd8-4c03-f8b3-08d88207ee28 x-ms-traffictypediagnostic: CS1PR8401MB0999: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:62; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xL5/u35amDa0PMT3C6FKuACEab/tg6ejv92HT+Ve/Jpi54mdLCtTIRdUYL5XGvivWjV6RYkDK0P2lkXzTWOyDPWZYw7Ya3iO58bUPB6qZ7+99+4dzwhfajn0PhWxdi4zwUqDpAXnxHJ1zwLtMEr1Deocjm4emFndOSjmb5bypz193tGCJ2wC3SWAv1j8a3tZ5xasgNozyMsfyNmByvB629qEIZjnVIe2S1m95UofC1DAsgxZMXd7VBjjKdiewwSMrYvRGSKhIoUFYuWP4p46z02h9Cg+C3RVpxJhHI0YjEdD7movBMxvFul3WWkztmrzlto/BEe+AxGRISKsyVhzDwkM3vTDz8QKAMgt1cELo+FKHPdfOUfz6h/W72jdX3eTMTVrKU5yn9rwAc3PkBiGHg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(366004)(396003)(39860400002)(136003)(376002)(346002)(110136005)(26005)(54906003)(8676002)(8936002)(19627235002)(4326008)(86362001)(186003)(316002)(478600001)(71200400001)(966005)(66446008)(33656002)(66556008)(66476007)(5660300002)(64756008)(76116006)(2906002)(66574015)(53546011)(66946007)(52536014)(55016002)(7696005)(83380400001)(6506007)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: YCOfpScUhA7iIDHIzzhFdOZx9Uua3ZDhPhDGpld2E+3tQuyIYIyv6WAgn21Bhtoxv4mUq+3gFabHA7hkD4rNVjd74lElwxTnUh4KlajUa1F+YTj207xci0GqIP8cJmGNYnAlQIOfXqwzET46FONm9agpwCfEprvgtYEvB5zkWgA29RWZfIQOQ88wgH5TVjYzzbpRRJK8QXhsL/j9cqvMxr/uoU0Xr7EMMvjHTrTYYggF15mxQ9brvotcI71LkkQcp0PsE2IbdUSV9+Q9u4dkCjhZq5Q1rXU5N7n/ImRvO3EWXwdvCI2Mk0SadXffpX+/ab/0YSnDGE7RYldFyiANC6nmBlUZtavGbMoSnUSaEgVF4vxvHXJ4En9uYrf7tQw4FZo++Pc7KgTZ66LpEyvTy7BvViVSXuGjX6VC30zKqg79/NJskr5rpdE0/g8JAyB1oo2todAKtHv1BMZ1cCrXi9uV/5s4vdJUnFJPqELhuCEpf6ODOZj6MQKhXJqBnozg7+NgYUB9CHJUD9SmyWWlmgrWu/ZA0gaLwtLqbkTrt2Ac81+8ND9hnN2uoUh43mXoD5MLU2hM5LfbHef2wAQxXxEcFXns8yU1RyfiBuPShNaBzO01dVV2twLPaqxrxz1+UkPCnp+aKxE9G7sK2BkjKg== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: e197ad6f-1bd8-4c03-f8b3-08d88207ee28 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2020 03:56:24.3820 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NbkzKHNlnVRpfX7gEAIbD53KIKXUjFe5RVjGs1C7auuewTY651Sx7gTxsiSkEPiZYwEyZT5GqBs8i5NuxLzcwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0999 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-06_01:2020-11-05,2020-11-06 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011060024 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Add Liming. > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Friday, November 6, 2020 10:50 AM > To: devel@edk2.groups.io > Cc: Jiaxin Wu ; Siyuan Fu ; Fa= n > Wang ; Jiewen Yao ; Dandan > Bi ; Eric Dong ; Wang, Nickle > (HPS SW) > Subject: [edk2-devel] [VFR support REST_STYLE PATCH v4 4/4] > MdeModulePkg/DriverSampleDxe: Add HII sample options >=20 > Add x-uefi-ns keyword REST_STYLE HII option and non x-uefi keyword > REST_STYLE HII option. >=20 > Signed-off-by: Abner Chang > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Fan Wang > Cc: Jiewen Yao > Cc: Dandan Bi > Cc: Eric Dong > Cc: Nickle Wang > --- > .../Universal/DriverSampleDxe/NVDataStruc.h | 5 ++- > .../Universal/DriverSampleDxe/Vfr.vfr | 36 +++++++++++++++++++ > .../Universal/DriverSampleDxe/VfrStrings.uni | 8 +++++ > 3 files changed, 48 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Universal/DriverSampleDxe/NVDataStruc.h > b/MdeModulePkg/Universal/DriverSampleDxe/NVDataStruc.h > index 8617617684..a4ec1b4bd1 100644 > --- a/MdeModulePkg/Universal/DriverSampleDxe/NVDataStruc.h > +++ b/MdeModulePkg/Universal/DriverSampleDxe/NVDataStruc.h > @@ -1,6 +1,7 @@ > /** @file >=20 > -Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
* > +(C) Copyright 2020 Hewlett Packard Enterprise Development LP
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > Module Name: > @@ -92,6 +93,8 @@ typedef struct { > UINT16 BitNumeric : 12; > MY_BITS_DATA MyBitData; > MY_EFI_UNION_DATA MyUnionData; > + UINT8 QuestionXUefiKeywordRestStyle; > + UINT8 QuestionNonXUefiKeywordRestStyle; > } DRIVER_SAMPLE_CONFIGURATION; >=20 > // > diff --git a/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr > b/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr > index 65a65d4d1d..5323e2b411 100644 > --- a/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr > +++ b/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr > @@ -3,6 +3,7 @@ > // Sample Setup formset. > // > // Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<= BR> > +// (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> // SPDX-License-Identifier: BSD-2-Clause-Patent // //**/ @@ -289,6 > +290,41 @@ formset > option text =3D STRING_TOKEN(STR_ONE_OF_TEXT3), value =3D 3, flag= s =3D 0; > endoneof; >=20 > + // > + // This is an HII option which has REST_STYLE flag and x-UEFI names= pace > + // UNI string associated. This HII option could be configured by ei= ther in- > band > + // edk2 setup browser or the remote management in out-of-band such = as > Redfish > + // service. This HII option is configured through > EFI_KEYWORD_HANDLER_PROTOCOL. > + // > + oneof varid =3D MyIfrNVData.QuestionXUefiKeywordRestStyle, > + prompt =3D STRING_TOKEN(STR_ONE_OF_PROMPT_X_UEFI), > + help =3D STRING_TOKEN(STR_ONE_OF_PROMPT_X_UEFI_HELP), > + flags =3D RESET_REQUIRED | REST_STYLE, > + option text =3D STRING_TOKEN(STR_ONE_OF_TEXT1), value =3D 0, flag= s =3D 0; > + option text =3D STRING_TOKEN(STR_ONE_OF_TEXT2), value =3D 1, flag= s =3D > DEFAULT; > + option text =3D STRING_TOKEN(STR_ONE_OF_TEXT3), value =3D 3, flag= s =3D 0; > + endoneof; > + > + > + // > + // This is a HII option which has REST_STYLE flag but without the x= -UEFI > namespace > + // UNI string associated. This HII option could be configured by ei= ther > + // setup browser or the remote management in out-of-band such as > Redfish > + // service. This HII option is configured through EFI HII Configura= tion > Routing > + // Protocol becasue it doesn't have x-UEFI namespace UNI string. > + // > + numeric varid =3D MyIfrNVData.QuestionNonXUefiKeywordRestStyle, > + prompt =3D STRING_TOKEN(STR_ONE_OF_PROMPT_NON_X_UEFI), > + help =3D STRING_TOKEN(STR_ONE_OF_PROMPT_NON_X_UEFI_HELP), > + flags =3D RESET_REQUIRED | REST_STYLE, > + minimum =3D 0, > + maximum =3D 0xf0, > + step =3D 0, // Stepping of 0 equates to a manual= entering > + // of a value, otherwise it will be ad= justed by "+"/"-" > + default =3D 0, // defaultstore could be used to spe= cify the default > type > + // If no defaultstore is specified, it= implies Standard Default > + endnumeric; > + > // > // Define a string (EFI_IFR_STRING) > // > diff --git a/MdeModulePkg/Universal/DriverSampleDxe/VfrStrings.uni > b/MdeModulePkg/Universal/DriverSampleDxe/VfrStrings.uni > index bafa194c63..9587e935a6 100644 > --- a/MdeModulePkg/Universal/DriverSampleDxe/VfrStrings.uni > +++ b/MdeModulePkg/Universal/DriverSampleDxe/VfrStrings.uni > @@ -1,6 +1,7 @@ > // *++ > // > // Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved. > +// (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> // SPDX-License-Identifier: BSD-2-Clause-Patent // // Module Name: > @@ -56,6 +57,13 @@ > #language x-UEFI-ns "iSCSIBootEn= able" > #string STR_CHECK_KEYWORD_SUPPORT #language en-US "Check iSCSI > Boot Enable" > #language fr-FR "Check iSCSI Boo= t Enable" > +#string STR_ONE_OF_PROMPT_X_UEFI #language en-US "x-UEFI HII > Option" > + #language fr-FR "x-UEFI HII Opti= on" > + #language x-UEFI-ns "xUefiHiiOpt= ion" > +#string STR_ONE_OF_PROMPT_X_UEFI_HELP #language en-US "This is an > HII option which has REST_STYLE flag and x-UEFI namespace UNI string > associated. This HII option could be configured by either in-band edk2 s= etup > browser or the remote management in out-of-band such as Redfish service. > This HII option is configured through EFI_KEYWORD_HANDLER_PROTOCOL." > +#string STR_ONE_OF_PROMPT_NON_X_UEFI #language en-US "Non x- > UEFI HII Option" > + #language fr-FR "Non x-UEFI = HII Option" > +#string STR_ONE_OF_PROMPT_NON_X_UEFI_HELP #language en-US "This > is a HII option which has REST_STYLE flag but without the x-UEFI namespa= ce > UNI string associated. This HII option could be configured by either set= up > browser or the remote management in out-of-band such as Redfish service. > This HII option is configured through EFI HII Configuration Routing Prot= ocol > becasue it doesn't have x-UEFI namespace UNI string." > #string STR_ONE_OF_HELP #language en-US "My one-of help = is > going to be a long string to test out the efficiency of the ability of t= he I am > tired of typing capabilities" > #language fr-FR "Mi uno- de ayud= a va a ser una cadena > larga a probar fuera de la eficacia de la capacidad del yo es cansada de > capacidades el pulsar." > #string STR_ONE_OF_TEXT1 #language en-US "My one-of text = #1" > -- > 2.17.1 >=20 >=20 >=20 >=20 >=20