public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Abner Chang" <abner.chang@hpe.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"ardb@kernel.org" <ardb@kernel.org>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Leif Lindholm <leif@nuviainc.com>,
	"Schaefer, Daniel" <daniel.schaefer@hpe.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg
Date: Fri, 15 Oct 2021 08:13:54 +0000	[thread overview]
Message-ID: <CS1PR8401MB11443C4271D42E1E39F8A9C0FFB99@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAMj1kXGCsqXA9g2k5CGXzu8qkL+CCD5e_gKFFdWqqY=OFqc3YQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2182 bytes --]

sigh... typo. Should be ArmPkg, will send V3.

Abner


________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Ard Biesheuvel <ardb@kernel.org>
Sent: Friday, October 15, 2021 3:59 PM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm <leif@nuviainc.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg

On Fri, 15 Oct 2021 at 09:58, Abner Chang <abner.chang@hpe.com> wrote:
>
> Compliant with BZ: #3665
> https://bugzilla.tianocore.org/show_bug.cgi?id=3665
>
> PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged
> by both ARM and RISC-V arch. This patch uses the one from MdePkg
> instead the one under ArmVirtPkg.
>

ArmVirtPkg??

> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> ---
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> index 91b8c7792e..af20739120 100644
> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> @@ -403,11 +403,11 @@ DEFINE X64EMU_ENABLE  = FALSE
>
>    gArmTokenSpaceGuid.PcdPciMmio32Base|0x40000000
>    gArmTokenSpaceGuid.PcdPciMmio32Size|0x80000000
> -  gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0
> +  gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation|0x0
>
>    gArmTokenSpaceGuid.PcdPciMmio64Base|0x100000000
>    gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
> -  gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
> +  gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation|0x0
>
>    ## Use PCI emulation for ATA PassThru
>    # gEfiMdeModulePkgTokenSpaceGuid.PcdAtaPassThruPciEmulation|TRUE
> --
> 2.17.1
>






[-- Attachment #2: Type: text/html, Size: 4071 bytes --]

  reply	other threads:[~2021-10-15  8:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15  6:59 [edk2-platforms][PATCH 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg Abner Chang
2021-10-15  7:00 ` [edk2-platforms][PATCH 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD " Abner Chang
2021-10-15  7:59   ` Ard Biesheuvel
2021-10-15  8:13     ` Abner Chang [this message]
2021-10-15  7:00 ` [edk2-platforms][PATCH 2/9] Platform/CelloBoard: " Abner Chang
2021-10-15  7:00 ` [edk2-platforms][PATCH 3/9] Platform/Overdrive1000Board: " Abner Chang
2021-10-15  7:00 ` [edk2-platforms][PATCH 4/9] Silicon/Styx: " Abner Chang
2021-10-15  7:00 ` [edk2-platforms][PATCH 5/9] Platform/ARM: " Abner Chang
2021-10-15  7:00 ` [edk2-platforms][PATCH 6/9] Platform/SabaQemu: " Abner Chang
2021-10-15  7:00 ` [edk2-platforms][PATCH 7/9] Silicon/SabaQemu: " Abner Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CS1PR8401MB11443C4271D42E1E39F8A9C0FFB99@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox