From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web12.7210.1626271559625529696 for ; Wed, 14 Jul 2021 07:05:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=eWTbBCkT; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=082937abdb=abner.chang@hpe.com) Received: from pps.filterd (m0150242.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16EE2DhS023411; Wed, 14 Jul 2021 14:05:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=UWXp+3o0+s8AeRgS3dQwuvIfucXWeEjeAN/JImEHllg=; b=eWTbBCkTfjTX/2InDz+FAtPt6mpPojVGR7hg5vXHfM2vVSd55wvqlNcbhgy50JMuCFdL S19mk9zvdYhQsoWyENXQB3JpOLyF/ttvLjoi5bVz6w0tUYzFs3AZlcXPrQ2byYp36Jk7 HxIGakATv5DZDO4UJHv5GGarxP2xKSSE+r8pa6j5XZyIsZfH2GF9xRacpLGs5e3oHHku r/4yk0pvZAbBlXrmQYz5DiIXBop69DWDJlJdJ/rCwnKbUlGnWwljYp7mduyzIkLVxY2c tIDLX877XoD7Bo3B1ThxBdUkIZh6eVRl/OWVDzTLG6bgP/+FcQH9LqIYKNYwbbMkTEH6 7A== Received: from g2t2354.austin.hpe.com (g2t2354.austin.hpe.com [15.233.44.27]) by mx0a-002e3701.pphosted.com with ESMTP id 39s7usvx81-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Jul 2021 14:05:56 +0000 Received: from G2W6309.americas.hpqcorp.net (g2w6309.austin.hp.com [16.197.64.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2354.austin.hpe.com (Postfix) with ESMTPS id 47A92A8; Wed, 14 Jul 2021 14:05:55 +0000 (UTC) Received: from G9W8453.americas.hpqcorp.net (2002:10d8:a0d3::10d8:a0d3) by G2W6309.americas.hpqcorp.net (2002:10c5:4033::10c5:4033) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 14 Jul 2021 14:05:55 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (15.241.52.13) by G9W8453.americas.hpqcorp.net (16.216.160.211) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Wed, 14 Jul 2021 14:05:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EVzxIIe+Hdgg4ebwZ60xPyc2SSVyjPkbxj4gWXW5eIvt3qdHXF/ZaAvYqzdV+XZJVU4lbfGghFrMdeXnfz9PnHBqTTU7LtI8TlXi1zMXXIOOquSDKUPho9y8xde4ZqJU9sAjM+jN4mQuzHzx/i9yL3es7O9MkQLAaW168tA5p+/F86XVcHrW1Bu9Omqlgob/9+9p3JvzI2RjfY0uUg1YEdxjeapuNCcbzSzdw9ykO/NFsTzw+J9sG4JMPdHKKLusWbeRw5/JWsrkTOYoCjwwQVqWNxHvYJNGk8Lh2BJLFT9W+vNkXa/nZTXLeyluiLMxBz7OsEtsEoE3/eNr3YHlcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TU0Zd++ZLQiU6fHTjpG1ys1D7HiNe9G5go/DqEgjMtY=; b=H39FZPggG/hzfSCEEH3FdOGNv2pipWYGvO40IF+qMTGbxlF4Iwuyk8kZw6uU+NqV19g1xNgQD/A/du64SOm8RLnbiZpmAmQVWW+scLqwXh3nO8Z23ikpXeTVbrLnHG+kwF9u6YD1aV6wefBeyO/4giTfbnkvX6zrYmTMxW8c5tvtosLZMy62kWC0DIY7T8rO6NF6z/08Xi4aexpaRV5Ws2jv5xIS890/dtfMeeTilP7RjnEwTwyWeR0SoeIGAQdKqVN05/Bce2tc/scMaQZFrPrWdQkZnadsD8+QfI0CgApZcNRdpbZbVadMaUyFmU5q0h9cZMML01cUH+EPeidw3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB1238.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:750a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Wed, 14 Jul 2021 14:05:54 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d447:2f82:1c6e:831f]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d447:2f82:1c6e:831f%4]) with mapi id 15.20.4308.027; Wed, 14 Jul 2021 14:05:53 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "Chang, Abner (HPS SW/FW Technologist)" , "Schaefer, Daniel" CC: Leif Lindholm , Ard Biesheuvel , Anup Patel Subject: Re: [edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to libfdt_env.h Thread-Topic: [edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to libfdt_env.h Thread-Index: AQHXTL93byUxDBsp60GcLz8Y44HJXqrq7jAwgFfq5xA= Date: Wed, 14 Jul 2021 14:05:53 +0000 Message-ID: References: <20210519145822.4028-1-daniel.schaefer@hpe.com> <1680817ADB2092C8.5504@groups.io> In-Reply-To: <1680817ADB2092C8.5504@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=hpe.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 02c08142-fecd-431c-0f54-08d946d07e8d x-ms-traffictypediagnostic: CS1PR8401MB1238: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /Rigm8e6jQOBJ5owev06dm7NRJYCsglkjyY8qA9mB7iIKSun/21LSd8iqKtR9C6S+XmskcMGNvbeBI6PAZvERy0nF9FB4mMrdlcRMx+VfUQHyTBkW0Ji1RqEiQ30qJcCtf3XWdfE3Ptr1Ui/U0nTanV98IN9au8tFrNau1JuCyCSRqmCBjxyexbgSUlaoWRNj5/vdW4Vqf/bdlMB2K5bme6Oo2qLEUsZDtHIDpnd3cZG/UT2eM+WwH59RaLIHhxeWetIxQHjfAjj+NuG148EyWkoSCEajISJvvLp5TLD2Vh0JoECc+cJZb551c8GijV+AJhq1CADxUhZUnPSFDbJE0X1W7FJtBuOi26Lq5fbxln2RMTemAYQJjP4HPb09rHRurCp/zfVKMGJMkaKgTK5Zho0POIZKxblC5/w1G75jcOhtHrdsoFLNILjz+dTbmQDaHXcm2SKIyonuMpfRCUPWOYcz7vZr7R1Gt0NHhSk4A1WJwgg3pSu63BrbR7ILEYnSGk973pu8Cy6nVIOiyrV5L9w+00VEY0ipm9ulG9RjvS9Kn5CYTq21LrXy5gbXmAXUwXX+AwuyPezYUj7OAuuDboENokXgXQq6ft2evFxFWYDZjXluTVb6Ez+Lvgn+ZhyIdEa8m5sv6/qWzbCNq46EO3y4mFBkVhErn5RBjuEdQti4v563fEP8PydWagVkueZBCbH6zU+B/z8WXLToA9soYxBChhjlHQHNBJZ1ffbWXwYdf9p6/w5PDApYwbq8CRV6xVwM4GXbWk/Fs+jIfbxqH+lKi7TPt2FH1H1T5tie+lNQc30OiIh/ADIjoal0YXLTozOtR+BFNjy5caNrepMBw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(39860400002)(366004)(346002)(136003)(376002)(396003)(478600001)(2906002)(316002)(71200400001)(8676002)(83380400001)(66946007)(26005)(122000001)(186003)(38100700002)(66476007)(966005)(33656002)(8936002)(9686003)(86362001)(66556008)(52536014)(7696005)(76116006)(5660300002)(6636002)(4326008)(54906003)(66446008)(64756008)(6506007)(55016002)(110136005)(53546011)(38070700004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CgK1kB+SoIACOq22J9dDipS3AwG/oetcYwpz6NB9y5Q1vToiXYqbVojELH4X?= =?us-ascii?Q?WXOqsKVbPTB0bBqTbMy5bfa+3meAMoZYdfUV34qu35FSDBECujvfQ8Xy9nns?= =?us-ascii?Q?isRgMw4mzY3bWY7U4fwhUTSWiNDdYgmVeo3p4UVunVKwKeqrBcSPUCoQTULJ?= =?us-ascii?Q?jx1glsgfFnbHNQhh2VxKkiu85jZfHJCMVsTINPaKZH5j77ghkEp1b7FR2Zwi?= =?us-ascii?Q?5t+OjaUpUrzTgEVmPRLbVi6l9cubPNWt1kSxAtN6562SnkfMuHa/I63rspU+?= =?us-ascii?Q?EXs0TKD+hcIKIsVAs1zT8nhrY7hwe/q83q7bYdZjTE7CSBPHBK3sCX3H5YZ0?= =?us-ascii?Q?XMfmNUBN46rAUmtJ4rQlXL/syAwOHRVIaV6jg+gTxdZAwjGo1h3EoaedXuwU?= =?us-ascii?Q?RgjiFzXvLj30xB5sMc83iKlmlK9y3APUOc4SPlLrYIf/BNDP+sJZI7sXuFrD?= =?us-ascii?Q?4tW0pma1S2FvNv0HQQkCxkADfidex25mlRSBptzv84bINtO50eLmuflViMQh?= =?us-ascii?Q?h0C6777IOI7Sr7Ijm8IdIwZ334+uRG4gsGFU40GYC2bEEkb6DxMGo+hvT5AN?= =?us-ascii?Q?PC6A9PNGOo8SKhMprALFK45IRibuTlVefER3/D0fu0dixsVAl4geMZcBg9C0?= =?us-ascii?Q?t4gYlrETZ6/vq09VEHCGFHnl3SPrfzig2TUmlhWeLOd4QJbVAeKXk745F8WM?= =?us-ascii?Q?zKxlQwYgMvvR5AyDruIq7xuvnLVA/tSTTMevTH1czRAGIrnhySrrKx+9cvC/?= =?us-ascii?Q?/OPlHo9jERqLrnXXUNS6xIWM6mb3fpfREzxlwSYpWRHURBIxhMrS8UuNOnOF?= =?us-ascii?Q?J+qVr7GcDZ+ydkq7InEM1gi42tAl/CM9SlCvVymmRJRBO4NXY4oHmYCGRx4Q?= =?us-ascii?Q?4tbslwSjr7U/E/akKzIrmQVq08mozgwfytMwCFjPujZtpGc6RWrzaHYGQFvF?= =?us-ascii?Q?ASQhUP7ibAIoUTq/RQNDsQP8ANwlCPbbqVEmS4gNr1d1zKXXbz5sIRpzQWQT?= =?us-ascii?Q?wiRT9sF1x/RU3rwGVm76TWw65o1Sn4/kcF+VWrQ1+AwPdbpJk/4rk5Igpb4b?= =?us-ascii?Q?eIv3YH2aGCzoladdpO6yh6FuuJYOHj2LxnxUQxFdh/m6GV61saSPOZCUj6qc?= =?us-ascii?Q?jT8IBUQti+fNzN0cIOQwWh0LzZs51btKgscd03MgisOt6LRL7I1RMxMBa+OU?= =?us-ascii?Q?CP7La8S1RScptMpVfiClYrJ7OmIuTgN81tPstHTmUdpbw17TgBIiSg6AE0CF?= =?us-ascii?Q?PIYRnTZvcA58RGXvIDYehlAYLtOBtrOSL64Ut+IYhNFTqwf5tGQq7x3PG0XV?= =?us-ascii?Q?pJpqC62/oswzsytYvyCONrc6?= X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 02c08142-fecd-431c-0f54-08d946d07e8d X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2021 14:05:53.8642 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B5xzhiHdHH2G59lwfKem1sUNVLDPO/veVOZAwSwIr2XTrrvG0yBSUYpqTtGsBqdQryrme7BpIRncRnOlIH4Qag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB1238 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: rw_3tOgv8_THmrDq-4AoDbQItaCIoUs1 X-Proofpoint-GUID: rw_3tOgv8_THmrDq-4AoDbQItaCIoUs1 X-Proofpoint-UnRewURL: 2 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-07-14_07:2021-07-14,2021-07-14 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 malwarescore=0 clxscore=1011 mlxscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 mlxlogscore=999 priorityscore=1501 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107140085 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif and Ard, Please help to review this and merge it if you have no comments on this pa= tch. Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Wednesday, May 19, 2021 11:30 PM > To: Schaefer, Daniel ; devel@edk2.groups.io > Cc: Leif Lindholm ; Ard Biesheuvel > ; Anup Patel > Subject: Re: [edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp > and strncpy to libfdt_env.h >=20 > Reviewed-by: Abner Chang >=20 > > -----Original Message----- > > From: Schaefer, Daniel > > Sent: Wednesday, May 19, 2021 10:58 PM > > To: devel@edk2.groups.io > > Cc: Chang, Abner (HPS SW/FW Technologist) ; > Leif > > Lindholm ; Ard Biesheuvel > ; > > Anup Patel > > Subject: [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to > > libfdt_env.h > > > > OpenSBI has started using those in v0.9. See: > > https://github.com/riscv/opensbi/blob/v0.9/lib/utils/fdt/fdt_domain.c > > > > Cc: Abner Chang > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Daniel Schaefer > > Cc: Anup Patel > > Signed-off-by: Daniel Schaefer > > --- > > EmbeddedPkg/Include/libfdt_env.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/EmbeddedPkg/Include/libfdt_env.h > > b/EmbeddedPkg/Include/libfdt_env.h > > index 7feff52bc0fb..c35ac739703c 100644 > > --- a/EmbeddedPkg/Include/libfdt_env.h > > +++ b/EmbeddedPkg/Include/libfdt_env.h > > @@ -76,8 +76,16 @@ static inline size_t strnlen (const char* str, size= _t > strsz ) { > > return AsciiStrnLenS (str, strsz); > > > > } > > > > > > > > +static inline size_t strcmp (const char* str1, const char* str2) { > > > > + return AsciiStrCmp (str1, str2); > > > > +} > > > > + > > > > static inline size_t strncmp (const char* str1, const char* str2, siz= e_t strsz ) > { > > > > return AsciiStrnCmp (str1, str2, strsz); > > > > } > > > > > > > > +static inline size_t strncpy (char* dest, const char* source, size_t > dest_max) { > > > > + return AsciiStrCpyS (dest, dest_max, source); > > > > +} > > > > + > > > > #endif /* _LIBFDT_ENV_H */ > > > > -- > > 2.30.1 >=20 >=20 >=20 >=20 >=20