public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Abner Chang" <abner.chang@hpe.com>
To: Sean Brogan <spbrogan@outlook.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	"Wang, Nickle (HPS SW)" <nickle.wang@hpe.com>
Subject: Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build
Date: Tue, 6 Oct 2020 23:39:44 +0000	[thread overview]
Message-ID: <CS1PR8401MB114444C16B5B2CDE0DDD3076FF0D0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <MN2PR07MB69748AD1B8FADA64F6FA123CC80D0@MN2PR07MB6974.namprd07.prod.outlook.com>



> -----Original Message-----
> From: Sean Brogan [mailto:spbrogan@outlook.com]
> Sent: Wednesday, October 7, 2020 7:05 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5
> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
> 
> On this change i would recommend that you add RedFishPkg to another in
> the list as i don't think the time it takes to compile and test this relatively
> small package makes it worth spinning up another machine, syncing sources,
> installing tools, etc.

Sean, do you mean to add RedFishPkg to another package? Or move drivers (currently is none) under RedFishPkg to another package?
This is the initial commit of RedFishPkg, more drivers will added to this package later on.
https://github.com/tianocore/edk2-staging/blob/UEFI_Redfish/Readme.md

That doesn't make sense to put RedFishPkg to any of another to save CI time, but what we can do now is remove RedFishPkg from CI test for the time being. Says don’t add RedfishPkg to GetPackageSupported for now.


> 
> Looking at the current matrix it looks like the SecurityPkg only takes 8
> minutes and CRYPTO only takes ~9 minutes.  I also see FMP and FAT is faster
> than the slowest entry.  We generally try to load balance this so that CI
> completes quickly.
> 
> vs2019
> INVALID URI REMOVED
> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
> 3D12811-26view-
> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
> D4sw4IjDO8v_OJ74lDlU0M&s=3XIQ_TF_f0Ck_fkywiGXKd-
> 2a23G5fMyOkEFrZgBz5M&e=
> 
> gcc
> INVALID URI REMOVED
> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
> 3D12810-26view-
> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
> D4sw4IjDO8v_OJ74lDlU0M&s=4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ6
> XbXB9yt4&e=
> 
> 
> Thanks
> Sean
> 
> 
> 
> On 10/6/2020 3:48 AM, Abner Chang wrote:
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Nickle Wang <nickle.wang@hpe.com>
> > Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > ---
> >   .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > b/.azurepipelines/templates/pr-gate-build-job.yml
> > index 2683687a1c..b5b09c2cca 100644
> > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > @@ -45,6 +45,9 @@ jobs:
> >         TARGET_SECURITY:
> >           Build.Pkgs: 'SecurityPkg'
> >           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > +      TARGET_REDFISH:
> > +        Build.Pkgs: 'RedfishPkg'
> > +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >         TARGET_PLATFORMS:
> >           # For Platforms only check code. Leave it to Platform CI
> >           # to build them.
> >

  reply	other threads:[~2020-10-06 23:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 10:48 [RedfishPkg PATCH v5 0/4] Inital RedfishPkg Abner Chang
2020-10-06 10:48 ` [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg Abner Chang
2020-10-06 14:36   ` Leif Lindholm
2020-10-06 16:20     ` [edk2-devel] " Abner Chang
2020-10-06 16:29       ` [EXTERNAL] " Leif Lindholm
2020-10-06 16:36         ` Abner Chang
2020-10-06 16:46         ` [EXTERNAL] " Laszlo Ersek
2020-10-06 23:57         ` Abner Chang
2020-10-06 10:48 ` [RedfishPkg PATCH v5 2/4] .pytool: Add CI on RedfishPkg Abner Chang
2020-10-06 13:48   ` [edk2-devel] " Laszlo Ersek
2020-10-06 10:48 ` [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
2020-10-06 23:05   ` [edk2-devel] " Sean
2020-10-06 23:39     ` Abner Chang [this message]
2020-10-06 23:45       ` Sean
2020-10-07  0:00         ` [EXTERNAL] " Bret Barkelew
2020-10-07  3:04           ` Abner Chang
2020-10-07  0:01         ` Abner Chang
2020-10-07  0:09           ` Abner Chang
2020-10-06 10:48 ` [RedfishPkg PATCH v5 4/4] edk2: Add maintainers to RedfishPkg Abner Chang
2020-10-06 18:38   ` [edk2-devel] " Leif Lindholm
2020-10-06 13:50 ` [edk2-devel] [RedfishPkg PATCH v5 0/4] Inital RedfishPkg Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CS1PR8401MB114444C16B5B2CDE0DDD3076FF0D0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox