From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web11.1635.1607388625537374353 for ; Mon, 07 Dec 2020 16:50:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=GXa5PObk; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0611956627=abner.chang@hpe.com) Received: from pps.filterd (m0150242.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0B80cvkr009114; Tue, 8 Dec 2020 00:50:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=LptJcRHITuRSkBHh2Vxr0ul5OwPjmplUgieRl2LCZY4=; b=GXa5PObk69tNa2eZDhUWfDjsOXi0iCnz6iLJhf1LCM+FRRdHeXxZCyFZgtVLLw1BHxn9 2kcOXp2FQYIxwwgw68XNr7CAsTtkW3J/YJ5WgyDqqWL236+wL10G/eGZOsFqiP3UiOoH J4ASIBKuL14RNE/OzCe8G0BhaDdRX2wr4Py95uAMXiRW6+RT1/cgLJ+sAt8/lth1C69j 3ikJDlPZyMmfknfjTGMQY4rGXHO0ng5dQO1KxdM08kvsx7es+aMiUhE94O6flXWevIgX NpR872I1tQ9gDM4z9EjFMv2ixW2Sg6sOMMmyaLQEe7LUqa/rOLSNxrKqBy3X47wMMqTX pA== Received: from g2t2354.austin.hpe.com (g2t2354.austin.hpe.com [15.233.44.27]) by mx0a-002e3701.pphosted.com with ESMTP id 358knu4qnr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Dec 2020 00:50:15 +0000 Received: from G2W6311.americas.hpqcorp.net (g2w6311.austin.hp.com [16.197.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2354.austin.hpe.com (Postfix) with ESMTPS id D20C8A8; Tue, 8 Dec 2020 00:50:13 +0000 (UTC) Received: from G9W8677.americas.hpqcorp.net (16.220.49.24) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Dec 2020 00:50:12 +0000 Received: from G9W9210.americas.hpqcorp.net (2002:10dc:429b::10dc:429b) by G9W8677.americas.hpqcorp.net (2002:10dc:3118::10dc:3118) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Dec 2020 00:50:12 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (15.241.52.11) by G9W9210.americas.hpqcorp.net (16.220.66.155) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 8 Dec 2020 00:50:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZvloDAjThGW4FDP61T3B19fnTAMUjWvRRqDE6TGSXxUvrCDcn28Mvg4k580WeM2QU3epfAd2gCr5jNb/9Qa/7VDcmQtE4Nrv+ewUJFu+EeQ+f3pn+GhSpJkKH8r7G7vOLBxFCQDDQaCHkAaoeOr8vN3elylA3A+HUAXrM6f6CNiR4IExRcfK4c/Rnkyx6sGeBikyLTHc6ZV1Q8p42J26WkTIj4jqzQhFjb9fsutseowaHURkzNA5obEbSWp6lPoZKrQgyhjftKcBnVsBu6G7r9suu+8jrutGnnFCRpSdQg34n5widCnSAfpnhR+gn1QpVGc08CVsaEC5o1HyF3vTiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bX93NLhEd/jrAfyzdANQqrhqqQau44KjOdZn8ws/YDE=; b=RPrXz0wcvEiY6qNT3kEwYmsX7mMbWViu2Z8ucFFCZopov+wDtI6MtHHnSYped5/+NUkR3xfXE5RinJj3jSAvRca/EZQDFl4ACKlIxeToTZCMHAaXZD2KXXgAQjb+Qj3yTMaxmNeCkbwBve4fjgppJU0zgVNLj3wlcMzgYs4InKRu8j8jKB3hr3sMuBZh4ifTA3G809et02cwKiuP7nISts6QNBOklUZ2iJM0qSU0G5jqVJfMPUoG7vFB0NryiLszxTX/zWdXKGRFwMsprECwijqmatrY+f7IYlV+nXl6tflIGCUDfBZbHYe8WAS0NApaweRxAoAKfPJS5xYQ6EsK6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB0837.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:750e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.18; Tue, 8 Dec 2020 00:50:08 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::a094:ed67:fb40:340e]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::a094:ed67:fb40:340e%10]) with mapi id 15.20.3632.021; Tue, 8 Dec 2020 00:50:08 +0000 From: "Abner Chang" To: "Wu, Hao A" , Leif Lindholm CC: "devel@edk2.groups.io" , Liming Gao , "Wang, Jian J" , "Wang, Nickle (HPS SW)" , "O'Hanley, Peter (EXL)" Subject: Re: [edk2-devel] [PATCH v4 1/6] MdeModulePkg/Ucs2Utf8lib: UCS2 to UFT8 manipulation library Thread-Topic: [edk2-devel] [PATCH v4 1/6] MdeModulePkg/Ucs2Utf8lib: UCS2 to UFT8 manipulation library Thread-Index: AQHWzGdSODE2j4SORkSZswTYVXEBGKnrPB1ggAAB1YCAAKPQgIAAfEwAgAAAg7A= Date: Tue, 8 Dec 2020 00:50:08 +0000 Message-ID: References: <20201207053655.29101-1-abner.chang@hpe.com> <20201207053655.29101-2-abner.chang@hpe.com> <20201207172039.GF1664@vanye> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d103b9af-1842-452a-5757-08d89b1335f2 x-ms-traffictypediagnostic: CS1PR8401MB0837: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:127; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fumjeSHXkwiFq4PkeA54St+O7FfCa/xGnUnp3luvXPKqkWlDvF0ny0clplxfCS9tq/bMdpgvG1BLIrLuGPeyQgX9tztfyEVLNIfFe0qUIYQk4YwiyfhcN2wsGbN3L1LCHrgLkiY6t2FydjRUBhw3LMOlIk+8uS30Su2qZV9VtkAOx1WKp1sx+qEsWZNFEGpGWsMaMVrmWbOPAHwnRS1+dH/o5JiEJTG0YFnbEZRuj9aZeeRXWQACj0Fvf5U2lK+4AUpoPzWUJOl+vkzaTEZVosc+YeJttMH46GVezRPblTI8J5n4oEWA9pmZ/p3doVEo/hgkq18/pOOMWxxT7tO7eOXRfjj4BRBbBiAaHdHqq8HQ9t5VhovhLPPI769wnGRD7uN9iQ7eN0KjvSSLo800Aw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(136003)(39860400002)(396003)(366004)(376002)(346002)(54906003)(478600001)(19627235002)(110136005)(86362001)(316002)(71200400001)(5660300002)(52536014)(4326008)(64756008)(7696005)(8936002)(6506007)(8676002)(66946007)(55016002)(83380400001)(30864003)(66446008)(66556008)(33656002)(966005)(66476007)(53546011)(9686003)(2906002)(186003)(76116006)(26005)(579004)(559001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?50oF1V4R2PHKi+1m3YnnTTf0jTZCN6d00wzShQvkOfl82WchuTEFOOIZUTmW?= =?us-ascii?Q?KG0AUpIDEf4AikTfgZylb6YIvsKdpylhoban7HAm2mCN1SxqY6vpNM6hhF/k?= =?us-ascii?Q?f/CKhDr+8sPluPEWB7iNJcgeMwXcygzBCvRZ+Hn6dQd4BpuA0HZ767P5zok8?= =?us-ascii?Q?KLv9oNn4imVpzf9O+g8nV1sUC4QXK9LZ6vWAUkeS79rFLIyHn/NDFIpOYDVW?= =?us-ascii?Q?VIKWO6gDhk3QF20rCCQw58OBF/1VqVb8cb6raW/QMgKGRhGdZZcGe1vNny2x?= =?us-ascii?Q?TDhN58QEpu7gY7nDa6Jjdi9LeKy8rOiyucpFimPj4VUrsfVpm1E8Wvuag9fE?= =?us-ascii?Q?/B4A2XfgUuDVIhvJ0MSSsJRBngoDnHqXY1E1Qe3BMcCHg1d77B6ptgVjp2Ly?= =?us-ascii?Q?aGjIz3J/3NGXsL22Wz/3eZT2H1WFalJKDIiV8Ri8Oju8806dx9kvsQiUoMrg?= =?us-ascii?Q?QDJywFwqpJ5xIefeJ/jW7lk8R4p5VibxLGN058DlcY2dLpSz68BOOLy/pr5d?= =?us-ascii?Q?zTrCxPCWGgblIPWUWEJoQKHn591J59AcvZ8c6h8wuimFJTlEJL6VfHNZ4OOH?= =?us-ascii?Q?3LXvUud32D6ljQUXlcDu22RIQaLxC6PWFo3DM9q2npHuH6kFd5KMyJuhpNFs?= =?us-ascii?Q?ijefCjVcxbIJb0JNhFMZUrc1ncCsjqO9Lizi9CqOV4pJAgBqb/OKMxg41fLl?= =?us-ascii?Q?CEyKgeDYhPqP6lGCK6aOT2DdwwSRLTSbAyD5Ub6Hi4QqZw1im+aoWjc47iyv?= =?us-ascii?Q?aO02zg7oYVvs8v+EwYNiqg4P3stcE6DZRMyJI+X9IVUn/O7Y0QdE6ljdr1qk?= =?us-ascii?Q?zAmJeT/52MODFNU0kImRwGniUFUrpTLMv0pUyPDGicRXybn9G7yzsNCfINNh?= =?us-ascii?Q?yZG8dRGQFqsE2yJImS46E24cXfJVI8iacqQ/EYXHV5Pl46Oi0htSiUGMat6O?= =?us-ascii?Q?jTaq5HgjXgTTkPpURvj+N6aLYnoiR5RbVMpQmheBsXg=3D?= X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: d103b9af-1842-452a-5757-08d89b1335f2 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2020 00:50:08.2894 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m5iy52FfdRC3OpH9IMzqHZ838rdLheKUBon8nxo6LCMSOGOj9gjXzFxLvCTmLKxebAqiCKyi1HJ4MHm6lD3WzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0837 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737 definitions=2020-12-07_19:2020-12-04,2020-12-07 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 clxscore=1015 bulkscore=0 malwarescore=0 impostorscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012080001 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Wu, Hao A [mailto:hao.a.wu@intel.com] > Sent: Tuesday, December 8, 2020 8:46 AM > To: Leif Lindholm > Cc: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io; Liming Gao ; Wang, Jian > J ; Wang, Nickle (HPS SW) ; > O'Hanley, Peter (EXL) > Subject: RE: [edk2-devel] [PATCH v4 1/6] MdeModulePkg/Ucs2Utf8lib: UCS2 > to UFT8 manipulation library >=20 > > -----Original Message----- > > From: Leif Lindholm > > Sent: Tuesday, December 8, 2020 1:21 AM > > To: Wu, Hao A > > Cc: Chang, Abner (HPS SW/FW Technologist) ; > > devel@edk2.groups.io; Liming Gao ; Wang, > > Jian J ; Wang, Nickle (HPS SW) > > ; O'Hanley, Peter (EXL) > > > Subject: Re: [edk2-devel] [PATCH v4 1/6] MdeModulePkg/Ucs2Utf8lib: > > UCS2 to UFT8 manipulation library > > > > Hi Hao Wu, > > > > On Mon, Dec 07, 2020 at 07:34:21 +0000, Wu, Hao A wrote: > > > > > For me, the Ucs2Utf8lib case is kind of similar with the jansson > > > > > library case for the Redfish feature. > > > > > If the current consumer is only the jansson library under the > > > > > RedfishPkg, I would suggest to put the Ucs2Utf8lib under > > > > > RedfishPkg > > first. > > > > > We can move this library to a more generic place if there are > > > > > more consumers. > > > > > > > > > > Best Regards, > > > > > Hao Wu > > > > > > > > Hi Hao, I have no problem with this. Will send patches again. > > > > Thanks > > > > > > > > > Thanks Abner. > > > Leif and Liming, do you have comments on this? Thanks. > > > > I was the one who suggested Abner try to add it to MdeModulePkg, since > > it sounded to me like a generically useful thing to have. >=20 >=20 > Agree that the library looks like a generic one. >=20 > I should have been involved in the discussion earlier. > Sorry for the late response. Don't worry, not a big deal to relocate that lib. Just don't ask me to mov= e it back to MdeModulePkg next week. hah :D >=20 >=20 > > > > But I understand the argument that it should not live there until it > > is known to have multiple users, and I am OK with that. >=20 >=20 > Thanks. >=20 > Best Regards, > Hao Wu >=20 >=20 > > > > Best Regards, > > > > Leif > > > > > Best Regards, > > > Hao Wu > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Abner Chang > > > > > > > > > > > > Cc: Jian J Wang > > > > > > Cc: Hao A Wu > > > > > > Cc: Liming Gao > > > > > > Cc: Leif Lindholm > > > > > > Cc: Nickle Wang > > > > > > Cc: Peter O'Hanley > > > > > > --- > > > > > > .../Include/Library/BaseUcs2Utf8Lib.h | 69 +++ > > > > > > .../Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.c | 417 > > > > > ++++++++++++++++++ > > > > > > .../BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf | 30 ++ > > > > > > MdeModulePkg/MdeModulePkg.dec | 5 + > > > > > > MdeModulePkg/MdeModulePkg.dsc | 2 + > > > > > > 5 files changed, 523 insertions(+) create mode 100644 > > > > > > MdeModulePkg/Include/Library/BaseUcs2Utf8Lib.h > > > > > > create mode 100644 > > > > > > MdeModulePkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.c > > > > > > create mode 100644 > > > > > > MdeModulePkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf > > > > > > > > > > > > diff --git a/MdeModulePkg/Include/Library/BaseUcs2Utf8Lib.h > > > > > > b/MdeModulePkg/Include/Library/BaseUcs2Utf8Lib.h > > > > > > new file mode 100644 > > > > > > index 0000000000..51ae924929 > > > > > > --- /dev/null > > > > > > +++ b/MdeModulePkg/Include/Library/BaseUcs2Utf8Lib.h > > > > > > @@ -0,0 +1,69 @@ > > > > > > +/** @file > > > > > > + UCS2 to UTF8 manipulation library header file. > > > > > > + > > > > > > + Copyright (c) 2019, Intel Corporation. All rights > > > > > > + reserved.
> > > > > > + (C) Copyright 2020 Hewlett Packard Enterprise Development > > > > > > + LP
> > > > > > + > > > > > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > + > > > > > > +**/ > > > > > > + > > > > > > +#ifndef BASE_UCS2UTF8_LIB_H_ > > > > > > +#define BASE_UCS2UTF8_LIB_H_ > > > > > > + > > > > > > +#include > > > > > > +#include > > > > > > +#include > > > > > > +#include #include > > > > > > + #include #include > > > > > > + > > > > > > + > > > > > > +/// > > > > > > +/// L"\u0000" > > > > > > +/// > > > > > > +#define UNICODE_FORMAT_LEN 6 > > > > > > +#define UNICODE_FORMAT_CHAR_LEN 2 > > > > > > +#define UNICODE_FORMAT_CHAR_SIZE 3 > > > > > > + > > > > > > +#define UTF8_BUFFER_FOR_UCS2_MAX_SIZE 3 > > > > > > + > > > > > > +/** > > > > > > + Convert a UCS2 string to a UTF8 encoded string. > > > > > > + > > > > > > + @param[in] Ucs2Str The provided UCS2 stri= ng. > > > > > > + @param[out] Utf8StrAddr The converted UTF8 str= ing > > address. > > > > > Caller > > > > > > + is responsible for Fre= e this string. > > > > > > + > > > > > > + @retval EFI_INVALID_PARAMETER One or more parameters > are > > > > > invalid. > > > > > > + @retval EFI_OUT_OF_RESOURCES System runs out of > > resources. > > > > > > + @retval EFI_SUCCESS The UTF8 encoded strin= g has been > > > > > > converted. > > > > > > + > > > > > > +**/ > > > > > > +EFI_STATUS > > > > > > +UCS2StrToUTF8 ( > > > > > > + IN CHAR16 *Ucs2Str, > > > > > > + OUT CHAR8 **Utf8StrAddr > > > > > > + ); > > > > > > + > > > > > > +/** > > > > > > + Convert a UTF8 encoded string to a UCS2 string. > > > > > > + > > > > > > + @param[in] Utf8Str The provided UTF8 enco= ded string. > > > > > > + @param[out] Ucs2StrAddr The converted UCS2 str= ing > > address. > > > > > > Caller > > > > > > + is responsible for Fre= e this string. > > > > > > + > > > > > > + @retval EFI_INVALID_PARAMETER The UTF8 encoded strin= g is > > not > > > > > valid > > > > > > to > > > > > > + convert to UCS2 string= . > > > > > > + One or more parameters= are invalid. > > > > > > + @retval EFI_OUT_OF_RESOURCES System runs out of > > resources. > > > > > > + @retval EFI_SUCCESS The UCS2 string has be= en > converted. > > > > > > + > > > > > > +**/ > > > > > > +EFI_STATUS > > > > > > +UTF8StrToUCS2 ( > > > > > > + IN CHAR8 *Utf8Str, > > > > > > + OUT CHAR16 **Ucs2StrAddr > > > > > > + ); > > > > > > + > > > > > > +#endif > > > > > > diff --git > > > > > > a/MdeModulePkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.c > > > > > > b/MdeModulePkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.c > > > > > > new file mode 100644 > > > > > > index 0000000000..6cff109a5c > > > > > > --- /dev/null > > > > > > +++ b/MdeModulePkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.c > > > > > > @@ -0,0 +1,417 @@ > > > > > > +/** @file > > > > > > + UCS2 to UTF8 manipulation library. > > > > > > + > > > > > > + Copyright (c) 2018 - 2019, Intel Corporation. All rights > > > > > > + reserved.
> > > > > > + (C) Copyright 2020 Hewlett Packard Enterprise Development > > > > > > + LP
> > > > > > + > > > > > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > + > > > > > > +**/ > > > > > > + > > > > > > +#include > > > > > > + > > > > > > +/** > > > > > > + Since each UCS2 character can be represented by 1-3 UTF8 > > > > > > +encoded characters, > > > > > > + this function is used to retrieve the UTF8 encoding size > > > > > > +for a > > > > > > +UCS2 > > > > > > character. > > > > > > + > > > > > > + @param[in] Utf8Buffer The buffer for UTF8 encoded d= ata. > > > > > > + > > > > > > + @retval Return the size of UTF8 encoding string or 0 i= f it is not > for > > > > > > + UCS2 format. > > > > > > + > > > > > > +**/ > > > > > > +UINT8 > > > > > > +GetUTF8SizeForUCS2 ( > > > > > > + IN CHAR8 *Utf8Buffer > > > > > > + ) > > > > > > +{ > > > > > > + CHAR8 TempChar; > > > > > > + UINT8 Utf8Size; > > > > > > + > > > > > > + ASSERT (Utf8Buffer !=3D NULL); > > > > > > + > > > > > > + TempChar =3D *Utf8Buffer; > > > > > > + if ((TempChar & 0xF0) =3D=3D 0xF0) { > > > > > > + > > > > > > + // > > > > > > + // This format is not for UCS2. > > > > > > + // > > > > > > + return 0; > > > > > > + } > > > > > > + > > > > > > + Utf8Size =3D 1; > > > > > > + if ((TempChar & 0x80) =3D=3D 0x80) { > > > > > > + if ((TempChar & 0xC0) =3D=3D 0xC0) { > > > > > > + > > > > > > + Utf8Size ++; > > > > > > + if ((TempChar & 0xE0) =3D=3D 0xE0) { > > > > > > + > > > > > > + Utf8Size ++; > > > > > > + } > > > > > > + } > > > > > > + } > > > > > > + > > > > > > + return Utf8Size; > > > > > > +} > > > > > > + > > > > > > +/** > > > > > > + Since each UCS2 character can be represented by the format: > > > > > > +\uXXXX, this function > > > > > > + is used to retrieve the UCS2 character from a Unicode forma= t. > > > > > > + Call MUST make sure there are at least 6 Bytes in the input > > > > > > +UTF8 > > buffer. > > > > > > + > > > > > > + @param[in] Utf8Buffer The buffer for UTF8 en= coded data. > > > > > > + @param[out] Ucs2Char The converted UCS2 cha= racter. > > > > > > + > > > > > > + @retval EFI_INVALID_PARAMETER Non-Ascii characters f= ound > > in the > > > > > > hexadecimal > > > > > > + digits string, and can= 't be converted to a UCS2 > > > > > > + character. > > > > > > + @retval EFI_SUCCESS The UCS2 character has= been > > retrieved. > > > > > > + > > > > > > +**/ > > > > > > +EFI_STATUS > > > > > > +GetUCS2CharByFormat ( > > > > > > + IN CHAR8 *Utf8Buffer, > > > > > > + OUT CHAR16 *Ucs2Char > > > > > > + ) > > > > > > +{ > > > > > > + UINT8 Num1; > > > > > > + UINT8 Num2; > > > > > > + UINT8 Index; > > > > > > + CHAR8 Ucs2CharFormat[UNICODE_FORMAT_CHAR_SIZE]; /// > > two > > > > > > Hexadecimal digits Ascii string, like "3F" > > > > > > + > > > > > > + for (Index =3D 0; Index < 4; Index ++) { > > > > > > + if ((*(Utf8Buffer + 2 + Index) & 0x80) !=3D 0x00) { > > > > > > + return EFI_INVALID_PARAMETER; > > > > > > + } > > > > > > + } > > > > > > + > > > > > > + ZeroMem (Ucs2CharFormat, UNICODE_FORMAT_CHAR_SIZE); > > > > > > + > > > > > > + // > > > > > > + // Get the First Number, Offset is 2 // CopyMem > > > > > > + (Ucs2CharFormat, Utf8Buffer + 2, > > > > > > UNICODE_FORMAT_CHAR_LEN); > > > > > > + Num1 =3D (UINT8) AsciiStrHexToUintn (Ucs2CharFormat); > > > > > > + > > > > > > + // > > > > > > + // Get the Second Number, Offset is 4 // CopyMem > > > > > > + (Ucs2CharFormat, Utf8Buffer + 4, > UNICODE_FORMAT_CHAR_LEN); > > > > > > + Num2 =3D (UINT8) AsciiStrHexToUintn (Ucs2CharFormat); > > > > > > + > > > > > > + // > > > > > > + // Ucs2Char is Little-Endian // > > > > > > + *((CHAR8 *) Ucs2Char) =3D Num2; > > > > > > + *(((CHAR8 *) Ucs2Char) + 1) =3D Num1; > > > > > > + > > > > > > + return EFI_SUCCESS; > > > > > > +} > > > > > > + > > > > > > +/** > > > > > > + Convert a UCS2 character to UTF8 encoding string. > > > > > > + > > > > > > + @param[in] Ucs2Char The provided UCS2 char= acter. > > > > > > + @param[out] Utf8Buffer The converted UTF8 enc= oded > data. > > > > > > + > > > > > > + @retval Return the size of UTF8 encoding data for this= UCS2 > > character. > > > > > > + > > > > > > +**/ > > > > > > +UINT8 > > > > > > +UCS2CharToUTF8 ( > > > > > > + IN CHAR16 Ucs2Char, > > > > > > + OUT CHAR8 *Utf8Buffer > > > > > > + ) > > > > > > +{ > > > > > > + UINT16 Ucs2Number; > > > > > > + > > > > > > + ASSERT (Utf8Buffer !=3D NULL); > > > > > > + > > > > > > + Ucs2Number =3D (UINT16) Ucs2Char; if (Ucs2Number <=3D 0x00= 7F) > > > > > > + { > > > > > > + > > > > > > + // > > > > > > + // UTF8 format: 0xxxxxxx > > > > > > + // > > > > > > + *Utf8Buffer =3D Ucs2Char & 0x7F; > > > > > > + return 1; > > > > > > + > > > > > > + } else if (Ucs2Number >=3D 0x0080 && Ucs2Number <=3D 0x07FF= ) { > > > > > > + > > > > > > + // > > > > > > + // UTF8 format: 110xxxxx 10xxxxxx > > > > > > + // > > > > > > + *(Utf8Buffer + 1) =3D (Ucs2Char & 0x3F) | 0x80; > > > > > > + *Utf8Buffer =3D ((Ucs2Char >> 6) & 0x1F) | 0xC0; > > > > > > + return 2; > > > > > > + > > > > > > + } else { /// Ucs2Number >=3D 0x0800 && Ucs2Number <=3D 0xF= FFF > > > > > > + > > > > > > + // > > > > > > + // UTF8 format: 1110xxxx 10xxxxxx 10xxxxxx > > > > > > + // > > > > > > + *(Utf8Buffer + 2) =3D (Ucs2Char & 0x3F) | 0x80; > > > > > > + *(Utf8Buffer + 1) =3D ((Ucs2Char >> 6) & 0x3F) | 0x80; > > > > > > + *Utf8Buffer =3D ((Ucs2Char >> 12) & 0x0F) | 0xE0; > > > > > > + return 3; > > > > > > + } > > > > > > +} > > > > > > + > > > > > > +/** > > > > > > + Convert a UTF8 encoded data to a UCS2 character. > > > > > > + > > > > > > + @param[in] Utf8Buffer The provided UTF8 enco= ded data. > > > > > > + @param[out] Ucs2Char The converted UCS2 cha= racter. > > > > > > + > > > > > > + @retval EFI_INVALID_PARAMETER The UTF8 encoded strin= g is > > not > > > > > valid > > > > > > or > > > > > > + not for UCS2 character= . > > > > > > + @retval EFI_SUCCESS The converted UCS2 cha= racter. > > > > > > + > > > > > > +**/ > > > > > > +EFI_STATUS > > > > > > +UTF8ToUCS2Char ( > > > > > > + IN CHAR8 *Utf8Buffer, > > > > > > + OUT CHAR16 *Ucs2Char > > > > > > + ) > > > > > > +{ > > > > > > + UINT8 Utf8Size; > > > > > > + CHAR8 *Ucs2Buffer; > > > > > > + CHAR8 TempChar1; > > > > > > + CHAR8 TempChar2; > > > > > > + CHAR8 TempChar3; > > > > > > + > > > > > > + ASSERT (Utf8Buffer !=3D NULL && Ucs2Char !=3D NULL); ZeroM= em > > > > > > + (Ucs2Char, sizeof (CHAR16)); Ucs2Buffer =3D (CHAR8 *) > > > > > > + Ucs2Char; > > > > > > + > > > > > > + Utf8Size =3D GetUTF8SizeForUCS2 (Utf8Buffer); switch > > > > > > + (Utf8Size) { > > > > > > + > > > > > > + case 1: > > > > > > + > > > > > > + // > > > > > > + // UTF8 format: 0xxxxxxx > > > > > > + // > > > > > > + TempChar1 =3D *Utf8Buffer; > > > > > > + if ((TempChar1 & 0x80) !=3D 0x00) { > > > > > > + return EFI_INVALID_PARAMETER; > > > > > > + } > > > > > > + > > > > > > + *Ucs2Buffer =3D TempChar1; > > > > > > + *(Ucs2Buffer + 1) =3D 0; > > > > > > + break; > > > > > > + > > > > > > + case 2: > > > > > > + > > > > > > + // > > > > > > + // UTF8 format: 110xxxxx 10xxxxxx > > > > > > + // > > > > > > + TempChar1 =3D *Utf8Buffer; > > > > > > + if ((TempChar1 & 0xE0) !=3D 0xC0) { > > > > > > + return EFI_INVALID_PARAMETER; > > > > > > + } > > > > > > + > > > > > > + TempChar2 =3D *(Utf8Buffer + 1); > > > > > > + if ((TempChar2 & 0xC0) !=3D 0x80) { > > > > > > + return EFI_INVALID_PARAMETER; > > > > > > + } > > > > > > + > > > > > > + *Ucs2Buffer =3D (TempChar1 << 6) + (TempChar2 & 0= x3F); > > > > > > + *(Ucs2Buffer + 1) =3D (TempChar1 >> 2) & 0x07; > > > > > > + break; > > > > > > + > > > > > > + case 3: > > > > > > + > > > > > > + // > > > > > > + // UTF8 format: 1110xxxx 10xxxxxx 10xxxxxx > > > > > > + // > > > > > > + TempChar1 =3D *Utf8Buffer; > > > > > > + if ((TempChar1 & 0xF0) !=3D 0xE0) { > > > > > > + return EFI_INVALID_PARAMETER; > > > > > > + } > > > > > > + > > > > > > + TempChar2 =3D *(Utf8Buffer + 1); > > > > > > + if ((TempChar2 & 0xC0) !=3D 0x80) { > > > > > > + return EFI_INVALID_PARAMETER; > > > > > > + } > > > > > > + > > > > > > + TempChar3 =3D *(Utf8Buffer + 2); > > > > > > + if ((TempChar3 & 0xC0) !=3D 0x80) { > > > > > > + return EFI_INVALID_PARAMETER; > > > > > > + } > > > > > > + > > > > > > + *Ucs2Buffer =3D (TempChar2 << 6) + (TempChar3 & 0= x3F); > > > > > > + *(Ucs2Buffer + 1) =3D (TempChar1 << 4) + ((TempChar2 >> > > > > > > + 2) & 0x0F); > > > > > > + > > > > > > + break; > > > > > > + > > > > > > + default: > > > > > > + > > > > > > + return EFI_INVALID_PARAMETER; } > > > > > > + > > > > > > + return EFI_SUCCESS; > > > > > > +} > > > > > > + > > > > > > +/** > > > > > > + Convert a UCS2 string to a UTF8 encoded string. > > > > > > + > > > > > > + @param[in] Ucs2Str The provided UCS2 stri= ng. > > > > > > + @param[out] Utf8StrAddr The converted UTF8 str= ing > > address. > > > > > Caller > > > > > > + is responsible for Fre= e this string. > > > > > > + > > > > > > + @retval EFI_INVALID_PARAMETER One or more parameters > are > > > > > invalid. > > > > > > + @retval EFI_OUT_OF_RESOURCES System runs out of > > resources. > > > > > > + @retval EFI_SUCCESS The UTF8 encoded strin= g has been > > > > > > converted. > > > > > > + > > > > > > +**/ > > > > > > +EFI_STATUS > > > > > > +UCS2StrToUTF8 ( > > > > > > + IN CHAR16 *Ucs2Str, > > > > > > + OUT CHAR8 **Utf8StrAddr > > > > > > + ) > > > > > > +{ > > > > > > + UINTN Ucs2StrIndex; > > > > > > + UINTN Ucs2StrLength; > > > > > > + CHAR8 *Utf8Str; > > > > > > + UINTN Utf8StrLength; > > > > > > + UINTN Utf8StrIndex; > > > > > > + CHAR8 Utf8Buffer[UTF8_BUFFER_FOR_UCS2_MAX_SIZE]; > > > > > > + UINT8 Utf8BufferSize; > > > > > > + > > > > > > + if (Ucs2Str =3D=3D NULL || Utf8StrAddr =3D=3D NULL) { > > > > > > + return EFI_INVALID_PARAMETER; } > > > > > > + > > > > > > + Ucs2StrLength =3D StrLen (Ucs2Str); Utf8StrLength =3D 0; > > > > > > + > > > > > > + for (Ucs2StrIndex =3D 0; Ucs2StrIndex < Ucs2StrLength; > > > > > > + Ucs2StrIndex > > > > > > + ++) { > > > > > > + > > > > > > + ZeroMem (Utf8Buffer, sizeof (Utf8Buffer)); > > > > > > + Utf8BufferSize =3D UCS2CharToUTF8 (Ucs2Str[Ucs2StrIndex], > > Utf8Buffer); > > > > > > + Utf8StrLength +=3D Utf8BufferSize; } > > > > > > + > > > > > > + Utf8Str =3D AllocateZeroPool (Utf8StrLength + 1); if > > > > > > + (Utf8Str =3D=3D > > > > > > + NULL) { > > > > > > + return EFI_OUT_OF_RESOURCES; } > > > > > > + > > > > > > + Utf8StrIndex =3D 0; > > > > > > + for (Ucs2StrIndex =3D 0; Ucs2StrIndex < Ucs2StrLength; > > > > > > + Ucs2StrIndex > > > > > > + ++) { > > > > > > + > > > > > > + ZeroMem (Utf8Buffer, sizeof (Utf8Buffer)); > > > > > > + Utf8BufferSize =3D UCS2CharToUTF8 (Ucs2Str[Ucs2StrIndex], > > > > > > + Utf8Buffer); > > > > > > + > > > > > > + CopyMem (Utf8Str + Utf8StrIndex, Utf8Buffer, Utf8BufferSi= ze); > > > > > > + Utf8StrIndex +=3D Utf8BufferSize; } > > > > > > + > > > > > > + Utf8Str[Utf8StrIndex] =3D '\0'; *Utf8StrAddr =3D Utf8Str; > > > > > > + > > > > > > + return EFI_SUCCESS; > > > > > > +} > > > > > > + > > > > > > +/** > > > > > > + Convert a UTF8 encoded string to a UCS2 string. > > > > > > + > > > > > > + @param[in] Utf8Str The provided UTF8 enco= ded string. > > > > > > + @param[out] Ucs2StrAddr The converted UCS2 str= ing > > address. > > > > > > Caller > > > > > > + is responsible for Fre= e this string. > > > > > > + > > > > > > + @retval EFI_INVALID_PARAMETER The UTF8 encoded strin= g is > > not > > > > > valid > > > > > > to > > > > > > + convert to UCS2 string= . > > > > > > + One or more parameters= are invalid. > > > > > > + @retval EFI_OUT_OF_RESOURCES System runs out of > > resources. > > > > > > + @retval EFI_SUCCESS The UCS2 string has be= en > converted. > > > > > > + > > > > > > +**/ > > > > > > +EFI_STATUS > > > > > > +UTF8StrToUCS2 ( > > > > > > + IN CHAR8 *Utf8Str, > > > > > > + OUT CHAR16 **Ucs2StrAddr > > > > > > + ) > > > > > > +{ > > > > > > + EFI_STATUS Status; > > > > > > + UINTN Utf8StrIndex; > > > > > > + UINTN Utf8StrLength; > > > > > > + UINTN Ucs2StrIndex; > > > > > > + UINT8 Utf8BufferSize; > > > > > > + CHAR16 *Ucs2StrTemp; > > > > > > + > > > > > > + if (Utf8Str =3D=3D NULL || Ucs2StrAddr =3D=3D NULL) { > > > > > > + return EFI_INVALID_PARAMETER; } > > > > > > + > > > > > > + // > > > > > > + // It is not an Ascii string, calculate string length. > > > > > > + // > > > > > > + Utf8StrLength =3D 0; > > > > > > + while (*(Utf8Str + Utf8StrLength) !=3D '\0') { > > > > > > + Utf8StrLength ++; > > > > > > + } > > > > > > + > > > > > > + // > > > > > > + // UCS2 string shall not be longer than the UTF8 string. > > > > > > + // > > > > > > + Ucs2StrTemp =3D AllocateZeroPool ((Utf8StrLength + 1) * > > > > > > + sizeof (CHAR16)); if (Ucs2StrTemp =3D=3D NULL) { > > > > > > + return EFI_OUT_OF_RESOURCES; } > > > > > > + > > > > > > + Utf8StrIndex =3D 0; > > > > > > + Ucs2StrIndex =3D 0; > > > > > > + while (Utf8Str[Utf8StrIndex] !=3D '\0') { > > > > > > + > > > > > > + if (CompareMem (Utf8Str + Utf8StrIndex, "\\u", 2) =3D=3D = 0 && > > > > > > + Utf8StrLength - Utf8StrIndex >=3D UNICODE_FORMAT_LEN) { > > > > > > + > > > > > > + Status =3D GetUCS2CharByFormat (Utf8Str + Utf8StrIndex, > > > > > > + Ucs2StrTemp + > > > > > > Ucs2StrIndex); > > > > > > + if (!EFI_ERROR (Status)) { > > > > > > + > > > > > > + Utf8StrIndex +=3D UNICODE_FORMAT_LEN; > > > > > > + Ucs2StrIndex ++; > > > > > > + } else { > > > > > > + > > > > > > + StrCpyS (Ucs2StrTemp + Ucs2StrIndex, 3, L"\\u"); > > > > > > + > > > > > > + Ucs2StrIndex +=3D 2; > > > > > > + Utf8StrIndex +=3D 2; > > > > > > + } > > > > > > + } else { > > > > > > + > > > > > > + Utf8BufferSize =3D GetUTF8SizeForUCS2 (Utf8Str + Utf8St= rIndex); > > > > > > + if (Utf8BufferSize =3D=3D 0 || Utf8StrLength - Utf8StrI= ndex > > > > > > + < > > > > > > + Utf8BufferSize) { > > > > > > + > > > > > > + FreePool (Ucs2StrTemp); > > > > > > + return EFI_INVALID_PARAMETER; > > > > > > + } > > > > > > + > > > > > > + Status =3D UTF8ToUCS2Char (Utf8Str + Utf8StrIndex, > > > > > > + Ucs2StrTemp > > > > > > + + > > > > > > Ucs2StrIndex); > > > > > > + if (EFI_ERROR (Status)) { > > > > > > + > > > > > > + FreePool (Ucs2StrTemp); > > > > > > + return EFI_INVALID_PARAMETER; > > > > > > + } > > > > > > + > > > > > > + Ucs2StrIndex ++; > > > > > > + Utf8StrIndex +=3D Utf8BufferSize; > > > > > > + } > > > > > > + } > > > > > > + > > > > > > + *Ucs2StrAddr =3D AllocateZeroPool ((Ucs2StrIndex + 1) * > > > > > > + sizeof (CHAR16)); if (*Ucs2StrAddr =3D=3D NULL) { > > > > > > + > > > > > > + FreePool (Ucs2StrTemp); > > > > > > + return EFI_OUT_OF_RESOURCES; } > > > > > > + > > > > > > + StrCpyS (*Ucs2StrAddr, Ucs2StrIndex + 1, Ucs2StrTemp); > > > > > > + *(*Ucs2StrAddr + Ucs2StrIndex) =3D L'\0'; FreePool > > > > > > + (Ucs2StrTemp); > > > > > > + > > > > > > + return EFI_SUCCESS; > > > > > > +} > > > > > > + > > > > > > diff --git > > > > > > a/MdeModulePkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf > > > > > > b/MdeModulePkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf > > > > > > new file mode 100644 > > > > > > index 0000000000..93efb1fb88 > > > > > > --- /dev/null > > > > > > +++ > b/MdeModulePkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf > > > > > > @@ -0,0 +1,30 @@ > > > > > > +## @file > > > > > > +# UCS2 to UTF8 manipulation library. > > > > > > +# > > > > > > +# Copyright (c) 2019, Intel Corporation. All rights > > > > > > +reserved.
# > > > > > > +(C) Copyright 2020 Hewlett Packard Enterprise Development > > > > > > +LP
> > # > > > > > > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > +# > > > > > > +## > > > > > > + > > > > > > +[Defines] > > > > > > + INF_VERSION =3D 0x0001001b > > > > > > + BASE_NAME =3D BaseUcs2Utf8Lib > > > > > > + FILE_GUID =3D 536646C3-46D0-4B12-ABC4-= CDE1A33B5256 > > > > > > + MODULE_TYPE =3D BASE > > > > > > + VERSION_STRING =3D 1.0 > > > > > > + LIBRARY_CLASS =3D Ucs2Utf8Lib > > > > > > + > > > > > > +# > > > > > > +# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 RIS= CV64 > > > > > > +# > > > > > > + > > > > > > +[Sources.common] > > > > > > + BaseUcs2Utf8Lib.c > > > > > > + > > > > > > +[Packages] > > > > > > + MdePkg/MdePkg.dec > > > > > > + MdeModulePkg/MdeModulePkg.dec > > > > > > + > > > > > > + > > > > > > diff --git a/MdeModulePkg/MdeModulePkg.dec > > > > > > b/MdeModulePkg/MdeModulePkg.dec index > > 9b52b34494..1cd8c6392d > > > > > > 100644 > > > > > > --- a/MdeModulePkg/MdeModulePkg.dec > > > > > > +++ b/MdeModulePkg/MdeModulePkg.dec > > > > > > @@ -154,6 +154,11 @@ > > > > > > # > > > > > > > > > > > > VariablePolicyHelperLib|Include/Library/VariablePolicyHelperLi= b. > > > > > > h > > > > > > > > > > > > + ## @libraryclass This library provides UCS2 to UTF8 manip= ulation > > > > > > + # functions. > > > > > > + # > > > > > > + Ucs2Utf8Lib|Include/Library/BaseUcs2Utf8Lib.h > > > > > > + > > > > > > [Guids] > > > > > > ## MdeModule package token space guid > > > > > > # Include/Guid/MdeModulePkgTokenSpace.h > > > > > > diff --git a/MdeModulePkg/MdeModulePkg.dsc > > > > > > b/MdeModulePkg/MdeModulePkg.dsc index > > 90165ca443..85e2daeeea > > > > > > 100644 > > > > > > --- a/MdeModulePkg/MdeModulePkg.dsc > > > > > > +++ b/MdeModulePkg/MdeModulePkg.dsc > > > > > > @@ -43,6 +43,7 @@ > > > > > > PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > > > > > > > > > > > > > > > > > > > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/B > > > > > PeCoffGetEntryPointLib|ase > > > > > > PeCoffGetEntryPointLib.inf > > > > > > SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > > > > > > + > > > > > > > > > > > > > Ucs2Utf8Lib|MdeModulePkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.i > > > > > Ucs2Utf8Lib|nf > > > > > > # > > > > > > # UEFI & PI > > > > > > # > > > > > > @@ -212,6 +213,7 @@ > > > > > > > > > > > > > > MdeModulePkg/Application/MemoryProfileInfo/MemoryProfileInfo.inf > > > > > > > > > > > > MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > > > > > > + MdeModulePkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf > > > > > > MdeModulePkg/Logo/Logo.inf > > > > > > MdeModulePkg/Logo/LogoDxe.inf > > > > > > MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > > > > > > -- > > > > > > 2.17.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > > > > > > > > > > > >