From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web11.10832.1594689213825036898 for ; Mon, 13 Jul 2020 18:13:33 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0464124c73=abner.chang@hpe.com) Received: from pps.filterd (m0134420.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06E18nat012064; Tue, 14 Jul 2020 01:13:33 GMT Received: from g2t2354.austin.hpe.com (g2t2354.austin.hpe.com [15.233.44.27]) by mx0b-002e3701.pphosted.com with ESMTP id 327qhubhhn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Jul 2020 01:13:33 +0000 Received: from G9W8456.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.216.161.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2354.austin.hpe.com (Postfix) with ESMTPS id 7FCBEB5; Tue, 14 Jul 2020 01:13:32 +0000 (UTC) Received: from G4W9120.americas.hpqcorp.net (2002:10d2:150f::10d2:150f) by G9W8456.americas.hpqcorp.net (2002:10d8:a15f::10d8:a15f) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 14 Jul 2020 01:13:31 +0000 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (15.241.52.10) by G4W9120.americas.hpqcorp.net (16.210.21.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 14 Jul 2020 01:13:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E8i6LFt5hR/vcO1hL8qXkJHsdRywBVn62ZEQ+Amv2tBnAjcWtPv0tETxOPVkN4bFDmG2vDKVw2vZtzScfXZnqPin1WaPUZ6p5PurbIcC5eDzxcTtQvq6EamriLqpI+4vEup8GSRVO3CH3gbucKNUJjxAZQR1uh47fRb4bwP0gdWKRBMUiL/nWHTGKTycgQb5e0hFusPRfzj8FO3XG3a3x4loQO+TLVthTYsk8fgg2+d9yFbQLEjGuucQX1DSHGr8GNZBMAdMFCKKYAbel1jQUMuyp/bOvnlMkYj8duvaD7jRRCjeSO5rEZQopTqsbb2nUj41xrolttb0oPKgR27Jgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1VqSf6nRI8Ef9wno+yPTGFnQVoe8v2+8MeI9PX8RBdQ=; b=NiYsWo4UTBllzT6NmFw4DI+qN9sFVjRklqN+njPjwfuGHtnfXasbDKgysS0PuNUCicetq8AHn6Kn/4kw/A8sfcuvy9mTMwL2gG4I8Ow5dzKF21YdefwlyEl/COyF0KYL6g3jDSxIJ7MiNH6OJLwCuS2OIRen0aNkDU9uE6K7B99KKP7eJX7USpKtBtiRbyljroLn0j4s7uJg/IztTnAQIdBC6zrRHE5X4BC+bxMvLTNzpBqR1zRRBACBKHIwmqRrIYVB5cbwzSutPUIT9ELb901d/z90PPUdzuwMzuaeuoWWXpW5aeVebXFOG3yF8xGPpV8+Yf8r1b7el3VcxEFScA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB1189.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7513::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Tue, 14 Jul 2020 01:13:30 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::58f4:cfb4:beb0:f5d5]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::58f4:cfb4:beb0:f5d5%7]) with mapi id 15.20.3174.025; Tue, 14 Jul 2020 01:13:30 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "lersek@redhat.com" CC: "Schaefer, Daniel (DualStudy)" , Jian J Wang , Xiaoyu Lu , Leif Lindholm , "Chen, Gilbert" Subject: Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 05/11] CryptoPkg: Add RISC-V architecture for EDK2 CI. Thread-Topic: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 05/11] CryptoPkg: Add RISC-V architecture for EDK2 CI. Thread-Index: AQHWWPfL6mrUSrsfx02gjP5Brbs8n6kFzosAgAB3SyA= Date: Tue, 14 Jul 2020 01:13:30 +0000 Message-ID: References: <20200306053620.12131-1-abner.chang@hpe.com> <20200306053620.12131-6-abner.chang@hpe.com> <4ec64acb-bd72-40c2-c994-38835cdc0a3e@redhat.com> <58c52e88-7df5-d7e8-56d0-e2e355ba64b9@redhat.com> In-Reply-To: <58c52e88-7df5-d7e8-56d0-e2e355ba64b9@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=hpe.com; x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2e889ea9-b4ec-45f9-21e5-08d827931ecf x-ms-traffictypediagnostic: CS1PR8401MB1189: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: loUY3q9fpdJVyzF7F+1QfNPiM8NE+s3WpOw/n6ZOfAzDa+p0f9vOOwYUi+/rcj8y9w7JoP7iYfbF2m0TJwvTPKJ4cdRZkccouCB453r0HCl0TiiD0RjsdTAfbwSyMyYQ6wdsKjcdiNujCU+sRDQ0eio3UflBA2wkZBphlT1u1oddlp8fc9ZWqrsi5RwvFLMqxef5N/CP2x4Lei0NY6c8RqvbBY2DSMG7D+6Bb5aiz5orINcB8AXcdaxk2SRI4vEpszCWKdW0PtLrl115LUgtEHj4M89elUXPqEkQLd7xlEPCwBga3Fu5uvVBokxbpDJi695EFsL8B5v7e4JlqlqRX6pBDxpgw4m8sIaCB/CeKZKXGS6+FWjUPeYKTeEDJnMaN9sZ+IpkeSGhE98kpak1rg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFTY:;SFS:(396003)(346002)(376002)(366004)(136003)(39860400002)(478600001)(26005)(7696005)(86362001)(5660300002)(66556008)(83380400001)(8676002)(71200400001)(54906003)(76116006)(33656002)(53546011)(110136005)(9686003)(52536014)(316002)(66946007)(66446008)(66476007)(55016002)(8936002)(6506007)(64756008)(2906002)(4326008)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: FQuazvzgyKiGXj8ixmHLgnxgxW5Y3aZrO6W6iF9fs4/au/ijnvfDO4/fO+YSjS2GqRDcfjo/+tIe2Da7xcPN5IswwoWgfvBIpMxoYlWyY/q20gNBxFYVPTNxTSyMIETq5ehn0EqJeJEptt8QxEZ/3P8g6M2bdPdBUYqlYZu5pYLqL1HHRxT9OGO9xAfOFGsAgHYpzt+85kk9YHyg68N4a5cDtkFMbe3NATJJLzMocgLHg3Q02mWW63h8u7NcDoxuBHmhu1OM7VackkVKVSDd91327Bs2l4ZxWkqTtAQ2jTokxI8rPfe+DrlvP6iDQB9vNloBH2hijcpeGiLSGuQtS5ljeSIXMnZESR/T+Aqokn9RX0dYi2DtiR/NfbxJexMVU9mpWCOSiphODKutYSdSUPFZRdOMzDGKISFpHp6vGKUBw1HvdCaYrcokAmUjM6MLn0l0K6wj4JoTbUcXtO3aIsuA4TJNf6fiP8qb8912TSsfgwBclBYmLdiWL2W5xaCH X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 2e889ea9-b4ec-45f9-21e5-08d827931ecf X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2020 01:13:30.2002 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P2Cmmh75818ikCrBR8B+Ov/6gH1Lbp2LaK51tT3CZwm7v+iXqyAVsfbX3ei9llp33HpZj48Gq0qbzIIXvNJJfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB1189 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-13_17:2020-07-13,2020-07-13 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 mlxlogscore=999 impostorscore=0 bulkscore=0 phishscore=0 adultscore=0 mlxscore=0 spamscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007140005 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sure Laszlo, I will figure it out. > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Tuesday, July 14, 2020 2:06 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Schaefer, Daniel (DualStudy) ; Jian J Wang > ; Xiaoyu Lu ; Leif Lindholm > ; Chen, Gilbert > Subject: Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 > 05/11] CryptoPkg: Add RISC-V architecture for EDK2 CI. >=20 > On 07/13/20 11:27, Laszlo Ersek wrote: > > Hi Abner, > > > > just noticed the following difference in this patch (now commit > > 9025a014f9d9a): > > > > On 03/06/20 06:36, Abner Chang wrote: > > > >> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > >> b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > >> index 3fa52f5543..01ee665183 100644 > >> --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > >> +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > >> @@ -661,6 +662,7 @@ > >> GCC:*_*_X64_CC_FLAGS =3D -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) - > Wno-error=3Dmaybe-uninitialized -Wno-error=3Dformat -Wno-format -Wno- > error=3Dunused-but-set-variable -DNO_MSABI_VA_FUNCS > >> GCC:*_*_ARM_CC_FLAGS =3D $(OPENSSL_FLAGS) -Wno-error=3Dmaybe- > uninitialized -Wno-error=3Dunused-but-set-variable > >> GCC:*_*_AARCH64_CC_FLAGS =3D $(OPENSSL_FLAGS) > >> -Wno-error=3Dmaybe-uninitialized -Wno-format > >> -Wno-error=3Dunused-but-set-variable > >> + GCC:*_*_RISCV64_CC_FLAGS =3D $(OPENSSL_FLAGS) -Wno- > error=3Dformat > >> + -Wno-error=3Dmaybe-uninitialized -Wno-format > >> + -Wno-error=3Dunused-but-set-variable > >> GCC:*_CLANG35_*_CC_FLAGS =3D -std=3Dc99 -Wno-error=3Duninitialized > >> GCC:*_CLANG38_*_CC_FLAGS =3D -std=3Dc99 -Wno-error=3Duninitialized > >> GCC:*_CLANGPDB_*_CC_FLAGS =3D -std=3Dc99 -Wno-error=3Duninitialized > >> -Wno-error=3Dincompatible-pointer-types -Wno-error=3Dpointer-sign > >> -Wno-error=3Dimplicit-function-declaration > >> -Wno-error=3Dignored-pragma-optimize > > > > vs. > > > >> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > >> b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > >> index f1f9fbb938..5c2206f6fb 100644 > >> --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > >> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > >> @@ -610,6 +611,7 @@ > >> GCC:*_*_X64_CC_FLAGS =3D -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) - > Wno-error=3Dmaybe-uninitialized -Wno-error=3Dformat -Wno-format -Wno- > error=3Dunused-but-set-variable -DNO_MSABI_VA_FUNCS > >> GCC:*_*_ARM_CC_FLAGS =3D $(OPENSSL_FLAGS) -Wno-error=3Dmaybe- > uninitialized -Wno-error=3Dunused-but-set-variable > >> GCC:*_*_AARCH64_CC_FLAGS =3D $(OPENSSL_FLAGS) > >> -Wno-error=3Dmaybe-uninitialized -Wno-format > >> -Wno-error=3Dunused-but-set-variable > >> + GCC:*_*_RISCV64_CC_FLAGS =3D $(OPENSSL_FLAGS) > >> + -Wno-error=3Dmaybe-uninitialized -Wno-format > >> + -Wno-error=3Dunused-but-set-variable > >> GCC:*_CLANG35_*_CC_FLAGS =3D -std=3Dc99 -Wno-error=3Duninitialized > >> GCC:*_CLANG38_*_CC_FLAGS =3D -std=3Dc99 -Wno-error=3Duninitialized > >> GCC:*_CLANGPDB_*_CC_FLAGS =3D -std=3Dc99 -Wno-error=3Duninitialized > >> -Wno-error=3Dincompatible-pointer-types -Wno-error=3Dpointer-sign > >> -Wno-error=3Dimplicit-function-declaration > >> -Wno-error=3Dignored-pragma-optimize > > > > Why do RISCV64_CC_FLAGS differ between "OpensslLib.inf" and > > "OpensslLibCrypto.inf"? > > > > The former has "-Wno-error=3Dformat" additionally. I think we should > > either remove it, or else add it to "OpensslLibCrypto.inf" as well. > > > > These INF files should be easily diffable against each other. The only > > differences should be (a) in the generated file list (the > > "OpensslLib.inf" file should list a bunch of "ssl/..." pathnames, > > while the other INF file should list none), and (b) in the BASE_NAME / > > MODULE_UNI_FILE / FILE_GUID defines. > > > > If you agree, can you please submit a patch, for eliminating the > > difference in RISCV64_CC_FLAGS? >=20 > I've filed about = this. >=20 > Thanks > Laszlo