From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web09.7178.1604634953177728558 for ; Thu, 05 Nov 2020 19:55:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=JylEmLwY; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=057929b778=abner.chang@hpe.com) Received: from pps.filterd (m0134420.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0A63r5Cn001989; Fri, 6 Nov 2020 03:55:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=XZaZmi+H6Hrdz8ePqzQRAbJWkgS7wrtOKIS/8SLAvfY=; b=JylEmLwY+DmNXHNi7rkfew1lWX1GCRzE0+lIMyOl5le1rNvGXZ9p88vAiNuK7hg7fYyf s2jhw62PTyrJinFtdk32z46PelAwrL1AQhGuKoL+Aadvf5pwekjfY7WQgnG96lcAzdPK s0vG/qGJBJxrymVkTX+f2WNHH0fYrhxRbZIfRujz1rNqVIixz6UVjmsAoPaJxUjdo7Hq vOy7DdySdprDdgDzdZN/9McLuZnFg1fjnne7iXO9piCQrMpift90D9O3hnyXu0RezoE2 NuXmzZHoep62UMGQUOUekMVVpwL0u5iHDF6ak0ldORRBYnI8p6Iah8At5rTfBi+WW6kB nw== Received: from g4t3426.houston.hpe.com (g4t3426.houston.hpe.com [15.241.140.75]) by mx0b-002e3701.pphosted.com with ESMTP id 34kc8dxtxq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 06 Nov 2020 03:55:50 +0000 Received: from G4W9121.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.210.21.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3426.houston.hpe.com (Postfix) with ESMTPS id 2A63362; Fri, 6 Nov 2020 03:55:49 +0000 (UTC) Received: from G1W8107.americas.hpqcorp.net (2002:10c1:483b::10c1:483b) by G4W9121.americas.hpqcorp.net (2002:10d2:1510::10d2:1510) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 6 Nov 2020 03:55:48 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (15.241.52.11) by G1W8107.americas.hpqcorp.net (16.193.72.59) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 6 Nov 2020 03:55:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dKp8YzBWQBd4Z2IB1qpchmT3hgrBeCNFuwVXp/8WREyecXgxLMLw3YG/TotphULYluzTT9sZYM0ptNIeK0Ds7WZKZDG+ir5QipYgSlWKtnr1kHsU4lDNx/NIKTtliWhYW6Mv5/T2GA/j7FxQUMzmdjBR3VUzLoMSrLQ9lD5F4RO3/KnR3/1OxCyW/1reZO4Z9U3fUuRcgMBhuJAtBr2UJuNRQVr6gDbvKFdtyGizL1ubYttafd1E1iir7SWKPDIngZqoyRydLD4fDU9uQHqJ+hNkdHt0D4/frKk45NbzAx0wKexwxxf/3xMU7v94H23TtA51InWjSfJrGlOKj44c0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EyaY+QfDWd2UZKranUl6rEhPphcZiZT6OXaKhgzWtGU=; b=DJRtza5lZSa+N/77kTES+TTYxSUzWCBlqx0coMlf3aXZUiceeClo87MG02AapzWC5mLQwLoPD8zHdh8oqKW5Rox6g95P+9rwbveBbBPYXZuqHP4zkJB7logbWspBLByk/jtE4mCyAxkzHixllB64vEtC48PTganpCMNQvCNSv0qOR1658owZuYVKBGM//SiAafx485/BNiAYtiNibWvgU0bI66VPGRC1H1Jjz9zaOzNAjxAu51avwSilzb9TFb04Pan4RXBXLYYhpok+3N/86s0zXLVijA+L9PIKI9hGA751YaLW+yOWPdCO929HPAUQZP5XLhYaNakneB38AQAKOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB0999.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:750f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.28; Fri, 6 Nov 2020 03:55:46 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5160:2077:988c:5e76]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5160:2077:988c:5e76%11]) with mapi id 15.20.3541.021; Fri, 6 Nov 2020 03:55:46 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "Chang, Abner (HPS SW/FW Technologist)" CC: Dandan Bi , Eric Dong , "Wang, Nickle (HPS SW)" , gaoliming Subject: Re: [edk2-devel] [VFR support REST_STYLE PATCH v4 3/4] MdeModulePkg/Library: Revise HiiLib to check REST_STYLE Thread-Topic: [edk2-devel] [VFR support REST_STYLE PATCH v4 3/4] MdeModulePkg/Library: Revise HiiLib to check REST_STYLE Thread-Index: AQHWs+3kZV1R4kWQKEy8rzCxiIl3kam6eWiw Date: Fri, 6 Nov 2020 03:55:46 +0000 Message-ID: References: <20201106024939.17761-1-abner.chang@hpe.com> <1644CDDEC21AD05F.25549@groups.io> In-Reply-To: <1644CDDEC21AD05F.25549@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=hpe.com; x-originating-ip: [1.34.113.40] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: bfa2237e-b6f8-455e-b2eb-08d88207d7a8 x-ms-traffictypediagnostic: CS1PR8401MB0999: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:20; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8skt09ofYUZbM2DxF+bitnfhD4Fw+9ZKRy6uhWszEji7gW8u6sEzyNUvkEUGGzKdHCMdsz2xDOPFfiL6sgFqoXX6mGUSfPkB8oCyUNVZ8N4h+tYfySGWKgu0LJcZQVLTOnNsycC/FZEoVF6q1tUkK2/q/5tEa61UaAOM+V+hd8zZhE/TE/+Fs6ghy1fl+WjXNtwSr+1/ppWKaIf9nKoxmL49O3M6RcRY978X+4vtYYl/wKPCX3x3kBuC2T5XD5Q/x9Pi5TtnarikqRL22TztRezVXwj843stPxpT8kpW76N56i/ZXVq6FVJipbxJJIAdgiFn4T/fh1CJmpyw8bn2EL9uqby0egMv8wKW9+cpr4WMMHIz4aS2VTsv8f6eaITk/5f2RmScRlYbp4S5A6uvDw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(346002)(136003)(376002)(366004)(39860400002)(396003)(2906002)(66556008)(33656002)(66446008)(64756008)(76116006)(66476007)(5660300002)(83380400001)(7696005)(9686003)(6506007)(66946007)(55016002)(52536014)(53546011)(54906003)(8676002)(4326008)(86362001)(19627235002)(8936002)(110136005)(26005)(478600001)(71200400001)(966005)(316002)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: r1+rBYNSj+N4eo6wNEISPEXzb61aaSNas9+J0AHbSQkdBrgWlZBiwDsPYvfd7A99e7SWJM5Z76KzmSAvU+LLL5Bxc6152iXkYwB/JpG82UhmdUxjiSGZSqJz1nO+1r6px9+NUhwwyQSB75ugMCP79xHg76ay3qdjm89c/fSGP6WMf5AEN/ZL1JqIdaszy/8ec0Sq/ANKPAWlJCfvwR+/SsZBGTln6BoSB64c0ix3PdJDzx1D/lJe9QZ4CeQVQs4ZFaOAti8Pc6kVd5cKxl5iOxbFkT4LeIySxFCgAsVXD+FlLbFE0Z7739t6cpOsnDYlrDll6CHb6HjqyxTAcP3/nN6T72ra4uZrejv/TqWpb57YDdAZ4hUSj8jLk+47WL0UTgtHOYKvlcBKAUpZGJol4BNNlzN1Vzxd6PdOglAO9+i7JCTaIERe0/R5kIhebyr3jyfBvZUtvVhNHaSQr3HYO7MvBw4wDDQkeQFp+XT75Q6vj69LmPYdV+IUG1OgPySKGOkZHm7Tq5gYdmmMKcWMEqjp9/PAmYoCJT+iP8IrEW1zrYhPdKMpJUxdBKg1LuVJUlj9l1SSaAvaQs/O7n7Jy5KgTaI15AYGvLmWvWQ3XP4yNZOPaoM1r+ZP1IXirsBpJD3/fZTtlpRYXCujrEF/kQ== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: bfa2237e-b6f8-455e-b2eb-08d88207d7a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2020 03:55:46.6714 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: a4nzzPUMRo97rvV0QuakUAKQJTFQbm8kwSQYE/+pb0VIkZH6RJFw9+5EUaiZ7JRxL+gzVYqEbu2tqD8TO21UIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0999 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-06_01:2020-11-05,2020-11-06 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011060024 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Add Limming. > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Friday, November 6, 2020 10:50 AM > To: devel@edk2.groups.io > Cc: Dandan Bi ; Eric Dong ; > Wang, Nickle (HPS SW) > Subject: [edk2-devel] [VFR support REST_STYLE PATCH v4 3/4] > MdeModulePkg/Library: Revise HiiLib to check REST_STYLE >=20 > This change checks REST_STYLE flag. >=20 > Signed-off-by: Jiaxin Wu > Signed-off-by: Ting Ye > Signed-off-by: Siyuan Fu > Signed-off-by: Fan Wang > Signed-off-by: Abner Chang > Cc: Dandan Bi > Cc: Eric Dong > Cc: Nickle Wang > --- > MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c > b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c > index 564169bc14..57602828fe 100644 > --- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c > +++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c > @@ -3605,7 +3605,7 @@ HiiCreateCheckBoxOpCode ( > EFI_IFR_CHECKBOX OpCode; > UINTN Position; >=20 > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) =3D=3D 0); > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_REST_STYLE))) =3D=3D 0); >=20 > ZeroMem (&OpCode, sizeof (OpCode)); > OpCode.Question.QuestionId =3D QuestionId; > @@ -3674,7 +3674,7 @@ HiiCreateNumericOpCode ( > UINTN Position; > UINTN Length; >=20 > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) =3D=3D 0); > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_REST_STYLE))) =3D=3D 0); >=20 > Length =3D 0; > ZeroMem (&OpCode, sizeof (OpCode)); > @@ -3773,7 +3773,7 @@ HiiCreateStringOpCode ( > EFI_IFR_STRING OpCode; > UINTN Position; >=20 > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) =3D=3D 0); > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_REST_STYLE))) =3D=3D 0); >=20 > ZeroMem (&OpCode, sizeof (OpCode)); > OpCode.Question.Header.Prompt =3D Prompt; > @@ -3841,7 +3841,7 @@ HiiCreateOneOfOpCode ( > UINTN Length; >=20 > ASSERT (OptionsOpCodeHandle !=3D NULL); > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_OPTIONS_ONLY))) =3D=3D 0); > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_REST_STYLE | EFI_IFR_FLAG_OPTIONS_ONLY))) =3D=3D 0); >=20 > ZeroMem (&OpCode, sizeof (OpCode)); > OpCode.Question.Header.Prompt =3D Prompt; > @@ -3912,7 +3912,7 @@ HiiCreateOrderedListOpCode ( > UINTN Position; >=20 > ASSERT (OptionsOpCodeHandle !=3D NULL); > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_OPTIONS_ONLY))) =3D=3D 0); > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_REST_STYLE | EFI_IFR_FLAG_OPTIONS_ONLY))) =3D=3D 0); >=20 > ZeroMem (&OpCode, sizeof (OpCode)); > OpCode.Question.Header.Prompt =3D Prompt; > @@ -4009,7 +4009,7 @@ HiiCreateDateOpCode ( > EFI_IFR_DATE OpCode; > UINTN Position; >=20 > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) =3D=3D 0); > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_REST_STYLE))) =3D=3D 0); > ASSERT ((DateFlags & (~(EFI_QF_DATE_YEAR_SUPPRESS | > EFI_QF_DATE_MONTH_SUPPRESS | EFI_QF_DATE_DAY_SUPPRESS | > EFI_QF_DATE_STORAGE))) =3D=3D 0); >=20 > ZeroMem (&OpCode, sizeof (OpCode)); > @@ -4074,7 +4074,7 @@ HiiCreateTimeOpCode ( > EFI_IFR_TIME OpCode; > UINTN Position; >=20 > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) =3D=3D 0); > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_REST_STYLE))) =3D=3D 0); > ASSERT ((TimeFlags & (~(QF_TIME_HOUR_SUPPRESS | > QF_TIME_MINUTE_SUPPRESS | QF_TIME_SECOND_SUPPRESS | > QF_TIME_STORAGE))) =3D=3D 0); >=20 > ZeroMem (&OpCode, sizeof (OpCode)); > -- > 2.17.1 >=20 >=20 >=20 >=20 >=20