Re: [edk2-devel] [RedfishPkg PATCH v2 1/4] RedfishPkg: Initial commit of RedfishPkg.

["Abner Chang" <abner.chang@hpe.com>]

V3 sent.

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Thursday, October 1, 2020 5:22 PM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> devel@edk2.groups.io
> Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Andrew Fish
> <afish@apple.com>; Leif Lindholm <leif@nuviainc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v2 1/4] RedfishPkg: Initial
> commit of RedfishPkg.
> 
> On 09/30/20 03:56, changab wrote:
> > Initial version of RedfishPkg.
> >
> > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> > Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> > Signed-off-by: Wang Fan <fan.wang@intel.com>
> > Signed-off-by: Chang Abner <abner.chang@hpe.com>
> > Cc: Nickle Wang <nickle.wang@hpe.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> >  RedfishPkg/RedfishPkg.ci.yaml | 67
> +++++++++++++++++++++++++++++++++++
> >  RedfishPkg/RedfishPkg.dec     | 18 ++++++++++
> >  RedfishPkg/RedfishPkg.dsc     | 40 +++++++++++++++++++++
> >  3 files changed, 125 insertions(+)
> >  create mode 100644 RedfishPkg/RedfishPkg.ci.yaml  create mode 100644
> > RedfishPkg/RedfishPkg.dec  create mode 100644
> > RedfishPkg/RedfishPkg.dsc
> 
> based on the diffstat:
> 
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> 
> However, I suggest resending this series (more precisely, sending a v3).
> Here's why:
> 
> The patch seems to have been posted "From: changab
> <abner.chang@hpe.com>". This will be recorded in the git history, by git-am.
> (The mergify bot overwrites the Committer meta-field, but the Author meta-
> field remains in place, from git-am -- and that works from
> "From:".)
> 
> I think "Abner Chang <abner.chang@hpe.com>" looks a whole lot better
> than "changab <abner.chang@hpe.com>", in the Author field. So please
> rebase this series locally, picking the "edit" action for each patch, and then
> re-commit each patch with:
> 
>   git commit --amend --author="Abner Chang <abner.chang@hpe.com>"
>   git rebase --continue
> 
> Additionally, please update the "user.name" knob in your git config.
> 
> Sorry for obsessing about this -- I'd really like the git history to look *nice*.
> 
> Thanks
> Laszlo
> 
> 
> 
> 
>