From: "Abner Chang" <abner.chang@hpe.com>
To: Pierre Gondois <pierre.gondois@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Thomas Abraham <thomas.abraham@arm.com>,
Sami Mujawar <sami.mujawar@arm.com>,
"Schaefer, Daniel" <daniel.schaefer@hpe.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 05/15] Platform/ARM: Use PcdPciIoTranslation PCD from MdePkg
Date: Fri, 15 Oct 2021 07:20:28 +0000 [thread overview]
Message-ID: <CS1PR8401MB1144636D13F8E7AC2E21683AFFB99@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <c43556a6-4467-82af-d8e3-1d64ff7d82f7@arm.com>
[-- Attachment #1: Type: text/plain, Size: 4716 bytes --]
Hi Pierre,
Seems like I missed the platform corresponding changes with these two PCDs.
I am fixing it now.
thanks
Abner
________________________________
From: Pierre Gondois <pierre.gondois@arm.com>
Sent: Friday, October 15, 2021 1:21 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Thomas Abraham <thomas.abraham@arm.com>; Sami Mujawar <sami.mujawar@arm.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 05/15] Platform/ARM: Use PcdPciIoTranslation PCD from MdePkg
Hi Abner,
This patch:
https://edk2.groups.io/g/devel/message/81310
renames:
gArmTokenSpaceGuid.PcdPciMmio32Translation
to:
gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation
but gArmTokenSpaceGuid.PcdPciMmio32Translation is still used in ARM
platforms,
e.g.: SgiPkg/SgiPlatform.dsc.inc:155:
gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0
The RdN2 platform which uses this .dsc.inc file can be built with:
build -a AARCH64 -t GCC5 -p Platform/ARM/SgiPkg/RdN2/RdN2.dsc
Regards,
Pierre
On 10/4/21 10:29, Abner Chang via groups.io wrote:
> Complaint with BZ: #3665
> https://bugzilla.tianocore.org/show_bug.cgi?id=3665
>
> PcdPciIoTranslation PCD is relocated to MdePkg that leveraged by
> both ARM and RISC-V arch. This patch uses the one from MdePkg
> instead the one under ArmVirtPkg.
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> ---
> Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 3 ++-
> Platform/ARM/JunoPkg/ArmJuno.dsc | 3 ++-
> .../Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf | 3 ++-
> 3 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> index 7e37732fb9..6679939d3b 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> @@ -1,5 +1,6 @@
> #
> # Copyright (c) 2018-2021, ARM Limited. All rights reserved.
> +# (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -150,7 +151,7 @@
> gArmTokenSpaceGuid.PcdPciBusMax|255
> gArmTokenSpaceGuid.PcdPciIoBase|0x0
> gArmTokenSpaceGuid.PcdPciIoSize|0x00800000
> - gArmTokenSpaceGuid.PcdPciIoTranslation|0x77800000
> + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x77800000
> gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0
> gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
> gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|24
> diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc
> index fdfc8cd9e2..3b7a63b643 100644
> --- a/Platform/ARM/JunoPkg/ArmJuno.dsc
> +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc
> @@ -1,5 +1,6 @@
> #
> # Copyright (c) 2013-2018, ARM Limited. All rights reserved.
> +# (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -178,7 +179,7 @@
> gArmTokenSpaceGuid.PcdPciMmio64Size|0x100000000
>
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0x40000000
> - gArmTokenSpaceGuid.PcdPciIoTranslation|0x5f800000
> + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x5f800000
> gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|24
>
> # List of Device Paths that support BootMonFs
> diff --git a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf
> index 8b4a6e2fad..fb513d7b3d 100644
> --- a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf
> +++ b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf
> @@ -2,6 +2,7 @@
> # PCI Host Bridge Library instance for ARM Juno
> #
> # Copyright (c) 2017, Linaro Ltd. All rights reserved.<BR>
> +# (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -51,7 +52,7 @@
> gArmTokenSpaceGuid.PcdPciBusMax
> gArmTokenSpaceGuid.PcdPciIoBase
> gArmTokenSpaceGuid.PcdPciIoSize
> - gArmTokenSpaceGuid.PcdPciIoTranslation
> + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation
> gArmTokenSpaceGuid.PcdPciMmio32Base
> gArmTokenSpaceGuid.PcdPciMmio32Size
> gArmTokenSpaceGuid.PcdPciMmio32Translation
[-- Attachment #2: Type: text/html, Size: 9828 bytes --]
next prev parent reply other threads:[~2021-10-15 7:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 9:29 [edk2-platforms][PATCH 00/15] Changes to compliant with BZ:#3665 Abner Chang
2021-10-04 9:29 ` [edk2-platforms][PATCH 01/15] Platform/Comcast: Use FdtClientDxe from EmbeddedPkg Abner Chang
2021-10-04 9:29 ` [edk2-platforms][PATCH 02/15] Platform/Hisilicon: Use PcdPciIoTranslation PCD from MdePkg Abner Chang
2021-10-04 9:29 ` [edk2-platforms][PATCH 03/15] Platform/SbsaQemu: " Abner Chang
2021-10-04 9:29 ` [edk2-platforms][PATCH 04/15] Platform/AMD: " Abner Chang
2021-10-04 9:29 ` [edk2-platforms][PATCH 05/15] Platform/ARM: " Abner Chang
2021-10-04 18:09 ` Sami Mujawar
2021-10-14 17:21 ` [edk2-devel] " PierreGondois
2021-10-15 7:20 ` Abner Chang [this message]
2021-10-04 9:29 ` [edk2-platforms][PATCH 06/15] Platform/Comcast: " Abner Chang
2021-10-04 9:29 ` [edk2-platforms][PATCH 07/15] Platform/LeMaker: " Abner Chang
2021-10-04 9:29 ` [edk2-platforms][PATCH 08/15] Platform/Phytium: " Abner Chang
2021-10-04 9:29 ` [edk2-platforms][PATCH 09/15] Platform/SoftIron: " Abner Chang
2021-10-04 9:29 ` [edk2-platforms][PATCH 10/15] Platform/Socionext: " Abner Chang
2021-10-04 9:29 ` [edk2-platforms][PATCH 11/15] Platform/Comcast: Use PciPcdProducerLib in OvmfPkg Abner Chang
2021-10-04 9:29 ` [edk2-platforms][PATCH 12/15] Platform/Comcast: Use HighMemDxe provided by OvmfPkg Abner Chang
2021-10-04 9:29 ` [edk2-platforms][PATCH 13/15] Platform/Comcast: Use QemuFwCfgMmio " Abner Chang
2021-10-04 9:30 ` [edk2-platforms][PATCH 14/15] Platform/Comcast: Use FdtPciHostBridgeLib " Abner Chang
2021-10-04 9:30 ` [edk2-platforms][PATCH 15/15] Platform/Comcast: Use VirtioFdtDxe " Abner Chang
2021-10-12 10:23 ` [edk2-devel] [edk2-platforms][PATCH 00/15] Changes to compliant with BZ:#3665 Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CS1PR8401MB1144636D13F8E7AC2E21683AFFB99@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox