From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web12.6236.1634282455201867129 for ; Fri, 15 Oct 2021 00:21:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=orQMo6hc; spf=temperror, err=temporary DNS error (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=0922d4c8eb=abner.chang@hpe.com) Received: from pps.filterd (m0150245.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19EK1scN028976; Fri, 15 Oct 2021 07:20:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pps0720; bh=Z/NaemzB+QeBZuf820jqYzatINgw8plE3dP4tRKNYuo=; b=orQMo6hclQtpnfy2CUeI9KmuYS0vH+IE+cR0t8OGBFP2nXmY03wYjIj8ZudR/P4hpdIb ihBxPzODAnSU2q9tN2oKYs3AWKhV3ZsYyPzOUXyu/jKO/0fzamQgU44O7ahj6kJmiJUs aeWVtHpLBesY+R9Csc5k37lzf8dlCz3/b9Ble4AKg9F3lTu9YntexK4hJBBNkfRNW8Ml sATS+H7mY9MsduYf6Nv05ONWZi+jb+T6y+9IDDJ1fpQquuE40lx81skhZWzbL4JAIH1X ICgN+5Mtf+we4KzmVOp2KTYvWdx7vcy+G9tE8HMmj8Ikcj5meU3V5axakAbPd0f50gJF UA== Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) by mx0b-002e3701.pphosted.com with ESMTP id 3bpnh97ctx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Oct 2021 07:20:50 +0000 Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5008.houston.hpe.com (Postfix) with ESMTPS id 6D8E164; Fri, 15 Oct 2021 07:20:49 +0000 (UTC) Received: from G9W8677.americas.hpqcorp.net (16.220.49.24) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Fri, 15 Oct 2021 07:20:37 +0000 Received: from G4W10204.americas.hpqcorp.net (2002:10cf:5210::10cf:5210) by G9W8677.americas.hpqcorp.net (2002:10dc:3118::10dc:3118) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Fri, 15 Oct 2021 07:20:37 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (15.241.52.10) by G4W10204.americas.hpqcorp.net (16.207.82.16) with Microsoft SMTP Server (TLS) id 15.0.1497.23 via Frontend Transport; Fri, 15 Oct 2021 07:20:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lz7zDRGA1APBnd0A2uRZ/mYTI06sv57l1OlATJP0FIRyBPbnjS7eeJtjT+0jKnNNBnaKoK2dqxzdaU4ypAOQbkuyNCPxKR9UjoGVwnk1yzZtLoGVB0YeBBzLRHmGrnZS6/Df5lVrbTNAUTJlMQ9lOW7ORaK1BI6VRRduzIt3SSDxi5ZGFvXMtd6WWfm09pBNKcr2hA8Z+yZLX1CINBHSTLSL72HLf2G/Tj9/Zg1sEuXVI7ABmdWK3h49LTKX4bY9NgGpIA6w+ke/ztr9GZSM85fe10wQADzkCRZYNd7d5aYFp0a+e2GKmcSvGxSrWW4jKjaDy61iUpvKYyCqHUtExA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ebHINHrApdWiZwnUrMyaXQDhpcvTqwlgT8WVjZ7Rl70=; b=Hi2SmYx6Jg1L3xO5/KwOiwNtKORPyBVSnOL8m4ITn1eMbX9pfGy0s+xhHjdSuoF1M6s/LyHjdUM6dm7uAeWM5DYvsjvVvNVwpdOeLaVit/4kcvriex/S5YCCXav9e1Nk3pk+EX0Ze2v4V4+AfmSoNf+F5IjxrmUBQzwr89mcAtMPyjxT21pkiMmUR6XsqitXNGVek9Gg8igjeLCBNIGipZ/kfi/NLLKVKr8xOhn+gUM7Ye2aQc5CYvB3yLicI0A99VOHuT6AaBytcmTnK6Zxk5RxHVJcAIZmC62CXrhtlxzsSAe4KIOV1y/W8zTP3jRCBY2TcZJvobS59MieNYCrOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB0647.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:750d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Fri, 15 Oct 2021 07:20:28 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b88a:7fe7:6294:683f]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b88a:7fe7:6294:683f%9]) with mapi id 15.20.4587.030; Fri, 15 Oct 2021 07:20:28 +0000 From: "Abner Chang" To: Pierre Gondois , "devel@edk2.groups.io" CC: Ard Biesheuvel , Thomas Abraham , Sami Mujawar , "Schaefer, Daniel" Subject: Re: [edk2-devel] [edk2-platforms][PATCH 05/15] Platform/ARM: Use PcdPciIoTranslation PCD from MdePkg Thread-Topic: [edk2-devel] [edk2-platforms][PATCH 05/15] Platform/ARM: Use PcdPciIoTranslation PCD from MdePkg Thread-Index: AQHXwR/iUBkRD7sa90Gk94T3uBpqOKvTp6w/ Date: Fri, 15 Oct 2021 07:20:28 +0000 Message-ID: References: <20211004093001.4576-1-abner.chang@hpe.com> <20211004093001.4576-6-abner.chang@hpe.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: 351245f2-194c-0067-3326-ae5889b39bdb authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=hpe.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0b43016a-af85-4119-5cc7-08d98fac43e0 x-ms-traffictypediagnostic: CS1PR8401MB0647: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tKraeV65b+MU6Qb7h3qJfNytqDfryBth+Npd8XA6MWSeUou4pqoTEX+uGJpRKFuAotfkGyDN3uuVyVs5qxRJm7VuahkE9kKIcCLD/oIoCKo2kqOEdUxIsNUovs2LM8eVuei0WtWpfU3HPNhQvWfL5p9xDLzLMivLa5oDll2RA6InG8gN/9CA4GLXbT9eTh5KNtDT77gdRcmMOdR1wh2pMKLAQTex5yy/tHCvqtU+u7CHM47DuYLbWyQd8JtQykBVS8C39V8eUnHLKav/ckiuF4sHLwn0nqTjZ+i7h7L2ssYZtMBOMFRQSiKyD57QGEeoP//MMmKzHg2/74Xsao42rO5id8X/UZ6o2C6RRapRJked8JH7h4EFykufTeWPphcKoFG/5xo/qP2d2gGbq7rVQG7XFLwVING98pHqc6jPwojAxukvOr+Eql5fIsmlrYoXEP5TjbK0vI9OJ3rHzUT/Ll5SkTdvlMKSqnELULp88WKqBu8rq3dY2atfoiT4ILdbJ3pTI6gbuHa1ShDyFy+gC+u0g5pKQFWdBv7RdGmgKEqRoe6GcpAl+BnJZVmxm9qXGjh/iXNsbZAVEz70gWUc95yFdt0IvxrsXq+LiQ4S1gBFs1+jQ74vfhxH7b/v0OFxuwwRhZjT5Ex0o6MhtxP9w8kmJXBhP0VjpSasnp0vjUqi5mvY4Fmf/ibfqAGFcuPkA+QmdfW3VwneapS78rTCXRrmwApHNkS7G0AJJlgLg2yKXGLT+Z+BC+gz+UznoNlgGm21kfrchiJdAOXBW71X+VPLcKT6xvBMwWiVDCbl4viSrpSSC0Ox760UiXHfrhcN8iPRuAPMEZTPiBzAd+le7w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(6029001)(366004)(76116006)(9686003)(71200400001)(52536014)(86362001)(83380400001)(508600001)(19627405001)(38100700002)(166002)(966005)(66946007)(55016002)(66476007)(66556008)(66446008)(19627235002)(8676002)(64756008)(4326008)(38070700005)(8936002)(7696005)(91956017)(33656002)(54906003)(110136005)(82960400001)(122000001)(5660300002)(55236004)(26005)(186003)(2906002)(53546011)(6506007)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?rnucZOSBwffqXhdcjWP/rWCiEBpsiMGB3Zb9C7eqIU0NkOVd4AVln2Wjn7?= =?iso-8859-1?Q?WAo1q3ZoCm1QTv6T7f6dv9Plczge6TDfg2w217Ey+TGQgjBh98UemcJVyy?= =?iso-8859-1?Q?i+ko8e7jYlCfV6MaMtyTszhAUvTdWF2LRroskE+4H7qWHAIdIZSvSbsWsF?= =?iso-8859-1?Q?99tzcLN7ASwsxD0JQyLh6sZbKvwI7sawElk1CGpmlSRESSq9Tqw/Wmk5af?= =?iso-8859-1?Q?vVxgEcpoeXDdBN506Lj1OHvcBuoVmNYR8qHW9XUrOUAev7TCYMBmHZXcC5?= =?iso-8859-1?Q?ylCs2vJP3rO/E2Bm54pj+2n01uDdWpeaatJP6MdQPtHb4+cBJE0abVBNQJ?= =?iso-8859-1?Q?goen/a69VYPWPtxYBGydo0RrcVfjADFCdgAOix34KR7+MAT0hUIO9qy2X9?= =?iso-8859-1?Q?aB7L1/4EEnDRNvEPwoWoYStbdOCs1bkwapqimphME3rV6YQHkjAcMRzUdg?= =?iso-8859-1?Q?ms/94W8fyzh7yXtSA7HtV2SoeHSlmZY6vcl5Rb04wHm9wWjsekdpDKVFiH?= =?iso-8859-1?Q?OQkFqof8OweAP2N0W0iicmJYxlogjVfBwfs5Cj1jtcZJI/f6XnKXgne4sc?= =?iso-8859-1?Q?08+hd5/Cwp3FYnNQoX4VKTfzR0j62KaMZOCsR3JDuihakeo7L9d/9BdvCu?= =?iso-8859-1?Q?KUAGs4R7Fp/kZDo4XmcbCmpkMoxjKAAF17Ux03PogH5vXaS8Ou4e7XPXDE?= =?iso-8859-1?Q?4g4F/ZWWPwwHnnq9Z3Kx0YxeCuBT4BD6ZW2eoCARxyVbquUHOC+ddnSxfi?= =?iso-8859-1?Q?b7JXIsAsm+o3IUs5mk3oaRkXu/nnBNEqE9d3zqyZL6J4YDE7RQrEfxBfQT?= =?iso-8859-1?Q?Tj/ByQKWLs5KS4aUDET9d7LO0mjFJBKG/0r/WsfSoyL1Y93TXx+JSqW60h?= =?iso-8859-1?Q?kjXNrOz7Cjgxis9nBAULdSUshigY8am17RpH2IvzEwizAUaK2z3pah1Yxw?= =?iso-8859-1?Q?M+jvjegACkeKIZnbghehTiyf+6VBhvuQjr8ZY0mOy4VfIdnW5/gB9V7o56?= =?iso-8859-1?Q?aVNs+czmO56jDJGDCb/kNr9bM6j3F/lh15JKNcOx7jENQAjQ6ysAqyGYtS?= =?iso-8859-1?Q?g4dBuE65Y1nfFY8oPTDlAdrLXx5k0bTk2XVWy6xl4kEXPycKe/0AYUFGKi?= =?iso-8859-1?Q?zePZavdiUNdvkmQ0OUT6hyjYbpwFO27kC/LJXi2P/VKgHzMz182u2+LxH4?= =?iso-8859-1?Q?PnDFzxYELgBblEf/F7ahUOb6fdGg3xUNhqCqE7zhWSi0Q7wa+V/SDU7oD/?= =?iso-8859-1?Q?7MvRmfN15eqv7/1o+GS2qmt6DJtgOpuwd1AUDvOOd0a7KwEqbxl6rF8SuR?= =?iso-8859-1?Q?3VzY+8t4I7Rway+w/9D7KOCKYjrsDuDKkyDvkZ/rNJt8FWmA8qMh6/+q1M?= =?iso-8859-1?Q?nl6B6MBIXY?= X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 0b43016a-af85-4119-5cc7-08d98fac43e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2021 07:20:28.4310 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rMWgGeqaNhPkmHxco+8XWkFeCESuJsaanaqZAm5poBKUVntViasJymh6JgQqRf4ldTpdfz1ZJAcwexLGpNxN6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0647 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: 8zFVUm7cgLnRzh6sYlOYtg35SHeCk3df X-Proofpoint-ORIG-GUID: 8zFVUm7cgLnRzh6sYlOYtg35SHeCk3df X-Proofpoint-UnRewURL: 8 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-15_02,2021-10-14_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 impostorscore=0 clxscore=1011 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110150045 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CS1PR8401MB1144636D13F8E7AC2E21683AFFB99CS1PR8401MB1144_" --_000_CS1PR8401MB1144636D13F8E7AC2E21683AFFB99CS1PR8401MB1144_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Pierre, Seems like I missed the platform corresponding changes with these two PCDs. I am fixing it now. thanks Abner ________________________________ From: Pierre Gondois Sent: Friday, October 15, 2021 1:21 AM To: devel@edk2.groups.io ; Chang, Abner (HPS SW/FW Te= chnologist) Cc: Ard Biesheuvel ; Thomas Abraham ; Sami Mujawar ; Schaefer, Daniel Subject: Re: [edk2-devel] [edk2-platforms][PATCH 05/15] Platform/ARM: Use P= cdPciIoTranslation PCD from MdePkg Hi Abner, This patch: https://edk2.groups.io/g/devel/message/81310 renames: gArmTokenSpaceGuid.PcdPciMmio32Translation to: gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation but gArmTokenSpaceGuid.PcdPciMmio32Translation is still used in ARM platforms, e.g.: SgiPkg/SgiPlatform.dsc.inc:155: gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0 The RdN2 platform which uses this .dsc.inc file can be built with: build -a AARCH64 -t GCC5 -p Platform/ARM/SgiPkg/RdN2/RdN2.dsc Regards, Pierre On 10/4/21 10:29, Abner Chang via groups.io wrote: > Complaint with BZ: #3665 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3665 > > PcdPciIoTranslation PCD is relocated to MdePkg that leveraged by > both ARM and RISC-V arch. This patch uses the one from MdePkg > instead the one under ArmVirtPkg. > > Signed-off-by: Abner Chang > Cc: Ard Biesheuvel > Cc: Thomas Abraham > Cc: Sami Mujawar > Cc: Daniel Schaefer > --- > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 3 ++- > Platform/ARM/JunoPkg/ArmJuno.dsc | 3 ++- > .../Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf | 3 ++- > 3 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPk= g/SgiPlatform.dsc.inc > index 7e37732fb9..6679939d3b 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > @@ -1,5 +1,6 @@ > # > # Copyright (c) 2018-2021, ARM Limited. All rights reserved. > +# (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -150,7 +151,7 @@ > gArmTokenSpaceGuid.PcdPciBusMax|255 > gArmTokenSpaceGuid.PcdPciIoBase|0x0 > gArmTokenSpaceGuid.PcdPciIoSize|0x00800000 > - gArmTokenSpaceGuid.PcdPciIoTranslation|0x77800000 > + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x77800000 > gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0 > gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0 > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|24 > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJ= uno.dsc > index fdfc8cd9e2..3b7a63b643 100644 > --- a/Platform/ARM/JunoPkg/ArmJuno.dsc > +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc > @@ -1,5 +1,6 @@ > # > # Copyright (c) 2013-2018, ARM Limited. All rights reserved. > +# (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -178,7 +179,7 @@ > gArmTokenSpaceGuid.PcdPciMmio64Size|0x100000000 > > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0x40000000 > - gArmTokenSpaceGuid.PcdPciIoTranslation|0x5f800000 > + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x5f800000 > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|24 > > # List of Device Paths that support BootMonFs > diff --git a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHos= tBridgeLib.inf b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciH= ostBridgeLib.inf > index 8b4a6e2fad..fb513d7b3d 100644 > --- a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridge= Lib.inf > +++ b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridge= Lib.inf > @@ -2,6 +2,7 @@ > # PCI Host Bridge Library instance for ARM Juno > # > # Copyright (c) 2017, Linaro Ltd. All rights reserved.
> +# (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -51,7 +52,7 @@ > gArmTokenSpaceGuid.PcdPciBusMax > gArmTokenSpaceGuid.PcdPciIoBase > gArmTokenSpaceGuid.PcdPciIoSize > - gArmTokenSpaceGuid.PcdPciIoTranslation > + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation > gArmTokenSpaceGuid.PcdPciMmio32Base > gArmTokenSpaceGuid.PcdPciMmio32Size > gArmTokenSpaceGuid.PcdPciMmio32Translation --_000_CS1PR8401MB1144636D13F8E7AC2E21683AFFB99CS1PR8401MB1144_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
Hi Pierre,
Seems like I missed the platform corresponding changes with these two PCDs.
I am fixing it now.

thanks
Abner

From: Pierre Gondois <= pierre.gondois@arm.com>
Sent: Friday, October 15, 2021 1:21 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Chang, Abner = (HPS SW/FW Technologist) <abner.chang@hpe.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Thomas Abraham= <thomas.abraham@arm.com>; Sami Mujawar <sami.mujawar@arm.com>;= Schaefer, Daniel <daniel.schaefer@hpe.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 05/15] Platform/ARM= : Use PcdPciIoTranslation PCD from MdePkg
 
Hi Abner,

This patch:
https://edk2.group= s.io/g/devel/message/81310

renames:
gArmTokenSpaceGuid.PcdPciMmio32Translation

to:
gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation

but gArmTokenSpaceGuid.PcdPciMmio32Translation is still used in ARM
platforms,

e.g.: SgiPkg/SgiPlatform.dsc.inc:155: 
gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0

The RdN2 platform which uses this .dsc.inc file can be built with:

build -a AARCH64 -t GCC5 -p Platform/ARM/SgiPkg/RdN2/RdN2.dsc

Regards,

Pierre


On 10/4/21 10:29, Abner Chang via groups.io wrote:
> Complaint with BZ: #3665
> http= s://bugzilla.tianocore.org/show_bug.cgi?id=3D3665
>
> PcdPciIoTranslation PCD is relocated to MdePkg that leveraged by
> both ARM and RISC-V arch. This patch uses the one from MdePkg
> instead the one under ArmVirtPkg.
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> ---
>  Platform/ARM/SgiPkg/SgiPlatform.dsc.inc    &= nbsp;           &nbs= p;       | 3 ++-
>  Platform/ARM/JunoPkg/ArmJuno.dsc     &n= bsp;            = ;             |= 3 ++-
>  .../Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf &= nbsp;    | 3 ++-
>  3 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/Sg= iPkg/SgiPlatform.dsc.inc
> index 7e37732fb9..6679939d3b 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> @@ -1,5 +1,6 @@
>  #
>  #  Copyright (c) 2018-2021, ARM Limited. All rights reserve= d.
> +#  (C) Copyright 2021 Hewlett Packard Enterprise Development LP&= lt;BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -150,7 +151,7 @@
>    gArmTokenSpaceGuid.PcdPciBusMax|255
>    gArmTokenSpaceGuid.PcdPciIoBase|0x0
>    gArmTokenSpaceGuid.PcdPciIoSize|0x00800000
> -  gArmTokenSpaceGuid.PcdPciIoTranslation|0x77800000
> +  gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x77800000
>    gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0
>    gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
>    gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|24
> diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/A= rmJuno.dsc
> index fdfc8cd9e2..3b7a63b643 100644
> --- a/Platform/ARM/JunoPkg/ArmJuno.dsc
> +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc
> @@ -1,5 +1,6 @@
>  #
>  #  Copyright (c) 2013-2018, ARM Limited. All rights reserve= d.
> +#  (C) Copyright 2021 Hewlett Packard Enterprise Development LP&= lt;BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -178,7 +179,7 @@
>    gArmTokenSpaceGuid.PcdPciMmio64Size|0x100000000
> 
>    gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0x= 40000000
> -  gArmTokenSpaceGuid.PcdPciIoTranslation|0x5f800000
> +  gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x5f800000
>    gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|24
> 
>    # List of Device Paths that support BootMonFs
> diff --git a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPci= HostBridgeLib.inf b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoP= ciHostBridgeLib.inf
> index 8b4a6e2fad..fb513d7b3d 100644
> --- a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBri= dgeLib.inf
> +++ b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBri= dgeLib.inf
> @@ -2,6 +2,7 @@
>  #  PCI Host Bridge Library instance for ARM Juno
>  #
>  #  Copyright (c) 2017, Linaro Ltd. All rights reserved.<= BR>
> +#  (C) Copyright 2021 Hewlett Packard Enterprise Development LP&= lt;BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -51,7 +52,7 @@
>    gArmTokenSpaceGuid.PcdPciBusMax
>    gArmTokenSpaceGuid.PcdPciIoBase
>    gArmTokenSpaceGuid.PcdPciIoSize
> -  gArmTokenSpaceGuid.PcdPciIoTranslation
> +  gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation
>    gArmTokenSpaceGuid.PcdPciMmio32Base
>    gArmTokenSpaceGuid.PcdPciMmio32Size
>    gArmTokenSpaceGuid.PcdPciMmio32Translation
--_000_CS1PR8401MB1144636D13F8E7AC2E21683AFFB99CS1PR8401MB1144_--