Re: [edk2-announce] Re: Soft Feature Freeze starts now for edk2-stable202008

["Abner Chang" <abner.chang@hpe.com>]

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

Hmm.. I had a one commit (which is not the feature) just reviewed by Leif but not pushing yet. Is that possible to push before the Hard Feature freeze and also be included in 202008 stable tag? I guess it gets the chance according to the article of SoftFeatureFreeze on Wiki page.
Patch attached FYR

Abner

> -----Original Message-----
> From: announce@edk2.groups.io [mailto:announce@edk2.groups.io] On
> Behalf Of Laszlo Ersek
> Sent: Wednesday, August 19, 2020 5:59 PM
> To: Bret Barkelew <Bret.Barkelew@microsoft.com>; devel@edk2.groups.io;
> liming.gao <liming.gao@intel.com>; announce@edk2.groups.io
> Cc: Leif Lindholm <leif@nuviainc.com>; afish@apple.com; Kinney, Michael D
> <michael.d.kinney@intel.com>; Guptha, Soumya K
> <soumya.k.guptha@intel.com>
> Subject: Re: [edk2-announce] [EXTERNAL] Re: Soft Feature Freeze starts
> now for edk2-stable202008
> 
> On 08/18/20 17:10, Bret Barkelew wrote:
> > I agree with the process and withdraw my request, replacing it instead with
> a disapproving head shake and deep sigh.
> 
> We as a community definitely deserve your disapproval, as our review
> response times have been abysmal. :(
> 
> > I’ll go back to pushing on this after the tag.
> 
> Thanks for your persistence!
> Laszlo
> 
> 
> 


[-- Attachment #2: 0001-EmbeddedPkg-libfdt-Add-strncmp-macro-to-use-AsciiStr.patch --]
[-- Type: application/octet-stream, Size: 1984 bytes --]

From e6531052d0185569065239087c82cec4dfc926a1 Mon Sep 17 00:00:00 2001
From: Abner Chang <abner.chang@hpe.com>
Date: Tue, 4 Aug 2020 17:06:39 +0800
Subject: [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp

For the implementation which utilizes libfdt provided in EmbeddedPkg
however it uses strncmp function in the libfdt helper library,
libfdt_env.h should provide the macro implied with edk2 strncmp
implementation.

The example is RISC-V OpenSBI library. edk2 RISC-V port uses OpenSBI
library and incorporate with edk2 libfdt. edk2 libfdt_env.h provides
the necessary macros to build OpenSBI which uses fdt functions in edk2
environment. However, OpenSBI also has libfdt helper library that uses
strncmp function which is not defined in edk2 libfdt_env.h. This commit
addresses the build issue caused by missing strncmp macro in
libfdt_env.h.

Check below three commits for the corresponding changes on OpenSBI,
https://github.com/riscv/opensbi/commit/8e47649eff96c303e02fbd58cdc6c4ed341066ec
https://github.com/riscv/opensbi/commit/2845d2d2cf4fb74a89452ba223995aa4a118c07e
https://github.com/riscv/opensbi/commit/2cfd2fc9048806353298a1b967abf985901e36e8

Signed-off-by: Abner Chang <abner.chang@hpe.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
---
 EmbeddedPkg/Include/libfdt_env.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/EmbeddedPkg/Include/libfdt_env.h b/EmbeddedPkg/Include/libfdt_env.h
index 11a9764733..7feff52bc0 100644
--- a/EmbeddedPkg/Include/libfdt_env.h
+++ b/EmbeddedPkg/Include/libfdt_env.h
@@ -76,4 +76,8 @@ static inline size_t strnlen (const char* str, size_t strsz ) {
   return AsciiStrnLenS (str, strsz);
 }
 
+static inline size_t strncmp (const char* str1, const char* str2, size_t strsz ) {
+  return AsciiStrnCmp (str1, str2, strsz);
+}
+
 #endif /* _LIBFDT_ENV_H */
-- 
2.25.0