public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Abner Chang" <abner.chang@hpe.com>
To: Mark Salter <msalter@redhat.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>,
	"Schaefer, Daniel" <daniel.schaefer@hpe.com>,
	"Chen, Gilbert" <gilbert.chen@hpe.com>
Subject: Re: [PATCH edk2-platforms 0/2] RISC-V: Fix build errors
Date: Tue, 22 Dec 2020 06:36:07 +0000	[thread overview]
Message-ID: <CS1PR8401MB11446B39678BC7331BCAF396FFDF0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20201221203855.635031-1-msalter@redhat.com>

Entire patch set looks good to me. Thanks for fixing this.
Reviewed-by: Abner Chang <abner.chang@hpe.com>

> -----Original Message-----
> From: Mark Salter [mailto:msalter@redhat.com]
> Sent: Tuesday, December 22, 2020 4:39 AM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm <leif@nuviainc.com>; Chang, Abner (HPS SW/FW
> Technologist) <abner.chang@hpe.com>; Schaefer, Daniel
> <daniel.schaefer@hpe.com>; Chen, Gilbert <gilbert.chen@hpe.com>
> Subject: [PATCH edk2-platforms 0/2] RISC-V: Fix build errors
> 
> I ran into some errors while compiling for RISC-V/SiFive target.
> These were trivial things arising from edk2 commits:
> 
>   bd9da7b1da26 MdePkg,ShellPkg: Fix typo in SMBIOS_TABLE_TYPE4 field
> ProcessorManufacturer
>   9c1f455f5f0e MdePkg: Remove code wrapped by
> DISABLE_NEW_DEPRECATED_INTERFACES
> 
> Mark Salter (2):
>   Silicon/RISC-V: Update old SMBIOS struct filed name
>   Platform/SiFive/U5SeriesPkg: Remove use of deprecated interfaces
> 
>  .../Dxe/RamFvbServicesRuntimeDxe/FwBlockService.c        | 9 ++++++---
>  .../ProcessorPkg/Universal/SmbiosDxe/RiscVSmbiosDxe.c    | 2 +-
>  .../SiFive/U54/Library/PeiCoreInfoHobLib/CoreInfoHob.c   | 2 +-
>  3 files changed, 8 insertions(+), 5 deletions(-)
> 
> --
> 2.29.2


  parent reply	other threads:[~2020-12-22  6:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-21 20:38 [PATCH edk2-platforms 0/2] RISC-V: Fix build errors Mark Salter
2020-12-21 20:38 ` [PATCH edk2-platforms 1/2] Silicon/RISC-V: Update old SMBIOS struct filed name Mark Salter
2020-12-21 20:38 ` [PATCH edk2-platforms 2/2] Platform/SiFive/U5SeriesPkg: Remove use of deprecated interfaces Mark Salter
2020-12-22  6:36 ` Abner Chang [this message]
2020-12-23  2:53   ` [edk2-devel] [PATCH edk2-platforms 0/2] RISC-V: Fix build errors Zhiguang Liu
2020-12-23  6:41     ` 回复: " gaoliming
2020-12-23  6:44       ` Michael D Kinney
2020-12-23  7:05         ` 回复: " gaoliming
2020-12-23  7:17           ` Bob Feng
2020-12-23  7:28           ` Zhiguang Liu
2020-12-23 15:47             ` Abner Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CS1PR8401MB11446B39678BC7331BCAF396FFDF0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox