From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web10.8327.1628081280089548354 for ; Wed, 04 Aug 2021 05:48:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=CpTyxRnG; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=08506c7e0c=abner.chang@hpe.com) Received: from pps.filterd (m0134425.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 174Cgvrq001868; Wed, 4 Aug 2021 12:47:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=O5beanzaxpYfowldqVevbxEUioEiAYpq+7TxdfXcgx4=; b=CpTyxRnGPN6BbGrrg6fHDUi83AlBOPa4VSllzime22reTT/C+j0wkPMy0B7PeJUwIy1f +35KGZuxnBi3Mhyol1LIR2DgdKzZlErXVFseY92LJKmMO8c1v/9nyk94uZGuP+TFbkKp xU4Ou9vVxx8ZIT7xxMaeCeop8mJnXfzjg7KlfW7z+IkLF73Up6/VXCVpK7vnm4WfMdy5 xb2gkgh+80e3R1ETJ8efuvUTjHa6iOCh4aR1+tdq/MQwl7XB6gPFq8oDpNbEHl63CNsf 3tLcTZb3Zxo/8oYvuapvo9HLzJtlrIzCUReslyb4Tf9AiRJ26XH209P3mp69i3798+nA SA== Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0b-002e3701.pphosted.com with ESMTP id 3a75k1aeru-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Aug 2021 12:47:56 +0000 Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5009.houston.hpe.com (Postfix) with ESMTPS id 7A3377C; Wed, 4 Aug 2021 12:47:55 +0000 (UTC) Received: from G9W8677.americas.hpqcorp.net (16.220.49.24) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 4 Aug 2021 12:47:49 +0000 Received: from G9W9209.americas.hpqcorp.net (2002:10dc:429c::10dc:429c) by G9W8677.americas.hpqcorp.net (2002:10dc:3118::10dc:3118) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 4 Aug 2021 12:47:49 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (15.241.52.13) by G9W9209.americas.hpqcorp.net (16.220.66.156) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Wed, 4 Aug 2021 12:47:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M2pMDN1xfeXLP9tocBfGuvrtGmdei2NnIFGwSHNV+pzFg+8bIZ7rbJov+VqZevBaEjkv2QDumc2VJTrDCbC20drnyNZzGgGFlhpStrpkKgUpLJOHGBoIYtEl6n4w5thMEm3OOg5dCFcEAVrOPQ2qgR3LZjDahtdA4Np3JnaV9+y0LRC04e+wQOtdru9J/FAjPXU+tjwMZSHOw4GrdW/f0xSME4XLnSjbORv1fUdQ3IeSl0RqaehRlmkyeclyinlnqsVprx5JbKp28xYWnz8puOh+wfEzxyUpIODc/+1/PngTzs0K1Bp+I1u2T1i8otG3HJ+a4KnF6pfAC8KKwNBS1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ehBT0mEMr/icEigJq+R7NRzWpFALvxr8wCNp++CAUZE=; b=GgkoCTg8M2XhRxEmgFpHv1BRx18INq7uqHA2SYnsvRHdb6oHKwj7xyHieco8Wxom3M1TW5RTXTRVz+umr8Ni0/szFKDM3P4tioX03aX5IkLNECq6xKiM5qzJN/sA8Kk5uGQOBBlNgMxvrBns+xclzmMuekCUmeTgGnp6BL274aq7QUlv+KA6AwX/4j6wRGfLs9C5WxGyvwD1jQ7Gba8ta/hnUZqMO8pz1m4aXdwK0K/MXYOvpFwuiz7mzK38aatI9KaQFkPJ4G1L9mePGd09jTG3CVXPl396QFUDvJzOGYCSxoFyGZ/JHiWOBvlw7Wm4ru85COt9LLo4vqgyHqqolw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB0518.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7512::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15; Wed, 4 Aug 2021 12:47:47 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d447:2f82:1c6e:831f]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d447:2f82:1c6e:831f%4]) with mapi id 15.20.4373.026; Wed, 4 Aug 2021 12:47:47 +0000 From: "Abner Chang" To: Leif Lindholm CC: "devel@edk2.groups.io" , "Schaefer, Daniel" , Ard Biesheuvel , "Anup Patel" Subject: Re: [edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to libfdt_env.h Thread-Topic: [edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to libfdt_env.h Thread-Index: AQHXTL93byUxDBsp60GcLz8Y44HJXqrq7jAwgFfq5xCAIOdfgIAAAozQ Date: Wed, 4 Aug 2021 12:47:46 +0000 Message-ID: References: <20210519145822.4028-1-daniel.schaefer@hpe.com> <1680817ADB2092C8.5504@groups.io> <20210804123351.2cgsmimicd53mf3r@leviathan> In-Reply-To: <20210804123351.2cgsmimicd53mf3r@leviathan> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=hpe.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 51180130-dd9a-4e95-9aeb-08d957460fa1 x-ms-traffictypediagnostic: CS1PR8401MB0518: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dXCW6nQlVwSq6oB6ojJgDOhG595uRIlYO91F6w1sMdbbsmLfHyBuA2DtGV9rL68gRY9eSHoPeVkHCSD54dEG9DzHAnjrwIZ74CcJdgJX5/NRLAChJmmAQS0WRl0x9RPHnc61Ei84K4dzjT2ajoG1md5qjiggC3WghY+CrpkuOfD8I9t/ERqJb4w3V0afEvPZidK5sPFukt/6yRoXSxSi1N0HfTKU9LZZ+0tLxdVx7j5rV/li+roHBuNvaCzcpySdjwAhyp7SnbZf8XINcZ90TOvAWGDZl1XMNs8MMac1WQtZklhsMelqfCQyTvXCjQ2e113rbLbnGImxw+1CkSiD11Xld2MWmv0/MFGgrzO1QxrC7UQGmI4gOaw6iczYkW+HVNBASX2AbPaPfViNsiEKW1RqmKjTEFw7vPO9F3YMHIUhXAEBNBT1xAZo4d/wUD0lSynvjDYX+mSReIrJH4pe6sG8vnBmx7YhpyskrapjvjeFRLJ3j0L9wJ+PYM4eznbOpCjzM/nk2PAX52QrJVnnhrzBcUx7nKKZArBigQU3qO8IZ8CWtmlvS9KvgeYRqsZf5dWmYLQ13DPlSEst3W7iy/wJQOdiHAvREmZbekWinShmrazuOQtmB+MnpAB8ww5WQ7cHOPQVClRg1RP58ADPWDd74xzLRErUPp5UiRvKcHb0gGYCS0+UNikkNtmHlfoLRDT+3+mq9fpRLcv20RwqsUbw6Zckv0xfsaM9gvtepW7p+/w5xY2/MrUh3L4Rg35l2dqR5ToNryrnjpE4QLdWmArGzvJvIcWO0i+fenSbBo3/4SaytQgt485KvBP9ygnqTiK8NLnsVe/vKGNjDB1WGw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(366004)(66446008)(64756008)(66476007)(66556008)(66946007)(83380400001)(5660300002)(86362001)(7696005)(38100700002)(38070700005)(122000001)(53546011)(316002)(54906003)(6506007)(71200400001)(76116006)(8676002)(186003)(8936002)(55016002)(2906002)(4326008)(508600001)(52536014)(33656002)(6916009)(9686003)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FxOfr+SveFja8uas5FjhhwWTOsrfSjL9nQnZJj85/fWiLfAiqUrEXGlOBe52?= =?us-ascii?Q?LXI9RXQxpPIdvuLfkrV68MFd7x7s3RLPjZKJ0QHEwVHnVq2iC5sJMKFAGTpJ?= =?us-ascii?Q?0kFjQnJfgsmahtzFi+vmIR/kbqlBQLXP/WID624Z+C5tOY8yxmBwEAe7etot?= =?us-ascii?Q?rA7XLqrVGIwLLItLJ5ILtwlNWSzMB93cuaybHi9Qx0xjPCsxuy70uFkOlp/D?= =?us-ascii?Q?k6C/025xS3y7NoQ+87yuHlibTovjtapF3piBkV46OWvB/Q2VsJvtk7WWLHId?= =?us-ascii?Q?WZya6dnsA1xn4FMxmV7kd1UChv+oLHFgD9lyLSRTaGdPVNd0M0WXpQGxM3z4?= =?us-ascii?Q?W7UjOPGeu6y9LEE+60S1M8Wv0YeKvwfXqMxdHNtX3XGHokus1kDFHrVUkxh5?= =?us-ascii?Q?8Q1UGlNqjXMx5j0++TDfvNvAAIUY3W1Bw793O9TvDJc3jP9R1I8tRZqP2Pz/?= =?us-ascii?Q?nFN4nKMXlINqmq8QJY74fRBfq53hf3AfKwk4XFLZjpjDgInlIPP00MwOLIdi?= =?us-ascii?Q?kQo4hRimqsga4/JzraHFJoFsND8qGmaP8erk4eYtQAB9Jea3ZBH4H851dw1x?= =?us-ascii?Q?6tNcsAj7XxQdKSaMHuIVAlOQatyDmiSjIdHWG6fVnDmEBSwBFQ2MyHjKH5Nw?= =?us-ascii?Q?aEVsIZTVEjQK713utlkVTh8FNJ8ghGCNIxqc8ngTpb+DQgWbrpdfwCUVm5oS?= =?us-ascii?Q?qe+z9bI8Ln34mrWYZ9h+b6LUdXh7Na+cHZOsHBhRNaQBpBEo3t7AY8n0WsgC?= =?us-ascii?Q?GxKZFuOFenCjWCO6hskdIPcW1rgaCagLJ0fkrZF69EpA4+Z6oxT6nZbgM9zJ?= =?us-ascii?Q?jfMbk2f8ani+rf0YR3iUO1klvLhVOU4W+h/1PFaKUnZ0OnQg1cnqy1zsRNpU?= =?us-ascii?Q?mSkBoZxV60xb1ZPInBaiLzaY0iE7e7IixPt+0mk8hOasKLX2tAYS02qYoK/Z?= =?us-ascii?Q?P/UnjPwA9IZUdKp8NyYWu33y0WU5XZMomkdqjg8D7dIb6p27p3XMRr9GkHVM?= =?us-ascii?Q?pJaZJnp4w6UDduYvJbYkNX1HwY7CJ2+BoN9GtENzm/3X1IiOS/sgiWivPbQ8?= =?us-ascii?Q?tXZ4O4DLGmPWCPBKywOQHg/zDmCRnXudynD90AH5SI8RNh3LBxpegcBwgMmo?= =?us-ascii?Q?7sVexMbE6jbGAidG9cB9fkJwqsvaOxl8UibKEQVsOeFbxrFKSQPeveKcoELE?= =?us-ascii?Q?w3g/8nQu8uRo1MABEkjnhKf42D1gDer/7EWi3BG3/x+ybo6eIEDkL4tFjMEx?= =?us-ascii?Q?0B8HLUwm6ovdtyj9ky78iWdtsP+Frq0ZR5/kErFSqPwW1084DVcQ/KGA1w/B?= =?us-ascii?Q?SNhWiG/4nhrXFvsV8S49Pnx9af+oXAfwAglhWV8IWkZShthPXaNNWy5p5mf9?= =?us-ascii?Q?Dx+51hJObxeNE9hs0Oq14/7ZM8fi?= X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 51180130-dd9a-4e95-9aeb-08d957460fa1 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2021 12:47:47.0172 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wERIYVY0LWsBFJJ8leQS+Nzpo4DysiN9lJiazPkfBCLpwzeIj6UJKG7WARBa8XylJJ7kRFmue2tipRoESGTxeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0518 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: 7Q7FgdaCg2HLCtcBOQ2iDiyyMpkIsraU X-Proofpoint-ORIG-GUID: 7Q7FgdaCg2HLCtcBOQ2iDiyyMpkIsraU X-Proofpoint-UnRewURL: 2 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-08-04_03:2021-08-04,2021-08-04 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 clxscore=1011 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108040067 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm [mailto:leif@nuviainc.com] > Sent: Wednesday, August 4, 2021 8:34 PM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: devel@edk2.groups.io; Schaefer, Daniel ; > Ard Biesheuvel ; Anup Patel > > Subject: Re: [edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp > and strncpy to libfdt_env.h >=20 > Gah, sorry. >=20 > The original patch landed while I was distracted, and this reminder > while I was on holiday. Thanks, will correct the subject before merging it. >=20 > Apart from the typo in the subject line, I guess I'm OK with this. > Acked-by: Leif Lindholm >=20 > However, I have a feeling RISC-V will be updating EmbeddedPkg as > frequently as ARM in the near future. > Could we add one or both of you as maintainers? Sure, we can be the maintainers of EmbeddedPkg. I can send out the patch of maintainers.txt first and then merge this patc= h later. Thanks Abner >=20 > / > Leif >=20 > On Wed, Jul 14, 2021 at 14:05:53 +0000, Chang, Abner (HPS SW/FW > Technologist) wrote: > > Hi Leif and Ard, > > Please help to review this and merge it if you have no comments on thi= s > patch. > > > > Thanks > > Abner > > > > > -----Original Message----- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf > Of > > > Abner Chang > > > Sent: Wednesday, May 19, 2021 11:30 PM > > > To: Schaefer, Daniel ; devel@edk2.groups.io > > > Cc: Leif Lindholm ; Ard Biesheuvel > > > ; Anup Patel > > > Subject: Re: [edk2-devel] [PATCH v1 1/1] EmbeddedPkg/libfdt: Add > strmp > > > and strncpy to libfdt_env.h > > > > > > Reviewed-by: Abner Chang > > > > > > > -----Original Message----- > > > > From: Schaefer, Daniel > > > > Sent: Wednesday, May 19, 2021 10:58 PM > > > > To: devel@edk2.groups.io > > > > Cc: Chang, Abner (HPS SW/FW Technologist) ; > > > Leif > > > > Lindholm ; Ard Biesheuvel > > > ; > > > > Anup Patel > > > > Subject: [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy = to > > > > libfdt_env.h > > > > > > > > OpenSBI has started using those in v0.9. See: > > > > https://github.com/riscv/opensbi/blob/v0.9/lib/utils/fdt/fdt_domai= n.c > > > > > > > > Cc: Abner Chang > > > > Cc: Leif Lindholm > > > > Cc: Ard Biesheuvel > > > > Cc: Daniel Schaefer > > > > Cc: Anup Patel > > > > Signed-off-by: Daniel Schaefer > > > > --- > > > > EmbeddedPkg/Include/libfdt_env.h | 8 ++++++++ > > > > 1 file changed, 8 insertions(+) > > > > > > > > diff --git a/EmbeddedPkg/Include/libfdt_env.h > > > > b/EmbeddedPkg/Include/libfdt_env.h > > > > index 7feff52bc0fb..c35ac739703c 100644 > > > > --- a/EmbeddedPkg/Include/libfdt_env.h > > > > +++ b/EmbeddedPkg/Include/libfdt_env.h > > > > @@ -76,8 +76,16 @@ static inline size_t strnlen (const char* str, = size_t > > > strsz ) { > > > > return AsciiStrnLenS (str, strsz); > > > > > > > > } > > > > > > > > > > > > > > > > +static inline size_t strcmp (const char* str1, const char* str2) = { > > > > > > > > + return AsciiStrCmp (str1, str2); > > > > > > > > +} > > > > > > > > + > > > > > > > > static inline size_t strncmp (const char* str1, const char* str2,= size_t > strsz ) > > > { > > > > > > > > return AsciiStrnCmp (str1, str2, strsz); > > > > > > > > } > > > > > > > > > > > > > > > > +static inline size_t strncpy (char* dest, const char* source, siz= e_t > > > dest_max) { > > > > > > > > + return AsciiStrCpyS (dest, dest_max, source); > > > > > > > > +} > > > > > > > > + > > > > > > > > #endif /* _LIBFDT_ENV_H */ > > > > > > > > -- > > > > 2.30.1 > > > > > > > > > > > >=20 > > > > >