From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web09.46454.1606183376371319577 for ; Mon, 23 Nov 2020 18:02:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=G0kpbQ3a; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=05978581c8=abner.chang@hpe.com) Received: from pps.filterd (m0134425.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0AO20UQ7014345; Tue, 24 Nov 2020 02:02:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=qKEQ5msLu+4FT3BioFC+cbiQbwEv5rRURtzSMTsU44Y=; b=G0kpbQ3a/gZ520Qnltz9FNZw90hF/x8KSoXVWXcCPVQrCQnGCB84h42+Akmoqxp2zcXP WWHfsE9S86n3PCIZf6mmD0V0WT031xcfMTzPE29t+IMUQv4mrYMrjnBmk9FulZa0z6Bq 8T+BLLA7do7RaHOIwh3DXjd9reZkUT5JlTcc6rgnD35sqOatzfPfAa427mm8UAryT1jh 4/W+T409BP/4L/WhG8+AA91VO6ObDY4naHdwEgHasqdzEsJ7yhBmKXROPADHwNmJ0l2D LBKLYuxYk1PVbliOrq2W9fLfctVRdgPc1rCc5L9HM/ggDYF8iIJnNFpX630MiXdzsrJ1 DQ== Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 34xv6q339v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Nov 2020 02:02:53 +0000 Received: from G9W9210.americas.hpqcorp.net (g9w9210.houston.hpecorp.net [16.220.66.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id 2B3CD5C; Tue, 24 Nov 2020 02:02:53 +0000 (UTC) Received: from G9W9210.americas.hpqcorp.net (2002:10dc:429b::10dc:429b) by G9W9210.americas.hpqcorp.net (2002:10dc:429b::10dc:429b) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 24 Nov 2020 02:02:53 +0000 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (15.241.52.11) by G9W9210.americas.hpqcorp.net (16.220.66.155) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 24 Nov 2020 02:02:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CRfA8rY8mEWvvCuhbAfWu8Als4punpdF3ZoXq4h/GnkIecFklZC+TZDd+bymj+QQG7n6P2F4SD2o8PQ2U25mg9eoKjuZcHzhvNnUGWI9evBrbK2lemLbd5FxWht9Z1f2w/NRuLY88k6pdJsVs+3EJrn8ThCz6PvnM3ohYoseq9wtuAYDfJHWCZSgZ7zEB0B1QT7D+tXbXKD0876XYl9Uf+tcg6IN4VplNIROkz4IfcUIwKw+Bc7UnH11nhAjjXxuPXQK92ddI5FjVBUcel7eppzQ7odhcu+4pawuQaJGryKzvMM4/roqPUWn2s2gR7gXBlRL/bLE5oi8GHME36s7cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+/8EK3Dsx3gvo7mHjuXNsExU+wMtUsenz9wzevbLMOM=; b=IQzPV06dycmf0bm+ppC9EwAv7unv8kJ2acMT26au5nfAvYcbR3VVI8Sbo5NEI//kcyDnxNxyX4Xsk3s5zsmv1lhwVNOFOtUpdPc3dYJfz/iMBtXTKLQcTaOLWzwjKpVrXl5ptYue4uZNsPapEXUD1SCR6ku3g8oOz4FBiYZH9X6K2YtDMeC1wXYkWJirwvJpWgzBZbBPCJgTmyQbP9iMxedEIwaDOVev4+d7ZlgcE7mOE7pbifPkq53ZbhrVXjeCBhIWu6nvdShJLM3YkNpPQ7vzrJFsa8SbW/w9nRstDRKEHovVQm1GMSFVq3kDrL5Z63KCeunyaqi4ipTFsRnyQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB0344.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7515::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.25; Tue, 24 Nov 2020 02:02:51 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::a094:ed67:fb40:340e]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::a094:ed67:fb40:340e%10]) with mapi id 15.20.3589.030; Tue, 24 Nov 2020 02:02:51 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "hao.a.wu@intel.com" CC: "Wang, Jian J" , Andrew Fish , Laszlo Ersek , Leif Lindholm , "Kinney, Michael D" , "Wang, Nickle (HPS SW)" , "O'Hanley, Peter (EXL)" Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port Thread-Topic: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port Thread-Index: AQHWwaWpgE6CyF0BvkuX9D6Pt2xq3KnWexUwgAADLLCAAAOjAIAABeig Date: Tue, 24 Nov 2020 02:02:51 +0000 Message-ID: References: <20201123134722.15980-1-abner.chang@hpe.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=hpe.com; x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 63e966d0-3491-4e74-a98e-08d8901d0c9b x-ms-traffictypediagnostic: CS1PR8401MB0344: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:462; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yGgPEv5KBgzl0/W58k+QvnIhv4BVIwLzI9Nl29hW7vCywrl5SRibgzOtI8XDm2PswqcpwAoDzff+m/U9IqVryYw4blKk79iuDIAPpkYlg9LIEp+9iCm39POZKnulUCUZaZ/qrXKwcVH2o3QKOIU8ikdyF9mQaBeR4cJDxxXo4vOrNP92HeN2GcOjSWS00+Mi+7msXviBbW6U9VXFkD6UQHUdvCdtyz7hjCqT06wJyggIeCyW3ykArt65slnISYbuT13J+/nN+afBYrGh0B7SKp96JRhh1kWEJQKmfUbvAR4jfKnEWqQYOSBDddZHiOSspupscUD1qO4eV76NPf34n26r9t5VQ9Z4ok+PeKDheBP+zAOkFz4bAWFd+eS4o97AZPBrHoGLrd7QksZ9GKqTwA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(366004)(376002)(346002)(136003)(39860400002)(396003)(64756008)(19627235002)(26005)(4326008)(110136005)(54906003)(186003)(316002)(33656002)(8936002)(8676002)(478600001)(966005)(53546011)(6506007)(7696005)(9686003)(55016002)(71200400001)(52536014)(5660300002)(2906002)(66446008)(83380400001)(66946007)(66476007)(76116006)(66556008)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 3BEtaGv+hY4sDcCngvDQ+H1I+8Rgt/Xqxz7VKOyxCsYQ9y+vIIj8TM3nO16t3uYeVhEwlIGoPLR1BF+6s+tgAr4NUHdqdP+zmmG4kjlDGp597Gkwp1/uxRHF1RKfmc3OXT9rKhfr77KwLRids6rCyVQFwJ2VP1S+EdVsXqpAzCNPY6ZiqDkvAS9GWYfdcdSJJsno3/Tyd3nQ1Yyvq256zbvMOnyXb/sfl2Ge33Ry6l/j1oay1yWY2vtzwmH3jCnwQw8e6vce4wlxzdNLxD2eSHbpJi14eogleJd4Z//JN2CdpuHyou9dKGmNMcwP+uzJqiMgEpjqy5NLdIftKHWb+B6fKJw3m4CBWtgA9JgVh4X50HamGP5tBCTnFZ/vLNbD76gcFFdp/8/X4a6grwd+vH9mwExwjCHGWmGgocyMiXP4cFKiDKKa3OoakvJx4tlQS/HkeR59ph+4i94g6STt1/Zxu6VVn3eQEOJx8WpQsxhCYzjqjks3rKcx7Z2XvCWGn8x+k68qhCZajcwlyixc0TUTKJ6IFDG0FF3l5o0v08saAVYpxzWjpCNxZl1yxnnpZDBRpuxXIdC8dfeAz/U997DCRuQxsU8DhyQEvypT19Ppr7piGk2081EwRPVr3CvMPrIw1zc+o2FZ+7Ln10f2uZqrtVFsXCaMdnywPLNebZF45N3qQ9nq59m8DG7SYblgA2q3UGTUg21+V/Ar9b7MR17AfqLNyPDEhQNxNkdVrhcCKaZvN65HkJoF/myfjddLpO84/Z/hR05pgG3WJG0t/yQCTYbPSpJLPM79FQ6Jus1IFvxe3RnsAwnlqFl80uenr3BN9wdnCxrzqnoZWELpplhpHihIoQTaRaLUGioSpiQc82dV26z2HjfTvCYgW4veDdGTknDMhE3nDBp5gvTE5A== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 63e966d0-3491-4e74-a98e-08d8901d0c9b X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2020 02:02:51.0965 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qQYFpsKJj4FEwfXGdRp6/NGetjocSmIAXlJBb01fHHHvJk2z1Gqjk/zF8lSQUgkP/0eTOD749inYwgHB8EVf5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0344 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-23_19:2020-11-23,2020-11-23 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 phishscore=0 clxscore=1015 malwarescore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011240011 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Tuesday, November 24, 2020 9:50 AM > To: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io > Cc: Wang, Jian J ; Andrew Fish ; > Laszlo Ersek ; Leif Lindholm ; > Kinney, Michael D ; Wang, Nickle (HPS SW) > ; O'Hanley, Peter (EXL) > Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port >=20 > > -----Original Message----- > > From: Chang, Abner (HPS SW/FW Technologist) > > Sent: Tuesday, November 24, 2020 9:31 AM > > To: devel@edk2.groups.io; Wu, Hao A > > Cc: Wang, Jian J ; Andrew Fish > > ; Laszlo Ersek ; Leif Lindholm > > ; Kinney, Michael D ; > > Wang, Nickle (HPS SW) ; O'Hanley, Peter (EXL) > > > > Subject: RE: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port > > > > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf > > > Of Wu, Hao A > > > Sent: Tuesday, November 24, 2020 9:20 AM > > > To: Chang, Abner (HPS SW/FW Technologist) ; > > > devel@edk2.groups.io > > > Cc: Wang, Jian J ; Andrew Fish > > > ; Laszlo Ersek ; Leif Lindholm > > > ; Kinney, Michael D ; > > > Wang, Nickle (HPS SW) ; O'Hanley, Peter (EXL) > > > > > > Subject: Re: [edk2-devel] [PATCH 0/3] JsonLib: jansson edk2 port > > > > > > > -----Original Message----- > > > > From: Abner Chang > > > > Sent: Monday, November 23, 2020 9:47 PM > > > > To: devel@edk2.groups.io > > > > Cc: Wang, Jian J ; Wu, Hao A > > > > ; Andrew Fish ; Laszlo Ersek > > > > ; Leif Lindholm ; Kinney, > > > > Michael D ; Nickle Wang > > > > ; Peter O'Hanley > > > > Subject: [PATCH 0/3] JsonLib: jansson edk2 port > > > > > > > > This set of pactehs is sent for the comments on edk2 JSON library. > > > > edk2 JSON library is based on jansson open source > > > > (https://github.com/akheron/jansson) and wrapped as an edk2 librar= y. > > > > edk2 JsonLib will be used by edk2 Redfish feature drivers (not > > > > contributed yet) > > > > > > > > > Hello, > > > > > > Sorry for possibly missing previous discussions on the Redfish featu= re. > > > I am wondering is it more straight-forward to put the JsonLib > > > together with the Readfish codes under RedfishPkg? > > Hi Hao, > > The idea is JSON is not the representation of data payload for Redfish > > only and JsonLib could be not only for Redfish neither. Any > > applications which use JSON as data payload can leverage JsonLib. >=20 >=20 > Thanks, >=20 > My concern is for the case of adding a common library/module, > MdeModulePkg usually seems to be the destination. But since > MdeModulePkg is already a huge and complex package, I am not sure if thi= s > is the right way to go. >=20 > I would like to get the inputs on other reviewers for putting the JsonLi= b > under MdeModulePkg. >=20 > If this is the right direction, could you help to add an item in the > Maintainers.txt for the Json related stuff in MdeModulePkg and list you = (and > 1 more person will be appreciated) as the reviewer? That's no problem. We are pleased to be the reviewer of JSON lib. Yes, see others input for JsonLib location. Thanks Abner >=20 > Thanks in advance. >=20 > Best Regards, > Hao Wu >=20 >=20 > > > > Thanks > > Abner > > > > > > Best Regards, > > > Hao Wu > > > > > > > > > > and the edk2 port of libredfish library (not contributed yet) > > > > based on DMTF GitHub (https://github.com/DMTF/libredfish). > > > > > > > > You will encounterred the build error with the jansson library > > > > pointed in submoudle (v2.13.1) and the fix is already submitted to > > > > jansson open source (https://github.com/akheron/jansson/pull/558). > > > > > > > > Signed-off-by: Abner Chang > > > > > > > > Cc: Jian J Wang > > > > Cc: Hao A Wu > > > > Cc: Andrew Fish > > > > Cc: Laszlo Ersek > > > > Cc: Leif Lindholm > > > > Cc: Michael D Kinney > > > > Cc: Nickle Wang > > > > Cc: Peter O'Hanley > > > > > > > > Abner Chang (3): > > > > edk2: jansson submodule of JSON library > > > > MdeModulePkg/library: EDK2 port jansson library > > > > MdeModulePkg: Add EDK2 port jansson library > > > > > > > > .gitmodules | 3 + > > > > MdeModulePkg/Include/Library/JsonLib.h | 596 +++++++++++++ > > > > .../Library/JsonLib/JanssonCrtLibSupport.c | 705 +++++++++++++= ++ > > > > .../Library/JsonLib/JanssonCrtLibSupport.h | 198 +++++ > > > > MdeModulePkg/Library/JsonLib/JsonLib.c | 805 > > > ++++++++++++++++++ > > > > MdeModulePkg/Library/JsonLib/JsonLib.inf | 81 ++ > > > > MdeModulePkg/Library/JsonLib/JsonUtilities.c | 417 +++++++++ > > > > MdeModulePkg/Library/JsonLib/JsonUtilities.h | 69 ++ > > > > MdeModulePkg/Library/JsonLib/assert.h | 11 + > > > > MdeModulePkg/Library/JsonLib/errno.h | 11 + > > > > MdeModulePkg/Library/JsonLib/jansson | 1 + > > > > MdeModulePkg/Library/JsonLib/jansson_config.h | 57 > > > > ++ .../Library/JsonLib/jansson_private_config.h | 19 + > > > > MdeModulePkg/Library/JsonLib/limits.h | 11 + > > > > MdeModulePkg/Library/JsonLib/math.h | 11 + > > > > MdeModulePkg/Library/JsonLib/stdarg.h | 11 + > > > > MdeModulePkg/Library/JsonLib/stddef.h | 11 + > > > > MdeModulePkg/Library/JsonLib/stdio.h | 11 + > > > > MdeModulePkg/Library/JsonLib/stdlib.h | 11 + > > > > MdeModulePkg/Library/JsonLib/string.h | 11 + > > > > MdeModulePkg/Library/JsonLib/sys/time.h | 11 + > > > > MdeModulePkg/Library/JsonLib/sys/types.h | 10 + > > > > MdeModulePkg/Library/JsonLib/time.h | 11 + > > > > MdeModulePkg/MdeModulePkg.dec | 7 +- > > > > MdeModulePkg/MdeModulePkg.dsc | 4 +- > > > > ReadMe.rst | 1 + > > > > 26 files changed, 3092 insertions(+), 2 deletions(-) create mode > > > > 100644 MdeModulePkg/Include/Library/JsonLib.h > > > > create mode 100644 > > > > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.c > > > > create mode 100644 > > > > MdeModulePkg/Library/JsonLib/JanssonCrtLibSupport.h > > > > create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.c > > > > create mode 100644 MdeModulePkg/Library/JsonLib/JsonLib.inf > > > > create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.c > > > > create mode 100644 MdeModulePkg/Library/JsonLib/JsonUtilities.h > > > > create mode 100644 MdeModulePkg/Library/JsonLib/assert.h > > > > create mode 100644 MdeModulePkg/Library/JsonLib/errno.h > > > > create mode 160000 MdeModulePkg/Library/JsonLib/jansson > > > > create mode 100644 MdeModulePkg/Library/JsonLib/jansson_config.h > > > > create mode 100644 > > > > MdeModulePkg/Library/JsonLib/jansson_private_config.h > > > > create mode 100644 MdeModulePkg/Library/JsonLib/limits.h > > > > create mode 100644 MdeModulePkg/Library/JsonLib/math.h > > > > create mode 100644 MdeModulePkg/Library/JsonLib/stdarg.h > > > > create mode 100644 MdeModulePkg/Library/JsonLib/stddef.h > > > > create mode 100644 MdeModulePkg/Library/JsonLib/stdio.h > > > > create mode 100644 MdeModulePkg/Library/JsonLib/stdlib.h > > > > create mode 100644 MdeModulePkg/Library/JsonLib/string.h > > > > create mode 100644 MdeModulePkg/Library/JsonLib/sys/time.h > > > > create mode 100644 MdeModulePkg/Library/JsonLib/sys/types.h > > > > create mode 100644 MdeModulePkg/Library/JsonLib/time.h > > > > > > > > -- > > > > 2.17.1 > > > > > > > > > > > > > > > > > >=20 >=20 >=20 >=20 >=20