From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web11.4703.1591768174969128404 for ; Tue, 09 Jun 2020 22:49:35 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=043079d09f=abner.chang@hpe.com) Received: from pps.filterd (m0150244.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05A5mK3f014535 for ; Wed, 10 Jun 2020 05:49:33 GMT Received: from g2t2353.austin.hpe.com (g2t2353.austin.hpe.com [15.233.44.26]) by mx0b-002e3701.pphosted.com with ESMTP id 31j3jg25bh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 10 Jun 2020 05:49:33 +0000 Received: from G9W8455.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.216.161.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2353.austin.hpe.com (Postfix) with ESMTPS id E8F7886 for ; Wed, 10 Jun 2020 05:49:32 +0000 (UTC) Received: from G1W8107.americas.hpqcorp.net (2002:10c1:483b::10c1:483b) by G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 10 Jun 2020 05:49:32 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (15.241.52.13) by G1W8107.americas.hpqcorp.net (16.193.72.59) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 10 Jun 2020 05:49:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BQ5MdA6Vbspk6vnSILkQiSgAfXbKcTRU4rkw5mX53P3TucfW6suhv3B8SYaw+1nGaVHEPAWKmSPaYhYUAc4E2HAXBGNamSkJamzeMPNG0Th5YGW4MN7/1WofqCp5IRni22JIEzm3s6FRRDXDuFOopE5LucrRSCRBWCQKjKtcQD/T6J/l5uRUPaRLSaeL82mUzy6F6uhNkcU84BbqhCXwBP8Ggi5pX0iuIL11sGt5QmbuCL0LIG/fLlN6r0dV2Bfs2sy4DRaVUIFcw0THJht/Guw4G2KcLGLUQsz6qbPDAlRXC0FdZuKI1rC8b3k7udOmF+8O5VjCHy65wRUGFuobMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HpQjUnUhDnQqKqqIPqyizQ+M+f4Osa4GBjK/soClzVo=; b=XyIMxLX34COYanb6IN9ov+Hr3tiF47i4YqChKXZPMa1mYWub9jFPTXhOEMsnmW0TXe/hmAzSPeX2FRd+/PQNKI/9S05liutd+MH7Lo7o1EJbXynMHM/5mLC7zzkQRObXQiRzQxXOw4QPfXq6AQbrgkR8sDfW+MhxZVGF1zxl5tqopN3n5si+VrNRj3cvucCXac43Sd4FgYdDCtI5qcryP6Jq6K6B8ROHjbudL7ODxR+vYFUJnQeqsjsd0J7YqUTH6NM32cGRISgqTsJaO60CGcZYM/P5AoKyR1RRvZlOP4y6S8mYsgItaP5sWidL05bsGKMXMZPEq1q96eyR4nzL7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB0822.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:750d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.19; Wed, 10 Jun 2020 05:49:31 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c816:8a7:91a0:1d75]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c816:8a7:91a0:1d75%11]) with mapi id 15.20.3088.018; Wed, 10 Jun 2020 05:49:31 +0000 From: "Abner Chang" To: "Bi, Dandan" , "Li, Walon" , "devel@edk2.groups.io" , "Gao, Liming" CC: "Wang, Nickle (HPS SW)" , "Wang, Sunny (HPS SW)" , "Dong, Eric" , "Wang, Jian J" , "Wu, Hao A" Subject: Re: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver with form-update Thread-Topic: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver with form-update Thread-Index: AQHWLl6+S12ZGp2W4U2XBX7OYWI9ZKi22fiAgA/0ToCAB55XgIADB8uAgAAEm4A= Date: Wed, 10 Jun 2020 05:49:31 +0000 Message-ID: References: <20200520042447.1017-1-walon.li@hpe.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [123.194.165.59] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 0f564410-0c2b-466c-0f1a-08d80d020bca x-ms-traffictypediagnostic: CS1PR8401MB0822: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 0430FA5CB7 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a7UFRm1lkZ5lv2nVBWaP5jiLYhU/rsQPUX4rJlYgdU3JhyeAVaaSdm2BEYa0K7ct/4TqFlQ4JoukMJD18EbwuemQAYYCyyaWfnW6Y4I6BL1hFXjroqsl4eXrt6A79v65tehFvQoPrsSE4L1GG6Wal30uZCasdSihFyBxrha1lBpzkfT6mVloG6CAdrcbKybbj011f3OnFHE/lOsIfzZpNdMKEgm2cVj9AUEb9mrvJMS92cfF5//2oG/jvLBOv8vKkoh30ZupY7vT8kueidDm3tTlxa/HpU17gEVmnpdq9QTldMGB0doBxEFQtYiQy3AXHnCXM/OVCdBXig0SgtqqjaGiCyx8JMLMCgUuKMaeCADm/tx6Ubuq9mC7E640geWlWg3LDMJHV60i13tuaylLCg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFTY:;SFS:(366004)(39860400002)(376002)(396003)(346002)(136003)(66946007)(76116006)(66574014)(83380400001)(66556008)(66446008)(64756008)(66476007)(71200400001)(5660300002)(52536014)(26005)(186003)(6506007)(316002)(8936002)(110136005)(54906003)(8676002)(15650500001)(9686003)(2906002)(7696005)(4326008)(33656002)(19627235002)(478600001)(55016002)(86362001)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: N5dOx9uq5T/UBmhWQNIBDxuGh5kYFEHp5IqvUk/mwRajvBMmBw1MNOxpCrDcC4yOik28HTuBYq2+8qUpnt3D46V0bMVaqKfcXA8WegPWG/1AarudPAcpA5sdqy8GAIg1F91E7uoeerEl8iKjfex+Cgb8/e83syoo4DbmEv5ol3DDsJzme1TO2Nzrxb0EHtjZF8LyB8j+j6SVSR8oEwOMwHbVfCmK8IOzO6ffqGpkFRKxBSpzdGlj1vUoLab5t6CvAddl/ro/bGXH/r+yZA2h6ivZEhnYn5qY9rxHVHUvHY1I+gL2r7kNtImNTKy4Zc9Vr9XMVWHaQso6DgSoGhobf+1QwT0VP7w16lrTkBT7GBMEkySxGJ6TZ1/8E5vlmoqYRSiCQfruvZXPAmzrYccBlBTSLnLsdge8RxuhYrlR/MNQqHEEB4EtTWpmNvmhY7G+bTkLMR4oI2vH9i9rX3JvOYhFW8TttGWl4uoP90bzo/+LN/ocYS64oMllIsA9mpXs X-MS-Exchange-CrossTenant-Network-Message-Id: 0f564410-0c2b-466c-0f1a-08d80d020bca X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2020 05:49:31.0333 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BDYLZ8lPOwACbMfSfr1w9mo+QueFJXNfKqF4LUcPt5n/Udh3SCQA15rwsG/U6VW8QX7G7vY5CD3Tq4SyRmOfGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0822 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-10_02:2020-06-10,2020-06-10 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 priorityscore=1501 bulkscore=0 cotscore=-2147483648 lowpriorityscore=0 impostorscore=0 clxscore=1015 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006100044 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Dandan. Abner > -----Original Message----- > From: Bi, Dandan [mailto:dandan.bi@intel.com] > Sent: Wednesday, June 10, 2020 1:33 PM > To: Li, Walon ; devel@edk2.groups.io; Gao, Liming > > Cc: Wang, Nickle (HPS SW) ; Chang, Abner (HPS > SW/FW Technologist) ; Wang, Sunny (HPS SW) > ; Dong, Eric ; Wang, Jian J > ; Wu, Hao A > Subject: RE: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect > driver with form-update >=20 > This patch is committed via 365fdb0f939cf00b26d37f27adbf579aa984221b >=20 >=20 > Thanks, > Dandan > > -----Original Message----- > > From: Bi, Dandan > > Sent: Monday, June 8, 2020 3:16 PM > > To: Li, Walon ; devel@edk2.groups.io; Gao, Liming > > > > Cc: Wang, Nickle (HPS SW) ; Chang, Abner (HPS > > SW/FW Technologist) ; Wang, Sunny (HPS SW) > > ; Dong, Eric ; Wang, Jian J > > ; Wu, Hao A > > Subject: RE: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect > > driver with form-update > > > > Hi All, > > > > Is there any concern for this patch? > > I will push this patch tomorrow if don't get any objection? > > > > > > > > Thanks, > > Dandan > > > > > -----Original Message----- > > > From: Li, Walon > > > Sent: Wednesday, June 3, 2020 6:56 PM > > > To: Bi, Dandan ; devel@edk2.groups.io; Gao, > > > Liming > > > Cc: Wang, Nickle (HPS SW) ; Chang, Abner (HPS > > > SW/FW Technologist) ; Wang, Sunny (HPS SW) > > > > > > Subject: RE: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not > reconnect > > > driver with form-update > > > > > > May I know the schedule of pushing this change to edk2-master? Or > > > what's next step I should do? > > > > > > Thanks, > > > Walon > > > -----Original Message----- > > > From: Bi, Dandan [mailto:dandan.bi@intel.com] > > > Sent: Sunday, May 24, 2020 3:17 PM > > > To: Li, Walon ; devel@edk2.groups.io > > > Cc: Wang, Nickle (HPS SW) ; Chang, Abner (HPS > > > SW/FW Technologist) ; Wang, Sunny (HPS SW) > > > > > > Subject: RE: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not > reconnect > > > driver with form-update > > > > > > Reviewed-by: Dandan Bi > > > > > > > > > Thanks, > > > Dandan > > > > -----Original Message----- > > > > From: Walon Li > > > > Sent: Wednesday, May 20, 2020 12:25 PM > > > > To: devel@edk2.groups.io > > > > Cc: walon.li@hpe.com; Bi, Dandan ; > > > > nickle.wang@hpe.com; abner.chang@hpe.com; sunnywang@hpe.com > > > > Subject: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect > > > driver > > > > with form-update > > > > > > > > REF:INVALID URI REMOVED. > > > > ti > > > > an > > > > ocore.org_show-5Fbug.cgi-3Fid- > > > 3D2701&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2LFWg > > > > > > > > > > &r=3DnGx4G_nX3rQG_ai3uSb52w&m=3Dj34dsoHyXFEvnpFmkT_iUSnMAF1kWbm > > > BFnMbHVJkJx > > > > U&s=3DV7D879dizWzD8-fTk-wXmw5sypK5jfdtjWAENVbXntQ&e=3D > > > > > > > > Recording to the spec, the reconnect is activated upon exiting of > > > > the formset or the browser. Exiting is by user but form-browser > > > > internal logic. That means the reconnection is only happened when > > > > user press ESC or _EXIT action to exit form. > > > > Driver callback may update HII form dynamically so form-browser > > > > needs to refresh its internal data. It's not exiting formset for > > > > user exactly and they didn't know what happened. So use a flag to > > > > record that and do not reconnect driver if updated by callback. > > > > > > > > Signed-off-by: Walon Li > > > > --- > > > > MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 2 ++ > > > > MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 8 > +++++++- > > > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > > > > > diff --git > a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > > > > b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > > > > index bafee4c612..7f85873730 100644 > > > > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > > > > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > > > > @@ -19,6 +19,7 @@ LIST_ENTRY mRefreshEventList =3D > > > > INITIALIZE_LIST_HEAD_VARIABLE (mRefreshEv > > > > UINT16 mCurFakeQestId; FORM_DISPLAY_ENGINE_FORM > > > > gDisplayFormData; BOOLEAN mFinishRetrieveCall =3D > > FALSE;+BOOLEAN > > > > mDynamicFormUpdated =3D FALSE; /** Check whether the > ConfigAccess > > > > protocol is available.@@ -1762,6 +1763,7 @@ FormUpdateNotify ( > > > > ) { mHiiPackageListUpdated =3D TRUE;+ mDynamicFormUpdated =3D > TRUE; > > > > return EFI_SUCCESS; }diff --git > > > > a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > > > b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > > > index 82067b541c..f936a4b8e8 100644 > > > > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > > > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > > > @@ -68,6 +68,7 @@ extern EFI_GUID mCurrentFormSetGuid; > > > > extern EFI_HII_HANDLE mCurrentHiiHandle; extern UINT16 > > > > mCurrentFormId; extern FORM_DISPLAY_ENGINE_FORM > > > > gDisplayFormData;+extern BOOLEAN mDynamicFormUpdated; /** > > > > Create a menu with specified formset GUID and form ID, and add it > > > > as a child@@ -536,6 +537,7 @@ SendForm ( > > > > } Selection->FormSet =3D FormSet; mSystemLevelFo= rmSet =3D > > > > FormSet;+ mDynamicFormUpdated =3D FALSE; // // Di= splay this > > > > formset@@ -547,7 +549,11 @@ SendForm ( > > > > gCurrentSelection =3D NULL; mSystemLevelFormSet =3D NU= LL; - if > > > > (gFlagReconnect || gCallbackReconnect) {+ //+ // If callb= ack > update > > > > form dynamically, it's not exiting of the formset for user so syste= m do > not > > > > reconnect driver hanlde+ // this time.+ //+ if > > > > (!mDynamicFormUpdated && (gFlagReconnect || gCallbackReconnect)) > > > > { RetVal =3D ReconnectController (FormSet->DriverHandle); = if > > > (!RetVal) > > > > { PopupErrorMessage(BROWSER_RECONNECT_FAIL, NULL, NULL, > > > > NULL);-- > > > > 2.23.0.windows.1 > > >