From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web11.13273.1621438229925265661 for ; Wed, 19 May 2021 08:30:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=M6S7wGpS; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0773379713=abner.chang@hpe.com) Received: from pps.filterd (m0148663.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14JFJ9A0018617; Wed, 19 May 2021 15:30:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=bS2UI9fP0cbE8oouUioZq6n7iHOBi3a3mH3p7LRO8PU=; b=M6S7wGpSsGmHeHns+HbMK2Kt2IALxOvfZo2v5EL27J5dMRYbrkGUO2fq6AJpijW22t7A GCIZcfqJjCrDJpnXgkUm3JUMlpilKp0rdCLacCWWMMzpI7COOCpGdU8KFA9VT6x04zYs W3QJ15Xi3ZPa8p3qs32Qkkj+1E3gX/Oc18K2fYgnJ9oNsCu36CtSAB5axVcE7K3szcDg IBGDto5KOn6ycMbiOPV7QtvN3OU97g0VFTlBBmeBl/nU3jSmasgOBKxLpFTQ+LUUV2GW KKsk98IWmTIk3KXUTIihnl2QPI2ev8gz53vjP+IWoCZWHVcRdlIOqk6G9y6JIW7DC9N1 bA== Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) by mx0a-002e3701.pphosted.com with ESMTP id 38mrn6e6wu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 May 2021 15:30:26 +0000 Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5008.houston.hpe.com (Postfix) with ESMTPS id DC53256; Wed, 19 May 2021 15:30:25 +0000 (UTC) Received: from G9W8676.americas.hpqcorp.net (16.220.49.23) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 May 2021 15:30:25 +0000 Received: from G4W10205.americas.hpqcorp.net (2002:10cf:520f::10cf:520f) by G9W8676.americas.hpqcorp.net (2002:10dc:3117::10dc:3117) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 May 2021 15:30:25 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (15.241.52.13) by G4W10205.americas.hpqcorp.net (16.207.82.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 19 May 2021 15:30:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JnSBK0MVWkKu/rMwFlD18YJzEcS2kiAijDHGTTJ1dW9I0oavM074LdsdlKvzypp1OxOKAMum49QvRBAC/epn0pumanWuhVvOAyqFEwdhvLwAuGDrnztwTL0WZYNLGQLDhQHVVaSCPGgclD8rcK0/WKaZeNNJnarf5xB2CNTpHiDHh/xHVLXGH+hByBl0ZlLDX4PKH/ZmfrmCIy/iR432oNTQsJuseO5JZbVeeKjh9AtnQpEuptzLXrhfwEuAUqZ1YYhuBV1lWb1jVT2zqcN7eLdFESCfdVOVoHcQ+3O9C/HYGl2CD+buqdWsS4vn/DxQHOvivdbL53lhygT5JIqlNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bS2UI9fP0cbE8oouUioZq6n7iHOBi3a3mH3p7LRO8PU=; b=HZfuF1ofYFbkFBiQ/u3QPRkQShnU1J94AVLJDVCe475u2pbl55kZCyNUAhE+JQAIjEbH2+Mf2KfWAzSMl9uz52TOTMMa9bbRHeiOc9HduqM3FipdXKHDy8A2jS8/sNr4RntrV0MRJMx/P6I5IB+fW72ouRPSyxbUo8MTG+hKVq8Oea539w0sHVoUoJBDgQPu5iyYpvOcbFuOUOSjUAX2uAs5F4GZs5KCYOGPPF6ZAGA9lMmigTFKKOyUOSa93L19KQerSS+6nna6GuZlBXRPdFYmDTSxoiQBgBp0NmmZfi4B9keHm4e+OiQ0Cwys8pOvJYgs8Y7fgBD2z3up2bkL0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB0424.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7510::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Wed, 19 May 2021 15:30:23 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::28f5:3e45:17cf:9231]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::28f5:3e45:17cf:9231%10]) with mapi id 15.20.4129.033; Wed, 19 May 2021 15:30:22 +0000 From: "Abner Chang" To: "Schaefer, Daniel" , "devel@edk2.groups.io" CC: Leif Lindholm , Ard Biesheuvel , Anup Patel Subject: Re: [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to libfdt_env.h Thread-Topic: [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to libfdt_env.h Thread-Index: AQHXTL93byUxDBsp60GcLz8Y44HJXqrq7jAw Date: Wed, 19 May 2021 15:30:22 +0000 Message-ID: References: <20210519145822.4028-1-daniel.schaefer@hpe.com> In-Reply-To: <20210519145822.4028-1-daniel.schaefer@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [165.225.117.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f1032e91-4122-421f-85f2-08d91adb04c0 x-ms-traffictypediagnostic: CS1PR8401MB0424: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1107; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fPUCb08bE4HbTCDy+kFRTXrzIWbNjftFcSDuN0te++R4zVrKS93wRG4g/Qxz0xQGAmmf19jaJU9UZ8Lq1JOi0wOhXkipHqtEP5RTFUhkG0GJwnnptDf8R2fcRgkKxt/bu8AmM4Pxnu7nlpMHWxeREomXNWA1+F0FXshjLvp44hLktZuvyxVkn4rXzEgBScAxViKkVbvGU7B96V+AI+SYiPrr2lxEuDUXO6Kw2s4hqOApMEzhr7zGY4l2V6nsDQYH2JD5QQUWfBLai1V4D02wGF7t+48Fxew6nwAy3bnc4uvxDEPn7Tv4S3PTK2ial9rer9QvUPOPwd0nn4RKS6zXOhCBaD1b+1UuUWBpEbqK2poSBrYMG/DiOivbWloozwkT7ZlCe08C6GK46QiQ414Gi0VgZtBwN+VYuMIyYwdZHmCn67XSSrhslMPwGK02qVh+PaFv/9Wg2+2QjfYLDyoS5YyE0es+YHTv6hv3vBCTuj1H/1WkoR7CXvu7SX1lb1/Qjb/cYC9bGxx0OtoyV9sQXI7uyKaWdg0+Nyag9JCipFfHZHbTuhyVdluKz+VzXWy63xO2ub9/cAK+Jn++K44bodAbHJ9sedKLEWfj6vp7KKeqNSckK1SDYebWHNZLlxtGDjDaY8RY1HFQLhCLDXH4bak5H3RtikKy6ZSnJQorUM6D8QWG0sxRfTkw9iMLjydHsxZAP3fn/2eTg55lDfXeIbsHQjEP6fKrVx6AS8EPfcc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(396003)(39860400002)(366004)(346002)(376002)(136003)(54906003)(38100700002)(83380400001)(8936002)(55236004)(52536014)(122000001)(110136005)(478600001)(53546011)(71200400001)(6506007)(316002)(86362001)(966005)(33656002)(8676002)(55016002)(7696005)(9686003)(2906002)(26005)(5660300002)(76116006)(64756008)(186003)(4326008)(66946007)(66446008)(66476007)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?iZziodBCHotkQPJZCVU4tnZ8M6V/FCZNIjFSYXNkt9AaaVvSakVGTaPe0Pfe?= =?us-ascii?Q?cNk+JZvZeuDwbL3+oGeyMMxdPD2+lZadcJMi7PvoFL6gehAPIR0RBYo2CmXi?= =?us-ascii?Q?U4xt+U13FRN8mPqALSfud/w4n7zyjD8P6WbKyp1VTpVbOfcXZE3l50nSHOcv?= =?us-ascii?Q?bix7u5ee/geRfBTH3RvdIoVLXJK5MGAzVGhD4UduN2h0GL5lqp/Ze3iWGRW9?= =?us-ascii?Q?ovLMfAlRpc8fxAYhc7n5qoSipvolPPYoAaWCQ2108lXTvauiCBBiVtZdNOYx?= =?us-ascii?Q?TGzE4k/y5azivGPvj2t9d4ov6TLYU1WDHO6F7JImojP/35mYA0BJ6jKX2/3l?= =?us-ascii?Q?N4dWg9TSX2rfK/aZ+n9DGOYuOiqLcmtYe+xzrpyw6fyALR/Ph3j62hMjS+ae?= =?us-ascii?Q?QRFkzg5/Pqr6Q8QA/1sqSV5h0NVeGVwrrWPYr6mFWDaMG3JL2oWpMyQSpCII?= =?us-ascii?Q?FquGj8YnHDRQ6ZBZLv53ltapmVhPiFUDV57DGCguQwBCqlU0MFUJeipufgEz?= =?us-ascii?Q?XwjSsNtoUSL152hSqzobjh/OgqTOqigu/NlubR9wvg+FTZy7BHgaR8IMP5Wt?= =?us-ascii?Q?jKOWJZTM96JhaL/gxEdYLj8DW7wXn/P9zL03bwl9qibBXPb+0sqDJwhhuJSi?= =?us-ascii?Q?W9HOQ2Pm+1eiR1tBpa1wsfrCRQuQFMhhPS9gmTEzP7/xbO8I4bS/XZk++TbH?= =?us-ascii?Q?oQPioxONJ5woSwv635y9/TEtcKMTHZJreVzCDWvUXoz//eIdgfgF08KE3R5r?= =?us-ascii?Q?SZSgC6vhg/k05jyFO44UVeMLQyIBPVkdoedrfMqAUMvlYs8adOovwDzZWIE5?= =?us-ascii?Q?d169R6K15ZxLx3hPIGOZRVcxGmUUTchJZypg1tEi0wCkrHXtwfHwmjKkxg4r?= =?us-ascii?Q?xfuwiZ3qCWOdzrNO0oio71wwEAF4AjcATqcMa5Tm6nTF1kUv+79SNzr0gfBk?= =?us-ascii?Q?GHLcRuha3Pi1BYJBeHid/1cNsnt1XOsbU2NPeA44AfF5giDsAAuhdFNKDv1I?= =?us-ascii?Q?xG2gWu7+Yn9R08MXwOzVYJZSytEbV6JQGZh7JMkJN9iUCeGsTXpEgJIK1gIw?= =?us-ascii?Q?og6MFSKcEqu+6QZDWCdYSPg6AMN3JNhqE5N0Sgh8kURettr+SYQHITqlaQJ3?= =?us-ascii?Q?VH51OCyof4aqS7zYThFIKtN75Oy0F8raiXz8sHbUdnpT13kOoxhl5VxF3Qpi?= =?us-ascii?Q?pf/oXuFvISqsrRpK/NbiIG4cHnuyMd+uzCsF6uc0+Ns9bwfApWIIx4EE7nZs?= =?us-ascii?Q?RThrQ1xFwbZMysrXaA+2NzKGQvprghs1PJB2nNuSun6SOnkh4QACX1lGVsnv?= =?us-ascii?Q?9LJoAVBX1K9SeMPkp/DO3ukI?= X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: f1032e91-4122-421f-85f2-08d91adb04c0 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2021 15:30:22.8312 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DolhfrBh4hh+TfQPS07BIHo8/lM6qs/M7TRptr7A6PT4xhokdAty7ROArHW02vBmwYaLddwS5pX4r4W9XGieyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0424 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: GBK6Z3AFcYe-zzyP-8cITufy64pmfPr7 X-Proofpoint-GUID: GBK6Z3AFcYe-zzyP-8cITufy64pmfPr7 X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-05-19_07:2021-05-19,2021-05-19 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 bulkscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105190096 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Abner Chang > -----Original Message----- > From: Schaefer, Daniel > Sent: Wednesday, May 19, 2021 10:58 PM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) ; Leif > Lindholm ; Ard Biesheuvel ; > Anup Patel > Subject: [PATCH v1 1/1] EmbeddedPkg/libfdt: Add strmp and strncpy to > libfdt_env.h >=20 > OpenSBI has started using those in v0.9. See: > https://github.com/riscv/opensbi/blob/v0.9/lib/utils/fdt/fdt_domain.c >=20 > Cc: Abner Chang > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Daniel Schaefer > Cc: Anup Patel > Signed-off-by: Daniel Schaefer > --- > EmbeddedPkg/Include/libfdt_env.h | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/EmbeddedPkg/Include/libfdt_env.h > b/EmbeddedPkg/Include/libfdt_env.h > index 7feff52bc0fb..c35ac739703c 100644 > --- a/EmbeddedPkg/Include/libfdt_env.h > +++ b/EmbeddedPkg/Include/libfdt_env.h > @@ -76,8 +76,16 @@ static inline size_t strnlen (const char* str, size_t = strsz ) { > return AsciiStrnLenS (str, strsz); >=20 > } >=20 >=20 >=20 > +static inline size_t strcmp (const char* str1, const char* str2) { >=20 > + return AsciiStrCmp (str1, str2); >=20 > +} >=20 > + >=20 > static inline size_t strncmp (const char* str1, const char* str2, size_t= strsz ) { >=20 > return AsciiStrnCmp (str1, str2, strsz); >=20 > } >=20 >=20 >=20 > +static inline size_t strncpy (char* dest, const char* source, size_t des= t_max) { >=20 > + return AsciiStrCpyS (dest, dest_max, source); >=20 > +} >=20 > + >=20 > #endif /* _LIBFDT_ENV_H */ >=20 > -- > 2.30.1