From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web10.3224.1618279120063618561 for ; Mon, 12 Apr 2021 18:58:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=LkcTwCGn; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0737d9f25c=abner.chang@hpe.com) Received: from pps.filterd (m0150241.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13D1rFV2025445; Tue, 13 Apr 2021 01:58:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=Ut3l9F4F58NraiWDMBumv1tyD1kweCuOk/OU1zuosgo=; b=LkcTwCGnJMnqHQrzQ+MFd43+GoAOMe4RCDGrM/yfZs4TVR+inbl4EbOwISogrWZyRsB/ 1JA8Nl4KkHdCyg4WZ9SFgVJ540kiEcqp4Fh9n8aZY4AShPCzzcUhN/ejx6xn/XD9f7uV VEMfg/62AjoYFvgudbbhdYMOilUHSRpBUxeWog227b9dGA7p6mjrTUbGR7+hthCmCiNE R9cfmMyDezKKntw6v0ozDcue0/oDXZ5LXBiSiZ9+0oDwixqFNoNGhjvMPNd/RuoISTp8 bmiYxa9OIZla9u8qG9QVjGTU+W6vpG0FpLSv1IR4XN2JHb7B6t2XIYKcl/MpPySuTr6b TA== Received: from g2t2352.austin.hpe.com (g2t2352.austin.hpe.com [15.233.44.25]) by mx0a-002e3701.pphosted.com with ESMTP id 37vgtxfs67-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Apr 2021 01:58:38 +0000 Received: from G2W6311.americas.hpqcorp.net (g2w6311.austin.hp.com [16.197.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2352.austin.hpe.com (Postfix) with ESMTPS id 0101091; Tue, 13 Apr 2021 01:58:37 +0000 (UTC) Received: from G4W9335.americas.hpqcorp.net (16.208.33.85) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 13 Apr 2021 01:58:38 +0000 Received: from G4W10204.americas.hpqcorp.net (2002:10cf:5210::10cf:5210) by G4W9335.americas.hpqcorp.net (2002:10d0:2155::10d0:2155) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 13 Apr 2021 01:58:37 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (15.241.52.10) by G4W10204.americas.hpqcorp.net (16.207.82.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 13 Apr 2021 01:58:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U4r3URgUZQvsK5ebs5757cfvt6rn+T/03PrFv0PFsvW33G/CbnZyDTev4kioqSTPb1SGOqkAhVTTgn4bWwpQHOjzaD0AgQGkLjB2p42UlwZoeSvNRbOM0FUd95yUYQ30p1StNn7oG+l0id0TXUc43mf23cVtJvdflT3QQO3Kmcv928K8tx5ndtA9O7MJaB55XhLYvKOCGFrCjdQNJYwzXd61EOpP9soAcLvN5mvoPlAIrnYlRp0FZkx60MaZ8yqhiunQkiG7lLUFV1illh7lasRyiHUeBOpHiRkAGfkqZcxp6cgKgK/6OlrmayhS6RA+ALEax5JvoxLLIVM68z5+lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LAl91ua88zdMO4QYx6UcK6+8HXo9xN6gPzOg6PvDqBo=; b=MEB54+ipDi9580cz5GhhrD78mQUBOSaptoa2Q8yq8q+xxqDA67e49V7Qae+/ODdtKJlqz2MGJiq0bp4vnBmvKRFpbhXfwEt91sxmsNR5lSQqhqenEj9a15b6wmq1Rp/7tz7/Tc9P5iCQUsggPqSMifAG9cSsyRZfzGhVw4pKiPaUToVZNPeIG4FYSJUjAL2IqPjHImaqZYPj9IlA5trDazJSnllTyDM/2FQRD2z57xKxcchFRMWq5whmPHkn7ypctwfQGQsIEHqDOwtv0p+eSP+2E9DfUtGlaZ0g0XaCbwzEd0bD472flF7x54o62psgXGTaPe1VfqjEhIvOCPDPeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB0469.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7507::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.18; Tue, 13 Apr 2021 01:58:36 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::28f5:3e45:17cf:9231]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::28f5:3e45:17cf:9231%10]) with mapi id 15.20.4020.022; Tue, 13 Apr 2021 01:58:36 +0000 From: "Abner Chang" To: Michael D Kinney , "devel@edk2.groups.io" CC: Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang , Andrew Fish Subject: Re: [Patch 2/3] CryptoPkg/Library/Include: Allow CPU specific defines to be predefined Thread-Topic: [Patch 2/3] CryptoPkg/Library/Include: Allow CPU specific defines to be predefined Thread-Index: AQHXLEELMO7EDrDWp0eTG3dltW3KI6qxuHEg Date: Tue, 13 Apr 2021 01:58:35 +0000 Message-ID: References: <20210408063240.877-1-michael.d.kinney@intel.com> <20210408063240.877-3-michael.d.kinney@intel.com> In-Reply-To: <20210408063240.877-3-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5a20e7cc-39ee-49c0-62a5-08d8fe1fa64e x-ms-traffictypediagnostic: CS1PR8401MB0469: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dU4s97dRjwvH9DU4gbLXSmKOLXysS7l9oxOdlB2EjrgPvnKir3ISxZDZ6egzLY4QAwrvTGCa/a8lrumDPPAlVIiRWgFOYSIC546clndfzKzot/iNthpye0T6mhYAd38p0IwaFGjjRzvO9UErrXu/QZc11iYHSpGroOT+xGU8fE5NlqMJbI3dhyrKoDvoJQxmQYu0bCns9OvNKB/mOVJqYJg8q1ORQk/tdtpgKDM5m7rILrc6RBbD165mFlyZ2HXcb919hl0BBN6zwcJfToNkGD7TroYtJ3aEWWof10miYp62+haOWH/BDAwG5sLc3/Fk2XvIz+GVpP9JjMPdJcZNZUxEYDWzCtvieCOkReTqO121qLYqDTixZ/occOTvzNjkZltqpKNMp7mVODRKy+tZVOveKsOo0A6OoELfzFK6vzVgEyUqQgnQtxCHfLK1HdQwUGuCmUGf+QVW2Jqh+xVdwbLLKeFEII8N4gWtD3YfT9QJFxT9UmtUrVSAfAWUBCoP5kf943XOKFS5a/UQgtm4s78h+5hCfR4YirVkiS473Zxe+gKOTiilBMZx5Nw7EnsmrAxpCeOX9k5DpvU91ok5DXyTOuwJa0o25dyRWAAzFqS4AoLJjZ5oPOOsBy3ujYIUbrF0ZOZotkwf5XFnmiTXnOE3hogQAHUdzEnHEgRZhSPZHp1aG3HYXbkmKJvHLprr/oW3IyMtkkghD4TfFuw2j/N1Drae1za+wt0bE/0eBWc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(346002)(39860400002)(396003)(366004)(136003)(376002)(2906002)(6506007)(4326008)(52536014)(38100700002)(478600001)(53546011)(7696005)(64756008)(122000001)(86362001)(110136005)(54906003)(66446008)(966005)(76116006)(71200400001)(316002)(186003)(66946007)(8676002)(83380400001)(8936002)(26005)(66556008)(9686003)(33656002)(66476007)(55016002)(5660300002)(21314003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?A/fCzhEkSXeujtviFjI4oCFJIhhnk66IANGZZB5rA3LsLhLnUBl1tKGQBTm6?= =?us-ascii?Q?ROIIE/VBOu9YgVJQbWbLdyTs+NI4GcZgHBAJLRpDvXUGyCTxmH/J6kSHGTtH?= =?us-ascii?Q?zKMWF405Vg8jQ98gki5+PJZ2m8aO/pO3mE6yclZx6HyCKcg0txplpYjXU9We?= =?us-ascii?Q?ZfALj1iWgtDX611uckDypBB8XmUCKzX/Pr0hRedRHiDQFVjwC595kBRhy0ez?= =?us-ascii?Q?Be517JjKyKAyZZi+TqGSwdNESiKHj79P4htiKn6YsgxzQIGG7lEq/gMuiHti?= =?us-ascii?Q?KyjnJJWyjPxaNxGJYXdslCnBDD5yuHR5fm2k7Hq9eJzY3SGX/oMUc2bL+fOG?= =?us-ascii?Q?NYQ67mu2Jp5vaG5z8BdFXEZrqS4EzCoRFxN45/n0X8vYAYnUH0uVyms022aA?= =?us-ascii?Q?KshcIjOguVEhnxGyWo7sBSxQJX6azXCjo2ws15P7kmFKAem4dc+83QkAGwGR?= =?us-ascii?Q?kQm8/uNViRhmUlIHevH8C/9Gtrf86XMwCvCW1WajvFmEnIsBgbmZyX60mQB8?= =?us-ascii?Q?TP+DHTPtPlEz3gtqceteDvmdfwa4WohDYNYV8coHO4SP8nDQjGYNhJyRd1Ky?= =?us-ascii?Q?A2Ulwt9hRLDtIykr3ZMKnMxF/7mFw93IYcBQxM3yCGgD8vEM6czwgwYlKV6y?= =?us-ascii?Q?/OemlkPv9onEgfI2Yl25kVghh8aa2bzcl5lSYF30jaqd62247zsZlRfHTz28?= =?us-ascii?Q?b6pPUkwzP+O2ZveuEcjEXN6rjxAlJ3OS2u1yWSXoBs5wk3pi4zJvL9EGeR3q?= =?us-ascii?Q?FQbieLVx746DP97BFEK8wLCLRKYonb6ZQh5J1gZhMFhHDdeBmXcLHMWJcvao?= =?us-ascii?Q?jsilehwHZ77LWiKcZyXVH4fh1G4/KW3Ib3k2/G5semST+DMnSdF08r3Fn8PA?= =?us-ascii?Q?kcij79GYAiIJUAfdHhOiQx0C+We5KxBngLJsR5H4D42RSlPJgDJmmfsQStB5?= =?us-ascii?Q?TgbCXrs92j2H4GmW2bqPK6TTevMOVwsi+7fnboWPTVJltneG1eI5sriQds2i?= =?us-ascii?Q?jEPu3zOAjGjbikPd+m298/6oXmoliulla6ca/4jYXVYFHM/aeW96ZmllFG+D?= =?us-ascii?Q?UvjYO6+F2QP9AMmMSE8cJApKxXMLynF/iMNfDrqS2XrksJagF8yNYlMrzgUp?= =?us-ascii?Q?8y2qBoQ9L7Uo/HFdkDv6DzIy/hSPmtgaTkXYBU5ehKFX4UJTLVpi5K6QWfEC?= =?us-ascii?Q?RVKbN1l8beksXozVIP8Acafj85W/YMtOTOIVwQ8ud1JVuNJJ4nZFX2ecSNeK?= =?us-ascii?Q?NHv8YrjjhvkThchvtNsaPo3MXReZdwfCcwArPQgXmHXYjKZilQ88X5fIaZ3+?= =?us-ascii?Q?qbebE3FUrDjIgPhW3maIIxP2?= x-ms-exchange-transport-forked: True X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 5a20e7cc-39ee-49c0-62a5-08d8fe1fa64e X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2021 01:58:35.9181 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Trp3JHicotEbXOPaEi2+MPLmsE96oaRKUFA9MgrzLxwPvJH1UDBanCGd6dFjvY7pwe/aImYBsW+Qu7esCSKXdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0469 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: Ol_P-ZCIKVA0YpIQF1sPzphk4z2dQoC- X-Proofpoint-GUID: Ol_P-ZCIKVA0YpIQF1sPzphk4z2dQoC- X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-04-12_15:2021-04-12,2021-04-12 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 mlxlogscore=999 impostorscore=0 adultscore=0 clxscore=1015 priorityscore=1501 phishscore=0 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104130011 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Abner Chang > -----Original Message----- > From: Michael D Kinney [mailto:michael.d.kinney@intel.com] > Sent: Thursday, April 8, 2021 2:33 PM > To: devel@edk2.groups.io > Cc: Jiewen Yao ; Jian J Wang > ; Xiaoyu Lu ; Guomin Jiang > ; Andrew Fish ; Chang, Abner > (HPS SW/FW Technologist) > Subject: [Patch 2/3] CryptoPkg/Library/Include: Allow CPU specific define= s to > be predefined >=20 > REF: > INVALID URI REMOVED > d=3D3308__;!!NpxR!2-P3Y- > hszCTVv28TDqqSG3TmDAWbHH_z7uQuHZYnM4_Gf5ueOE8v4f32Jklssow$ >=20 > The EDK II Build Specifications do not restrict the set of > CPU architectures that can be supported. Remove places in > the EDK II that assume a fixed set of CPU architectures. >=20 > Update SIXTY_FOUR_BIT and THIRTY_TWO_BIT defines in the > CryptoPkg to allow one of them to be predefined on the EDK II > build command line using /D flag or in DSC file [BuildOptions] > sections. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Cc: Andrew Fish > Cc: Abner Chang > Signed-off-by: Michael D Kinney > --- > CryptoPkg/Library/Include/CrtLibSupport.h | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h > b/CryptoPkg/Library/Include/CrtLibSupport.h > index 7a82f1d40633..a7d9a768695a 100644 > --- a/CryptoPkg/Library/Include/CrtLibSupport.h > +++ b/CryptoPkg/Library/Include/CrtLibSupport.h > @@ -44,6 +44,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > #define CONFIG_HEADER_BN_H >=20 > +#if !defined(SIXTY_FOUR_BIT) && !defined (THIRTY_TWO_BIT) > #if defined(MDE_CPU_X64) || defined(MDE_CPU_AARCH64) || > defined(MDE_CPU_IA64) || defined(MDE_CPU_RISCV64) > // > // With GCC we would normally use SIXTY_FOUR_BIT_LONG, but MSVC > needs > @@ -56,6 +57,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #else > #error Unknown target architecture > #endif > +#endif >=20 > // > // Map all va_xxxx elements to VA_xxx defined in MdePkg/Include/Base.h > -- > 2.31.1.windows.1