public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Abner Chang" <abner.chang@hpe.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"naitaku@gmail.com" <naitaku@gmail.com>
Cc: Gilbert Chen <gilbert.chen@hpe.com>,
	"Schaefer, Daniel" <daniel.schaefer@hpe.com>
Subject: Re: [edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add VariablePolicyHelperLib to the dsc files
Date: Wed, 14 Jul 2021 14:00:46 +0000	[thread overview]
Message-ID: <CS1PR8401MB11448F36171E3CFBB8FB1001FF139@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210713152455.61236-2-naitaku@gmail.com>

Reviewed-by: Abner Chang <abner.chang@hpe.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Takuto Naito
> Sent: Tuesday, July 13, 2021 11:25 PM
> To: devel@edk2.groups.io
> Cc: Takuto Naito <naitaku@gmail.com>; Chang, Abner (HPS SW/FW
> Technologist) <abner.chang@hpe.com>; Gilbert Chen
> <gilbert.chen@hpe.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>
> Subject: [edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add
> VariablePolicyHelperLib to the dsc files
> 
> REF:INVALID URI REMOVED.
> cgi?id=3489__;!!NpxR!28wVbfpiJVaHlDPAeFb0ytViSTrcY-
> e9p8QDrO0p4DRra6hFiM30xb3yR7kxe5Y$
> 
> Fix build error of U540 and U500 caused by BdsDxe.
> The edk2 patch
>  MdeModulePkg/BdsDxe: Update BdsEntry to use Variable Policy
> requires VariablePolicyHelperLib, but U500.dsc and U540.dsc
> didn't have it in the LibraryClasses section.
> 
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Signed-off-by: Takuto Naito <naitaku@gmail.com>
> ---
>  Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc       | 1 +
>  .../SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc  | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> index b91823ceeb..2031265806 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> @@ -99,6 +99,7 @@
>    SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> 
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBoo
> tManagerLib.inf
>    FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> +
> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Va
> riablePolicyHelperLib.inf
> 
>  # RISC-V Platform Library
>    TimeBaseLib|EmbeddedPkg//Library/TimeBaseLib/TimeBaseLib.inf
> diff --git
> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d
> sc
> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.
> dsc
> index 0eafe29880..0262b2a909 100644
> ---
> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d
> sc
> +++
> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.
> dsc
> @@ -99,6 +99,7 @@
>    SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> 
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBoo
> tManagerLib.inf
>    FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> +
> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Va
> riablePolicyHelperLib.inf
> 
>  # RISC-V Platform Library
>    TimeBaseLib|EmbeddedPkg//Library/TimeBaseLib/TimeBaseLib.inf
> --
> 2.32.0
> 
> 
> 
> 
> 


      parent reply	other threads:[~2021-07-14 14:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13 15:24 [edk2-platforms PATCH v1 0/1] Platform/SiFive: Fix build error of U540 and U500 caused by BdsDxe Takuto Naito
2021-07-13 15:24 ` [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add VariablePolicyHelperLib to the dsc files Takuto Naito
2021-07-14  4:59   ` 回复: [edk2-devel] " gaoliming
2021-07-14  5:11   ` Daniel Schaefer
2021-07-14 14:00   ` Abner Chang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CS1PR8401MB11448F36171E3CFBB8FB1001FF139@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox