[edk2-platforms PATCH v1 0/1] Platform/SiFive: Fix build error of U540 and U500 caused by BdsDxe

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [edk2-platforms PATCH v1 0/1] Platform/SiFive: Fix build error of U540 and U500 caused by BdsDxe
@ 2021-07-13 15:24 Takuto Naito
  2021-07-13 15:24 ` [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add VariablePolicyHelperLib to the dsc files Takuto Naito
  0 siblings, 1 reply; 5+ messages in thread
From: Takuto Naito @ 2021-07-13 15:24 UTC (permalink / raw)
  To: devel; +Cc: Takuto Naito, Abner Chang, Gilbert Chen, Daniel Schaefer

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3489

v1
  https://github.com/naitaku/edk2-platforms/tree/variablepolicyhelperlib_for_riscv_v1

Cc: Abner Chang <abner.chang@hpe.com>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>

Takuto Naito (1):
  Platform/SiFive: Add VariablePolicyHelperLib to the dsc files

 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc       | 1 +
 .../SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc  | 1 +
 2 files changed, 2 insertions(+)

-- 
2.32.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add VariablePolicyHelperLib to the dsc files
  2021-07-13 15:24 [edk2-platforms PATCH v1 0/1] Platform/SiFive: Fix build error of U540 and U500 caused by BdsDxe Takuto Naito
@ 2021-07-13 15:24 ` Takuto Naito
  2021-07-14  4:59   ` 回复: [edk2-devel] " gaoliming
                     ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Takuto Naito @ 2021-07-13 15:24 UTC (permalink / raw)
  To: devel; +Cc: Takuto Naito, Abner Chang, Gilbert Chen, Daniel Schaefer

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3489

Fix build error of U540 and U500 caused by BdsDxe.
The edk2 patch
 MdeModulePkg/BdsDxe: Update BdsEntry to use Variable Policy
requires VariablePolicyHelperLib, but U500.dsc and U540.dsc
didn't have it in the LibraryClasses section.

Cc: Abner Chang <abner.chang@hpe.com>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
Signed-off-by: Takuto Naito <naitaku@gmail.com>
---
 Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc       | 1 +
 .../SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
index b91823ceeb..2031265806 100644
--- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
+++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
@@ -99,6 +99,7 @@
   SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
   UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
   FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
+  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
 # RISC-V Platform Library
   TimeBaseLib|EmbeddedPkg//Library/TimeBaseLib/TimeBaseLib.inf
diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
index 0eafe29880..0262b2a909 100644
--- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
+++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
@@ -99,6 +99,7 @@
   SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
   UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
   FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
+  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
 
 # RISC-V Platform Library
   TimeBaseLib|EmbeddedPkg//Library/TimeBaseLib/TimeBaseLib.inf
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* 回复: [edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add VariablePolicyHelperLib to the dsc files
  2021-07-13 15:24 ` [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add VariablePolicyHelperLib to the dsc files Takuto Naito
@ 2021-07-14  4:59   ` gaoliming
  2021-07-14  5:11   ` Daniel Schaefer
  2021-07-14 14:00   ` [edk2-devel] " Abner Chang
  2 siblings, 0 replies; 5+ messages in thread
From: gaoliming @ 2021-07-14  4:59 UTC (permalink / raw)
  To: devel, naitaku
  Cc: 'Abner Chang', 'Gilbert Chen',
	'Daniel Schaefer'

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Takuto Naito
> 发送时间: 2021年7月13日 23:25
> 收件人: devel@edk2.groups.io
> 抄送: Takuto Naito <naitaku@gmail.com>; Abner Chang
> <abner.chang@hpe.com>; Gilbert Chen <gilbert.chen@hpe.com>; Daniel
> Schaefer <daniel.schaefer@hpe.com>
> 主题: [edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add
> VariablePolicyHelperLib to the dsc files
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3489
> 
> Fix build error of U540 and U500 caused by BdsDxe.
> The edk2 patch
>  MdeModulePkg/BdsDxe: Update BdsEntry to use Variable Policy
> requires VariablePolicyHelperLib, but U500.dsc and U540.dsc
> didn't have it in the LibraryClasses section.
> 
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Signed-off-by: Takuto Naito <naitaku@gmail.com>
> ---
>  Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc       |
> 1 +
>  .../SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc  | 1
> +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> index b91823ceeb..2031265806 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> @@ -99,6 +99,7 @@
>    SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> 
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBoot
> ManagerLib.inf
>    FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> +
> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Vari
> ablePolicyHelperLib.inf
> 
>  # RISC-V Platform Library
>    TimeBaseLib|EmbeddedPkg//Library/TimeBaseLib/TimeBaseLib.inf
> diff --git
> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d
> sc
> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d
> sc
> index 0eafe29880..0262b2a909 100644
> ---
> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d
> sc
> +++
> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d
> sc
> @@ -99,6 +99,7 @@
>    SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> 
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBoot
> ManagerLib.inf
>    FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> +
> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Vari
> ablePolicyHelperLib.inf
> 
>  # RISC-V Platform Library
>    TimeBaseLib|EmbeddedPkg//Library/TimeBaseLib/TimeBaseLib.inf
> --
> 2.32.0
> 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add VariablePolicyHelperLib to the dsc files
  2021-07-13 15:24 ` [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add VariablePolicyHelperLib to the dsc files Takuto Naito
  2021-07-14  4:59   ` 回复: [edk2-devel] " gaoliming
@ 2021-07-14  5:11   ` Daniel Schaefer
  2021-07-14 14:00   ` [edk2-devel] " Abner Chang
  2 siblings, 0 replies; 5+ messages in thread
From: Daniel Schaefer @ 2021-07-14  5:11 UTC (permalink / raw)
  To: Takuto Naito, devel; +Cc: Abner Chang

Thanks!

Reviewed-By: Daniel Schaefer <daniel.schaefer@hpe.com>

On 7/13/21 11:24 PM, Takuto Naito wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3489
> 
> Fix build error of U540 and U500 caused by BdsDxe.
> The edk2 patch
>   MdeModulePkg/BdsDxe: Update BdsEntry to use Variable Policy
> requires VariablePolicyHelperLib, but U500.dsc and U540.dsc
> didn't have it in the LibraryClasses section.
> 
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Signed-off-by: Takuto Naito <naitaku@gmail.com>
> ---
>   Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc       | 1 +
>   .../SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc  | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> index b91823ceeb..2031265806 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> @@ -99,6 +99,7 @@
>     SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
>     UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
>     FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> +  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>   
>   # RISC-V Platform Library
>     TimeBaseLib|EmbeddedPkg//Library/TimeBaseLib/TimeBaseLib.inf
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> index 0eafe29880..0262b2a909 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> @@ -99,6 +99,7 @@
>     SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
>     UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
>     FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> +  VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>   
>   # RISC-V Platform Library
>     TimeBaseLib|EmbeddedPkg//Library/TimeBaseLib/TimeBaseLib.inf
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add VariablePolicyHelperLib to the dsc files
  2021-07-13 15:24 ` [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add VariablePolicyHelperLib to the dsc files Takuto Naito
  2021-07-14  4:59   ` 回复: [edk2-devel] " gaoliming
  2021-07-14  5:11   ` Daniel Schaefer
@ 2021-07-14 14:00   ` Abner Chang
  2 siblings, 0 replies; 5+ messages in thread
From: Abner Chang @ 2021-07-14 14:00 UTC (permalink / raw)
  To: devel@edk2.groups.io, naitaku@gmail.com; +Cc: Gilbert Chen, Schaefer, Daniel

Reviewed-by: Abner Chang <abner.chang@hpe.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Takuto Naito
> Sent: Tuesday, July 13, 2021 11:25 PM
> To: devel@edk2.groups.io
> Cc: Takuto Naito <naitaku@gmail.com>; Chang, Abner (HPS SW/FW
> Technologist) <abner.chang@hpe.com>; Gilbert Chen
> <gilbert.chen@hpe.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>
> Subject: [edk2-devel] [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add
> VariablePolicyHelperLib to the dsc files
> 
> REF:INVALID URI REMOVED.
> cgi?id=3489__;!!NpxR!28wVbfpiJVaHlDPAeFb0ytViSTrcY-
> e9p8QDrO0p4DRra6hFiM30xb3yR7kxe5Y$
> 
> Fix build error of U540 and U500 caused by BdsDxe.
> The edk2 patch
>  MdeModulePkg/BdsDxe: Update BdsEntry to use Variable Policy
> requires VariablePolicyHelperLib, but U500.dsc and U540.dsc
> didn't have it in the LibraryClasses section.
> 
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Signed-off-by: Takuto Naito <naitaku@gmail.com>
> ---
>  Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc       | 1 +
>  .../SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc  | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> index b91823ceeb..2031265806 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> @@ -99,6 +99,7 @@
>    SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> 
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBoo
> tManagerLib.inf
>    FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> +
> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Va
> riablePolicyHelperLib.inf
> 
>  # RISC-V Platform Library
>    TimeBaseLib|EmbeddedPkg//Library/TimeBaseLib/TimeBaseLib.inf
> diff --git
> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d
> sc
> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.
> dsc
> index 0eafe29880..0262b2a909 100644
> ---
> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d
> sc
> +++
> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.
> dsc
> @@ -99,6 +99,7 @@
>    SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> 
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBoo
> tManagerLib.inf
>    FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> +
> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Va
> riablePolicyHelperLib.inf
> 
>  # RISC-V Platform Library
>    TimeBaseLib|EmbeddedPkg//Library/TimeBaseLib/TimeBaseLib.inf
> --
> 2.32.0
> 
> 
> 
> 
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-07-14 14:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-13 15:24 [edk2-platforms PATCH v1 0/1] Platform/SiFive: Fix build error of U540 and U500 caused by BdsDxe Takuto Naito
2021-07-13 15:24 ` [edk2-platforms PATCH v1 1/1] Platform/SiFive: Add VariablePolicyHelperLib to the dsc files Takuto Naito
2021-07-14  4:59   ` 回复: [edk2-devel] " gaoliming
2021-07-14  5:11   ` Daniel Schaefer
2021-07-14 14:00   ` [edk2-devel] " Abner Chang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox