From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web08.5312.1625199148384350046 for ; Thu, 01 Jul 2021 21:12:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=bc3cJUXe; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0817b25ea3=abner.chang@hpe.com) Received: from pps.filterd (m0134421.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16248is2019994; Fri, 2 Jul 2021 04:11:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=ZMWhrUqZ1RiZo4mMa5JwPUeUswmny5Sy80FpgAwYXl0=; b=bc3cJUXeA/WHIZ/2uGqEAeb21XepKveZxHN+/5gz87EVZBJoioXnPW6imH890uUki0u7 VqYLrXh/ULd4Nbujw7IvQeka1UJiQSRn1A8D8ehTOMxiydipcdnuA86TwiQOu44vn1Oh YeqAfQKAo7Rxmsq+3B8KVAEqzW0oKuYtg5xnoaX1rMP0XIhyRMUfvOaa/GvitKVgfSaK B0hCQhLV7UAjBlj4Ni4JwTSNwWX39VN+pqsHde7sht3jy7SFc+GDtRkLxjLMXyoWG5ov 4BRJsaFPv5L3Im7E4lGe4SOlz6NXAG/pmG5yKqk8uPmjbfiV+razYcKmuOftIYziBIoR pA== Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) by mx0b-002e3701.pphosted.com with ESMTP id 39hbk4r3k5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 02 Jul 2021 04:11:58 +0000 Received: from G2W6311.americas.hpqcorp.net (g2w6311.austin.hp.com [16.197.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5008.houston.hpe.com (Postfix) with ESMTPS id 7D9EA72; Fri, 2 Jul 2021 04:11:57 +0000 (UTC) Received: from G9W8675.americas.hpqcorp.net (16.220.49.22) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 2 Jul 2021 04:11:42 +0000 Received: from G4W10204.americas.hpqcorp.net (2002:10cf:5210::10cf:5210) by G9W8675.americas.hpqcorp.net (2002:10dc:3116::10dc:3116) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 2 Jul 2021 04:11:42 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (15.241.52.11) by G4W10204.americas.hpqcorp.net (16.207.82.16) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Fri, 2 Jul 2021 04:11:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YWkJ6U85LVXCqKTAjsoFkzTMSv/Uow8JngpoHk6x/y8dclCCtBgPqxUy071qJj+GKOvUtmCWVFSvCEpjbeIlMZHsADsso48WY/GSzK9AlHJ3kqG0MQtZMOotPuyjaxGi4liuiEphL93FgLCoyT/H2ZGBF/wkf6GuVXK7oqJp3g7kg5TH7CkeU2+EiLSc2ZWkiiFtOPSaa2/A10TXk34gGUBz1dWBvzgg2rayy6b0PonPMGLaan7H0DGGZKiTWCA1POnT/3kRtX0HbczztbsMKkfXh0EOrOlItnFmEjwrZ2ZS1MRALgG4MXiMd6K08c7U4MVmJ4ciwCDIH2PR9yXHLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wgucQJXfF3HED8kMf5oFNJOWWRQeBj6Q6TQ3JM2gCBs=; b=GvBtfPyAIJHsXw9PBuhskCZR21mYzAXD7Ft0NvBtXTNf4dnTx5q51Pq7Osjqj4JvgynP9NdCWoBwJA7abg3Bjua/Zy4+4+aWnPLtIB7kJPU/3vEOSyIh9Ans1UGf1B6gKV4RbH6r7wrIha1y1Uw1ytAMwYnc/KSGvqXA9hK6PUgPmB/pfYZkzxo6+DoYdk6MVUD+UQcniGxMJrF2WOMIeK0LjnVwiiW7lNVzJsKblAB3/wsHOAiIDBBAcovInEwVUN6VB1a7pujpvQx7dfCQAiTAIigECNgJeHgOwFz7S02mHy3TyZRD7MHncPhedaVTjoXPiB4KefdVzuhv7g/DDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB1240.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:750b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.27; Fri, 2 Jul 2021 04:11:39 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d447:2f82:1c6e:831f]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d447:2f82:1c6e:831f%4]) with mapi id 15.20.4287.027; Fri, 2 Jul 2021 04:11:39 +0000 From: "Abner Chang" To: Grzegorz Bernacki , "devel@edk2.groups.io" CC: "leif@nuviainc.com" , "ardb+tianocore@kernel.org" , "Samer.El-Haj-Mahmoud@arm.com" , "sunny.Wang@arm.com" , "mw@semihalf.com" , "upstream@semihalf.com" , "jiewen.yao@intel.com" , "jian.j.wang@intel.com" , "min.m.xu@intel.com" , "lersek@redhat.com" , "sami.mujawar@arm.com" , "afish@apple.com" , "ray.ni@intel.com" , "jordan.l.justen@intel.com" , "rebecca@bsdio.com" , "grehan@freebsd.org" , "thomas.abraham@arm.com" , "chasel.chiu@intel.com" , "nathaniel.l.desimone@intel.com" , "gaoliming@byosoft.com.cn" , "eric.dong@intel.com" , "michael.d.kinney@intel.com" , "zailiang.sun@intel.com" , "yi.qian@intel.com" , "graeme@nuviainc.com" , "rad@semihalf.com" , "pete@akeo.ie" , "Schaefer, Daniel" Subject: Re: [edk2-platforms PATCH v5 3/4] RISC-V Platforms: add SecureBootVariableLib class resolution Thread-Topic: [edk2-platforms PATCH v5 3/4] RISC-V Platforms: add SecureBootVariableLib class resolution Thread-Index: AQHXblp3PXbLGXh2D0+S5tNVc5D4HqsvE0cg Date: Fri, 2 Jul 2021 04:11:39 +0000 Message-ID: References: <20210701092051.1057606-1-gjb@semihalf.com> <20210701092051.1057606-4-gjb@semihalf.com> In-Reply-To: <20210701092051.1057606-4-gjb@semihalf.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: semihalf.com; dkim=none (message not signed) header.d=none;semihalf.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [165.225.117.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3fa1b5d8-ce10-4c81-0bf5-08d93d0f7dfe x-ms-traffictypediagnostic: CS1PR8401MB1240: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eaTzn1yg/jyOpsJejopOJdRguXrccKuWKrGhCrLMq2mFXUl8d7ASrFHFbO5HkOjwy2f+7e4frulO2pDUVFVF2efDdloqcHepaCIHGeE8GUbFyqX4gnQQMZNbUnbQ3knyZB+uvO1L9MCv4HJsvUywOxZl4BT1oiqtBD+oU0JQ5mBPJwGjO6p09pKzHr2cK6Vhijk1gPvZDYCfL8DkH3PFPKxjdoIdt0UkkiJsndxseqiSW8NFRuHBCnHYyaKWCqfog3L4kY81j8jqPcJDhhcrxaJ3kjmjaJ+eXr5gIlhaRkHU3hGE3TiMdkMnFufF0nYe3hgurxCESCpNQaIbdkF4tIl3X5ucPUlet0VSHaliFAgO9BnFkdFwanT06x2phko1H1um9uqo5jpGypHv8xBS2saIDiH1rS9JRiQwGJbuNONKx1DWDxKtFM/aDWkefXyhkUoWQs7vDJn1NG9nTtLqV8S9W8CznWfvpZPjYaYX+yORJn2KtXRHXFu/LVLD4LW3K5zYcQh/UZ1ZgLma5FJxwx5u4bz/0XUnoj2zdfhK4nf615MbtD8tqI4IrVRE4lEEkqlP9wZ7fG2mYkeSQPcknnFDpJSh12OIbGbLoMTYp3cVCHklF/+wFnlV+m82+xiYYyBnVWsqoHH4Xf7uw7dBgA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(366004)(376002)(39860400002)(346002)(136003)(396003)(478600001)(52536014)(5660300002)(4326008)(71200400001)(2906002)(66476007)(64756008)(66556008)(55016002)(9686003)(66446008)(54906003)(7416002)(76116006)(316002)(110136005)(66946007)(83380400001)(53546011)(6506007)(55236004)(7696005)(86362001)(38100700002)(33656002)(186003)(8676002)(26005)(122000001)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ws/OmEhTqcWQpKlC0JrYLUqFfNezOtj0qxc83auBmNCHTUS6BdDCqAzy5dzA?= =?us-ascii?Q?O6dU9D8U+0+EaF6KpDRaLlPaqu5+njWxrczKSf426VH2mRbvxhKpEwPkLLNu?= =?us-ascii?Q?EVZvXuqklf17A7XngUZkca54E7j/oPVJywqUmC2mxk4X71tc/Yb49BLFqpt9?= =?us-ascii?Q?yKmUaQLPcwK3ATGSVhL+R5DnJHY6TNUzE0/HnLNS6bDQ9/SXuQr8jycNygdU?= =?us-ascii?Q?HxvQPIx0zgzoIqL9FlRKUDhcvqFKOXL60U7iujOVgOZImd6uXecb/s7DfW0W?= =?us-ascii?Q?UFRzk77fDnxRMEOYwLDIxQzCmV3wmUioUeAFVBZCbPiVlsCJnmSqUvmjnw+D?= =?us-ascii?Q?J6YDbYK3M6vHmlbnS+hjhveOQ9Gh+gYREA+foIZm6gGRN16Hsi50RoxpalHw?= =?us-ascii?Q?AnBLEtLJYnm6cHq1t68H4SX9K3C4rvEWNSt/Qq4AZb7ChEUhQ4bO4KM+Mlnh?= =?us-ascii?Q?2/7lOauVnXQAvlPCkS6nS8Hbg6bc1xEIxnziHqAJtqpP/u3gRWN1V5QRwbwT?= =?us-ascii?Q?rVSv0Wr+b/YqeSoME/2KfaZq4bxo8aeK50WOplBsWgvWpth8N6El0lBo7T+Q?= =?us-ascii?Q?N9Iqeppg+0rX/gERqDmgQMa9QWfqtfbMTAFiW/PlE4SS/T5ByK1tv2owX/ks?= =?us-ascii?Q?j2pWrAhTLPyHZoknE5+c32d01buVa9GKXegEAhXmDJeNU+IOlnl1Fmb1rbY7?= =?us-ascii?Q?fB+fQrCPq6Fm7SBeCJUI3Il4VZaK4DUnjaAjZHTphlbczIf5PITIiAV+ti6J?= =?us-ascii?Q?L20Tr4FZC1R4xQpAMV+5BosbzOk9RNdEIza95gnDSbIF3cXterXoxQi0FaTd?= =?us-ascii?Q?jCRouxXbAAVMPyogEQhJd6gjun8M+atIEMfKC8ClbKfbE2NssW+P6ieuFG5n?= =?us-ascii?Q?1FKCPmc6NyqxRPd25IEbsnoHinOk1MhNQF1n5mVFri+nzqg/ykWJJORy01Mj?= =?us-ascii?Q?Lw2gjZhE4KULVRDC4QDMNlsBWyRmAi/TgsbNTC1koF3NLr+OFStI+/ZfHtcN?= =?us-ascii?Q?jit35F++sbK4Je+H4ElIDEbCqqiDlYEjdd7dNtntGfbFky/4UqyojW1DFdHU?= =?us-ascii?Q?NfOntiRmP/Vorh7sx3hM0ffMshQyWyComlVk1tCPVP77tw9qXIPFAnOrsk7N?= =?us-ascii?Q?QmwO+Uhe/3E7gn7lqC5oJBB/kW904WLbbR625l7OBkPX9GyfQbSyeFGl0+kD?= =?us-ascii?Q?vsSM4HoP988i2cIdDlCnx/ZHCTZkYCSu0HPWZEC/nSDoS6YvsVQMWEuNNail?= =?us-ascii?Q?df8Mh7TCvR/XkFtMTgEeAKzlF11pAT0xvtjiKYfwQqqChmMFcgdHUAQcS1bI?= =?us-ascii?Q?YYD2z7hzRKFA3XwifePCdrV1?= X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 3fa1b5d8-ce10-4c81-0bf5-08d93d0f7dfe X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2021 04:11:39.5181 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hHSizIUcG+a8l/fgCV/GEL6vk1xGpohycWuUoS/dGD0XSHXc+mcNUf0EPOBmClI8NnWztXp6jZdWnr2OPnrlvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB1240 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: wCiQzXGYVh2xyZlrQIcoiSLvZYFlJsvV X-Proofpoint-ORIG-GUID: wCiQzXGYVh2xyZlrQIcoiSLvZYFlJsvV X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-07-01_15:2021-07-01,2021-07-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 mlxlogscore=999 priorityscore=1501 bulkscore=0 mlxscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107020019 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Grzegorz, Was the entire series of patches got reviewed-by? Regards, Abner > -----Original Message----- > From: Grzegorz Bernacki [mailto:gjb@semihalf.com] > Sent: Thursday, July 1, 2021 5:21 PM > To: devel@edk2.groups.io > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer.El-Haj- > Mahmoud@arm.com; sunny.Wang@arm.com; mw@semihalf.com; > upstream@semihalf.com; jiewen.yao@intel.com; jian.j.wang@intel.com; > min.m.xu@intel.com; lersek@redhat.com; sami.mujawar@arm.com; > afish@apple.com; ray.ni@intel.com; jordan.l.justen@intel.com; > rebecca@bsdio.com; grehan@freebsd.org; thomas.abraham@arm.com; > chasel.chiu@intel.com; nathaniel.l.desimone@intel.com; > gaoliming@byosoft.com.cn; eric.dong@intel.com; > michael.d.kinney@intel.com; zailiang.sun@intel.com; yi.qian@intel.com; > graeme@nuviainc.com; rad@semihalf.com; pete@akeo.ie; Grzegorz > Bernacki ; Chang, Abner (HPS SW/FW Technologist) > ; Schaefer, Daniel > Subject: [edk2-platforms PATCH v5 3/4] RISC-V Platforms: add > SecureBootVariableLib class resolution >=20 > The edk2 patch > SecurityPkg: Create library for setting Secure Boot variables. >=20 > removes generic functions from SecureBootConfigDxe and places > them into SecureBootVariableLib. This patch adds SecureBootVariableLib > mapping for each RICS-V platform which uses SecureBootConfigDxe. >=20 > Signed-off-by: Grzegorz Bernacki > Reviewed-by: Abner Chang > Reviewed-by: Daniel Schaefer > --- > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 1= + >=20 > Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > | 1 + > 2 files changed, 2 insertions(+) >=20 > diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > index b91823ceeb..fc5ba2a07f 100644 > --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > @@ -122,6 +122,7 @@ > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf >=20 > TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTp > mMeasurementLib.inf > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf > + > SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureB > ootVariableLib.inf > !else >=20 > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tp > mMeasurementLibNull.inf >=20 > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableL > ibNull.inf > diff --git > a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d > sc > b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540. > dsc > index 0eafe29880..71add8ff9a 100644 > --- > a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.d > sc > +++ > b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540. > dsc > @@ -122,6 +122,7 @@ > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf >=20 > TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTp > mMeasurementLib.inf > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf > + > SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureB > ootVariableLib.inf > !else >=20 > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/Tp > mMeasurementLibNull.inf >=20 > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableL > ibNull.inf > -- > 2.25.1