public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Abner Chang" <abner.chang@hpe.com>
To: Dandan Bi <dandan.bi@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Schaefer, Daniel" <daniel.schaefer@hpe.com>,
	"Chen, Gilbert" <gilbert.chen@hpe.com>
Subject: Re: [edk2-platforms] [patch V2 20/35] Platform/RISC-V: Consume MdeLibs.dsc.inc for RegisterFilterLib
Date: Tue, 23 Mar 2021 02:18:12 +0000	[thread overview]
Message-ID: <CS1PR8401MB1144A80EE665FE2FB993FF7DFF649@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210322082040.14104-21-dandan.bi@intel.com>

We can remove the indent (as Laszlo mentioned) to make all changes in consistent.
All other changes on RISC-V are the same. Thanks

Reviewed-by: Abner Chang <abner.chang@hpe.com>

> -----Original Message-----
> From: Dandan Bi [mailto:dandan.bi@intel.com]
> Sent: Monday, March 22, 2021 4:20 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> Schaefer, Daniel <daniel.schaefer@hpe.com>; Chen, Gilbert
> <gilbert.chen@hpe.com>
> Subject: [edk2-platforms] [patch V2 20/35] Platform/RISC-V: Consume
> MdeLibs.dsc.inc for RegisterFilterLib
> 
> REF: INVALID URI REMOVED
> 3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid-
> 3D3246&d=DwIBAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulks
> kz6qU3NYRO03nHp9P7Z5q59A3E&m=Us0bEx6-
> rMuxeAV21PFz3igajFEdNSWCnZ3L5n-wUv8&s=O-PHg5t3PRykzhU-
> mwLPjR5EyFarY4iRfUiz8oBOxjo&e=
> 
> MdeLibs.dsc.inc was added for some basic/default library
> instances provided by MdePkg and RegisterFilterLibNull Library
> was also added into it as the first version of MdeLibs.dsc.inc.
> 
> So update platform dsc to consume MdeLibs.dsc.inc for
> RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
> 
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc
> b/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc
> index 092717d2ef..78a737317f 100644
> --- a/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc
> +++ b/Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc
> @@ -35,10 +35,12 @@ [BuildOptions]
> 
> ##########################################################
> ######################
>  [SkuIds]
>    0|DEFAULT
> 
>  [LibraryClasses.common]
> +  !include MdePkg/MdeLibs.dsc.inc
> +
>    RiscVOpensbiPlatformLib|Platform/RISC-
> V/PlatformPkg/Library/OpensbiPlatformLibNull/OpensbiPlatformLibNull.inf
>    RiscVCpuLib|Silicon/RISC-
> V/ProcessorPkg/Library/RiscVCpuLib/RiscVCpuLib.inf
>    RiscVEdk2SbiLib|Silicon/RISC-
> V/ProcessorPkg/Library/RiscVEdk2SbiLib/RiscVEdk2SbiLib.inf
>    RiscVOpensbiLib|Silicon/RISC-
> V/ProcessorPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf
>    BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> --
> 2.18.0.windows.1


  parent reply	other threads:[~2021-03-23  2:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22  8:20 [edk2-platforms] [patch V2 00/35] Consume MdeLibs.dsc.inc for RegisterFilterLib Dandan Bi
2021-03-22  8:20 ` [edk2-platforms] [patch V2 01/35] Drivers/ASIX: " Dandan Bi
2021-03-22  8:20 ` [edk2-platforms] [patch V2 02/35] Drivers/DisplayLink: " Dandan Bi
2021-03-22  8:20 ` [edk2-platforms] [patch V2 03/35] Drivers/OptionRomPkg: " Dandan Bi
2021-03-25 23:31   ` Ni, Ray
2021-03-22  8:20 ` [edk2-platforms] [patch V2 04/35] Features/Debugging: " Dandan Bi
2021-03-22  8:20 ` [edk2-platforms] [patch V2 05/35] Features/Network: " Dandan Bi
2021-03-22  8:20 ` [edk2-platforms] [patch V2 06/35] Features/OutOfBandManagement: " Dandan Bi
2021-03-22  8:20 ` [edk2-platforms] [patch V2 07/35] Features/PowerManagement: " Dandan Bi
2021-03-22  8:20 ` [edk2-platforms] [patch V2 08/35] Features/SystemInformation: " Dandan Bi
2021-03-22  8:20 ` [edk2-platforms] [patch V2 09/35] Features/UserInterface: " Dandan Bi
     [not found] ` <20210322082040.14104-21-dandan.bi@intel.com>
2021-03-23  2:18   ` Abner Chang [this message]
     [not found] ` <20210322082040.14104-22-dandan.bi@intel.com>
2021-03-23  2:18   ` [edk2-platforms] [patch V2 21/35] Platform/SiFive: " Abner Chang
     [not found] ` <20210322082040.14104-34-dandan.bi@intel.com>
2021-03-23  2:18   ` [edk2-platforms] [patch V2 33/35] Silicon/RISC_V: " Abner Chang
     [not found] ` <20210322082040.14104-27-dandan.bi@intel.com>
2021-03-25 23:31   ` [edk2-platforms] [patch V2 26/35] Silicon/IntelSiliconPkg: " Ni, Ray
  -- strict thread matches above, loose matches on Subject: below --
2021-03-22  8:53 [edk2-platforms] [patch V2 10/35] Platform/AMD: " Dandan Bi
2021-03-22  8:53 ` [edk2-platforms] [patch V2 20/35] Platform/RISC-V: " Dandan Bi
2021-03-23  2:19   ` Abner Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CS1PR8401MB1144A80EE665FE2FB993FF7DFF649@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox