From: "Abner Chang" <abner.chang@hpe.com>
To: gaoliming <gaoliming@byosoft.com.cn>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
'Laszlo Ersek' <lersek@redhat.com>
Cc: "Wang, Nickle (HPS SW)" <nickle.wang@hpe.com>,
'Andrew Fish' <afish@apple.com>,
'Leif Lindholm' <leif@nuviainc.com>,
'Michael D Kinney' <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg
Date: Wed, 30 Sep 2020 02:48:29 +0000 [thread overview]
Message-ID: <CS1PR8401MB1144BA2C51955BE34AE3BE57FF330@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <004701d696c4$d5c0b120$81421360$@byosoft.com.cn>
[-- Attachment #1: Type: text/plain, Size: 3239 bytes --]
Got it! v2 patches sent to mail list.
From: gaoliming [mailto:gaoliming@byosoft.com.cn]
Sent: Wednesday, September 30, 2020 8:59 AM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; 'Laszlo Ersek' <lersek@redhat.com>
Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; 'Andrew Fish' <afish@apple.com>; 'Leif Lindholm' <leif@nuviainc.com>; 'Michael D Kinney' <michael.d.kinney@intel.com>
Subject: 回复: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg
Yes. Maintainer has the both role of reviewer and patch merge.
Thanks
Liming
发件人: bounce+27952+65723+4905953+8761045@groups.io<mailto:bounce+27952+65723+4905953+8761045@groups.io> <bounce+27952+65723+4905953+8761045@groups.io<mailto:bounce+27952+65723+4905953+8761045@groups.io>> 代表 Abner Chang
发送时间: 2020年9月29日 19:23
收件人: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
抄送: Wang, Nickle (HPS SW) <nickle.wang@hpe.com<mailto:nickle.wang@hpe.com>>; Andrew Fish <afish@apple.com<mailto:afish@apple.com>>; Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>; Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
主题: Re: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg
Without R, I still can give reviewed-by to others contribute to RedfishPkg right?
Get Outlook for Android<https://aka.ms/ghei36>
________________________________
From: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>
Sent: Tuesday, September 29, 2020, 6:42 PM
To: Chang, Abner (HPS SW/FW Technologist); devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Wang, Nickle (HPS SW); Andrew Fish; Leif Lindholm; Michael D Kinney
Subject: Re: [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg
On 09/29/20 11:47, changab wrote:
> Signed-off-by: Chang Abner <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>
> Cc: Nickle Wang <nickle.wang@hpe.com<mailto:nickle.wang@hpe.com>>
> Cc: Andrew Fish <afish@apple.com<mailto:afish@apple.com>>
> Cc: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>
> Cc: Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>
> Cc: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
> ---
> Maintainers.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 6a22a14796..cc9d173285 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -503,6 +503,12 @@ F: PcAtChipsetPkg/
> W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
> M: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>>
>
> +RedfishPkg: Redfish related modules
> +F: RedfishPkg/
> +M: Abner Chang <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>
> +R: Abner Chang <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>
I don't think it makes much sense to add Abner as both M and R. I
suggest dropping the R line for Abner.
Thanks
Laszlo
> +R: Nickle Wang <nickle.wang@hpe.com<mailto:nickle.wang@hpe.com>>
> +
> SecurityPkg
> F: SecurityPkg/
> W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
>
[-- Attachment #2: Type: text/html, Size: 9543 bytes --]
prev parent reply other threads:[~2020-09-30 2:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 9:47 [RedfishPkg PATCH 0/4] Inital RedfishPkg Abner Chang
2020-09-29 9:47 ` [RedfishPkg PATCH 1/4] RedfishPkg: Initial commit of RedfishPkg Abner Chang
2020-09-29 9:47 ` [RedfishPkg PATCH 2/4] .pytool: Add CI on RedfishPkg Abner Chang
2020-09-29 9:47 ` [RedfishPkg PATCH 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
2020-10-15 1:57 ` [edk2-devel] " Sean
2020-10-15 2:29 ` Abner Chang
2020-09-29 9:47 ` [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg Abner Chang
2020-09-29 10:42 ` Laszlo Ersek
2020-09-29 11:23 ` Abner Chang
2020-09-30 0:58 ` 回复: [edk2-devel] " gaoliming
2020-09-30 2:48 ` Abner Chang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CS1PR8401MB1144BA2C51955BE34AE3BE57FF330@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox