From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web12.10437.1602238186198299724 for ; Fri, 09 Oct 2020 03:09:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=F4l6s4dq; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=05510f201e=abner.chang@hpe.com) Received: from pps.filterd (m0134424.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0999q7Dh031157 for ; Fri, 9 Oct 2020 10:09:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pps0720; bh=912y787ubhs1FGeNVpBvRhRqcKD+SXzfDmOMFGX3F2U=; b=F4l6s4dqzGpTaCd0jcLUHf/TwqT/vrtgr1h4JOEWR5PZ4TNJvCGcchDOay/QCJcvy3t5 jFTd2VBl6v7B+fvQg5bYXTXKeO9NxUryf7G8ik2Y3I8dl6KpHtJg7XP8BAloGlf5Fndd iYLJ6WtkWPzD09+afCR2lwKPujUwTOwQ5ct2509m/MG8vFd00C4MKEUETmaXTb5luMta vXHpwSUyoczsgeht/P8nM6Sr9V+18kc8/jwyQzB1w+raa5feLwOgw4HsJ4Lh5vGYknrP n3gYFXH7WgRRnpgs8k2GLLiffD3TxL3QCLIw2uTRXE6CXe1riwuwUaugw+vsUTIjivrc QQ== Received: from g4t3426.houston.hpe.com (g4t3426.houston.hpe.com [15.241.140.75]) by mx0b-002e3701.pphosted.com with ESMTP id 3429m0n414-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 09 Oct 2020 10:09:45 +0000 Received: from G9W8453.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.216.160.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3426.houston.hpe.com (Postfix) with ESMTPS id 7AEEB5F for ; Fri, 9 Oct 2020 10:09:44 +0000 (UTC) Received: from G9W8453.americas.hpqcorp.net (2002:10d8:a0d3::10d8:a0d3) by G9W8453.americas.hpqcorp.net (2002:10d8:a0d3::10d8:a0d3) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 9 Oct 2020 10:09:20 +0000 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (15.241.52.12) by G9W8453.americas.hpqcorp.net (16.216.160.211) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 9 Oct 2020 10:09:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nLo1UM3B1fprhA0FgfsXJvrLPvIHSE9ynLri9K8Fnac+Z/qIUPwdrt7MrN8mT5BVf3rhFPvLaGDpTz8D1N+MX1pLLpYtK9K4P72nOyrLlVhQS+DuKzfFJe+epJZlKLSXKHJs6BbPE952oNtBEkAE3yFvxpvdt67CCxz5qZzIPJ7loCLoF40t0KoggKA3LC5F4e0Qeqt/Ni4uePa6FSGMyLiPnbx30F6CrgKW9YlXryU3b0gCn1admNeAHD7uho43K51IS0LYakYtqG+YIvaO1wwwIBqP/Y+ejDagYP7JDgAggsK/rZpJMoBXUyJP0mvWg0VRR2IF+ng5wxBSXOtLVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+IZCSgmRpF3XYnnKKozOx8+nIbXEfCOR45lOw2bUCbU=; b=B31IgdPej4JGOp5FjVLgynWXdMKV4l4VyvqMDZe92D8z9C9VjDZ2Brm9DrQcgCiJxG0pD59oiL1VlafO4l/l2YK0g+XYq5Aoro1K1iT5pawWP3N1xd+akC4Bm37BoOLFfp6mLcAtq9Ab8dehH6aW7+C0RWVG8TReDjQN2BWLSITHOODjgEhwbdqRihnttoZs8W6Mn7TFwseiOW+kku2wEgaG2+fnoPYcFiU0Y9BvBYY1oMzWyjqEWoh9/XPmqj5Q8NDiwB6e4jrKPFmIzPO4gwRYP+rlZWIol7YUX29r+j7vC7tx8RpA17SzAe7Z30VexTnj2P+tbSTaScbe6jTMGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB0518.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7512::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.39; Fri, 9 Oct 2020 10:09:17 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d111:132b:4b87:a9ea]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d111:132b:4b87:a9ea%3]) with mapi id 15.20.3433.046; Fri, 9 Oct 2020 10:09:17 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" CC: Wu Jiaxin , Fu Siyuan , "Wang, Nickle (HPS SW)" Subject: Re: [edk2-devel] [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset Thread-Topic: [edk2-devel] [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset Thread-Index: AQHWlWDCEOTobN8KH06dRIJHxasfxal/oz+AgA4lnvCAAUxwUYAAB3D+ Date: Fri, 9 Oct 2020 10:09:17 +0000 Message-ID: References: <20200928062934.505108-1-abner.chang@hpe.com> <163C10A7913BC273.18560@groups.io>,<13bdfac3-0d22-30ec-d5f0-bd397563291a@linux.intel.com> In-Reply-To: <13bdfac3-0d22-30ec-d5f0-bd397563291a@linux.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [1.34.113.40] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3fbfb817-05e6-472a-ba10-08d86c3b6227 x-ms-traffictypediagnostic: CS1PR8401MB0518: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:114; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KWLAz9gqaSoTM6kA6t5nhuR7v2URCr70sQxvCgvDZ8d73fUI5gqFrNmDUolm1IYv5jvBbBG7WAMYNAWdI9p0CU2vH8ISHJ86MsY4MNFERVWLCta4SMfOL5jZG+qOA90bg4Flb2Y7IaTu5s1Q7IFO1wHdE/HGw1QkowYJCcybhfexmsFyKSquGsZ3hOUgHBZ4kkly+Za7EAUtX+pr5RLsjgNMW1QVChhDtx/6tbOCszhQdI1I3ZT/wmVDuZx5t90lGkH6VPMzzKwekrLUNHD1EA6IM5Z/EhDYtLuEM465/J8CG3xvfSJK294IZBbBDId7RZzQ0GqrLz/JE3t0/4/i9/h1pfawHublyvuNvrSVPyy9DmdFOKcx3nTZS4EOYySSyyiaRqdu1CfxvguoSAoS3w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(39860400002)(396003)(346002)(136003)(366004)(376002)(66556008)(55016002)(86362001)(71200400001)(4326008)(8676002)(7696005)(6916009)(2906002)(83380400001)(186003)(9686003)(53546011)(6506007)(8936002)(54906003)(478600001)(33656002)(66446008)(64756008)(45080400002)(52536014)(83080400001)(5660300002)(316002)(26005)(66476007)(66946007)(76116006)(91956017)(166002)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 65FoWt0WrekXw6i4hP//2ADLWM38T1NX71UAkeNsAHF9SPPp0ptr2DZT1WKeI2WOVmaloX9t4mHgvZ7zFNOpWMCvR6R8K5GthytI1BsC0FUPm99cW0qAEqooWeVGi90+9Q/BVTILs71CFueh+gO3CL1r90b4O+bbN4rYpzOMqbl9GQCOnyW2a6JBsJ7czHFIMW2axm9nh9OwkHtaqKZYEGAkAvEHognODIcM1OXfQEuz9cp0vM3NimHdO6D7PHdj98KGMUnUVMnviptpBVkTU0tjOcp6sbINHnb5McQ4oMBDlGWoNOYY+sn73JQ+PzCp44O56dwtCUGb3JFQ2xm3yuqvmo966zCcgOQ3pHlU6f3/pqT7BpsvQKvn8B/5JXgR4lNKmNbt5Me5mCdtrCcVy8JqgWOkBmTR7v5gSU0AqtErrJ3rdVCf8iFHyTqzjQAjSI77aZl4m0Brjm6a1QpXm3dp9GnujUGzwWDDVqbkNCB2/YpPhVZINfdszDWwk4JbBPI85bj0j+magI/5kvNy0cFqrJ2+GTYrwxYTF1xSGwmqkZkHzCFprVwMUp5urVKvuPOuv/yFTdJ18spU4V7k70wkxsgH/PYZFqtWMPCFASp4/50mgrYZyRG9flUjkfbpYLQFqL0yvIMi7Ac/qHJHgA== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 3fbfb817-05e6-472a-ba10-08d86c3b6227 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2020 10:09:17.7346 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RjiR+n+p/fYniP9b9SlGtIMloN4FlQEm5Yds157sxLY6f1BpfPzw4z2wirxRRJtC7iGcgEGkQujU7Dnd+Olz7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0518 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 16 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-10-09_05:2020-10-09,2020-10-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 phishscore=0 clxscore=1015 spamscore=0 priorityscore=1501 mlxlogscore=999 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010090069 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CS1PR8401MB1144BA56720E0BE7C7EEC3D2FF080CS1PR8401MB1144_" --_000_CS1PR8401MB1144BA56720E0BE7C7EEC3D2FF080CS1PR8401MB1144_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Maciej. Abner Get Outlook for Android ________________________________ From: Rabeda, Maciej Sent: Friday, October 9, 2020, 5:39 PM To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) Cc: Wu Jiaxin; Fu Siyuan; Wang, Nickle (HPS SW) Subject: Re: [edk2-devel] [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is no= t cleared when reset Merged: https://github.com/tianocore/edk2/commit/5df413119ec80cb462bf9c888ef5574f8= ce8ae2e https://github.com/tianocore/edk2/pull/995 On 08-Oct-20 18:17, Maciej Rabeda wrote: > Hi Abner, > > Waiting for review on a different patch on NetworkPkg, else CI likely > fires in my face when I try to integrate yours. > > https://edk2.groups.io/g/devel/message/65833 > > Thanks, > Maciej > > On 08-Oct-20 15:50, Abner Chang wrote: >> Hi Maciej, >> Could you please help to merge this patch? Thanks! >> Abner >> >>> -----Original Message----- >>> From: Rabeda, Maciej [mailto:maciej.rabeda@linux.intel.com] >>> Sent: Tuesday, September 29, 2020 9:47 PM >>> To: Chang, Abner (HPS SW/FW Technologist) ; >>> devel@edk2.groups.io >>> Cc: Wu Jiaxin ; Fu Siyuan ; >>> Wang, Nickle (HPS SW) >>> Subject: Re: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared >>> when reset >>> >>> Reviewed-by: Maciej Rabeda >>> >>> On 28-Sep-20 08:29, Abner Chang wrote: >>>> BZ #2909, >>>> INVALID URI REMOVED >>>> e.org_show-5Fbug.cgi-3Fid- >>> 3D2909&d=3DDwICaQ&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_ >>> SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DgVilLut38Vw51w0YX >>> bkL2XI7A >>>> ieZI7M- >>> u7_bYls4zQo&s=3DeavHqEkeSVmQnn5EYDmq9TnEyjp8MS3_hdpPDgG9hSY&e=3D >>>> When Http->Configure() is invoked with HttpConfigData set to NULL to >>>> reset the EFI HTTP instance, TLS child instance is destroyed but >>>> HttpInstance->TlsChildHandle is not set to NULL. After reconfiguring >>>> HTTP through Http->Configure() and sending the HTTP request to HTTPS >>>> URL, TLS child instance is not recreated because >>>> HttpInstance->TlsChildHandle is not NULL. >>>> >>>> Signed-off-by: Abner Chang >>>> >>>> Cc: Maciej Rabeda >>>> Cc: Wu Jiaxin >>>> Cc: Fu Siyuan >>>> Cc: Nickle Wang >>>> --- >>>> NetworkPkg/HttpDxe/HttpProto.c | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/NetworkPkg/HttpDxe/HttpProto.c >>>> b/NetworkPkg/HttpDxe/HttpProto.c index 3c7c6ff9f0c..afc7db5a726 >>> 100644 >>>> --- a/NetworkPkg/HttpDxe/HttpProto.c >>>> +++ b/NetworkPkg/HttpDxe/HttpProto.c >>>> @@ -873,6 +873,7 @@ HttpCleanProtocol ( >>>> // Destroy the TLS instance. >>>> // >>>> HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, >>>> HttpInstance->TlsChildHandle); >>>> + HttpInstance->TlsChildHandle =3D NULL; >>>> } >>>> >>>> if (HttpInstance->Tcp4ChildHandle !=3D NULL) { >> >> >> >> >> > > > >=20 > > --_000_CS1PR8401MB1144BA56720E0BE7C7EEC3D2FF080CS1PR8401MB1144_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Thanks Maciej.
Abner

From: Rabeda, Maciej <maciej= .rabeda@linux.intel.com>
Sent: Friday, October 9, 2020, 5:39 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technol= ogist)
Cc: Wu Jiaxin; Fu Siyuan; Wang, Nickle (HPS SW)
Subject: Re: [edk2-devel] [PATCH] NetworkPkg/HttpDxe: Tls= ChildHandle is not cleared when reset

Merged:
https://github.com/tianocore/edk2/commit/5df413119ec80c= b462bf9c888ef5574f8ce8ae2e
https://github.com/= tianocore/edk2/pull/995

On 08-Oct-20 18:17, Maciej Rabeda wrote:
> Hi Abner,
>
> Waiting for review on a different patch on NetworkPkg, else CI likely=
> fires in my face when I try to integrate yours.
>
> https://edk2= .groups.io/g/devel/message/65833
>
> Thanks,
> Maciej
>
> On 08-Oct-20 15:50, Abner Chang wrote:
>> Hi Maciej,
>> Could you please help to merge this patch? Thanks!
>> Abner
>>
>>> -----Original Message-----
>>> From: Rabeda, Maciej [mailto:maciej.rabeda@linux.intel.com]
>>> Sent: Tuesday, September 29, 2020 9:47 PM
>>> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe= .com>;
>>> devel@edk2.groups.io
>>> Cc: Wu Jiaxin <jiaxin.wu@intel.com>; Fu Siyuan <siyu= an.fu@intel.com>;
>>> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
>>> Subject: Re: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is no= t cleared
>>> when reset
>>>
>>> Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com&= gt;
>>>
>>> On 28-Sep-20 08:29, Abner Chang wrote:
>>>> BZ #2909,
>>>> INVALID URI REMOVED
>>>> e.org_show-5Fbug.cgi-3Fid-
>>> 3D2909&d=3DDwICaQ&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D= _
>>> SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DgVilLut38V= w51w0YX
>>> bkL2XI7A
>>>> ieZI7M-
>>> u7_bYls4zQo&s=3DeavHqEkeSVmQnn5EYDmq9TnEyjp8MS3_hdpPDgG9h= SY&e=3D
>>>> When Http->Configure() is invoked with HttpConfigData = set to NULL to
>>>> reset the EFI HTTP instance, TLS child instance is destro= yed but
>>>> HttpInstance->TlsChildHandle is not set to NULL. After= reconfiguring
>>>> HTTP through Http->Configure() and sending the HTTP re= quest to HTTPS
>>>> URL, TLS child instance is not recreated because
>>>> HttpInstance->TlsChildHandle is not NULL.
>>>>
>>>> Signed-off-by: Abner Chang <abner.chang@hpe.com> >>>>
>>>> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com> >>>> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
>>>> Cc: Fu Siyuan <siyuan.fu@intel.com>
>>>> Cc: Nickle Wang <nickle.wang@hpe.com>
>>>> ---
>>>>    NetworkPkg/HttpDxe/HttpProto.c | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/NetworkPkg/HttpDxe/HttpProto.c
>>>> b/NetworkPkg/HttpDxe/HttpProto.c index 3c7c6ff9f0c..afc7d= b5a726
>>> 100644
>>>> --- a/NetworkPkg/HttpDxe/HttpProto.c
>>>> +++ b/NetworkPkg/HttpDxe/HttpProto.c
>>>> @@ -873,6 +873,7 @@ HttpCleanProtocol (
>>>>        // Destroy the TLS i= nstance.
>>>>        //
>>>>        HttpInstance->Tls= Sb->DestroyChild (HttpInstance->TlsSb,
>>>> HttpInstance->TlsChildHandle);
>>>> +    HttpInstance->TlsChildHandle =3D N= ULL;
>>>>      }
>>>>
>>>>      if (HttpInstance->Tcp4ChildHa= ndle !=3D NULL) {
>>
>>
>>
>>
>>
>
>
>
>
>
>


--_000_CS1PR8401MB1144BA56720E0BE7C7EEC3D2FF080CS1PR8401MB1144_--