From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web08.11663.1604055122843730347 for ; Fri, 30 Oct 2020 03:52:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=WRQiGVGd; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0572814f16=abner.chang@hpe.com) Received: from pps.filterd (m0134422.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 09UAlvnf011016 for ; Fri, 30 Oct 2020 10:52:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=b3WOjd0wAnX0DhFuHeoPXR4oUSeD5jhWxUEDAVhrHv0=; b=WRQiGVGdcrTN7I6UgRigcB8ykQumj4UOX2IcW5wAwLaRQ2D8tLzxpMFqlUFruaxza3Qp QDCzuFceEBYwvnpLQ50ZHanBtMkrnkWMKQ76D+bc0i3yFYE0VF566XdF0EZv94iv8mjk 8UO6G7H9R/f7r5di4Ne+TDaQJVBPFtAVRSeKG/LSiavza5h3/f0Mr3Sqkbqjlinmb1F1 YtGcBCwJFbp1f/Puqgix584s6RbAzbqRcdl4MXcQpmoacns+of4/JhG7eog+HickLWS2 1NctOBaAg4q8r4RzC1S9QAISt0DRlDI4w1iJJGe7dTXQaCEkRbnwQHQIqjoR+jmfU31B 1Q== Received: from g2t2353.austin.hpe.com (g2t2353.austin.hpe.com [15.233.44.26]) by mx0b-002e3701.pphosted.com with ESMTP id 34fan21m2t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 30 Oct 2020 10:52:02 +0000 Received: from G4W10205.americas.hpqcorp.net (g4w10205.houston.hpecorp.net [16.207.82.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2353.austin.hpe.com (Postfix) with ESMTPS id AD8FF77 for ; Fri, 30 Oct 2020 10:52:01 +0000 (UTC) Received: from G9W9210.americas.hpqcorp.net (2002:10dc:429b::10dc:429b) by G4W10205.americas.hpqcorp.net (2002:10cf:520f::10cf:520f) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 30 Oct 2020 10:52:01 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (15.241.52.13) by G9W9210.americas.hpqcorp.net (16.220.66.155) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 30 Oct 2020 10:52:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hauhUZi2CNI2lhNuOzx40eZeQs8Vmm3U9J1+k+AsGLFuuIJQWJiy/350xXEG9h4prb3bqAAfCIsP0jhiMghWcNqLYY3cg/dvGVB4d4S8GaySvflbqxOmQCV6p5omASof2pHUC4R+BQKFsSVxALVr0I+1IRR7jgWvkpNDOKU33zwXeW1caEfIcNVHsUclyPYavQVWv+qHOACmeIzX7YBX+AQNXZvaePPP3qLjoJGtojfyedT7po9YWKh6Du0oZMGgdzMvZnI20qpZVeSqOPX+wplgDT+WXa/KNuiTpB2UAf4jyerPZfi8k7qWZlMV1oMqO8Hfn9pppB2TexCMwK2MsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b3WOjd0wAnX0DhFuHeoPXR4oUSeD5jhWxUEDAVhrHv0=; b=a9+0NnFrQGLQgMFUgnN/i6ZYmTK7Kv3FNtAvvsme9iIHRrFHHj0gD++Yt5f8XH/eeH2Br2dTcbpQ/aLOdf8mVqZeU2yMHNbQp6nG2OwpG0fi0sDzy85ecUCNNyml3rq/8MqV6U7tAbJrUKJOq1IW4+TuankxeHaJnBhmKzecxX8a1NLCurCZBCb8AowbFHyU5in2wpHHGqwrDyZhj8K5lIO4/GsPgGRmx+b+rGc88pUybtA9H/51dtuzH2tp6mg9kWaoI7OXPabsxASsRplvsr56C1OkIWPgq+3F33mr1I0wY26UICbUrHiX6CfnhcwbaCGBjwUifi8iLEc1q6ui1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB1095.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7510::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.28; Fri, 30 Oct 2020 10:51:59 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::f4a5:2722:be1c:7222]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::f4a5:2722:be1c:7222%6]) with mapi id 15.20.3499.029; Fri, 30 Oct 2020 10:51:59 +0000 From: "Abner Chang" To: "Wang, Nickle (HPS SW)" , "devel@edk2.groups.io" CC: Jiaxin Wu , Siyuan Fu , Fan Wang , Jiewen Yao Subject: Re: [EFI Redfish Host Interface PATCH 3/5] RedfishPkg/PlatformHostInterfaceLib: Platform NULL lib Thread-Topic: [EFI Redfish Host Interface PATCH 3/5] RedfishPkg/PlatformHostInterfaceLib: Platform NULL lib Thread-Index: AQHWoRy2DxyAJLoBMEie9XSGDPmonqmuNn/AgAHcYdA= Date: Fri, 30 Oct 2020 10:51:59 +0000 Message-ID: References: <20201013040805.20523-1-abner.chang@hpe.com> <20201013040805.20523-4-abner.chang@hpe.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [1.34.113.40] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: da6006fa-80b9-47a8-4d31-08d87cc1d3a8 x-ms-traffictypediagnostic: CS1PR8401MB1095: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:93; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: liuJX/sSpoWFw9EtB5gQgEOwoe08NQSJA3c2IPk8ArGiPt3TUWIjeBzLqYSnmBU9/GTQqJHECqR2VXazlqeB2yNHycH9si6k99ivW2+FB3yRvcGMW6RVUK7cDMY/X3pzMATj/qP5pTEV6FkOBkt88LPrVLt+wP9YqQ9i7JcxIBAUNkgV0MfUrhlsUWmJnleAdUWOJa8veN2gdZxExt49NVap0oCLl8uPIFZPSXXonf3QjjpjlgaIYZxObDsdog3MIE/JjKbkSZZizUJVnXbZ2JsLJipa2j58rfXubwqC3/ZP+tytYR/NevwLlcIjqnB4reZUBQC90YsGmCQKTeRaxw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(366004)(346002)(376002)(396003)(136003)(39860400002)(4326008)(76116006)(8936002)(2906002)(52536014)(66476007)(66446008)(64756008)(33656002)(66556008)(7696005)(26005)(6506007)(53546011)(186003)(86362001)(71200400001)(66946007)(316002)(110136005)(54906003)(478600001)(83380400001)(55016002)(9686003)(8676002)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: YHs+D+MiPdTSYFhqPWSTivvioRZh7a5ux6ds5am28zobZRxq1CfpSJ0XE4t/o0VtvFInnQKO04v5Ycp8/BgMgVYbas68UUJYNpRTYKKGzX3lm7DP30iOBSENc3J7NYw6o5KDS3x+2nVy0EaJN06nU9OAPJO6YhPyP7tmEoLoJ+8jOtQTuzeVcv4w2eLJJo37q9M2PFFZiqV3TfGHrXt/kKAEkFldD+5PH2YwiY7DrqcvKQbbDwHr64lFupPfJYZiqIw5b1Couu+6lluBE9d+/lAIXFWBRluPCs6ca2eFCYakTP8paoscEM2YjjDIoHHI0PIGrKmbMcx7MljhQjIlON2JhCdD6iY9l5wmKClPd9t+VVRnwM+3j/zasTw2qeQlx/R2g/FgTrO6aWHQRA7pxdLmD3Sb34uKwRA8njqCwwvSnZXs8hhumg38Wc9aw2fcADhFCQuSb8OePYZK8VDEiEp/nrfJcLeYIRoeBrXTwdUlgUq/s3sWIqDFgIYQ28ueHi4IPovfsI/xDSYackKA3QWc0IF0T35P2L7k0Bj7Np05gjrcGR4u3SSXOOYvsCssdmN+lQBbbkUj9xry3RefO65oiMLWl3vGfmMGUzTgkc3G9+zv26Z7OmaJ6DjVcbxsRfM7mMpl4Y0MWAVjEseV5w== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: da6006fa-80b9-47a8-4d31-08d87cc1d3a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2020 10:51:59.3080 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RsGhE7DHAllK0HvlzKJtJvk1ryEP3QyyGWfmIh8lN1jraK5As2llUe17bYfH/Pn2bphmm+gxf3Ul04iojpyO8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB1095 X-OriginatorOrg: hpe.com X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-10-30_02:2020-10-30,2020-10-30 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 phishscore=0 suspectscore=0 clxscore=1015 impostorscore=0 mlxscore=0 malwarescore=0 bulkscore=0 spamscore=0 mlxlogscore=999 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010300082 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Nickle, I have addressed the feedbacks you gave to v1 on the v2 patches set. Thanks Abner > -----Original Message----- > From: Wang, Nickle (HPS SW) > Sent: Thursday, October 29, 2020 2:27 PM > To: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io > Cc: Jiaxin Wu ; Siyuan Fu ; Fan > Wang ; Jiewen Yao > Subject: RE: [EFI Redfish Host Interface PATCH 3/5] > RedfishPkg/PlatformHostInterfaceLib: Platform NULL lib >=20 > Hi Abner, >=20 > I do not see any usage of DEBUG macro in this NULL library so maybe > "DebugLib" could be removed from INF file. >=20 > Thanks, > Nickle >=20 > > -----Original Message----- > > From: Chang, Abner (HPS SW/FW Technologist) > > Sent: Tuesday, October 13, 2020 12:08 PM > > To: devel@edk2.groups.io > > Cc: Jiaxin Wu ; Siyuan Fu ; > > Fan Wang ; Jiewen Yao ; > > Wang, Nickle (HPS SW) > > Subject: [EFI Redfish Host Interface PATCH 3/5] > > RedfishPkg/PlatformHostInterfaceLib: Platform NULL lib > > > > NULL instance of PlatformHostInterfaceLib. > > > > Signed-off-by: Abner Chang > > > > Cc: Jiaxin Wu > > Cc: Siyuan Fu > > Cc: Fan Wang > > Cc: Jiewen Yao > > Cc: Nickle Wang > > --- > > .../PlatformHostInterfaceLibNull.c | 53 +++++++++++++++++++ > > .../PlatformHostInterfaceLibNull.inf | 34 ++++++++++++ > > 2 files changed, 87 insertions(+) > > create mode 100644 > > RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceL > > ibN > > ull.c > > create mode 100644 > > RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfaceL > > ibN > > ull.inf > > > > diff --git > > a/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfac > > eLi > > bNull.c > > b/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfac > > eLi > > bNull.c > > new file mode 100644 > > index 0000000000..7653f22d25 > > --- /dev/null > > +++ > > b/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfac > > eLi > > bNull.c > > @@ -0,0 +1,53 @@ > > +/** @file > > + NULL instace of RedfishPlatformHostInterfaceLib > > + > > + (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> > + > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > + > > +**/ > > +#include > > +#include > > +#include > > +#include > > + > > +/** > > + Get platform Redfish host interface device descriptor. > > + > > + @param[out] DeviceType Pointer to retrieve device type. > > + @param[out] DeviceDescriptor Pointer to retrieve > > REDFISH_INTERFACE_DATA, caller has to free > > + this memory using FreePool(). > > + @retval EFI_SUCCESS Device descriptor is returned successfully i= n > > DeviceDescriptor. > > + @retval EFI_NOT_FOUND No Redfish host interface descriptor provide= d > > on this platform. > > + @retval Others Fail to get device descriptor. > > +**/ > > +EFI_STATUS > > +RedfishPlatformHostInterfaceDeviceDescriptor ( > > + IN UINT8 *DeviceType, > > + IN REDFISH_INTERFACE_DATA **DeviceDescriptor > > +) > > +{ > > + return EFI_NOT_FOUND; > > +} > > +/** > > + Get platform Redfish host interface protocol data. > > + Caller should pass NULL in ProtocolRecord to retrive the first > > +protocol > > record. > > + Then continuously pass previous ProtocolRecord for retrieving the > > + next > > ProtocolRecord. > > + > > + @param[in, out] ProtocolRecord Pointer to retrieve the first or > > + the next > > protocol record. > > + caller has to free the new protocol = record returned from > > + this function using FreePool(). > > + param[in] IndexOfProtocolData The index of protocol data. > > + > > + @retval EFI_SUCESS Protocol records are all returned. > > + @retval EFI_NOT_FOUND No more protocol records. > > + @retval Others Fail to get protocol records. > > +**/ > > +EFI_STATUS > > +RedfishPlatformHostInterfaceProtocolData ( > > + IN MC_HOST_INTERFACE_PROTOCOL_RECORD **ProtocolRecord, > > + IN UINT8 IndexOfProtocolData > > +) > > +{ > > + return EFI_NOT_FOUND; > > +} > > diff --git > > a/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfac > > eLi > > bNull.inf > > b/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfac > > eLi > > bNull.inf > > new file mode 100644 > > index 0000000000..bb840ce3cb > > --- /dev/null > > +++ > > b/RedfishPkg/Library/PlatformHostInterfaceLibNull/PlatformHostInterfac > > eLi > > bNull.inf > > @@ -0,0 +1,34 @@ > > +## @file > > +# NULL instance of RedfishPlatformHostInterfaceLib # # (C) > > +Copyright 2020 Hewlett Packard Enterprise Development LP
# # > > +SPDX-License-Identifier: BSD-2-Clause-Patent # ## > > + > > +[Defines] > > + INF_VERSION =3D 0x0001000b > > + BASE_NAME =3D RedfishPlatformHostInterfaceLibNu= ll > > + FILE_GUID =3D 851229BF-4D8B-30F3-DD0D-20AFAF99A= 77B > > + MODULE_TYPE =3D DXE_DRIVER > > + VERSION_STRING =3D 1.0 > > + LIBRARY_CLASS =3D RedfishPlatformHostInterfaceLib > > + > > +# > > +# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 > > +# > > + > > +[Sources] > > + PlatformHostInterfaceLibNull.c > > + > > +[Packages] > > + MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > + RedfishPkg/RedfishPkg.dec > > + > > +[LibraryClasses] > > + UefiLib > > + BaseLib > > + DebugLib > > + > > -- > > 2.17.1