From: "Abner Chang" <abner.chang@hpe.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Chang, Abner (HPS SW/FW Technologist)" <abner.chang@hpe.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Wang, Nickle (HPS SW)" <nickle.wang@hpe.com>,
Andrew Fish <afish@apple.com>, Laszlo Ersek <lersek@redhat.com>,
Leif Lindholm <leif@nuviainc.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of RedfishPkg.
Date: Thu, 8 Oct 2020 12:58:02 +0000 [thread overview]
Message-ID: <CS1PR8401MB1144D3A116CDD50A24A49178FF0B0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <163BE1007D20ADD8.22371@groups.io>
Please ignore this. I was original thought I am not the maintainer of edk2 root.
But as Laszlo mentioned in previous email,
>>>Andrew, Leif, Mike: please check patches #1 and #4.
>>>I'd like to have at least one other ACK on those, and then (I think) Abner can merge the series himself.
Thus, I will merge 1/4 (RedfishPkg) and 4/4 (Maintainers.txt) together to make it consistent, but still leave the merge of 2/4 and 3/4 to Sean and Bret.
Thanks
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Thursday, October 8, 2020 9:45 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
> Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Andrew Fish
> <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> <leif@nuviainc.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial
> commit of RedfishPkg.
>
> I don’t think I should merge this patch to edk2 by my own. Mike or Laszlo
> could any of your merge it. Thanks Leif also gave feedback tag on this patch
> by the way.
>
>
> > -----Original Message-----
> > From: Kinney, Michael D [mailto:michael.d.kinney@intel.com]
> > Sent: Thursday, October 8, 2020 12:29 AM
> > To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> > devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> > Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Andrew Fish
> > <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> > <leif@nuviainc.com>
> > Subject: RE: [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of
> > RedfishPkg.
> >
> > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > > -----Original Message-----
> > > From: Abner Chang <abner.chang@hpe.com>
> > > Sent: Tuesday, October 6, 2020 7:16 PM
> > > To: devel@edk2.groups.io
> > > Cc: Nickle Wang <nickle.wang@hpe.com>; Andrew Fish
> > <afish@apple.com>;
> > > Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>;
> > > Kinney, Michael D <michael.d.kinney@intel.com>
> > > Subject: [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of
> > RedfishPkg.
> > >
> > > Initial version of RedfishPkg.
> > >
> > > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> > > Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> > > Signed-off-by: Wang Fan <fan.wang@intel.com>
> > > Signed-off-by: Chang Abner <abner.chang@hpe.com>
> > > Cc: Nickle Wang <nickle.wang@hpe.com>
> > > Cc: Andrew Fish <afish@apple.com>
> > > Cc: Laszlo Ersek <lersek@redhat.com>
> > > Cc: Leif Lindholm <leif@nuviainc.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Acked-by: Laszlo Ersek <lersek@redhat.com>
> > > ---
> > > RedfishPkg/RedfishPkg.ci.yaml | 67
> > +++++++++++++++++++++++++++++++++++
> > > RedfishPkg/RedfishPkg.dec | 18 ++++++++++
> > > RedfishPkg/RedfishPkg.dsc | 40 +++++++++++++++++++++
> > > 3 files changed, 125 insertions(+)
> > > create mode 100644 RedfishPkg/RedfishPkg.ci.yaml create mode
> > > 100644 RedfishPkg/RedfishPkg.dec create mode 100644
> > > RedfishPkg/RedfishPkg.dsc
> > >
> > > diff --git a/RedfishPkg/RedfishPkg.ci.yaml
> > > b/RedfishPkg/RedfishPkg.ci.yaml new file mode 100644 index
> > > 0000000000..75c3b6a8ad
> > > --- /dev/null
> > > +++ b/RedfishPkg/RedfishPkg.ci.yaml
> > > @@ -0,0 +1,67 @@
> > > +## @file
> > > +# CI configuration for NetworkPkg
> > > +#
> > > +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> > > +#
> > > +SPDX-License-Identifier: BSD-2-Clause-Patent ## {
> > > + "LicenseCheck": {
> > > + "IgnoreFiles": []
> > > + },
> > > + "EccCheck": {
> > > + ## Exception sample looks like below:
> > > + ## "ExceptionList": [
> > > + ## "<ErrorID>", "<KeyWord>"
> > > + ## ]
> > > + "ExceptionList": [
> > > + ],
> > > + ## Both file path and directory path are accepted.
> > > + "IgnoreFiles": [
> > > + ]
> > > + },
> > > + "CompilerPlugin": {
> > > + "DscPath": "RedfishPkg.dsc"
> > > + },
> > > + "CharEncodingCheck": {
> > > + "IgnoreFiles": []
> > > + },
> > > + "DependencyCheck": {
> > > + "AcceptableDependencies": [
> > > + "MdePkg/MdePkg.dec",
> > > + "MdeModulePkg/MdeModulePkg.dec",
> > > + "NetworkPkg/NetworkPkg.dec"
> > > + ],
> > > + # For host based unit tests
> > > + "AcceptableDependencies-HOST_APPLICATION":[],
> > > + # For UEFI shell based apps
> > > + "AcceptableDependencies-UEFI_APPLICATION":[
> > > + "ShellPkg/ShellPkg.dec"
> > > + ],
> > > + "IgnoreInf": []
> > > + },
> > > + "DscCompleteCheck": {
> > > + "DscPath": "RedfishPkg.dsc",
> > > + "IgnoreInf": []
> > > + },
> > > + "GuidCheck": {
> > > + "IgnoreGuidName": [],
> > > + "IgnoreGuidValue": [],
> > > + "IgnoreFoldersAndFiles": []
> > > + },
> > > + "LibraryClassCheck": {
> > > + "IgnoreHeaderFile": []
> > > + },
> > > +
> > > + ## options defined ci/Plugin/SpellCheck
> > > + "SpellCheck": {
> > > + "AuditOnly": True, # Fails test but run in AuditOnly mode to
> > collect log
> > > + "IgnoreFiles": [], # use gitignore syntax to ignore errors in
> > matching files
> > > + "ExtendWords": [], # words to extend to the dictionary for this
> > package
> > > + "IgnoreStandardPaths": [], # Standard Plugin defined paths that
> > should be ignore
> > > + "AdditionalIncludePaths": [] # Additional paths to spell
> > > + check
> > (wildcards supported)
> > > + },
> > > +
> > > + "Defines": {
> > > + "BLD_*_CONTINUOUS_INTEGRATION": "TRUE"
> > > + }
> > > +}
> > > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec
> > > new file mode 100644 index 0000000000..e95ec5fe10
> > > --- /dev/null
> > > +++ b/RedfishPkg/RedfishPkg.dec
> > > @@ -0,0 +1,18 @@
> > > +## @file
> > > +# Redfish Package
> > > +#
> > > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > > +(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR> #
> > > +#
> > > +SPDX-License-Identifier: BSD-2-Clause-Patent ##
> > > +
> > > +[Defines]
> > > + DEC_SPECIFICATION = 0x0001001b
> > > + PACKAGE_NAME = RedfishPkg
> > > + PACKAGE_GUID = c432b76e-5232-11e7-9010-005056c00008
> > > + PACKAGE_VERSION = 1.0
> > > +
> > > +[Guids]
> > > + gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c,
> { 0x88,
> > 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
> > > +
> > > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
> > > new file mode 100644 index 0000000000..8acadddefc
> > > --- /dev/null
> > > +++ b/RedfishPkg/RedfishPkg.dsc
> > > @@ -0,0 +1,40 @@
> > > +## @file
> > > +# Redfish Package
> > > +#
> > > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > > +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
> > > +#
> > > +# SPDX-License-Identifier: BSD-2-Clause-Patent
> > > +#
> > > +##
> > > +
> > > +[Defines]
> > > + PLATFORM_NAME = RedfishPkg
> > > + PLATFORM_GUID = c4352870-5232-11e7-9522-005056c00008
> > > + PLATFORM_VERSION = 1.0
> > > + DSC_SPECIFICATION = 0x0001001c
> > > + OUTPUT_DIRECTORY = Build/RedfishPkg
> > > + SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64|RISCV64
> > > + BUILD_TARGETS = DEBUG|RELEASE|NOOPT
> > > + SKUID_IDENTIFIER = DEFAULT
> > > +
> > > +[LibraryClasses]
> > > +
> > > +UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriver
> > > +UefiDriverEntryPoint|En
> > > +tryPoint.inf
> > > +
> > >
> >
> +UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/Uefi
> > > +BootServicesTableLib.inf
> > > + UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> > > +
> > >
> >
> +UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLi
> > > +b/UefiRuntimeServicesTableLib.inf
> > > + UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> > > +
> > >
> >
> +MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMem
> > ory
> > > +AllocationLib.inf
> > > +
> > >
> +DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.in
> > > +DevicePathLib|f
> > > + BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> > > + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> > > +
> > >
> >
> +SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchron
> > > +izationLib.inf
> > > + PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> > > + DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> > > +
> > >
> >
> +DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Ba
> > > +seDebugPrintErrorLevelLib.inf
> > > +
> > >
> >
> +PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPo
> > rt8
> > > +0.inf
> > > + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> > > +
> > >
> >
> +PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Bas
> > e
> > > +PeCoffGetEntryPointLib.inf
> > > +
> > >
> >
> +DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTab
> > > +leLib.inf
> > > + DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> > > +
> > >
> >
> +ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/D
> > xeRe
> > > +portStatusCodeLib.inf
> > > --
> > > 2.17.1
>
>
>
>
>
next prev parent reply other threads:[~2020-10-08 12:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 2:15 [RedfishPkg PATCH v6 0/4] Inital RedfishPkg Abner Chang
2020-10-07 2:15 ` [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of RedfishPkg Abner Chang
2020-10-07 9:30 ` Leif Lindholm
2020-10-07 16:29 ` Michael D Kinney
2020-10-08 1:44 ` Abner Chang
[not found] ` <163BE1007D20ADD8.22371@groups.io>
2020-10-08 12:58 ` Abner Chang [this message]
2020-10-07 2:15 ` [RedfishPkg PATCH v6 2/4] .pytool: Add CI on RedfishPkg Abner Chang
2020-10-07 2:15 ` [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
2020-10-07 10:54 ` [edk2-devel] " Laszlo Ersek
2020-10-07 2:15 ` [RedfishPkg PATCH v6 4/4] edk2: Add maintainers to RedfishPkg Abner Chang
2020-10-07 16:28 ` [edk2-devel] " Michael D Kinney
2020-10-07 10:49 ` [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg Laszlo Ersek
2020-10-07 11:23 ` Abner Chang
2020-10-07 15:00 ` Abner Chang
2020-10-07 15:48 ` Laszlo Ersek
[not found] ` <163B968D94C2410C.25576@groups.io>
2020-10-08 0:59 ` [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
2020-10-08 1:00 ` Sean
2020-10-08 1:08 ` Abner Chang
[not found] ` <163BDF0D4D469E1C.12039@groups.io>
2020-10-08 3:56 ` Abner Chang
2020-10-14 13:30 ` Abner Chang
[not found] ` <163DDF075C4BB2E8.14646@groups.io>
2020-10-15 1:19 ` Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CS1PR8401MB1144D3A116CDD50A24A49178FF0B0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox