* [RedfishPkg PATCH v6 0/4] Inital RedfishPkg
@ 2020-10-07 2:15 Abner Chang
2020-10-07 2:15 ` [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of RedfishPkg Abner Chang
` (5 more replies)
0 siblings, 6 replies; 21+ messages in thread
From: Abner Chang @ 2020-10-07 2:15 UTC (permalink / raw)
To: devel
Note for v6: In patch 3/4, move RedfishPkg to TARGET_NETWORK to
save time on CI test.
In patch 1/4, add NOOPT back to RedfishPkg.dsc becasue
this change is not required in v4 pacth set.
Note for v5: Add reviewers's tags.
Note for v4: NOOPT is removed from RedfishPkg.dsc and
pr-gate-build-job.yml because we don't have host-based
unit test on Redfish yet. We keep NO-TARGET for the
non build CI test on RedfishPkg.
Initial version of RedfishPkg and the CI test
on RedfishPkg.
CI Test result:
https://github.com/tianocore/edk2/pull/986
There is no components in RedfishPkg in this commit,
the further edk2 Redfish components will be committed
base on this version.
Abner Chang (4):
RedfishPkg: Initial commit of RedfishPkg.
.pytool: Add CI on RedfishPkg
.azurepipelines/templates: Add RedfishPkg to target build
edk2: Add maintainers to RedfishPkg
.../templates/pr-gate-build-job.yml | 2 +-
.pytool/CISettings.py | 3 +-
Maintainers.txt | 5 ++
RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++
RedfishPkg/RedfishPkg.dec | 18 +++++
RedfishPkg/RedfishPkg.dsc | 40 +++++++++++
6 files changed, 133 insertions(+), 2 deletions(-)
create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
create mode 100644 RedfishPkg/RedfishPkg.dec
create mode 100644 RedfishPkg/RedfishPkg.dsc
--
2.17.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of RedfishPkg.
2020-10-07 2:15 [RedfishPkg PATCH v6 0/4] Inital RedfishPkg Abner Chang
@ 2020-10-07 2:15 ` Abner Chang
2020-10-07 9:30 ` Leif Lindholm
2020-10-07 16:29 ` Michael D Kinney
2020-10-07 2:15 ` [RedfishPkg PATCH v6 2/4] .pytool: Add CI on RedfishPkg Abner Chang
` (4 subsequent siblings)
5 siblings, 2 replies; 21+ messages in thread
From: Abner Chang @ 2020-10-07 2:15 UTC (permalink / raw)
To: devel
Cc: Nickle Wang, Andrew Fish, Laszlo Ersek, Leif Lindholm,
Michael D Kinney
Initial version of RedfishPkg.
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
Signed-off-by: Wang Fan <fan.wang@intel.com>
Signed-off-by: Chang Abner <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
---
RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++++++++++++++++++
RedfishPkg/RedfishPkg.dec | 18 ++++++++++
RedfishPkg/RedfishPkg.dsc | 40 +++++++++++++++++++++
3 files changed, 125 insertions(+)
create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
create mode 100644 RedfishPkg/RedfishPkg.dec
create mode 100644 RedfishPkg/RedfishPkg.dsc
diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml
new file mode 100644
index 0000000000..75c3b6a8ad
--- /dev/null
+++ b/RedfishPkg/RedfishPkg.ci.yaml
@@ -0,0 +1,67 @@
+## @file
+# CI configuration for NetworkPkg
+#
+# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+ "LicenseCheck": {
+ "IgnoreFiles": []
+ },
+ "EccCheck": {
+ ## Exception sample looks like below:
+ ## "ExceptionList": [
+ ## "<ErrorID>", "<KeyWord>"
+ ## ]
+ "ExceptionList": [
+ ],
+ ## Both file path and directory path are accepted.
+ "IgnoreFiles": [
+ ]
+ },
+ "CompilerPlugin": {
+ "DscPath": "RedfishPkg.dsc"
+ },
+ "CharEncodingCheck": {
+ "IgnoreFiles": []
+ },
+ "DependencyCheck": {
+ "AcceptableDependencies": [
+ "MdePkg/MdePkg.dec",
+ "MdeModulePkg/MdeModulePkg.dec",
+ "NetworkPkg/NetworkPkg.dec"
+ ],
+ # For host based unit tests
+ "AcceptableDependencies-HOST_APPLICATION":[],
+ # For UEFI shell based apps
+ "AcceptableDependencies-UEFI_APPLICATION":[
+ "ShellPkg/ShellPkg.dec"
+ ],
+ "IgnoreInf": []
+ },
+ "DscCompleteCheck": {
+ "DscPath": "RedfishPkg.dsc",
+ "IgnoreInf": []
+ },
+ "GuidCheck": {
+ "IgnoreGuidName": [],
+ "IgnoreGuidValue": [],
+ "IgnoreFoldersAndFiles": []
+ },
+ "LibraryClassCheck": {
+ "IgnoreHeaderFile": []
+ },
+
+ ## options defined ci/Plugin/SpellCheck
+ "SpellCheck": {
+ "AuditOnly": True, # Fails test but run in AuditOnly mode to collect log
+ "IgnoreFiles": [], # use gitignore syntax to ignore errors in matching files
+ "ExtendWords": [], # words to extend to the dictionary for this package
+ "IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore
+ "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
+ },
+
+ "Defines": {
+ "BLD_*_CONTINUOUS_INTEGRATION": "TRUE"
+ }
+}
diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec
new file mode 100644
index 0000000000..e95ec5fe10
--- /dev/null
+++ b/RedfishPkg/RedfishPkg.dec
@@ -0,0 +1,18 @@
+## @file
+# Redfish Package
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+
+[Defines]
+ DEC_SPECIFICATION = 0x0001001b
+ PACKAGE_NAME = RedfishPkg
+ PACKAGE_GUID = c432b76e-5232-11e7-9010-005056c00008
+ PACKAGE_VERSION = 1.0
+
+[Guids]
+ gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88, 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
+
diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
new file mode 100644
index 0000000000..8acadddefc
--- /dev/null
+++ b/RedfishPkg/RedfishPkg.dsc
@@ -0,0 +1,40 @@
+## @file
+# Redfish Package
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# (C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+ PLATFORM_NAME = RedfishPkg
+ PLATFORM_GUID = c4352870-5232-11e7-9522-005056c00008
+ PLATFORM_VERSION = 1.0
+ DSC_SPECIFICATION = 0x0001001c
+ OUTPUT_DIRECTORY = Build/RedfishPkg
+ SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64|RISCV64
+ BUILD_TARGETS = DEBUG|RELEASE|NOOPT
+ SKUID_IDENTIFIER = DEFAULT
+
+[LibraryClasses]
+ UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
+ UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
+ UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
+ UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
+ UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
+ MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
+ DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
+ BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
+ BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
+ SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
+ PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
+ DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
+ DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
+ PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPort80.inf
+ PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
+ PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
+ DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
+ DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
+ ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
--
2.17.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [RedfishPkg PATCH v6 2/4] .pytool: Add CI on RedfishPkg
2020-10-07 2:15 [RedfishPkg PATCH v6 0/4] Inital RedfishPkg Abner Chang
2020-10-07 2:15 ` [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of RedfishPkg Abner Chang
@ 2020-10-07 2:15 ` Abner Chang
2020-10-07 2:15 ` [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
` (3 subsequent siblings)
5 siblings, 0 replies; 21+ messages in thread
From: Abner Chang @ 2020-10-07 2:15 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao,
Nickle Wang
Add RedfishPkg to CI test.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Nickle Wang <nickle.wang@hpe.com>
Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
---
.pytool/CISettings.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index 0c2dd0181a..b337d046ae 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -55,7 +55,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
"FatPkg",
"CryptoPkg",
"UnitTestFrameworkPkg",
- "OvmfPkg"
+ "OvmfPkg",
+ "RedfishPkg"
)
def GetArchitecturesSupported(self):
--
2.17.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build
2020-10-07 2:15 [RedfishPkg PATCH v6 0/4] Inital RedfishPkg Abner Chang
2020-10-07 2:15 ` [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of RedfishPkg Abner Chang
2020-10-07 2:15 ` [RedfishPkg PATCH v6 2/4] .pytool: Add CI on RedfishPkg Abner Chang
@ 2020-10-07 2:15 ` Abner Chang
2020-10-07 10:54 ` [edk2-devel] " Laszlo Ersek
2020-10-07 2:15 ` [RedfishPkg PATCH v6 4/4] edk2: Add maintainers to RedfishPkg Abner Chang
` (2 subsequent siblings)
5 siblings, 1 reply; 21+ messages in thread
From: Abner Chang @ 2020-10-07 2:15 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao,
Nickle Wang
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Nickle Wang <nickle.wang@hpe.com>
Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
.azurepipelines/templates/pr-gate-build-job.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 2683687a1c..89c632c0a7 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -31,7 +31,7 @@ jobs:
Build.Pkgs: 'MdeModulePkg'
Build.Targets: 'RELEASE,NO-TARGET'
TARGET_NETWORK:
- Build.Pkgs: 'NetworkPkg'
+ Build.Pkgs: 'NetworkPkg,RedfishPkg'
Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
TARGET_OTHER:
Build.Pkgs: 'PcAtChipsetPkg,ShellPkg'
--
2.17.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [RedfishPkg PATCH v6 4/4] edk2: Add maintainers to RedfishPkg
2020-10-07 2:15 [RedfishPkg PATCH v6 0/4] Inital RedfishPkg Abner Chang
` (2 preceding siblings ...)
2020-10-07 2:15 ` [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
@ 2020-10-07 2:15 ` Abner Chang
2020-10-07 16:28 ` [edk2-devel] " Michael D Kinney
2020-10-07 10:49 ` [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg Laszlo Ersek
[not found] ` <163B968D94C2410C.25576@groups.io>
5 siblings, 1 reply; 21+ messages in thread
From: Abner Chang @ 2020-10-07 2:15 UTC (permalink / raw)
To: devel
Cc: Nickle Wang, Andrew Fish, Laszlo Ersek, Leif Lindholm,
Michael D Kinney
Signed-off-by: Chang Abner <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Acked-by: Leif Lindholm <leif@nuviainc.com>
---
Maintainers.txt | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 6a22a14796..cabadac177 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -503,6 +503,11 @@ F: PcAtChipsetPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
M: Ray Ni <ray.ni@intel.com>
+RedfishPkg: Redfish related modules
+F: RedfishPkg/
+M: Abner Chang <abner.chang@hpe.com>
+R: Nickle Wang <nickle.wang@hpe.com>
+
SecurityPkg
F: SecurityPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
--
2.17.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of RedfishPkg.
2020-10-07 2:15 ` [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of RedfishPkg Abner Chang
@ 2020-10-07 9:30 ` Leif Lindholm
2020-10-07 16:29 ` Michael D Kinney
1 sibling, 0 replies; 21+ messages in thread
From: Leif Lindholm @ 2020-10-07 9:30 UTC (permalink / raw)
To: Abner Chang
Cc: devel, Nickle Wang, Andrew Fish, Laszlo Ersek, Michael D Kinney
On Wed, Oct 07, 2020 at 10:15:42 +0800, Abner Chang wrote:
> Initial version of RedfishPkg.
>
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> Signed-off-by: Wang Fan <fan.wang@intel.com>
> Signed-off-by: Chang Abner <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
Acked-by: Leif Lindholm <leif@nuviainc.com>
> ---
> RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++++++++++++++++++
> RedfishPkg/RedfishPkg.dec | 18 ++++++++++
> RedfishPkg/RedfishPkg.dsc | 40 +++++++++++++++++++++
> 3 files changed, 125 insertions(+)
> create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
> create mode 100644 RedfishPkg/RedfishPkg.dec
> create mode 100644 RedfishPkg/RedfishPkg.dsc
>
> diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml
> new file mode 100644
> index 0000000000..75c3b6a8ad
> --- /dev/null
> +++ b/RedfishPkg/RedfishPkg.ci.yaml
> @@ -0,0 +1,67 @@
> +## @file
> +# CI configuration for NetworkPkg
> +#
> +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +##
> +{
> + "LicenseCheck": {
> + "IgnoreFiles": []
> + },
> + "EccCheck": {
> + ## Exception sample looks like below:
> + ## "ExceptionList": [
> + ## "<ErrorID>", "<KeyWord>"
> + ## ]
> + "ExceptionList": [
> + ],
> + ## Both file path and directory path are accepted.
> + "IgnoreFiles": [
> + ]
> + },
> + "CompilerPlugin": {
> + "DscPath": "RedfishPkg.dsc"
> + },
> + "CharEncodingCheck": {
> + "IgnoreFiles": []
> + },
> + "DependencyCheck": {
> + "AcceptableDependencies": [
> + "MdePkg/MdePkg.dec",
> + "MdeModulePkg/MdeModulePkg.dec",
> + "NetworkPkg/NetworkPkg.dec"
> + ],
> + # For host based unit tests
> + "AcceptableDependencies-HOST_APPLICATION":[],
> + # For UEFI shell based apps
> + "AcceptableDependencies-UEFI_APPLICATION":[
> + "ShellPkg/ShellPkg.dec"
> + ],
> + "IgnoreInf": []
> + },
> + "DscCompleteCheck": {
> + "DscPath": "RedfishPkg.dsc",
> + "IgnoreInf": []
> + },
> + "GuidCheck": {
> + "IgnoreGuidName": [],
> + "IgnoreGuidValue": [],
> + "IgnoreFoldersAndFiles": []
> + },
> + "LibraryClassCheck": {
> + "IgnoreHeaderFile": []
> + },
> +
> + ## options defined ci/Plugin/SpellCheck
> + "SpellCheck": {
> + "AuditOnly": True, # Fails test but run in AuditOnly mode to collect log
> + "IgnoreFiles": [], # use gitignore syntax to ignore errors in matching files
> + "ExtendWords": [], # words to extend to the dictionary for this package
> + "IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore
> + "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
> + },
> +
> + "Defines": {
> + "BLD_*_CONTINUOUS_INTEGRATION": "TRUE"
> + }
> +}
> diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec
> new file mode 100644
> index 0000000000..e95ec5fe10
> --- /dev/null
> +++ b/RedfishPkg/RedfishPkg.dec
> @@ -0,0 +1,18 @@
> +## @file
> +# Redfish Package
> +#
> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +##
> +
> +[Defines]
> + DEC_SPECIFICATION = 0x0001001b
> + PACKAGE_NAME = RedfishPkg
> + PACKAGE_GUID = c432b76e-5232-11e7-9010-005056c00008
> + PACKAGE_VERSION = 1.0
> +
> +[Guids]
> + gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88, 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
> +
> diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
> new file mode 100644
> index 0000000000..8acadddefc
> --- /dev/null
> +++ b/RedfishPkg/RedfishPkg.dsc
> @@ -0,0 +1,40 @@
> +## @file
> +# Redfish Package
> +#
> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +# (C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +##
> +
> +[Defines]
> + PLATFORM_NAME = RedfishPkg
> + PLATFORM_GUID = c4352870-5232-11e7-9522-005056c00008
> + PLATFORM_VERSION = 1.0
> + DSC_SPECIFICATION = 0x0001001c
> + OUTPUT_DIRECTORY = Build/RedfishPkg
> + SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64|RISCV64
> + BUILD_TARGETS = DEBUG|RELEASE|NOOPT
> + SKUID_IDENTIFIER = DEFAULT
> +
> +[LibraryClasses]
> + UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> + UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
> + UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> + UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
> + UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> + MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> + DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> + BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> + SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
> + PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> + DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> + DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
> + PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPort80.inf
> + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> + PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
> + DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
> + DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg
2020-10-07 2:15 [RedfishPkg PATCH v6 0/4] Inital RedfishPkg Abner Chang
` (3 preceding siblings ...)
2020-10-07 2:15 ` [RedfishPkg PATCH v6 4/4] edk2: Add maintainers to RedfishPkg Abner Chang
@ 2020-10-07 10:49 ` Laszlo Ersek
2020-10-07 11:23 ` Abner Chang
[not found] ` <163B968D94C2410C.25576@groups.io>
5 siblings, 1 reply; 21+ messages in thread
From: Laszlo Ersek @ 2020-10-07 10:49 UTC (permalink / raw)
To: devel, abner.chang
Abner,
On 10/07/20 04:15, Abner Chang wrote:
> Note for v6: In patch 3/4, move RedfishPkg to TARGET_NETWORK to
> save time on CI test.
> In patch 1/4, add NOOPT back to RedfishPkg.dsc becasue
> this change is not required in v4 pacth set.
you really need to collect the CC's from *all* the commit messages
across the entire series, and manually add those to your cover letter.
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23
"This will ensure that even if a maintainer is involved in reviewing one
or two of your patches across the series, he or she will get a copy of
your cover letter, which outlines the full feature or bugfix"
No need to repost this, but please remember it in the future.
Thanks
Laszlo
>
> Note for v5: Add reviewers's tags.
>
> Note for v4: NOOPT is removed from RedfishPkg.dsc and
> pr-gate-build-job.yml because we don't have host-based
> unit test on Redfish yet. We keep NO-TARGET for the
> non build CI test on RedfishPkg.
>
> Initial version of RedfishPkg and the CI test
> on RedfishPkg.
>
> CI Test result:
> https://github.com/tianocore/edk2/pull/986
>
> There is no components in RedfishPkg in this commit,
> the further edk2 Redfish components will be committed
> base on this version.
>
> Abner Chang (4):
> RedfishPkg: Initial commit of RedfishPkg.
> .pytool: Add CI on RedfishPkg
> .azurepipelines/templates: Add RedfishPkg to target build
> edk2: Add maintainers to RedfishPkg
>
> .../templates/pr-gate-build-job.yml | 2 +-
> .pytool/CISettings.py | 3 +-
> Maintainers.txt | 5 ++
> RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++
> RedfishPkg/RedfishPkg.dec | 18 +++++
> RedfishPkg/RedfishPkg.dsc | 40 +++++++++++
> 6 files changed, 133 insertions(+), 2 deletions(-)
> create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
> create mode 100644 RedfishPkg/RedfishPkg.dec
> create mode 100644 RedfishPkg/RedfishPkg.dsc
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build
2020-10-07 2:15 ` [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
@ 2020-10-07 10:54 ` Laszlo Ersek
0 siblings, 0 replies; 21+ messages in thread
From: Laszlo Ersek @ 2020-10-07 10:54 UTC (permalink / raw)
To: devel, abner.chang
Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao,
Nickle Wang, Leif Lindholm (Nuvia address)
On 10/07/20 04:15, Abner Chang wrote:
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> ---
> .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
> index 2683687a1c..89c632c0a7 100644
> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> @@ -31,7 +31,7 @@ jobs:
> Build.Pkgs: 'MdeModulePkg'
> Build.Targets: 'RELEASE,NO-TARGET'
> TARGET_NETWORK:
> - Build.Pkgs: 'NetworkPkg'
> + Build.Pkgs: 'NetworkPkg,RedfishPkg'
> Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> TARGET_OTHER:
> Build.Pkgs: 'PcAtChipsetPkg,ShellPkg'
>
I'd like Sean and/or Bret to re-review this patch, because the related
subthread in the v5 review session seems to have ended with an open
question about NetworkPkg.
https://edk2.groups.io/g/devel/message/65948
http://mid.mail-archive.com/CS1PR8401MB1144EF23CAAF9AF8A147D874FF0A0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM
It would also be nice to have *some* explanation in the commit message
*why* we're coupling RedfishPkg with NetworkPkg specifically. I'm not
arguing against this coupling by any means, I'd just like to see it
explained.
If someone can propose a concise 1-2 paragraph explanation in response,
I'm happy to reword the commit message myself (including those
paragraphs), when I merge this (v6) series (with Sean's or Bret's
renewed approval of this patch).
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg
2020-10-07 10:49 ` [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg Laszlo Ersek
@ 2020-10-07 11:23 ` Abner Chang
2020-10-07 15:00 ` Abner Chang
2020-10-07 15:48 ` Laszlo Ersek
0 siblings, 2 replies; 21+ messages in thread
From: Abner Chang @ 2020-10-07 11:23 UTC (permalink / raw)
To: Laszlo Ersek, devel@edk2.groups.io
Thanks for that information, I never read through that guidance... and I should.
One question Leif,
If the patches get the new tag from reviewers, shall I have to send the new version of patches to the mailing list which includes all of reviewer's tag?
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Wednesday, October 7, 2020 6:49 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg
>
> Abner,
>
> On 10/07/20 04:15, Abner Chang wrote:
> > Note for v6: In patch 3/4, move RedfishPkg to TARGET_NETWORK to
> > save time on CI test.
> > In patch 1/4, add NOOPT back to RedfishPkg.dsc becasue
> > this change is not required in v4 pacth set.
>
> you really need to collect the CC's from *all* the commit messages across the
> entire series, and manually add those to your cover letter.
>
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-
> unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23
>
> "This will ensure that even if a maintainer is involved in reviewing one or two
> of your patches across the series, he or she will get a copy of your cover
> letter, which outlines the full feature or bugfix"
>
> No need to repost this, but please remember it in the future.
>
> Thanks
> Laszlo
>
> >
> > Note for v5: Add reviewers's tags.
> >
> > Note for v4: NOOPT is removed from RedfishPkg.dsc and
> > pr-gate-build-job.yml because we don't have host-based
> > unit test on Redfish yet. We keep NO-TARGET for the
> > non build CI test on RedfishPkg.
> >
> > Initial version of RedfishPkg and the CI test on RedfishPkg.
> >
> > CI Test result:
> > https://github.com/tianocore/edk2/pull/986
> >
> > There is no components in RedfishPkg in this commit, the further edk2
> > Redfish components will be committed base on this version.
> >
> > Abner Chang (4):
> > RedfishPkg: Initial commit of RedfishPkg.
> > .pytool: Add CI on RedfishPkg
> > .azurepipelines/templates: Add RedfishPkg to target build
> > edk2: Add maintainers to RedfishPkg
> >
> > .../templates/pr-gate-build-job.yml | 2 +-
> > .pytool/CISettings.py | 3 +-
> > Maintainers.txt | 5 ++
> > RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++
> > RedfishPkg/RedfishPkg.dec | 18 +++++
> > RedfishPkg/RedfishPkg.dsc | 40 +++++++++++
> > 6 files changed, 133 insertions(+), 2 deletions(-) create mode
> > 100644 RedfishPkg/RedfishPkg.ci.yaml create mode 100644
> > RedfishPkg/RedfishPkg.dec create mode 100644
> > RedfishPkg/RedfishPkg.dsc
> >
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg
2020-10-07 11:23 ` Abner Chang
@ 2020-10-07 15:00 ` Abner Chang
2020-10-07 15:48 ` Laszlo Ersek
1 sibling, 0 replies; 21+ messages in thread
From: Abner Chang @ 2020-10-07 15:00 UTC (permalink / raw)
To: Laszlo Ersek, devel@edk2.groups.io
Sorry, it's typo. Below question is to Laszlo not Leif,
>>>If the patches get the new tag from reviewers, shall I have to send the new
>>> version of patches to the mailing list which includes all of reviewer's tag?
I mean there is no more feedbacks on patches itself but just get new feedback tags from reviewers. Can we just add those tags to patches when merge it?
Or as you mentioned in the previous email "...it helps maintainers if they don't need to go back to earlier versions to hunt down feedback tags."
Thanks
> -----Original Message-----
> From: Chang, Abner (HPS SW/FW Technologist)
> Sent: Wednesday, October 7, 2020 7:24 PM
> To: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io
> Subject: RE: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg
>
> Thanks for that information, I never read through that guidance... and I
> should.
>
> One question Leif,
> If the patches get the new tag from reviewers, shall I have to send the new
> version of patches to the mailing list which includes all of reviewer's tag?
>
> > -----Original Message-----
> > From: Laszlo Ersek [mailto:lersek@redhat.com]
> > Sent: Wednesday, October 7, 2020 6:49 PM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang@hpe.com>
> > Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg
> >
> > Abner,
> >
> > On 10/07/20 04:15, Abner Chang wrote:
> > > Note for v6: In patch 3/4, move RedfishPkg to TARGET_NETWORK to
> > > save time on CI test.
> > > In patch 1/4, add NOOPT back to RedfishPkg.dsc becasue
> > > this change is not required in v4 pacth set.
> >
> > you really need to collect the CC's from *all* the commit messages
> > across the entire series, and manually add those to your cover letter.
> >
> > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-
> > unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23
> >
> > "This will ensure that even if a maintainer is involved in reviewing
> > one or two of your patches across the series, he or she will get a
> > copy of your cover letter, which outlines the full feature or bugfix"
> >
> > No need to repost this, but please remember it in the future.
> >
> > Thanks
> > Laszlo
> >
> > >
> > > Note for v5: Add reviewers's tags.
> > >
> > > Note for v4: NOOPT is removed from RedfishPkg.dsc and
> > > pr-gate-build-job.yml because we don't have host-based
> > > unit test on Redfish yet. We keep NO-TARGET for the
> > > non build CI test on RedfishPkg.
> > >
> > > Initial version of RedfishPkg and the CI test on RedfishPkg.
> > >
> > > CI Test result:
> > > https://github.com/tianocore/edk2/pull/986
> > >
> > > There is no components in RedfishPkg in this commit, the further
> > > edk2 Redfish components will be committed base on this version.
> > >
> > > Abner Chang (4):
> > > RedfishPkg: Initial commit of RedfishPkg.
> > > .pytool: Add CI on RedfishPkg
> > > .azurepipelines/templates: Add RedfishPkg to target build
> > > edk2: Add maintainers to RedfishPkg
> > >
> > > .../templates/pr-gate-build-job.yml | 2 +-
> > > .pytool/CISettings.py | 3 +-
> > > Maintainers.txt | 5 ++
> > > RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++
> > > RedfishPkg/RedfishPkg.dec | 18 +++++
> > > RedfishPkg/RedfishPkg.dsc | 40 +++++++++++
> > > 6 files changed, 133 insertions(+), 2 deletions(-) create mode
> > > 100644 RedfishPkg/RedfishPkg.ci.yaml create mode 100644
> > > RedfishPkg/RedfishPkg.dec create mode 100644
> > > RedfishPkg/RedfishPkg.dsc
> > >
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg
2020-10-07 11:23 ` Abner Chang
2020-10-07 15:00 ` Abner Chang
@ 2020-10-07 15:48 ` Laszlo Ersek
1 sibling, 0 replies; 21+ messages in thread
From: Laszlo Ersek @ 2020-10-07 15:48 UTC (permalink / raw)
To: Chang, Abner (HPS SW/FW Technologist), devel@edk2.groups.io
On 10/07/20 13:23, Chang, Abner (HPS SW/FW Technologist) wrote:
> Thanks for that information, I never read through that guidance... and I should.
>
> One question Leif,
> If the patches get the new tag from reviewers, shall I have to send the new version of patches to the mailing list which includes all of reviewer's tag?
No. If the feedback you get purely consists of feedback tags, and
through them, the patch series becomes eligible for merging, then it is
the maintainer's job to apply your series on a local topic branch of
theirs (git-am), pick up the feedback tags (git-rebase + reword on each
patch), and finally push the topic branch to github, open a PR, set the
"push" label, and let the mergify bot merge the series once the CI run
passes.
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#maint-04
Thanks
Laszlo
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [RedfishPkg PATCH v6 4/4] edk2: Add maintainers to RedfishPkg
2020-10-07 2:15 ` [RedfishPkg PATCH v6 4/4] edk2: Add maintainers to RedfishPkg Abner Chang
@ 2020-10-07 16:28 ` Michael D Kinney
0 siblings, 0 replies; 21+ messages in thread
From: Michael D Kinney @ 2020-10-07 16:28 UTC (permalink / raw)
To: devel@edk2.groups.io, abner.chang@hpe.com, Kinney, Michael D
Cc: Nickle Wang, Andrew Fish, Laszlo Ersek, Leif Lindholm
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner Chang
> Sent: Tuesday, October 6, 2020 7:16 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang <nickle.wang@hpe.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [RedfishPkg PATCH v6 4/4] edk2: Add maintainers to RedfishPkg
>
> Signed-off-by: Chang Abner <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> Acked-by: Leif Lindholm <leif@nuviainc.com>
> ---
> Maintainers.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 6a22a14796..cabadac177 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -503,6 +503,11 @@ F: PcAtChipsetPkg/
> W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
> M: Ray Ni <ray.ni@intel.com>
>
> +RedfishPkg: Redfish related modules
> +F: RedfishPkg/
> +M: Abner Chang <abner.chang@hpe.com>
> +R: Nickle Wang <nickle.wang@hpe.com>
> +
> SecurityPkg
> F: SecurityPkg/
> W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
> --
> 2.17.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of RedfishPkg.
2020-10-07 2:15 ` [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of RedfishPkg Abner Chang
2020-10-07 9:30 ` Leif Lindholm
@ 2020-10-07 16:29 ` Michael D Kinney
2020-10-08 1:44 ` Abner Chang
[not found] ` <163BE1007D20ADD8.22371@groups.io>
1 sibling, 2 replies; 21+ messages in thread
From: Michael D Kinney @ 2020-10-07 16:29 UTC (permalink / raw)
To: Abner Chang, devel@edk2.groups.io, Kinney, Michael D
Cc: Nickle Wang, Andrew Fish, Laszlo Ersek, Leif Lindholm
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: Abner Chang <abner.chang@hpe.com>
> Sent: Tuesday, October 6, 2020 7:16 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang <nickle.wang@hpe.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of RedfishPkg.
>
> Initial version of RedfishPkg.
>
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> Signed-off-by: Wang Fan <fan.wang@intel.com>
> Signed-off-by: Chang Abner <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> ---
> RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++++++++++++++++++
> RedfishPkg/RedfishPkg.dec | 18 ++++++++++
> RedfishPkg/RedfishPkg.dsc | 40 +++++++++++++++++++++
> 3 files changed, 125 insertions(+)
> create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
> create mode 100644 RedfishPkg/RedfishPkg.dec
> create mode 100644 RedfishPkg/RedfishPkg.dsc
>
> diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml
> new file mode 100644
> index 0000000000..75c3b6a8ad
> --- /dev/null
> +++ b/RedfishPkg/RedfishPkg.ci.yaml
> @@ -0,0 +1,67 @@
> +## @file
> +# CI configuration for NetworkPkg
> +#
> +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +##
> +{
> + "LicenseCheck": {
> + "IgnoreFiles": []
> + },
> + "EccCheck": {
> + ## Exception sample looks like below:
> + ## "ExceptionList": [
> + ## "<ErrorID>", "<KeyWord>"
> + ## ]
> + "ExceptionList": [
> + ],
> + ## Both file path and directory path are accepted.
> + "IgnoreFiles": [
> + ]
> + },
> + "CompilerPlugin": {
> + "DscPath": "RedfishPkg.dsc"
> + },
> + "CharEncodingCheck": {
> + "IgnoreFiles": []
> + },
> + "DependencyCheck": {
> + "AcceptableDependencies": [
> + "MdePkg/MdePkg.dec",
> + "MdeModulePkg/MdeModulePkg.dec",
> + "NetworkPkg/NetworkPkg.dec"
> + ],
> + # For host based unit tests
> + "AcceptableDependencies-HOST_APPLICATION":[],
> + # For UEFI shell based apps
> + "AcceptableDependencies-UEFI_APPLICATION":[
> + "ShellPkg/ShellPkg.dec"
> + ],
> + "IgnoreInf": []
> + },
> + "DscCompleteCheck": {
> + "DscPath": "RedfishPkg.dsc",
> + "IgnoreInf": []
> + },
> + "GuidCheck": {
> + "IgnoreGuidName": [],
> + "IgnoreGuidValue": [],
> + "IgnoreFoldersAndFiles": []
> + },
> + "LibraryClassCheck": {
> + "IgnoreHeaderFile": []
> + },
> +
> + ## options defined ci/Plugin/SpellCheck
> + "SpellCheck": {
> + "AuditOnly": True, # Fails test but run in AuditOnly mode to collect log
> + "IgnoreFiles": [], # use gitignore syntax to ignore errors in matching files
> + "ExtendWords": [], # words to extend to the dictionary for this package
> + "IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore
> + "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
> + },
> +
> + "Defines": {
> + "BLD_*_CONTINUOUS_INTEGRATION": "TRUE"
> + }
> +}
> diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec
> new file mode 100644
> index 0000000000..e95ec5fe10
> --- /dev/null
> +++ b/RedfishPkg/RedfishPkg.dec
> @@ -0,0 +1,18 @@
> +## @file
> +# Redfish Package
> +#
> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +##
> +
> +[Defines]
> + DEC_SPECIFICATION = 0x0001001b
> + PACKAGE_NAME = RedfishPkg
> + PACKAGE_GUID = c432b76e-5232-11e7-9010-005056c00008
> + PACKAGE_VERSION = 1.0
> +
> +[Guids]
> + gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88, 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
> +
> diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
> new file mode 100644
> index 0000000000..8acadddefc
> --- /dev/null
> +++ b/RedfishPkg/RedfishPkg.dsc
> @@ -0,0 +1,40 @@
> +## @file
> +# Redfish Package
> +#
> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +# (C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +##
> +
> +[Defines]
> + PLATFORM_NAME = RedfishPkg
> + PLATFORM_GUID = c4352870-5232-11e7-9522-005056c00008
> + PLATFORM_VERSION = 1.0
> + DSC_SPECIFICATION = 0x0001001c
> + OUTPUT_DIRECTORY = Build/RedfishPkg
> + SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64|RISCV64
> + BUILD_TARGETS = DEBUG|RELEASE|NOOPT
> + SKUID_IDENTIFIER = DEFAULT
> +
> +[LibraryClasses]
> + UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> + UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
> + UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> + UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
> + UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> + MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> + DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> + BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> + SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
> + PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> + DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> + DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
> + PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPort80.inf
> + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> + PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
> + DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
> + DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> --
> 2.17.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build
[not found] ` <163B968D94C2410C.25576@groups.io>
@ 2020-10-08 0:59 ` Abner Chang
2020-10-08 1:00 ` Sean
0 siblings, 1 reply; 21+ messages in thread
From: Abner Chang @ 2020-10-08 0:59 UTC (permalink / raw)
To: devel@edk2.groups.io, Chang, Abner (HPS SW/FW Technologist)
Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao,
Wang, Nickle (HPS SW)
Hi Sean and Bret,
The v6 update for .azurepiplines is to put RedfishPkg together with Network in the TARGET_NETWORK? Is that ok RedfishPkg is involved in TARGET_NETWORK CI test? I think it should be fine right? They don't impact each other when developers are working on these two packages separately.
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Wednesday, October 7, 2020 10:16 AM
> To: devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> Subject: [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates:
> Add RedfishPkg to target build
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> ---
> .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> b/.azurepipelines/templates/pr-gate-build-job.yml
> index 2683687a1c..89c632c0a7 100644
> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> @@ -31,7 +31,7 @@ jobs:
> Build.Pkgs: 'MdeModulePkg'
> Build.Targets: 'RELEASE,NO-TARGET'
> TARGET_NETWORK:
> - Build.Pkgs: 'NetworkPkg'
> + Build.Pkgs: 'NetworkPkg,RedfishPkg'
> Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> TARGET_OTHER:
> Build.Pkgs: 'PcAtChipsetPkg,ShellPkg'
> --
> 2.17.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build
2020-10-08 0:59 ` [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
@ 2020-10-08 1:00 ` Sean
2020-10-08 1:08 ` Abner Chang
[not found] ` <163BDF0D4D469E1C.12039@groups.io>
0 siblings, 2 replies; 21+ messages in thread
From: Sean @ 2020-10-08 1:00 UTC (permalink / raw)
To: devel, abner.chang
Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao,
Wang, Nickle (HPS SW)
thats correct. The grouping in the "matrix" is just to load balance the
servers when CI/PR gates run.
On 10/7/2020 5:59 PM, Abner Chang wrote:
> Hi Sean and Bret,
> The v6 update for .azurepiplines is to put RedfishPkg together with Network in the TARGET_NETWORK? Is that ok RedfishPkg is involved in TARGET_NETWORK CI test? I think it should be fine right? They don't impact each other when developers are working on these two packages separately.
>
>> -----Original Message-----
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> Abner Chang
>> Sent: Wednesday, October 7, 2020 10:16 AM
>> To: devel@edk2.groups.io
>> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
>> <Bret.Barkelew@microsoft.com>; Michael D Kinney
>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
>> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
>> Subject: [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates:
>> Add RedfishPkg to target build
>>
>> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Nickle Wang <nickle.wang@hpe.com>
>> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
>> ---
>> .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
>> b/.azurepipelines/templates/pr-gate-build-job.yml
>> index 2683687a1c..89c632c0a7 100644
>> --- a/.azurepipelines/templates/pr-gate-build-job.yml
>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
>> @@ -31,7 +31,7 @@ jobs:
>> Build.Pkgs: 'MdeModulePkg'
>> Build.Targets: 'RELEASE,NO-TARGET'
>> TARGET_NETWORK:
>> - Build.Pkgs: 'NetworkPkg'
>> + Build.Pkgs: 'NetworkPkg,RedfishPkg'
>> Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>> TARGET_OTHER:
>> Build.Pkgs: 'PcAtChipsetPkg,ShellPkg'
>> --
>> 2.17.1
>>
>>
>>
>>
>>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build
2020-10-08 1:00 ` Sean
@ 2020-10-08 1:08 ` Abner Chang
[not found] ` <163BDF0D4D469E1C.12039@groups.io>
1 sibling, 0 replies; 21+ messages in thread
From: Abner Chang @ 2020-10-08 1:08 UTC (permalink / raw)
To: devel@edk2.groups.io, spbrogan@outlook.com
Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao,
Wang, Nickle (HPS SW)
Ok thanks for clarifying this!
I think the entire series of patch for the initial version of RedfishPkg is all good now. I will push my part (1/4) and please help to push 2/4 and 3/4, with your feedback tag is better because v6 has updates on pr-gate-build-job.yml.
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Sean
> Sent: Thursday, October 8, 2020 9:01 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v6
> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
>
> thats correct. The grouping in the "matrix" is just to load balance the servers
> when CI/PR gates run.
>
>
>
> On 10/7/2020 5:59 PM, Abner Chang wrote:
> > Hi Sean and Bret,
> > The v6 update for .azurepiplines is to put RedfishPkg together with
> Network in the TARGET_NETWORK? Is that ok RedfishPkg is involved in
> TARGET_NETWORK CI test? I think it should be fine right? They don't impact
> each other when developers are working on these two packages separately.
> >
> >> -----Original Message-----
> >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> >> Abner Chang
> >> Sent: Wednesday, October 7, 2020 10:16 AM
> >> To: devel@edk2.groups.io
> >> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> >> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> >> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> >> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> >> Subject: [edk2-devel] [RedfishPkg PATCH v6
> 3/4] .azurepipelines/templates:
> >> Add RedfishPkg to target build
> >>
> >> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >> Cc: Sean Brogan <sean.brogan@microsoft.com>
> >> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> >> Cc: Nickle Wang <nickle.wang@hpe.com>
> >> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >> ---
> >> .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> >> b/.azurepipelines/templates/pr-gate-build-job.yml
> >> index 2683687a1c..89c632c0a7 100644
> >> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> >> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> >> @@ -31,7 +31,7 @@ jobs:
> >> Build.Pkgs: 'MdeModulePkg'
> >> Build.Targets: 'RELEASE,NO-TARGET'
> >> TARGET_NETWORK:
> >> - Build.Pkgs: 'NetworkPkg'
> >> + Build.Pkgs: 'NetworkPkg,RedfishPkg'
> >> Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >> TARGET_OTHER:
> >> Build.Pkgs: 'PcAtChipsetPkg,ShellPkg'
> >> --
> >> 2.17.1
> >>
> >>
> >>
> >>
> >>
> >
> >
> >
> >
> >
> >
>
>
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of RedfishPkg.
2020-10-07 16:29 ` Michael D Kinney
@ 2020-10-08 1:44 ` Abner Chang
[not found] ` <163BE1007D20ADD8.22371@groups.io>
1 sibling, 0 replies; 21+ messages in thread
From: Abner Chang @ 2020-10-08 1:44 UTC (permalink / raw)
To: Kinney, Michael D, devel@edk2.groups.io
Cc: Wang, Nickle (HPS SW), Andrew Fish, Laszlo Ersek, Leif Lindholm
I don’t think I should merge this patch to edk2 by my own. Mike or Laszlo could any of your merge it. Thanks
Leif also gave feedback tag on this patch by the way.
> -----Original Message-----
> From: Kinney, Michael D [mailto:michael.d.kinney@intel.com]
> Sent: Thursday, October 8, 2020 12:29 AM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Andrew Fish
> <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> <leif@nuviainc.com>
> Subject: RE: [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of
> RedfishPkg.
>
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> > -----Original Message-----
> > From: Abner Chang <abner.chang@hpe.com>
> > Sent: Tuesday, October 6, 2020 7:16 PM
> > To: devel@edk2.groups.io
> > Cc: Nickle Wang <nickle.wang@hpe.com>; Andrew Fish
> <afish@apple.com>;
> > Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>;
> > Kinney, Michael D <michael.d.kinney@intel.com>
> > Subject: [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of
> RedfishPkg.
> >
> > Initial version of RedfishPkg.
> >
> > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> > Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> > Signed-off-by: Wang Fan <fan.wang@intel.com>
> > Signed-off-by: Chang Abner <abner.chang@hpe.com>
> > Cc: Nickle Wang <nickle.wang@hpe.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Acked-by: Laszlo Ersek <lersek@redhat.com>
> > ---
> > RedfishPkg/RedfishPkg.ci.yaml | 67
> +++++++++++++++++++++++++++++++++++
> > RedfishPkg/RedfishPkg.dec | 18 ++++++++++
> > RedfishPkg/RedfishPkg.dsc | 40 +++++++++++++++++++++
> > 3 files changed, 125 insertions(+)
> > create mode 100644 RedfishPkg/RedfishPkg.ci.yaml create mode 100644
> > RedfishPkg/RedfishPkg.dec create mode 100644
> > RedfishPkg/RedfishPkg.dsc
> >
> > diff --git a/RedfishPkg/RedfishPkg.ci.yaml
> > b/RedfishPkg/RedfishPkg.ci.yaml new file mode 100644 index
> > 0000000000..75c3b6a8ad
> > --- /dev/null
> > +++ b/RedfishPkg/RedfishPkg.ci.yaml
> > @@ -0,0 +1,67 @@
> > +## @file
> > +# CI configuration for NetworkPkg
> > +#
> > +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR> #
> > +SPDX-License-Identifier: BSD-2-Clause-Patent ## {
> > + "LicenseCheck": {
> > + "IgnoreFiles": []
> > + },
> > + "EccCheck": {
> > + ## Exception sample looks like below:
> > + ## "ExceptionList": [
> > + ## "<ErrorID>", "<KeyWord>"
> > + ## ]
> > + "ExceptionList": [
> > + ],
> > + ## Both file path and directory path are accepted.
> > + "IgnoreFiles": [
> > + ]
> > + },
> > + "CompilerPlugin": {
> > + "DscPath": "RedfishPkg.dsc"
> > + },
> > + "CharEncodingCheck": {
> > + "IgnoreFiles": []
> > + },
> > + "DependencyCheck": {
> > + "AcceptableDependencies": [
> > + "MdePkg/MdePkg.dec",
> > + "MdeModulePkg/MdeModulePkg.dec",
> > + "NetworkPkg/NetworkPkg.dec"
> > + ],
> > + # For host based unit tests
> > + "AcceptableDependencies-HOST_APPLICATION":[],
> > + # For UEFI shell based apps
> > + "AcceptableDependencies-UEFI_APPLICATION":[
> > + "ShellPkg/ShellPkg.dec"
> > + ],
> > + "IgnoreInf": []
> > + },
> > + "DscCompleteCheck": {
> > + "DscPath": "RedfishPkg.dsc",
> > + "IgnoreInf": []
> > + },
> > + "GuidCheck": {
> > + "IgnoreGuidName": [],
> > + "IgnoreGuidValue": [],
> > + "IgnoreFoldersAndFiles": []
> > + },
> > + "LibraryClassCheck": {
> > + "IgnoreHeaderFile": []
> > + },
> > +
> > + ## options defined ci/Plugin/SpellCheck
> > + "SpellCheck": {
> > + "AuditOnly": True, # Fails test but run in AuditOnly mode to
> collect log
> > + "IgnoreFiles": [], # use gitignore syntax to ignore errors in
> matching files
> > + "ExtendWords": [], # words to extend to the dictionary for this
> package
> > + "IgnoreStandardPaths": [], # Standard Plugin defined paths that
> should be ignore
> > + "AdditionalIncludePaths": [] # Additional paths to spell check
> (wildcards supported)
> > + },
> > +
> > + "Defines": {
> > + "BLD_*_CONTINUOUS_INTEGRATION": "TRUE"
> > + }
> > +}
> > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec new
> > file mode 100644 index 0000000000..e95ec5fe10
> > --- /dev/null
> > +++ b/RedfishPkg/RedfishPkg.dec
> > @@ -0,0 +1,18 @@
> > +## @file
> > +# Redfish Package
> > +#
> > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > +(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR> # #
> > +SPDX-License-Identifier: BSD-2-Clause-Patent ##
> > +
> > +[Defines]
> > + DEC_SPECIFICATION = 0x0001001b
> > + PACKAGE_NAME = RedfishPkg
> > + PACKAGE_GUID = c432b76e-5232-11e7-9010-005056c00008
> > + PACKAGE_VERSION = 1.0
> > +
> > +[Guids]
> > + gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88,
> 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
> > +
> > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new
> > file mode 100644 index 0000000000..8acadddefc
> > --- /dev/null
> > +++ b/RedfishPkg/RedfishPkg.dsc
> > @@ -0,0 +1,40 @@
> > +## @file
> > +# Redfish Package
> > +#
> > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
> > +#
> > +# SPDX-License-Identifier: BSD-2-Clause-Patent
> > +#
> > +##
> > +
> > +[Defines]
> > + PLATFORM_NAME = RedfishPkg
> > + PLATFORM_GUID = c4352870-5232-11e7-9522-005056c00008
> > + PLATFORM_VERSION = 1.0
> > + DSC_SPECIFICATION = 0x0001001c
> > + OUTPUT_DIRECTORY = Build/RedfishPkg
> > + SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64|RISCV64
> > + BUILD_TARGETS = DEBUG|RELEASE|NOOPT
> > + SKUID_IDENTIFIER = DEFAULT
> > +
> > +[LibraryClasses]
> > +
> > +UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEn
> > +tryPoint.inf
> > +
> >
> +UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/Uefi
> > +BootServicesTableLib.inf
> > + UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> > +
> >
> +UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLi
> > +b/UefiRuntimeServicesTableLib.inf
> > + UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> > +
> >
> +MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMem
> ory
> > +AllocationLib.inf
> > +
> > +DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > + BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> > + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> > +
> >
> +SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchron
> > +izationLib.inf
> > + PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> > + DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> > +
> >
> +DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Ba
> > +seDebugPrintErrorLevelLib.inf
> > +
> >
> +PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPo
> rt8
> > +0.inf
> > + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> > +
> >
> +PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Bas
> e
> > +PeCoffGetEntryPointLib.inf
> > +
> >
> +DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTab
> > +leLib.inf
> > + DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> > +
> >
> +ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/D
> xeRe
> > +portStatusCodeLib.inf
> > --
> > 2.17.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build
[not found] ` <163BDF0D4D469E1C.12039@groups.io>
@ 2020-10-08 3:56 ` Abner Chang
2020-10-14 13:30 ` Abner Chang
[not found] ` <163DDF075C4BB2E8.14646@groups.io>
0 siblings, 2 replies; 21+ messages in thread
From: Abner Chang @ 2020-10-08 3:56 UTC (permalink / raw)
To: devel@edk2.groups.io, Chang, Abner (HPS SW/FW Technologist),
spbrogan@outlook.com
Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao,
Wang, Nickle (HPS SW), Laszlo Ersek, Leif Lindholm
Add Laszlo and Leif to aware of this conversation.
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Thursday, October 8, 2020 9:09 AM
> To: devel@edk2.groups.io; spbrogan@outlook.com
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v6
> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
>
> Ok thanks for clarifying this!
>
> I think the entire series of patch for the initial version of RedfishPkg is all
> good now. I will push my part (1/4) and please help to push 2/4 and 3/4, with
> your feedback tag is better because v6 has updates on pr-gate-build-job.yml.
>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Sean
> > Sent: Thursday, October 8, 2020 9:01 AM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang@hpe.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> > Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 3/4]
> > .azurepipelines/templates: Add RedfishPkg to target build
> >
> > thats correct. The grouping in the "matrix" is just to load balance
> > the servers when CI/PR gates run.
> >
> >
> >
> > On 10/7/2020 5:59 PM, Abner Chang wrote:
> > > Hi Sean and Bret,
> > > The v6 update for .azurepiplines is to put RedfishPkg together with
> > Network in the TARGET_NETWORK? Is that ok RedfishPkg is involved in
> > TARGET_NETWORK CI test? I think it should be fine right? They don't
> > impact each other when developers are working on these two packages
> separately.
> > >
> > >> -----Original Message-----
> > >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > >> Of Abner Chang
> > >> Sent: Wednesday, October 7, 2020 10:16 AM
> > >> To: devel@edk2.groups.io
> > >> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > >> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > >> <michael.d.kinney@intel.com>; Liming Gao
> > >> <gaoliming@byosoft.com.cn>; Wang, Nickle (HPS SW)
> > >> <nickle.wang@hpe.com>
> > >> Subject: [edk2-devel] [RedfishPkg PATCH v6
> > 3/4] .azurepipelines/templates:
> > >> Add RedfishPkg to target build
> > >>
> > >> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > >> Cc: Sean Brogan <sean.brogan@microsoft.com>
> > >> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > >> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > >> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > >> Cc: Nickle Wang <nickle.wang@hpe.com>
> > >> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > >> ---
> > >> .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > >> b/.azurepipelines/templates/pr-gate-build-job.yml
> > >> index 2683687a1c..89c632c0a7 100644
> > >> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > >> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > >> @@ -31,7 +31,7 @@ jobs:
> > >> Build.Pkgs: 'MdeModulePkg'
> > >> Build.Targets: 'RELEASE,NO-TARGET'
> > >> TARGET_NETWORK:
> > >> - Build.Pkgs: 'NetworkPkg'
> > >> + Build.Pkgs: 'NetworkPkg,RedfishPkg'
> > >> Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > >> TARGET_OTHER:
> > >> Build.Pkgs: 'PcAtChipsetPkg,ShellPkg'
> > >> --
> > >> 2.17.1
> > >>
> > >>
> > >>
> > >>
> > >>
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of RedfishPkg.
[not found] ` <163BE1007D20ADD8.22371@groups.io>
@ 2020-10-08 12:58 ` Abner Chang
0 siblings, 0 replies; 21+ messages in thread
From: Abner Chang @ 2020-10-08 12:58 UTC (permalink / raw)
To: devel@edk2.groups.io, Chang, Abner (HPS SW/FW Technologist),
Kinney, Michael D
Cc: Wang, Nickle (HPS SW), Andrew Fish, Laszlo Ersek, Leif Lindholm,
Bret Barkelew, Sean Brogan
Please ignore this. I was original thought I am not the maintainer of edk2 root.
But as Laszlo mentioned in previous email,
>>>Andrew, Leif, Mike: please check patches #1 and #4.
>>>I'd like to have at least one other ACK on those, and then (I think) Abner can merge the series himself.
Thus, I will merge 1/4 (RedfishPkg) and 4/4 (Maintainers.txt) together to make it consistent, but still leave the merge of 2/4 and 3/4 to Sean and Bret.
Thanks
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Thursday, October 8, 2020 9:45 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
> Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Andrew Fish
> <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> <leif@nuviainc.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial
> commit of RedfishPkg.
>
> I don’t think I should merge this patch to edk2 by my own. Mike or Laszlo
> could any of your merge it. Thanks Leif also gave feedback tag on this patch
> by the way.
>
>
> > -----Original Message-----
> > From: Kinney, Michael D [mailto:michael.d.kinney@intel.com]
> > Sent: Thursday, October 8, 2020 12:29 AM
> > To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> > devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> > Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Andrew Fish
> > <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm
> > <leif@nuviainc.com>
> > Subject: RE: [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of
> > RedfishPkg.
> >
> > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > > -----Original Message-----
> > > From: Abner Chang <abner.chang@hpe.com>
> > > Sent: Tuesday, October 6, 2020 7:16 PM
> > > To: devel@edk2.groups.io
> > > Cc: Nickle Wang <nickle.wang@hpe.com>; Andrew Fish
> > <afish@apple.com>;
> > > Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>;
> > > Kinney, Michael D <michael.d.kinney@intel.com>
> > > Subject: [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of
> > RedfishPkg.
> > >
> > > Initial version of RedfishPkg.
> > >
> > > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> > > Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> > > Signed-off-by: Wang Fan <fan.wang@intel.com>
> > > Signed-off-by: Chang Abner <abner.chang@hpe.com>
> > > Cc: Nickle Wang <nickle.wang@hpe.com>
> > > Cc: Andrew Fish <afish@apple.com>
> > > Cc: Laszlo Ersek <lersek@redhat.com>
> > > Cc: Leif Lindholm <leif@nuviainc.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Acked-by: Laszlo Ersek <lersek@redhat.com>
> > > ---
> > > RedfishPkg/RedfishPkg.ci.yaml | 67
> > +++++++++++++++++++++++++++++++++++
> > > RedfishPkg/RedfishPkg.dec | 18 ++++++++++
> > > RedfishPkg/RedfishPkg.dsc | 40 +++++++++++++++++++++
> > > 3 files changed, 125 insertions(+)
> > > create mode 100644 RedfishPkg/RedfishPkg.ci.yaml create mode
> > > 100644 RedfishPkg/RedfishPkg.dec create mode 100644
> > > RedfishPkg/RedfishPkg.dsc
> > >
> > > diff --git a/RedfishPkg/RedfishPkg.ci.yaml
> > > b/RedfishPkg/RedfishPkg.ci.yaml new file mode 100644 index
> > > 0000000000..75c3b6a8ad
> > > --- /dev/null
> > > +++ b/RedfishPkg/RedfishPkg.ci.yaml
> > > @@ -0,0 +1,67 @@
> > > +## @file
> > > +# CI configuration for NetworkPkg
> > > +#
> > > +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> > > +#
> > > +SPDX-License-Identifier: BSD-2-Clause-Patent ## {
> > > + "LicenseCheck": {
> > > + "IgnoreFiles": []
> > > + },
> > > + "EccCheck": {
> > > + ## Exception sample looks like below:
> > > + ## "ExceptionList": [
> > > + ## "<ErrorID>", "<KeyWord>"
> > > + ## ]
> > > + "ExceptionList": [
> > > + ],
> > > + ## Both file path and directory path are accepted.
> > > + "IgnoreFiles": [
> > > + ]
> > > + },
> > > + "CompilerPlugin": {
> > > + "DscPath": "RedfishPkg.dsc"
> > > + },
> > > + "CharEncodingCheck": {
> > > + "IgnoreFiles": []
> > > + },
> > > + "DependencyCheck": {
> > > + "AcceptableDependencies": [
> > > + "MdePkg/MdePkg.dec",
> > > + "MdeModulePkg/MdeModulePkg.dec",
> > > + "NetworkPkg/NetworkPkg.dec"
> > > + ],
> > > + # For host based unit tests
> > > + "AcceptableDependencies-HOST_APPLICATION":[],
> > > + # For UEFI shell based apps
> > > + "AcceptableDependencies-UEFI_APPLICATION":[
> > > + "ShellPkg/ShellPkg.dec"
> > > + ],
> > > + "IgnoreInf": []
> > > + },
> > > + "DscCompleteCheck": {
> > > + "DscPath": "RedfishPkg.dsc",
> > > + "IgnoreInf": []
> > > + },
> > > + "GuidCheck": {
> > > + "IgnoreGuidName": [],
> > > + "IgnoreGuidValue": [],
> > > + "IgnoreFoldersAndFiles": []
> > > + },
> > > + "LibraryClassCheck": {
> > > + "IgnoreHeaderFile": []
> > > + },
> > > +
> > > + ## options defined ci/Plugin/SpellCheck
> > > + "SpellCheck": {
> > > + "AuditOnly": True, # Fails test but run in AuditOnly mode to
> > collect log
> > > + "IgnoreFiles": [], # use gitignore syntax to ignore errors in
> > matching files
> > > + "ExtendWords": [], # words to extend to the dictionary for this
> > package
> > > + "IgnoreStandardPaths": [], # Standard Plugin defined paths that
> > should be ignore
> > > + "AdditionalIncludePaths": [] # Additional paths to spell
> > > + check
> > (wildcards supported)
> > > + },
> > > +
> > > + "Defines": {
> > > + "BLD_*_CONTINUOUS_INTEGRATION": "TRUE"
> > > + }
> > > +}
> > > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec
> > > new file mode 100644 index 0000000000..e95ec5fe10
> > > --- /dev/null
> > > +++ b/RedfishPkg/RedfishPkg.dec
> > > @@ -0,0 +1,18 @@
> > > +## @file
> > > +# Redfish Package
> > > +#
> > > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > > +(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR> #
> > > +#
> > > +SPDX-License-Identifier: BSD-2-Clause-Patent ##
> > > +
> > > +[Defines]
> > > + DEC_SPECIFICATION = 0x0001001b
> > > + PACKAGE_NAME = RedfishPkg
> > > + PACKAGE_GUID = c432b76e-5232-11e7-9010-005056c00008
> > > + PACKAGE_VERSION = 1.0
> > > +
> > > +[Guids]
> > > + gEfiRedfishPkgTokenSpaceGuid = { 0x4fdbccb7, 0xe829, 0x4b4c,
> { 0x88,
> > 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
> > > +
> > > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
> > > new file mode 100644 index 0000000000..8acadddefc
> > > --- /dev/null
> > > +++ b/RedfishPkg/RedfishPkg.dsc
> > > @@ -0,0 +1,40 @@
> > > +## @file
> > > +# Redfish Package
> > > +#
> > > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > > +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
> > > +#
> > > +# SPDX-License-Identifier: BSD-2-Clause-Patent
> > > +#
> > > +##
> > > +
> > > +[Defines]
> > > + PLATFORM_NAME = RedfishPkg
> > > + PLATFORM_GUID = c4352870-5232-11e7-9522-005056c00008
> > > + PLATFORM_VERSION = 1.0
> > > + DSC_SPECIFICATION = 0x0001001c
> > > + OUTPUT_DIRECTORY = Build/RedfishPkg
> > > + SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64|RISCV64
> > > + BUILD_TARGETS = DEBUG|RELEASE|NOOPT
> > > + SKUID_IDENTIFIER = DEFAULT
> > > +
> > > +[LibraryClasses]
> > > +
> > > +UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriver
> > > +UefiDriverEntryPoint|En
> > > +tryPoint.inf
> > > +
> > >
> >
> +UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/Uefi
> > > +BootServicesTableLib.inf
> > > + UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> > > +
> > >
> >
> +UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLi
> > > +b/UefiRuntimeServicesTableLib.inf
> > > + UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> > > +
> > >
> >
> +MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMem
> > ory
> > > +AllocationLib.inf
> > > +
> > >
> +DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.in
> > > +DevicePathLib|f
> > > + BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> > > + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> > > +
> > >
> >
> +SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchron
> > > +izationLib.inf
> > > + PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> > > + DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> > > +
> > >
> >
> +DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Ba
> > > +seDebugPrintErrorLevelLib.inf
> > > +
> > >
> >
> +PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPo
> > rt8
> > > +0.inf
> > > + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> > > +
> > >
> >
> +PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Bas
> > e
> > > +PeCoffGetEntryPointLib.inf
> > > +
> > >
> >
> +DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTab
> > > +leLib.inf
> > > + DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> > > +
> > >
> >
> +ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/D
> > xeRe
> > > +portStatusCodeLib.inf
> > > --
> > > 2.17.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build
2020-10-08 3:56 ` Abner Chang
@ 2020-10-14 13:30 ` Abner Chang
[not found] ` <163DDF075C4BB2E8.14646@groups.io>
1 sibling, 0 replies; 21+ messages in thread
From: Abner Chang @ 2020-10-14 13:30 UTC (permalink / raw)
To: devel@edk2.groups.io, spbrogan@outlook.com
Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao,
Wang, Nickle (HPS SW), Laszlo Ersek, Leif Lindholm
Hi Sean and Bret,
I picked up patch 2/4 and 3/4 from v6 and created a PR. https://github.com/tianocore/edk2/pull/1013
Are you able to take a look and set Push label to merge it? However the PR was closed.
Thanks
Abner
> -----Original Message-----
> From: Chang, Abner (HPS SW/FW Technologist)
> Sent: Thursday, October 8, 2020 11:57 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>; spbrogan@outlook.com
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Laszlo Ersek
> <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>
> Subject: RE: [edk2-devel] [RedfishPkg PATCH v6
> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
>
> Add Laszlo and Leif to aware of this conversation.
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Abner Chang
> > Sent: Thursday, October 8, 2020 9:09 AM
> > To: devel@edk2.groups.io; spbrogan@outlook.com
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> > Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 3/4]
> > .azurepipelines/templates: Add RedfishPkg to target build
> >
> > Ok thanks for clarifying this!
> >
> > I think the entire series of patch for the initial version of
> > RedfishPkg is all good now. I will push my part (1/4) and please help
> > to push 2/4 and 3/4, with your feedback tag is better because v6 has
> updates on pr-gate-build-job.yml.
> >
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > > Of Sean
> > > Sent: Thursday, October 8, 2020 9:01 AM
> > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > > <abner.chang@hpe.com>
> > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > > <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > > <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>;
> > > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> > > Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 3/4]
> > > .azurepipelines/templates: Add RedfishPkg to target build
> > >
> > > thats correct. The grouping in the "matrix" is just to load balance
> > > the servers when CI/PR gates run.
> > >
> > >
> > >
> > > On 10/7/2020 5:59 PM, Abner Chang wrote:
> > > > Hi Sean and Bret,
> > > > The v6 update for .azurepiplines is to put RedfishPkg together
> > > > with
> > > Network in the TARGET_NETWORK? Is that ok RedfishPkg is involved in
> > > TARGET_NETWORK CI test? I think it should be fine right? They don't
> > > impact each other when developers are working on these two packages
> > separately.
> > > >
> > > >> -----Original Message-----
> > > >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On
> > > >> Behalf Of Abner Chang
> > > >> Sent: Wednesday, October 7, 2020 10:16 AM
> > > >> To: devel@edk2.groups.io
> > > >> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > > >> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > > >> <michael.d.kinney@intel.com>; Liming Gao
> > > >> <gaoliming@byosoft.com.cn>; Wang, Nickle (HPS SW)
> > > >> <nickle.wang@hpe.com>
> > > >> Subject: [edk2-devel] [RedfishPkg PATCH v6
> > > 3/4] .azurepipelines/templates:
> > > >> Add RedfishPkg to target build
> > > >>
> > > >> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > > >> Cc: Sean Brogan <sean.brogan@microsoft.com>
> > > >> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > >> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > >> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > >> Cc: Nickle Wang <nickle.wang@hpe.com>
> > > >> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > >> ---
> > > >> .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
> > > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >>
> > > >> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > > >> b/.azurepipelines/templates/pr-gate-build-job.yml
> > > >> index 2683687a1c..89c632c0a7 100644
> > > >> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > > >> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > > >> @@ -31,7 +31,7 @@ jobs:
> > > >> Build.Pkgs: 'MdeModulePkg'
> > > >> Build.Targets: 'RELEASE,NO-TARGET'
> > > >> TARGET_NETWORK:
> > > >> - Build.Pkgs: 'NetworkPkg'
> > > >> + Build.Pkgs: 'NetworkPkg,RedfishPkg'
> > > >> Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > > >> TARGET_OTHER:
> > > >> Build.Pkgs: 'PcAtChipsetPkg,ShellPkg'
> > > >> --
> > > >> 2.17.1
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build
[not found] ` <163DDF075C4BB2E8.14646@groups.io>
@ 2020-10-15 1:19 ` Abner Chang
0 siblings, 0 replies; 21+ messages in thread
From: Abner Chang @ 2020-10-15 1:19 UTC (permalink / raw)
To: devel@edk2.groups.io, Chang, Abner (HPS SW/FW Technologist),
spbrogan@outlook.com
Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao,
Wang, Nickle (HPS SW), Laszlo Ersek, Leif Lindholm
Just learned that from Liming, one of the maintainers can just create PR for the reviewed-by patch set and merge the patches even he/she is just one of maintainers in that set of patches.
I will recreate a PR those this two CI changes and merge it.
Thanks
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Wednesday, October 14, 2020 9:31 PM
> To: devel@edk2.groups.io; spbrogan@outlook.com
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Laszlo Ersek
> <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v6
> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
>
> Hi Sean and Bret,
> I picked up patch 2/4 and 3/4 from v6 and created a PR.
> https://github.com/tianocore/edk2/pull/1013
> Are you able to take a look and set Push label to merge it? However the PR
> was closed.
>
> Thanks
> Abner
>
>
> > -----Original Message-----
> > From: Chang, Abner (HPS SW/FW Technologist)
> > Sent: Thursday, October 8, 2020 11:57 AM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang@hpe.com>; spbrogan@outlook.com
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Laszlo Ersek
> > <lersek@redhat.com>; Leif Lindholm <leif@nuviainc.com>
> > Subject: RE: [edk2-devel] [RedfishPkg PATCH v6 3/4]
> > .azurepipelines/templates: Add RedfishPkg to target build
> >
> > Add Laszlo and Leif to aware of this conversation.
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > > Of Abner Chang
> > > Sent: Thursday, October 8, 2020 9:09 AM
> > > To: devel@edk2.groups.io; spbrogan@outlook.com
> > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > > <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > > <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>;
> > > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> > > Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 3/4]
> > > .azurepipelines/templates: Add RedfishPkg to target build
> > >
> > > Ok thanks for clarifying this!
> > >
> > > I think the entire series of patch for the initial version of
> > > RedfishPkg is all good now. I will push my part (1/4) and please
> > > help to push 2/4 and 3/4, with your feedback tag is better because
> > > v6 has
> > updates on pr-gate-build-job.yml.
> > >
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > > > Of Sean
> > > > Sent: Thursday, October 8, 2020 9:01 AM
> > > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > > > <abner.chang@hpe.com>
> > > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > > > <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > > > <michael.d.kinney@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>;
> > > > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> > > > Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 3/4]
> > > > .azurepipelines/templates: Add RedfishPkg to target build
> > > >
> > > > thats correct. The grouping in the "matrix" is just to load
> > > > balance the servers when CI/PR gates run.
> > > >
> > > >
> > > >
> > > > On 10/7/2020 5:59 PM, Abner Chang wrote:
> > > > > Hi Sean and Bret,
> > > > > The v6 update for .azurepiplines is to put RedfishPkg together
> > > > > with
> > > > Network in the TARGET_NETWORK? Is that ok RedfishPkg is involved
> > > > in TARGET_NETWORK CI test? I think it should be fine right? They
> > > > don't impact each other when developers are working on these two
> > > > packages
> > > separately.
> > > > >
> > > > >> -----Original Message-----
> > > > >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On
> > > > >> Behalf Of Abner Chang
> > > > >> Sent: Wednesday, October 7, 2020 10:16 AM
> > > > >> To: devel@edk2.groups.io
> > > > >> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > > > >> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > > > >> <michael.d.kinney@intel.com>; Liming Gao
> > > > >> <gaoliming@byosoft.com.cn>; Wang, Nickle (HPS SW)
> > > > >> <nickle.wang@hpe.com>
> > > > >> Subject: [edk2-devel] [RedfishPkg PATCH v6
> > > > 3/4] .azurepipelines/templates:
> > > > >> Add RedfishPkg to target build
> > > > >>
> > > > >> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > > > >> Cc: Sean Brogan <sean.brogan@microsoft.com>
> > > > >> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > > >> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > >> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > > >> Cc: Nickle Wang <nickle.wang@hpe.com>
> > > > >> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > > >> ---
> > > > >> .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
> > > > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >>
> > > > >> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > > > >> b/.azurepipelines/templates/pr-gate-build-job.yml
> > > > >> index 2683687a1c..89c632c0a7 100644
> > > > >> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > > > >> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > > > >> @@ -31,7 +31,7 @@ jobs:
> > > > >> Build.Pkgs: 'MdeModulePkg'
> > > > >> Build.Targets: 'RELEASE,NO-TARGET'
> > > > >> TARGET_NETWORK:
> > > > >> - Build.Pkgs: 'NetworkPkg'
> > > > >> + Build.Pkgs: 'NetworkPkg,RedfishPkg'
> > > > >> Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > > > >> TARGET_OTHER:
> > > > >> Build.Pkgs: 'PcAtChipsetPkg,ShellPkg'
> > > > >> --
> > > > >> 2.17.1
> > > > >>
> > > > >>
> > > > >>
> > > > >>
> > > > >>
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
>
>
>
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2020-10-15 1:19 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-07 2:15 [RedfishPkg PATCH v6 0/4] Inital RedfishPkg Abner Chang
2020-10-07 2:15 ` [RedfishPkg PATCH v6 1/4] RedfishPkg: Initial commit of RedfishPkg Abner Chang
2020-10-07 9:30 ` Leif Lindholm
2020-10-07 16:29 ` Michael D Kinney
2020-10-08 1:44 ` Abner Chang
[not found] ` <163BE1007D20ADD8.22371@groups.io>
2020-10-08 12:58 ` [edk2-devel] " Abner Chang
2020-10-07 2:15 ` [RedfishPkg PATCH v6 2/4] .pytool: Add CI on RedfishPkg Abner Chang
2020-10-07 2:15 ` [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
2020-10-07 10:54 ` [edk2-devel] " Laszlo Ersek
2020-10-07 2:15 ` [RedfishPkg PATCH v6 4/4] edk2: Add maintainers to RedfishPkg Abner Chang
2020-10-07 16:28 ` [edk2-devel] " Michael D Kinney
2020-10-07 10:49 ` [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg Laszlo Ersek
2020-10-07 11:23 ` Abner Chang
2020-10-07 15:00 ` Abner Chang
2020-10-07 15:48 ` Laszlo Ersek
[not found] ` <163B968D94C2410C.25576@groups.io>
2020-10-08 0:59 ` [edk2-devel] [RedfishPkg PATCH v6 3/4] .azurepipelines/templates: Add RedfishPkg to target build Abner Chang
2020-10-08 1:00 ` Sean
2020-10-08 1:08 ` Abner Chang
[not found] ` <163BDF0D4D469E1C.12039@groups.io>
2020-10-08 3:56 ` Abner Chang
2020-10-14 13:30 ` Abner Chang
[not found] ` <163DDF075C4BB2E8.14646@groups.io>
2020-10-15 1:19 ` Abner Chang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox