From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web12.10298.1604478044992942391 for ; Wed, 04 Nov 2020 00:20:45 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=h1EsaSpb; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=057768be5f=abner.chang@hpe.com) Received: from pps.filterd (m0148663.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0A48Cwef015593 for ; Wed, 4 Nov 2020 08:20:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=CvWH0T2jkQMhOmQnuoGeWjfYT7lsGAeG6q6w2ariIZQ=; b=h1EsaSpbe3D7W/14rxp2WETDrtSJz4E4RIPyS7gcj7C1sWIQ93+uU8QxynUoqcYS6G+X r/+JtNRf7NyEp+VZbcMSw1mgQbY8qw6GvBVAqaJ0bC+ep6ysKsQmBoYzeLF4OB8qqEIZ vDi/kVZXsn2F2jnlJrtuIJFDEkCJrjjwMl7QzUcQFVxn0gMzAq/QG0HXWSBaaCujy3HB Pcu5/l6RzuOD3EMeZlZgMF7KSklBCiZUUDDnmckxUp5Aw7VbgNYngyLlowyb7U+ZTpCY TQ/qdWcCjjgKqRcIthir8r526gQGigKNdQjeW0mzSn5kftjnBV1BT2av4QzOcUD8QfoP KA== Received: from g2t2353.austin.hpe.com (g2t2353.austin.hpe.com [15.233.44.26]) by mx0a-002e3701.pphosted.com with ESMTP id 34k9ca6vx4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 04 Nov 2020 08:20:44 +0000 Received: from G2W6310.americas.hpqcorp.net (g2w6310.austin.hp.com [16.197.64.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2353.austin.hpe.com (Postfix) with ESMTPS id 556268C for ; Wed, 4 Nov 2020 08:20:43 +0000 (UTC) Received: from G4W9119.americas.hpqcorp.net (2002:10d2:14d6::10d2:14d6) by G2W6310.americas.hpqcorp.net (2002:10c5:4034::10c5:4034) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 4 Nov 2020 08:20:43 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (15.241.52.11) by G4W9119.americas.hpqcorp.net (16.210.20.214) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 4 Nov 2020 08:20:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZMN56y6Mq4NVF4FxaxMwKlcvCQace77F/xQz4RYCjEbXclH3WIs9sWIGwT5LgK3tQ2GlnguceZS/VgoZw7oXSWxkHhLcrJe/MWuk4Jqr6CGQ/iSkSf1yEcJWMeRG2J2KtzBt/GjVGJr90CPh5ut+7uvh7QisOm/GSf00s2KWDqrLJhpv9Ewl2C9GEf3HsXA991N05/+iOftAgk9UYys7VJeWPC/vPNCsoVt8a5kdMnb+xgwv6+0YIC0Df+wfjbegSQ/uNn1Xo+ViPgLjNEH+JHy296z1qcVMfrkjP1Wieq/XfoRsOlP/VdQ9pfLcTvgcnsLHTiOwtRqqO2K/ZKQf7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TKdxxes6gMTIc71GB3apAJXa+36alGOgebxDYdSXwrw=; b=JZeKbCBCSYcnDi/q2JBnE9tNzP2w9IyudOGXDf9JI5upXbIJoVcUSJDOZCwo63XQaMLdqUaSpoOJceBnyRmEYGvkoaom0TUjdshL4tSvCux7vgL17HHIYcwF/wqHjqGuFVvsiKdZkDp/ONnYwFslL6aBZAuI1QFilxkeCBUmrHvoxz6iL4aSTQ+UKXDNHCPi0YKrD51QEZMv7u2UKQs9F9meuZDunY+3+tzYIkyEFEWAPqF0SLomOMKnZM9ja7sStt2HIXejrN8X1jMCDmPDQyoALQq5zGMu2Jurt53xpM+D6DDbaP9EAGGKuIHEgQXpHmjWjZL9uqwRKDeO5tU6Cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB1141.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:750a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.29; Wed, 4 Nov 2020 08:20:41 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::f4a5:2722:be1c:7222]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::f4a5:2722:be1c:7222%6]) with mapi id 15.20.3499.032; Wed, 4 Nov 2020 08:20:41 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "Chang, Abner (HPS SW/FW Technologist)" CC: 'Dandan Bi' , 'Eric Dong' , "Gao, Liming" Subject: Re: [edk2-devel] [VFR support REST_STYLE PATCH v3 3/4] MdeModulePkg/Library: Revise HiiLib to support REST_STYLE Thread-Topic: [edk2-devel] [VFR support REST_STYLE PATCH v3 3/4] MdeModulePkg/Library: Revise HiiLib to support REST_STYLE Thread-Index: AQHWsnsskx3+rVMQTUW++cSSG9x62am3oO+w Date: Wed, 4 Nov 2020 08:20:41 +0000 Message-ID: References: <20201104063557.22857-1-abner.chang@hpe.com> <16443D0E1EA9DC18.19640@groups.io> In-Reply-To: <16443D0E1EA9DC18.19640@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=hpe.com; x-originating-ip: [1.34.113.40] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b753d952-fac1-45e2-b590-08d8809a84c8 x-ms-traffictypediagnostic: CS1PR8401MB1141: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:44; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UddLnGrqxeqHiQN6Bl9KJ2PrlmpcBKhCwSdXHAhHEvz0U/LNE4jVBfhAnBwC78dGOEccqFKz6AVTQZZAmF9U9ZrxHO02UiPuy1IdVKlCxW/Rnx8e1Vr/0/1Tl2vd2N/IFo6tsnrBGEBK0V21HSIcy6jCp73FjrTMvAOy8vpqDCqOb8izJL34qoGLasyObKmf6YLO/gDH5s3PWm4LxnnKvcdo3Edp+8CaF6f/lyLOKNTNHyq+cUaSB5DdKff4PIewXZyVrZNjgsB62TK9V5Q6AWv7MKzM5PUXwMvSVyuKA0iA9+/VW99a0yHhoi/67HWHuv+CwftQKnuvU+rkUxBDwc+9GVcaDYy/5XFyrPbi71OH6/JDI5WcvXOw/O++8lAXK9pQi0mkusEEyeps4eG4rw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(396003)(136003)(376002)(366004)(39860400002)(346002)(5660300002)(55016002)(86362001)(8936002)(19627235002)(478600001)(9686003)(83380400001)(52536014)(8676002)(2906002)(7696005)(4326008)(6506007)(54906003)(76116006)(66946007)(966005)(71200400001)(26005)(53546011)(64756008)(66556008)(66476007)(186003)(66446008)(33656002)(316002)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: fnY8Xd1ahJAla36YjXM4hgOo0laA2Pve94kX43ag3q90GFGef51AWqRLYG1zTyrx++qDF9LBkAsRKK/8FGurKKG+lo+ioUsLXpI9XsgYvLE5/VGLaLxy4hq0E3n8+f3MkbjAxwb2C1XyBy5rasDGHjGfUKyqTLpU+CgkTABg6J9E2eSLwO5uzR5wdCv9a2N7pDK8DlpnLtKEEV9Qfj8dCS5zlykigH7D3ltrrGminkZbMP8rXDBmP3VtMWhgoW17NLibbhhU9177OCYDxPgXLix57Jf66brrmPAQhCuVnH0AlXGZyQDrt2IlttbUbg0Dy7XBG7Akh5bth9EOqkofpvy/flVo20mKcl/cb2lpAo/KkjSeSeOhFaMoj2RzdcpF2d9y/p/8oHjgOOxnho+skXfQmZh+JdGwwueQjwKVqbVo1UnkYTKkpi5FCnXttGh/e/AQZKe1sygscUw2CYbhsO/cL1tGduY+Wg0Nr+e5wuwUASB3MTozdUy9dXVp5pm17GPsciMbl7FBD1zmmO0v7Kc5JAJlXSuFlQuavz3E9I+7fqKjzwa/wxk9h7hLW0BGNZu08uJuNob0ikoYOunf+r2CKfw9prSlPyz/Nw63UinVnKIg1sgDfZz1s4RJrYjmi7ZhkCl70Zc66e4zLq34VA== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: b753d952-fac1-45e2-b590-08d8809a84c8 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2020 08:20:41.3310 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: syfoKP9kLOEHycn0aKpiqkVlXIV8X1RkTGdWSRSbFBzvTnnFhmmRIIMCvdaFRaYM42IfjRh55THiwlGKN7VN9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB1141 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737 definitions=2020-11-04_06:2020-11-04,2020-11-04 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 malwarescore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 spamscore=0 adultscore=0 suspectscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011040060 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry, forget to CC reviewers. Abner > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Wednesday, November 4, 2020 2:36 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [VFR support REST_STYLE PATCH v3 3/4] > MdeModulePkg/Library: Revise HiiLib to support REST_STYLE >=20 > Add REST_STYLE support >=20 > Signed-off-by: Jiaxin Wu > Signed-off-by: Ting Ye > Signed-off-by: Siyuan Fu > Signed-off-by: Fan Wang > Signed-off-by: Abner Chang > --- > MdeModulePkg/Library/UefiHiiLib/HiiLib.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c > b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c > index 564169bc14..57602828fe 100644 > --- a/MdeModulePkg/Library/UefiHiiLib/HiiLib.c > +++ b/MdeModulePkg/Library/UefiHiiLib/HiiLib.c > @@ -3605,7 +3605,7 @@ HiiCreateCheckBoxOpCode ( > EFI_IFR_CHECKBOX OpCode; > UINTN Position; >=20 > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) =3D=3D 0); > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_REST_STYLE))) =3D=3D 0); >=20 > ZeroMem (&OpCode, sizeof (OpCode)); > OpCode.Question.QuestionId =3D QuestionId; > @@ -3674,7 +3674,7 @@ HiiCreateNumericOpCode ( > UINTN Position; > UINTN Length; >=20 > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) =3D=3D 0); > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_REST_STYLE))) =3D=3D 0); >=20 > Length =3D 0; > ZeroMem (&OpCode, sizeof (OpCode)); > @@ -3773,7 +3773,7 @@ HiiCreateStringOpCode ( > EFI_IFR_STRING OpCode; > UINTN Position; >=20 > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) =3D=3D 0); > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_REST_STYLE))) =3D=3D 0); >=20 > ZeroMem (&OpCode, sizeof (OpCode)); > OpCode.Question.Header.Prompt =3D Prompt; > @@ -3841,7 +3841,7 @@ HiiCreateOneOfOpCode ( > UINTN Length; >=20 > ASSERT (OptionsOpCodeHandle !=3D NULL); > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_OPTIONS_ONLY))) =3D=3D 0); > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_REST_STYLE | EFI_IFR_FLAG_OPTIONS_ONLY))) =3D=3D 0); >=20 > ZeroMem (&OpCode, sizeof (OpCode)); > OpCode.Question.Header.Prompt =3D Prompt; > @@ -3912,7 +3912,7 @@ HiiCreateOrderedListOpCode ( > UINTN Position; >=20 > ASSERT (OptionsOpCodeHandle !=3D NULL); > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_OPTIONS_ONLY))) =3D=3D 0); > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_REST_STYLE | EFI_IFR_FLAG_OPTIONS_ONLY))) =3D=3D 0); >=20 > ZeroMem (&OpCode, sizeof (OpCode)); > OpCode.Question.Header.Prompt =3D Prompt; > @@ -4009,7 +4009,7 @@ HiiCreateDateOpCode ( > EFI_IFR_DATE OpCode; > UINTN Position; >=20 > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) =3D=3D 0); > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_REST_STYLE))) =3D=3D 0); > ASSERT ((DateFlags & (~(EFI_QF_DATE_YEAR_SUPPRESS | > EFI_QF_DATE_MONTH_SUPPRESS | EFI_QF_DATE_DAY_SUPPRESS | > EFI_QF_DATE_STORAGE))) =3D=3D 0); >=20 > ZeroMem (&OpCode, sizeof (OpCode)); > @@ -4074,7 +4074,7 @@ HiiCreateTimeOpCode ( > EFI_IFR_TIME OpCode; > UINTN Position; >=20 > - ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED))) =3D=3D 0); > + ASSERT ((QuestionFlags & (~(EFI_IFR_FLAG_READ_ONLY | > EFI_IFR_FLAG_CALLBACK | EFI_IFR_FLAG_RESET_REQUIRED | > EFI_IFR_FLAG_REST_STYLE))) =3D=3D 0); > ASSERT ((TimeFlags & (~(QF_TIME_HOUR_SUPPRESS | > QF_TIME_MINUTE_SUPPRESS | QF_TIME_SECOND_SUPPRESS | > QF_TIME_STORAGE))) =3D=3D 0); >=20 > ZeroMem (&OpCode, sizeof (OpCode)); > -- > 2.17.1 >=20 >=20 >=20 >=20 >=20