public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Abner Chang" <abner.chang@hpe.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Chang, Abner (HPS SW/FW Technologist)" <abner.chang@hpe.com>
Cc: "Wang, Nickle (HPS SW)" <nickle.wang@hpe.com>,
	Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH] edk2-staging/RedfishClientPkg: Update RedfishCollectionCommon.h
Date: Thu, 28 Oct 2021 14:07:36 +0000	[thread overview]
Message-ID: <CS1PR8401MB1144E4990562CAEE851912C8FF869@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <16B216213357D993.30289@groups.io>

Reviewed-by: Abner Chang <abner.chang@hpe.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Thursday, October 28, 2021 12:05 PM
> To: devel@edk2.groups.io
> Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH] edk2-staging/RedfishClientPkg: Update
> RedfishCollectionCommon.h
> 
> Update RedfishCollectionCommon.h header file. Remove the "Event"
> field from REDFISH_COLLECTION_PRIVATE because the feature driver
> is not started up by the EFI event that is registered by feature
> driver itself anymore.
> 
> Signed-off-by: Nickle Wang <nickle.wang@hpe.com>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> ---
>  .../Include/RedfishCollectionCommon.h             | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/RedfishClientPkg/Include/RedfishCollectionCommon.h
> b/RedfishClientPkg/Include/RedfishCollectionCommon.h
> index 3962b361ed3..05a0f672f39 100644
> --- a/RedfishClientPkg/Include/RedfishCollectionCommon.h
> +++ b/RedfishClientPkg/Include/RedfishCollectionCommon.h
> @@ -36,15 +36,14 @@
>  #define REDFISH_DEBUG_TRACE             DEBUG_INFO
> 
>  typedef struct _REDFISH_COLLECTION_PRIVATE {
> -  EFI_REST_JSON_STRUCTURE_PROTOCOL    *JsonStructProtocol;
> -  EDKII_REDFISH_FEATURE_PROTOCOL      *FeatureProtocol;
> -  REDFISH_SERVICE                     RedfishService;
> +  EFI_REST_JSON_STRUCTURE_PROTOCOL      *JsonStructProtocol;
> +  EDKII_REDFISH_FEATURE_PROTOCOL        *FeatureProtocol;
> +  REDFISH_SERVICE                       RedfishService;
>    EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL ConfigHandler;
> -  EFI_EVENT                           Event;
> -  CHAR8                               *CollectionPath;
> -  CHAR8                               *CollectionJson;
> -  REDFISH_PAYLOAD                     CollectionPayload;
> -  REDFISH_RESPONSE                    RedResponse;
> +  CHAR8                                 *CollectionPath;
> +  CHAR8                                 *CollectionJson;
> +  REDFISH_PAYLOAD                       CollectionPayload;
> +  REDFISH_RESPONSE                      RedResponse;
>  } REDFISH_COLLECTION_PRIVATE;
> 
>  #define REDFISH_COLLECTION_PRIVATE_DATA_FROM_PROTOCOL(This) \
> --
> 2.21.0.windows.1
> 
> 
> 
> 
> 


      parent reply	other threads:[~2021-10-28 14:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <16B216213357D993.30289@groups.io>
2021-10-28  4:07 ` [edk2-devel] [PATCH] edk2-staging/RedfishClientPkg: Update RedfishCollectionCommon.h Abner Chang
2021-10-28 14:07 ` Abner Chang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CS1PR8401MB1144E4990562CAEE851912C8FF869@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox