* Re: [edk2-devel] [PATCH] edk2-staging/RedfishClientPkg: Update RedfishCollectionCommon.h
[not found] <16B216213357D993.30289@groups.io>
@ 2021-10-28 4:07 ` Abner Chang
2021-10-28 14:07 ` Abner Chang
1 sibling, 0 replies; 2+ messages in thread
From: Abner Chang @ 2021-10-28 4:07 UTC (permalink / raw)
To: devel@edk2.groups.io, Chang, Abner (HPS SW/FW Technologist)
Cc: Wang, Nickle (HPS SW), Liming Gao
This patch is sent in behalf of Nickle Wang.
Reviewed-by: Abner Chang <abner.chang@hpe.com>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Thursday, October 28, 2021 12:05 PM
> To: devel@edk2.groups.io
> Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH] edk2-staging/RedfishClientPkg: Update
> RedfishCollectionCommon.h
>
> Update RedfishCollectionCommon.h header file. Remove the "Event"
> field from REDFISH_COLLECTION_PRIVATE because the feature driver
> is not started up by the EFI event that is registered by feature
> driver itself anymore.
>
> Signed-off-by: Nickle Wang <nickle.wang@hpe.com>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> ---
> .../Include/RedfishCollectionCommon.h | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/RedfishClientPkg/Include/RedfishCollectionCommon.h
> b/RedfishClientPkg/Include/RedfishCollectionCommon.h
> index 3962b361ed3..05a0f672f39 100644
> --- a/RedfishClientPkg/Include/RedfishCollectionCommon.h
> +++ b/RedfishClientPkg/Include/RedfishCollectionCommon.h
> @@ -36,15 +36,14 @@
> #define REDFISH_DEBUG_TRACE DEBUG_INFO
>
> typedef struct _REDFISH_COLLECTION_PRIVATE {
> - EFI_REST_JSON_STRUCTURE_PROTOCOL *JsonStructProtocol;
> - EDKII_REDFISH_FEATURE_PROTOCOL *FeatureProtocol;
> - REDFISH_SERVICE RedfishService;
> + EFI_REST_JSON_STRUCTURE_PROTOCOL *JsonStructProtocol;
> + EDKII_REDFISH_FEATURE_PROTOCOL *FeatureProtocol;
> + REDFISH_SERVICE RedfishService;
> EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL ConfigHandler;
> - EFI_EVENT Event;
> - CHAR8 *CollectionPath;
> - CHAR8 *CollectionJson;
> - REDFISH_PAYLOAD CollectionPayload;
> - REDFISH_RESPONSE RedResponse;
> + CHAR8 *CollectionPath;
> + CHAR8 *CollectionJson;
> + REDFISH_PAYLOAD CollectionPayload;
> + REDFISH_RESPONSE RedResponse;
> } REDFISH_COLLECTION_PRIVATE;
>
> #define REDFISH_COLLECTION_PRIVATE_DATA_FROM_PROTOCOL(This) \
> --
> 2.21.0.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [edk2-devel] [PATCH] edk2-staging/RedfishClientPkg: Update RedfishCollectionCommon.h
[not found] <16B216213357D993.30289@groups.io>
2021-10-28 4:07 ` [edk2-devel] [PATCH] edk2-staging/RedfishClientPkg: Update RedfishCollectionCommon.h Abner Chang
@ 2021-10-28 14:07 ` Abner Chang
1 sibling, 0 replies; 2+ messages in thread
From: Abner Chang @ 2021-10-28 14:07 UTC (permalink / raw)
To: devel@edk2.groups.io, Chang, Abner (HPS SW/FW Technologist)
Cc: Wang, Nickle (HPS SW), Liming Gao
Reviewed-by: Abner Chang <abner.chang@hpe.com>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Thursday, October 28, 2021 12:05 PM
> To: devel@edk2.groups.io
> Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH] edk2-staging/RedfishClientPkg: Update
> RedfishCollectionCommon.h
>
> Update RedfishCollectionCommon.h header file. Remove the "Event"
> field from REDFISH_COLLECTION_PRIVATE because the feature driver
> is not started up by the EFI event that is registered by feature
> driver itself anymore.
>
> Signed-off-by: Nickle Wang <nickle.wang@hpe.com>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> ---
> .../Include/RedfishCollectionCommon.h | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/RedfishClientPkg/Include/RedfishCollectionCommon.h
> b/RedfishClientPkg/Include/RedfishCollectionCommon.h
> index 3962b361ed3..05a0f672f39 100644
> --- a/RedfishClientPkg/Include/RedfishCollectionCommon.h
> +++ b/RedfishClientPkg/Include/RedfishCollectionCommon.h
> @@ -36,15 +36,14 @@
> #define REDFISH_DEBUG_TRACE DEBUG_INFO
>
> typedef struct _REDFISH_COLLECTION_PRIVATE {
> - EFI_REST_JSON_STRUCTURE_PROTOCOL *JsonStructProtocol;
> - EDKII_REDFISH_FEATURE_PROTOCOL *FeatureProtocol;
> - REDFISH_SERVICE RedfishService;
> + EFI_REST_JSON_STRUCTURE_PROTOCOL *JsonStructProtocol;
> + EDKII_REDFISH_FEATURE_PROTOCOL *FeatureProtocol;
> + REDFISH_SERVICE RedfishService;
> EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL ConfigHandler;
> - EFI_EVENT Event;
> - CHAR8 *CollectionPath;
> - CHAR8 *CollectionJson;
> - REDFISH_PAYLOAD CollectionPayload;
> - REDFISH_RESPONSE RedResponse;
> + CHAR8 *CollectionPath;
> + CHAR8 *CollectionJson;
> + REDFISH_PAYLOAD CollectionPayload;
> + REDFISH_RESPONSE RedResponse;
> } REDFISH_COLLECTION_PRIVATE;
>
> #define REDFISH_COLLECTION_PRIVATE_DATA_FROM_PROTOCOL(This) \
> --
> 2.21.0.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread