From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web10.538.1602002201353557556 for ; Tue, 06 Oct 2020 09:36:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=ngcv3JWm; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=0548da70be=abner.chang@hpe.com) Received: from pps.filterd (m0134424.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 096GZrHs005147; Tue, 6 Oct 2020 16:36:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : date : message-id : references : in-reply-to : content-type : mime-version : subject; s=pps0720; bh=CQyKW+Su8t8IwSh9c2Fi50QelYjY+PikXIrl9u+gitw=; b=ngcv3JWmvot+CHqgvO+N1oJP1r02qCyE7usAzV6PcoGuQ+Bc85cMAfD9g7WVun5n9983 YlJep+va1cI5gu/SB/YXPQxLdq5dvj/40WgrYhYD+XxEDmytehBgCZpGTd8SgfhMEUZI 6IzDUZQNTN5lXgTkJX6kfNC6uxatOhKvTp1QWWtSgJJk+m5laQtK2QsXwVJ1comFleWn oXxiAmptBTp7ANQ4D58vxBqMh4A+g3FtQ1IWl0+cdGVb7ZJN4fFpnSBvKDcShCA5QkpP I0qUmuHLezVUdbxKuq6OA4hHQ3OXW/3M8hL1a/modnlUM8OtrzPuVQV3OdhFnHOkKyFH yA== Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 33xg9nbetr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Oct 2020 16:36:38 +0000 Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id 13EA27F; Tue, 6 Oct 2020 16:36:38 +0000 (UTC) Received: from G2W6311.americas.hpqcorp.net (2002:10c5:4035::10c5:4035) by G1W8106.americas.hpqcorp.net (2002:10c1:483d::10c1:483d) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 6 Oct 2020 16:36:37 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (15.241.52.11) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 6 Oct 2020 16:36:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AHTB2GZNRPobpEqGMN/lNIzPYk7VRQ3a5F+cv0aTf5W8UkcMVgxZCX1zLMmpkUlS4ARWU8ZXorPeOUXsgSfSSVSKSl9Y23cEtieRv0wrdNJHAvTsGXNv89em67Vi6zF+ubTjUGIrtGi5g8yvrWKVZ5mOonecKAKGdBB9Um4+sqRzrRC+JIH4nNniiiqC5x1x1PejHmdmiHfePEmHeR7lBHcyuwppBGObRsQ8u28tlgsMXeU2DmwJ7u0/8WJTsx9o49ZTIquo0SwuhPCdx9T1PPqER6ALaWGQ1NLESCcMVxsJHv+16evn0jvf7J+zP2aQxdMm1qn61KPhMX7Lyl8CAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cynvploilTNdM0M4AtGtlJf2jvi6ClOzg3YVXvjn4QY=; b=h3DCDBuvHhQ5vPegm5UL+PBqJhKrBGB8dlSfQMZSonc8ccRPSg6U/cnTQ8zfQ6+t/GG0u5wdt0PDESC6Rb4HHGmP44wZIYxZJXLU2A+lOZaNrQPvGmSA8Sx16QNkPjIGtbwjmG6p1uqsmstb4lGjCL50+VbXhw5/v/mNqhWiXYrSv33bRS2Ob/dBhsIobmnSXcHFLcmOHmlQeG+hS7sffDqnuS3u5OOY1GZHYW4SPtK8fGcDw/lD/C98tcOU6oQwH7vWyyAO4A4b3jw5R9ioLkoGRBeft7pt9535jQ7cWQ7lDJZ/n2xQcXaoXYXJPHwZYW8toj09vteH+wZMsLmvrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7508::16) by CS1PR8401MB0647.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:750d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.32; Tue, 6 Oct 2020 16:36:36 +0000 Received: from CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d111:132b:4b87:a9ea]) by CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM ([fe80::d111:132b:4b87:a9ea%3]) with mapi id 15.20.3433.045; Tue, 6 Oct 2020 16:36:36 +0000 From: "Abner Chang" To: Leif Lindholm CC: "devel@edk2.groups.io" , "Wang, Nickle (HPS SW)" , Andrew Fish , Laszlo Ersek , Michael D Kinney Thread-Topic: [EXTERNAL] RE: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg. Thread-Index: AQHWm+4lqboOMtSM1k2H3J0O+3csramKwB5QgAADvgCAAAHBCg== Date: Tue, 6 Oct 2020 16:36:36 +0000 Message-ID: References: <20201006104804.14724-1-abner.chang@hpe.com> <20201006104804.14724-2-abner.chang@hpe.com> <20201006143659.GP5623@vanye> , In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [1.34.113.40] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 6ccef887-510c-4f29-af92-08d86a15fe1e x-ms-traffictypediagnostic: CS1PR8401MB0647: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: krfjuch4pA8fsfgDbqpIoUBF4tbbJ+g0MdbPA/pKdOGrelHn0ZJcY624bcvqQjaMU6TAk2dLbR8BUFq1bOmFTE7fwTnLCCDz/DgeeiTKmnF8lywG00QUrXi0Dl+Q6hE0219Z3MdsV0zlin9J7PbZAdnVqyr6BV/x/pJ/1S0UOasbO0fqFFuV4SzRPH/DHb6KYeRjJU42uFPlleJzVjM6nJgKzCMNZ7N862PWcnt9hIOTDnIHFZD0PZgQnHgCbFsuJTawSR8+wnc5UCZIK15hUyS7kkCD/KCogboFTWNs1HKC+0WIVheY1+u1aEbypbgpy6j6fkCZecApYa/p4HTxYA2Un64NEJil9Lao1xrl9ds9NzBdZjV8CaQYKdIV2Vm13sI1RjV6tjobIt8gKAOVeQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(396003)(346002)(376002)(366004)(39860400002)(136003)(83080400001)(166002)(86362001)(2906002)(52536014)(5660300002)(83380400001)(6916009)(91956017)(76116006)(33656002)(4326008)(8676002)(66556008)(64756008)(8936002)(66946007)(6506007)(478600001)(53546011)(7696005)(45080400002)(316002)(9686003)(54906003)(55016002)(186003)(66476007)(66446008)(71200400001)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: AGa7n4mV4rQnKPkDLoHBpzN4y9IhXxIu6zisJqjsocU5f7HHVfCQEo1airkK8ErV7Wxji5GrKkmtfrGE69CClFi8mCNO8rCMNivPBEfMbJiklgMUgfurTLRO4oxuTTUJ8XJBVU61l+MjO6X6hIhsCvWVRyiEZ8JHP7XjKXUq1wNG6ebQwB+3ai8gJtZ8k3/jjZjXUbTTDwemUdjl/FDgWmricn1VqPTg67gU7W68EmibJwmp7AM3ABsFM8RS5YO1t4n/UZwIKeLrnkCuLip6ssn62fhhSx4/A18viHJaG9oCgqHSvtHLnBGVcWzzsnxTeDDF/LD11TrC4kbwmMR96rPO9kooB8OxitrKQXYRNI8QhHXrdfenNTIITsRsmJXtDllDtrBD71vexWNPF1aW1y7ehngniRO9s4y24y/1UnmB04oGdfYgbwT8RgXIZ02GIa8HRoT1f8DwIiNFYzrxaVXBwsbKt6e8nvxOg4v9b21HV3xSOdsZ3puc4FHeob/n6oCFfQbVTSvLDGWpugDFr9JqzuTlj6fqXrtmex0SZv5+Rb2BP/jJ9NTdZFdSXYz4STEAU3Wkox5QtdZindzspo+jNkd13h9/2bHDjfNZHd5OHC3YS3NZqEYKlqJkS0FS1Nq39Yjcb1yq9PRew1wwGA== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 6ccef887-510c-4f29-af92-08d86a15fe1e X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 16:36:36.2007 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OlLFPXHbViTZiICvYS5k7elWdNcxUsW8xThr00DjA3drlCJOnDgcLREm4glEKEca5XBxetJXwqxenIK22PLNoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0647 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 Subject: Re: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg. X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-10-06_09:2020-10-06,2020-10-06 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 mlxscore=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010060106 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CS1PR8401MB1144EF053FD069E05A01DB98FF0D0CS1PR8401MB1144_" --_000_CS1PR8401MB1144EF053FD069E05A01DB98FF0D0CS1PR8401MB1144_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yeah, I will send another version for this. Thanks Abner Get Outlook for Android ________________________________ From: Leif Lindholm Sent: Wednesday, October 7, 2020 12:29:28 AM To: Chang, Abner (HPS SW/FW Technologist) Cc: devel@edk2.groups.io ; Wang, Nickle (HPS SW) ; Andrew Fish ; Laszlo Ersek ; Michael D Kinney Subject: Re: [EXTERNAL] RE: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishP= kg: Initial commit of RedfishPkg. Hi Abner, On Tue, Oct 6, 2020 at 5:20 PM Chang, Abner (HPS SW/FW Technologist) > wrote: > > > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new > > > file mode 100644 index 0000000000..d5c65f68c3 > > > --- /dev/null > > > +++ b/RedfishPkg/RedfishPkg.dsc > > > @@ -0,0 +1,40 @@ > > > +## @file > > > +# Redfish Package > > > +# > > > +# Copyright (c) 2019, Intel Corporation. All rights reserved.
# > > > +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP. > > > +# > > > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > > +# > > > +## > > > + > > > +[Defines] > > > + PLATFORM_NAME =3D RedfishPkg > > > + PLATFORM_GUID =3D c4352870-5232-11e7-9522-005056c= 00008 > > > + PLATFORM_VERSION =3D 1.0 > > > + DSC_SPECIFICATION =3D 0x0001001c > > > + OUTPUT_DIRECTORY =3D Build/RedfishPkg > > > + SUPPORTED_ARCHITECTURES =3D IA32|X64|ARM|AARCH64|RISCV64 > > > + BUILD_TARGETS =3D DEBUG|RELEASE > > > > v3 included NOOPT here. That was the version Laszlo gave his R-b for. > > > > v4 cover letter does mention NOOPT being removed, but I can see no > > conversation in which this is discussed. What have I missed? > > No Leif, you did miss nothing. There was some Q/A conversations between B= ret and me about the build target of CI. This should really be referenced in the cover letter. > We would like to keep NO-TARGET for the non-build CI test but remove NOOP= T for now because we do not have > the host-based unit test at the moment. We would like to add NOOPT back o= nce we have the corresponding unit test on RedfishPkg. Right, but dropping it from the .dsc BUILD_TARGETS is not required for that. And it's not clear to me that Laszlo noticed this change. / Leif --_000_CS1PR8401MB1144EF053FD069E05A01DB98FF0D0CS1PR8401MB1144_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Yeah, I will send another version for this. 
Thanks
Abner
From: Leif Lindholm <lei= f@nuviainc.com>
Sent: Wednesday, October 7, 2020 12:29:28 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>= ;
Cc: devel@edk2.groups.io <devel@edk2.groups.io>; Wang, Nickle = (HPS SW) <nickle.wang@hpe.com>; Andrew Fish <afish@apple.com>; = Laszlo Ersek <lersek@redhat.com>; Michael D Kinney <michael.d.kinn= ey@intel.com>
Subject: Re: [EXTERNAL] RE: [edk2-devel] [RedfishPkg PATCH v5 1/4] R= edfishPkg: Initial commit of RedfishPkg.
 
Hi Abner,

On Tue, Oct 6, 2020 at 5:20 PM Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com> wrote:
> > > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishP= kg.dsc new
> > > file mode 100644 index 0000000000..d5c65f68c3
> > > --- /dev/null
> > > +++ b/RedfishPkg/RedfishPkg.dsc
> > > @@ -0,0 +1,40 @@
> > > +## @file
> > > +# Redfish Package
> > > +#
> > > +# Copyright (c) 2019, Intel Corporation. All rights reserve= d.<BR> #
> > > +(C) Copyright 2020 Hewlett-Packard Enterprise Development L= P.
> > > +#
> > > +#    SPDX-License-Identifier: BSD-2-Clause-Patent=
> > > +#
> > > +##
> > > +
> > > +[Defines]
> > > +  PLATFORM_NAME           &nb= sp;      =3D RedfishPkg
> > > +  PLATFORM_GUID           &nb= sp;      =3D c4352870-5232-11e7-9522-005056c00008
> > > +  PLATFORM_VERSION           =     =3D 1.0
> > > +  DSC_SPECIFICATION          =    =3D 0x0001001c
> > > +  OUTPUT_DIRECTORY           =     =3D Build/RedfishPkg
> > > +  SUPPORTED_ARCHITECTURES        = =3D IA32|X64|ARM|AARCH64|RISCV64
> > > +  BUILD_TARGETS           &nb= sp;      =3D DEBUG|RELEASE
> >
> > v3 included NOOPT here. That was the version Laszlo gave his R-b = for.
> >
> > v4 cover letter does mention NOOPT being removed, but I can see n= o
> > conversation in which this is discussed. What have I missed?
>
> No Leif, you did miss nothing. There was some Q/A conversations b= etween Bret and me about the build target of CI.

This should really be referenced in the cover letter.

> We would like to keep NO-TARGET for the non-build CI test but rem= ove NOOPT for now because we do not have
> the host-based unit test at the moment. We would like to add NOOP= T back once we have the corresponding unit test on RedfishPkg.

Right, but dropping it from the .dsc BUILD_TARGETS is not required for= that.
And it's not clear to me that Laszlo noticed this change.

/
    Leif
--_000_CS1PR8401MB1144EF053FD069E05A01DB98FF0D0CS1PR8401MB1144_--