Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

["Abner Chang" <abner.chang@hpe.com>]

> -----Original Message-----
> From: Chang, Abner (HPS SW/FW Technologist)
> Sent: Wednesday, October 7, 2020 8:02 AM
> To: devel@edk2.groups.io; spbrogan@outlook.com
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> Subject: RE: [edk2-devel] [RedfishPkg PATCH v5
> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
> 
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Sean
> > Sent: Wednesday, October 7, 2020 7:46 AM
> > To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> > devel@edk2.groups.io
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> > Subject: Re: [edk2-devel] [RedfishPkg PATCH v5 3/4]
> > .azurepipelines/templates: Add RedfishPkg to target build
> >
> > I am just suggesting that for CI you should put redfishpkg into an
> > existing matrix item rather than create a new matrix item.  Each one
> > of those is a build that spins up when CI/PR is invoked.
> >
> >
> > instead of this (your patch)
> >
> > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > b/.azurepipelines/templates/pr-gate-build-job.yml
> > index 2683687a1c..b5b09c2cca 100644
> > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > @@ -45,6 +45,9 @@ jobs:
> >          TARGET_SECURITY:
> >            Build.Pkgs: 'SecurityPkg'
> >            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > +      TARGET_REDFISH:
> > +        Build.Pkgs: 'RedfishPkg'
> > +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >          TARGET_PLATFORMS:
> >            # For Platforms only check code. Leave it to Platform CI
> >            # to build them.
> >
> > I would just do something like below.  (i hand edited the diff so
> > might not be perfect but hopefully you get the idea).
> >
> >
> > @@ -45,6 +45,9 @@ jobs:
> > -        TARGET_SECURITY:
> > +        TARGET_SECURITY_REDFISH:
> > -          Build.Pkgs: 'SecurityPkg'
> > +          Build.Pkgs: 'SecurityPkg,RedfishPkg'
> >            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >
> >
> Got you. I will put it with NetworkPkg, more like a family. :) Thanks
Not quite sure how this yaml file works with CI test.
Does it mean RedfishPkg is involved in NetworkPkg CI test? Even CI only runs on TARGET_NETWORK?
But eventually RedfishPkg would be moved out from TARGET_NETWORK once it grows up to big enough, right?

> 
> >
> > Thanks
> > Sean
> >
> >
> > On 10/6/2020 4:39 PM, Chang, Abner (HPS SW/FW Technologist) wrote:
> > >
> > >
> > >> -----Original Message-----
> > >> From: Sean Brogan [mailto:spbrogan@outlook.com]
> > >> Sent: Wednesday, October 7, 2020 7:05 AM
> > >> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > >> <abner.chang@hpe.com>
> > >> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > >> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > >> <michael.d.kinney@intel.com>; Liming Gao
> > >> <gaoliming@byosoft.com.cn>; Wang, Nickle (HPS SW)
> > >> <nickle.wang@hpe.com>
> > >> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5 3/4]
> > >> .azurepipelines/templates: Add RedfishPkg to target build
> > >>
> > >> On this change i would recommend that you add RedFishPkg to another
> > >> in the list as i don't think the time it takes to compile and test
> > >> this relatively small package makes it worth spinning up another
> > >> machine, syncing
> > sources,
> > >> installing tools, etc.
> > >
> > > Sean, do you mean to add RedFishPkg to another package? Or move
> > drivers (currently is none) under RedFishPkg to another package?
> > > This is the initial commit of RedFishPkg, more drivers will added to
> > > this
> > package later on.
> > > https://github.com/tianocore/edk2-
> > staging/blob/UEFI_Redfish/Readme.md
> > >
> > > That doesn't make sense to put RedFishPkg to any of another to save
> > > CI
> > time, but what we can do now is remove RedFishPkg from CI test for the
> > time being. Says don’t add RedfishPkg to GetPackageSupported for now.
> > >
> > >
> > >>
> > >> Looking at the current matrix it looks like the SecurityPkg only
> > >> takes 8 minutes and CRYPTO only takes ~9 minutes.  I also see FMP
> > >> and FAT is
> > faster
> > >> than the slowest entry.  We generally try to load balance this so
> > >> that CI completes quickly.
> > >>
> > >> vs2019
> > >> INVALID URI REMOVED
> > >> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
> > >> 3D12811-26view-
> > >>
> >
> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
> > >> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
> > >> D4sw4IjDO8v_OJ74lDlU0M&s=3XIQ_TF_f0Ck_fkywiGXKd-
> > >> 2a23G5fMyOkEFrZgBz5M&e=
> > >>
> > >> gcc
> > >> INVALID URI REMOVED
> > >> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
> > >> 3D12810-26view-
> > >>
> >
> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
> > >> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
> > >>
> >
> D4sw4IjDO8v_OJ74lDlU0M&s=4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ6
> > >> XbXB9yt4&e=
> > >>
> > >>
> > >> Thanks
> > >> Sean
> > >>
> > >>
> > >>
> > >> On 10/6/2020 3:48 AM, Abner Chang wrote:
> > >>> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > >>> Cc: Sean Brogan <sean.brogan@microsoft.com>
> > >>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > >>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > >>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > >>> Cc: Nickle Wang <nickle.wang@hpe.com>
> > >>> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > >>> ---
> > >>>    .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> > >>>    1 file changed, 3 insertions(+)
> > >>>
> > >>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > >>> b/.azurepipelines/templates/pr-gate-build-job.yml
> > >>> index 2683687a1c..b5b09c2cca 100644
> > >>> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > >>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > >>> @@ -45,6 +45,9 @@ jobs:
> > >>>          TARGET_SECURITY:
> > >>>            Build.Pkgs: 'SecurityPkg'
> > >>>            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > >>> +      TARGET_REDFISH:
> > >>> +        Build.Pkgs: 'RedfishPkg'
> > >>> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > >>>          TARGET_PLATFORMS:
> > >>>            # For Platforms only check code. Leave it to Platform CI
> > >>>            # to build them.
> > >>>
> >
> >
> > 
> >