From: "Abner Chang" <abner.chang@hpe.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>
Cc: 'Leif Lindholm' <leif@nuviainc.com>,
"Wang, Nickle (HPS SW)" <nickle.wang@hpe.com>,
'Michael D Kinney' <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by a accident
Date: Mon, 1 Feb 2021 02:59:09 +0000 [thread overview]
Message-ID: <CS1PR8401MB1144F24FB20C16B74D3511D8FFB69@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <000201d6f83d$286cc9c0$79465d40$@byosoft.com.cn>
Yes, CI is enabled on RedfishPkg.
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> gaoliming
> Sent: Monday, February 1, 2021 9:54 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Cc: 'Leif Lindholm' <leif@nuviainc.com>; Wang, Nickle (HPS SW)
> <nickle.wang@hpe.com>; 'Michael D Kinney' <michael.d.kinney@intel.com>
> Subject: 回复: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix the mistake of
> removing code by a accident
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> Besides, does CI enable in RedfishPkg?
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: bounce+27952+70885+4905953+8761045@groups.io
> > <bounce+27952+70885+4905953+8761045@groups.io> 代表 Abner Chang
> > 发送时间: 2021年1月29日 12:20
> > 收件人: devel@edk2.groups.io
> > 抄送: Leif Lindholm <leif@nuviainc.com>; Nickle Wang
> > <nickle.wang@hpe.com>; Michael D Kinney
> <michael.d.kinney@intel.com>
> > 主题: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix the mistake of
> > removing code by a accident
> >
> > json_string_value() in JsonValueGetAsciiString () is removed by a
> > accident when clean up the code.
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Nickle Wang <nickle.wang@hpe.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> > RedfishPkg/Library/JsonLib/JsonLib.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/RedfishPkg/Library/JsonLib/JsonLib.c
> > b/RedfishPkg/Library/JsonLib/JsonLib.c
> > index 34ff381aee..d729e3ec27 100644
> > --- a/RedfishPkg/Library/JsonLib/JsonLib.c
> > +++ b/RedfishPkg/Library/JsonLib/JsonLib.c
> > @@ -430,10 +430,10 @@ JsonValueGetAsciiString (
> > IN EDKII_JSON_VALUE Json
> > )
> > {
> > - CHAR8 *AsciiStr;
> > + CONST CHAR8 *AsciiStr;
> > UINTN Index;
> >
> > - AsciiStr = (CHAR8 *) ((json_t *) Json);
> > + AsciiStr = json_string_value ((json_t *) Json);
> > if (AsciiStr == NULL) {
> > return NULL;
> > }
> > --
> > 2.17.1
> >
> >
> >
> >
> >
>
>
>
>
>
>
>
next prev parent reply other threads:[~2021-02-01 3:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 4:19 [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by a accident Abner Chang
2021-02-01 1:54 ` 回复: [edk2-devel] " gaoliming
2021-02-01 2:59 ` Abner Chang [this message]
2021-02-18 3:33 ` Nickle Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CS1PR8401MB1144F24FB20C16B74D3511D8FFB69@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox