public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Abner Chang" <abner.chang@hpe.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"leif@nuviainc.com" <leif@nuviainc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	"Schaefer, Daniel" <daniel.schaefer@hpe.com>,
	Thomas Abraham <thomas.abraham@arm.com>,
	"Sami Mujawar" <sami.mujawar@arm.com>,
	Graeme Gregory <graeme@nuviainc.com>,
	Radoslaw Biernacki <rad@semihalf.com>,
	Pierre Gondois <pierre.gondois@arm.com>,
	Peng Xie <xiepeng@phytium.com.cn>,
	Ling Jia <jialing@phytium.com.cn>,
	Yiqi Shu <shuyiqi@phytium.com.cn>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH V3 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg
Date: Fri, 15 Oct 2021 11:46:17 +0000	[thread overview]
Message-ID: <CS1PR8401MB1144FBED119593FD9677A9F0FFB99@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20211015105400.m36n7oa4jea32ko2@leviathan>

[-- Attachment #1: Type: text/plain, Size: 4009 bytes --]

Merged.
The fastest review process I ever experienced. :-D

Thanks
Abner


________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Leif Lindholm <leif@nuviainc.com>
Sent: Friday, October 15, 2021 6:54 PM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Cc: devel@edk2.groups.io <devel@edk2.groups.io>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Schaefer, Daniel <daniel.schaefer@hpe.com>; Thomas Abraham <thomas.abraham@arm.com>; Sami Mujawar <sami.mujawar@arm.com>; Graeme Gregory <graeme@nuviainc.com>; Radoslaw Biernacki <rad@semihalf.com>; Pierre Gondois <pierre.gondois@arm.com>; Peng Xie <xiepeng@phytium.com.cn>; Ling Jia <jialing@phytium.com.cn>; Yiqi Shu <shuyiqi@phytium.com.cn>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH V3 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg

On Fri, Oct 15, 2021 at 15:32:56 +0800, Abner Chang wrote:
> In V3: Fix the commit message in each patch.
>        ArmVirtPkg->ArmPkg
> In V2: Fix the invalid email address.

Less haste, more speed ;)

Acked-by: Leif Lindholm <leif@nuviainc.com>

> This patch set fixes the build error caused by referring to
> PcdPciMmio(32)64Translation under ArmPkg. It should use the ones from
> MdePkg because of the PCD relocation (BZ:#3665).
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=3665
>
> BZ:#3665 is to migrate some modules from ArmVirtPkg
> to under OvmfPkg for the upcoming RiscVVirtPkg that can leverage
> those modules without the dependency with Arm*Pkg.
> Refer to below message of the pacthes of edk2 portion.
> https://edk2.groups.io/g/devel/message/81306
>
> Below PCDs are moved to under MdePkg and leverage by RiscVVirtPkg.
> - PcdPciMmio32Translation
> - PcdPciMmio64Translation
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Graeme Gregory <graeme@nuviainc.com>
> Cc: Radoslaw Biernacki <rad@semihalf.com>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
> Cc: Peng Xie <xiepeng@phytium.com.cn>
> Cc: Ling Jia <jialing@phytium.com.cn>
> Cc: Yiqi Shu <shuyiqi@phytium.com.cn>
>
> Abner Chang (9):
>   Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD from
>     MdePkg
>   Platform/CelloBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Platform/Overdrive1000Board: Use PcdPciMmio(32)64Translation PCD from
>     MdePkg
>   Silicon/Styx: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Platform/ARM: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Platform/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Silicon/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Platform/DurianPkg: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Silicon/FT2000-4Pkg: Use PcdPciMmio(32)64Translation PCD from MdePkg
>
>  Platform/ARM/SgiPkg/SgiPlatform.dsc.inc                       | 4 ++--
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                | 4 ++--
>  Platform/LeMaker/CelloBoard/CelloBoard.dsc                    | 4 ++--
>  Platform/Phytium/DurianPkg/DurianPkg.dsc                      | 2 +-
>  Platform/Qemu/SbsaQemu/SbsaQemu.dsc                           | 4 ++--
>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc   | 4 ++--
>  .../Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf     | 4 ++--
>  .../ARM/SgiPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf  | 2 +-
>  .../AmdStyxPciHostBridgeLib/AmdStyxPciHostBridgeLib.inf       | 4 ++--
>  .../Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.inf   | 2 +-
>  Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf               | 4 ++--
>  .../SbsaQemuPciHostBridgeLib/SbsaQemuPciHostBridgeLib.c       | 4 ++--
>  12 files changed, 21 insertions(+), 21 deletions(-)
>
> --
> 2.17.1
>






[-- Attachment #2: Type: text/html, Size: 7333 bytes --]

      reply	other threads:[~2021-10-15 11:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15  7:32 [edk2-platforms][PATCH V3 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg Abner Chang
2021-10-15  7:32 ` [edk2-platforms][PATCH V3 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD " Abner Chang
2021-10-15  7:32 ` [edk2-platforms][PATCH V3 2/9] Platform/CelloBoard: " Abner Chang
2021-10-15  7:32 ` [edk2-platforms][PATCH V3 3/9] Platform/Overdrive1000Board: " Abner Chang
2021-10-15  7:33 ` [edk2-platforms][PATCH V3 4/9] Silicon/Styx: " Abner Chang
2021-10-15  7:33 ` [edk2-platforms][PATCH V3 5/9] Platform/ARM: " Abner Chang
2021-10-15  7:33 ` [edk2-platforms][PATCH V3 6/9] Platform/SabaQemu: " Abner Chang
2021-10-15  7:33 ` [edk2-platforms][PATCH V3 7/9] Silicon/SabaQemu: " Abner Chang
2021-10-15  7:33 ` [edk2-platforms][PATCH V3 8/9] Platform/DurianPkg: " Abner Chang
2021-10-15  7:33 ` [edk2-platforms][PATCH V3 9/9] Silicon/FT2000-4Pkg: " Abner Chang
2021-10-15 10:54 ` [edk2-platforms][PATCH V3 0/9] Use PcdPciMmio(32)64Translation PCDs " Leif Lindholm
2021-10-15 11:46   ` Abner Chang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CS1PR8401MB1144FBED119593FD9677A9F0FFB99@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox