From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=216.205.24.162; helo=us-smtp-delivery-162.mimecast.com; envelope-from=eugene@hp.com; receiver=edk2-devel@lists.01.org Received: from us-smtp-delivery-162.mimecast.com (us-smtp-delivery-162.mimecast.com [216.205.24.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B82FE201B0423 for ; Wed, 27 Feb 2019 02:59:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hp.com; s=mimecast20180716; t=1551265140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references; bh=TDphQkfLxyGUcZKGrLXPmQqHDs88GNfkvz7+7kDb5BU=; b=WT2UeykIum4vpodg4/kYlP+4uErjISYq3R2vS6aezXxlv4ej4DipivOa4fSgxNnzvgBagVISNcNm59o5pnvHOD2bV0Pfp31Cq0LZPrO4v+fYa8b5FGQG0+PhnfXty2mKQFfqqM9wGFzDBtHh5nOR64Re+qW1+luDjDwxAyS9wkc= Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02lp2058.outbound.protection.outlook.com [104.47.37.58]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-327-yUo1-IXgM9ScBoaWBHH30A-1; Wed, 27 Feb 2019 05:58:59 -0500 Received: from CS1PR8401MB1189.NAMPRD84.PROD.OUTLOOK.COM (10.169.97.20) by CS1PR8401MB1190.NAMPRD84.PROD.OUTLOOK.COM (10.169.96.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.14; Wed, 27 Feb 2019 10:58:57 +0000 Received: from CS1PR8401MB1189.NAMPRD84.PROD.OUTLOOK.COM ([fe80::ec9d:c9c3:8a92:4378]) by CS1PR8401MB1189.NAMPRD84.PROD.OUTLOOK.COM ([fe80::ec9d:c9c3:8a92:4378%4]) with mapi id 15.20.1643.019; Wed, 27 Feb 2019 10:58:57 +0000 From: "Cohen, Eugene" To: "edk2-devel@lists.01.org" , Hao Wu Thread-Topic: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems Thread-Index: AdTOimUh6bq74L7bQyCZsF0hnADHfg== Date: Wed, 27 Feb 2019 10:58:57 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [15.65.252.14] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cbb6feb1-67e2-4a90-6a1d-08d69ca292a9 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:CS1PR8401MB1190; x-ms-traffictypediagnostic: CS1PR8401MB1190: x-microsoft-exchange-diagnostics: =?us-ascii?Q?1; CS1PR8401MB1190; 23:+w2oxxZ46JbtiTdzMJMXL60hLeCJVnxQAPWln8g?= =?us-ascii?Q?Lt5FWQVDAKXIiF0DGRkd7lBN+I6M7EcxsEA8iG/44fSZonehqt5CoLxL/ccG?= =?us-ascii?Q?h0gEMBzFKvarOjLpTJpNkm9Dy+ZxKjShlNxx3XRV6qvNGCHn1t2+Iq2txRcd?= =?us-ascii?Q?UrcbHniUpT3CLVP6lOK8RwFH8k+6DYIWtZPjLEWu717Fso3lyk8O7nVzA8E+?= =?us-ascii?Q?Xbck69gQ2McHMKxib9U2uKq5qAJd/SfE+mktT2chi0JDmGQQdSOcp2O2RXJw?= =?us-ascii?Q?VtxCehDFKKnrlNBWVBAwOeamCiWT4oup7LFrnEER2UsNP2K4NFYFuSqkzUeP?= =?us-ascii?Q?9+VXI4cAYRQ5usPyLoc5ZLsUWgrNCmqf/TvRodts59vJyUDNRdIa0oO5OXKZ?= =?us-ascii?Q?MbxqigSLcJv4LZvDBi1nCtpIa6lZRl1zkbV4Ddq22B1288tzovPGhdsKjdbL?= =?us-ascii?Q?9Ijoj0OZlHfWF9wFUnrneXZakkBu53H3xCdL92Fa2vo6NLkzLbyJiA9+NT/n?= =?us-ascii?Q?4vJRxXUNOIs8WGlslWdg62hn28o3QPgmA2g9nAIx32Nnew6OQoVjmWl/GjWJ?= =?us-ascii?Q?wFt8I8M6478YLAnTHPfNa470Ic1xQ6/pEqLXawDWr/NTVRpUkomttG+e7e7E?= =?us-ascii?Q?7k9+p27hX6cLQeJjcOxPaBhA4WkK3Sd8KaSVeZ6X92veWVKuNYNYBWWuCDve?= =?us-ascii?Q?IeiUqn8TpAXnMZkSYrsyhGLfxFK55zlV9AEk7T5gjH02frBH/xhEu1uUx/HS?= =?us-ascii?Q?Ale8FCnLw+grcYhtZhbnfmmmnU91150oQSCehcaIzfXhFFdwLh1ZdUIXxD0E?= =?us-ascii?Q?b0CgO7NkT1LlJJu2rlpNBsVYM+yAPK/85ISQTutvLGjhmAoZqo6Dw+Uq0yOY?= =?us-ascii?Q?BVKklMjs4/Xik+VkpRRQ/vccYiVVnKbS8dnZcxxGNKMSN9my4TLiuRmzcChz?= =?us-ascii?Q?tX+ZtQrM1ezhqTXPXyIbRjBGJi/v25TgJEIUMkwdIV61kIhhoS819mNPFbyQ?= =?us-ascii?Q?LvaD/YFBJ2m2CTKy0Nebtf5HQ/nz+faAP/Cn9MCv7zfHwRYrUzcQ260ocXfW?= =?us-ascii?Q?clTYMKbB0Ma7DoNA5ZM88Asl/LQlP/h2PTAKZQQTmCHigdYpC4trM3OFo4Ol?= =?us-ascii?Q?li7a3FWguFdj8VzDi2zwGkQWG77Fhf6tz5hX7kYk9iDwWVm8la0e6wJWGEJE?= =?us-ascii?Q?9cVPKrlATtLyIg8c=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0961DF5286 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6029001)(396003)(366004)(376002)(346002)(136003)(39860400002)(189003)(199004)(6602003)(53936002)(110136005)(81156014)(6506007)(81166006)(6436002)(3846002)(86362001)(106356001)(102836004)(790700001)(486006)(6116002)(66066001)(7696005)(8676002)(105586002)(54896002)(9686003)(6306002)(71190400001)(71200400001)(476003)(5660300002)(99286004)(478600001)(33656002)(25786009)(97736004)(68736007)(74316002)(14454004)(7736002)(55016002)(2501003)(26005)(14444005)(2906002)(186003)(316002)(256004)(8936002); DIR:OUT; SFP:1102; SCL:1; SRVR:CS1PR8401MB1190; H:CS1PR8401MB1189.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: SIpZFFoKVLGEr/87UCT3y5AnvZJ1cmTon35u5Cqry5UmhM151TIO3w70NQ2UEkOpn+iKKjjpBSrQlTu6wUo1FEBP8jhNfCcf+Ni1rZMbf3dwaMNFbKUVyFtNVOk0y78EJ/VHSpPWyoiGdeD0zUzTrDOmW7AL/hEjOF90YQftwyJYqVawoRgprehgcGL3Oi2qpY6dejfU6GJtOiS0M9xSXwYUCeUaBwqw4ROEqj+i5KsCFe8t8pIODN6jOnNdBJOSTsq6dgt4o5BemsswDsNQu4kXD98DUqGSM8KBeSVch7L7fMJwkOgMciW6fcvkXztg1jNAbIAyqQipQLCb7GlCmjxMQFACrTReKv8zfWWKY7fiFfLPKhVSILjORXW6F0ugvhhNdivKTTTAN0TrtHHjE7Vc5nIq4qP57dYhq9aZh5c= MIME-Version: 1.0 X-OriginatorOrg: hp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cbb6feb1-67e2-4a90-6a1d-08d69ca292a9 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2019 10:58:57.7984 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: ca7981a2-785a-463d-b82a-3db87dfc3ce6 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB1190 X-MC-Unique: yUo1-IXgM9ScBoaWBHH30A-1 X-Mimecast-Spam-Score: 0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix DMA on SDHC v3 64-bit systems X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 10:59:03 -0000 Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable The SdMmcPciHcDriverBindingStart function was checking two different capability bits in determining whether 64-bit DMA modes were supported, one mode is defined in the SDHC version 3 specification (using 96-bit descriptors) and another is defined in the SDHC version 4 specification (using 128-bit descriptors). Since the currently implementation of 64-bit ADMA2 only supports the SDHC version 4 implementation it is incorrect to check the V3 64-bit capability bit since this will activate V4 ADMA2 on V3 controllers. Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Eugene Cohen --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c b/MdeModule= Pkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c index b474f8d..5bc91c5 100644 --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c @@ -666,8 +666,7 @@ SdMmcPciHcDriverBindingStart ( // If any of the slots does not support 64b system bus // do not enable 64b DMA in the PCI layer. // - if (Private->Capability[Slot].SysBus64V3 =3D=3D 0 && - Private->Capability[Slot].SysBus64V4 =3D=3D 0) { + if (Private->Capability[Slot].SysBus64V4 =3D=3D 0) { Support64BitDma =3D FALSE; } -- 2.7.4