From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=01658f8fdc=abner.chang@hpe.com) Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by groups.io with SMTP; Wed, 18 Sep 2019 20:38:38 -0700 Received: from pps.filterd (m0134422.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8J3b7NI008238; Thu, 19 Sep 2019 03:38:37 GMT Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0b-002e3701.pphosted.com with ESMTP id 2v3vapdbdx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Sep 2019 03:38:37 +0000 Received: from G4W9120.americas.hpqcorp.net (g4w9120.houston.hp.com [16.210.21.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5009.houston.hpe.com (Postfix) with ESMTPS id 94DB351; Thu, 19 Sep 2019 03:38:36 +0000 (UTC) Received: from G4W9119.americas.hpqcorp.net (2002:10d2:14d6::10d2:14d6) by G4W9120.americas.hpqcorp.net (2002:10d2:150f::10d2:150f) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 19 Sep 2019 03:38:36 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (15.241.52.13) by G4W9119.americas.hpqcorp.net (16.210.20.214) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 19 Sep 2019 03:38:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=clAEQpluJyhnAhOLF+tZYYj5ltXXDK2K54VsiYhTy/P+A/dccH0vLlimQXMZ4K7G877MXVe3o5PayfiqeSOd5FIwuwcnp9UHyNYEOrpoZmvj+RN2fJjCT1lLEX5ERePXpM4xi/wilH8VKgPbJB3/1Qe6wjmw8kEVSnQg144p+bXNlZZ8Y0w0GIj8qxXbLBuQqUxrUxLTgbO+1huyb7vffrjZNFaX7a2mPHGIPmzNALVeCt0uPoWyHzdynP5Qa7VeR+ex0ObohiYA6gH5pnQDE51FnnoG02w+yWFULIPKrcgLFJwfSTEB42S6eYs6l5lS/lJOWg2FMX7aIBELuqfTjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6qGmdK0iFmOPjuJusUt5TzwazmQHNJuPqeqCM7UNBQs=; b=Ro67i9+fAJ9ZAOZxiGM7ezpxQ8VRxdMwbzMNzDTHPYCWh1BaVidNlptZiaUYppJZkMgRxxWtFbZkBwqW6+0YGQao/Ncmue+fLENihoYHI6LV+qGz6tSK8CE4wa4+jmEJPXhs9IzZkx9vgpbEoB0rrZrWVmMuVHlEcBIlOtNKLzOs+5vVZs5eoYwTdkqKdqmk0bDp/zmx+G0J+JHoeRkpuJPWJM6M58EjwbXPS68NPHj3HvJY11UKDh9CdOrgm7GQHzfVkKpXm8p9Kb3wzmKIaAdw7oyYp6bZba18uAhmnskT3gEdtHcnaa/rlGf7UZGUHFkQvvDEwiT7GO9g7cAHWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM (10.169.12.151) by CS1PR8401MB0646.NAMPRD84.PROD.OUTLOOK.COM (10.169.97.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.21; Thu, 19 Sep 2019 03:38:35 +0000 Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4fb:84b9:76e6:1cde]) by CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4fb:84b9:76e6:1cde%8]) with mapi id 15.20.2263.023; Thu, 19 Sep 2019 03:38:35 +0000 From: "Abner Chang" To: "Gao, Liming" , "devel@edk2.groups.io" , "leif.lindholm@linaro.org" CC: "Kinney, Michael D" , "Chen, Gilbert" Subject: Re: [edk2-devel] [PATCH] MdePkg:Include: Update SmBios header file Thread-Topic: [edk2-devel] [PATCH] MdePkg:Include: Update SmBios header file Thread-Index: AQHVbSTukZOi0AW+VUycVBRg59KOpqcv3riAgAATX4CAAmo2oA== Date: Thu, 19 Sep 2019 03:38:34 +0000 Message-ID: References: <1568701470-19480-1-git-send-email-abner.chang@hpe.com> <20190917133335.GD28454@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FD801@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FD801@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0d563226-522f-481e-6ffd-08d73cb2d9ae x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:CS1PR8401MB0646; x-ms-traffictypediagnostic: CS1PR8401MB0646: x-ms-exchange-purlcount: 1 x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2582; x-forefront-prvs: 016572D96D x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6029001)(396003)(136003)(376002)(346002)(366004)(39860400002)(199004)(189003)(13464003)(14444005)(102836004)(4326008)(15650500001)(71200400001)(76176011)(11346002)(14454004)(25786009)(7696005)(2201001)(71190400001)(446003)(6116002)(19627235002)(2906002)(54906003)(6436002)(486006)(966005)(5660300002)(6506007)(7736002)(478600001)(9686003)(186003)(256004)(99286004)(26005)(53546011)(74316002)(3846002)(305945005)(476003)(86362001)(110136005)(64756008)(55016002)(52536014)(66946007)(76116006)(316002)(33656002)(81156014)(8936002)(8676002)(81166006)(66446008)(66556008)(66476007)(229853002)(6306002)(66066001)(2501003)(6246003);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR8401MB0646;H:CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 0E2r/copQww/FnejfIFOLBbAIy2HN7xxPG5ZhIBOK5Pc9dn1Vt3B0XPExCPqGQaXOout+A/nIHZe8d30UukvXu6TvwF3KJq8EYEXtLV3P3uAh9YqD0TddRo3rSlnbJk7e6aAShPqacZgknIsWJRHIfmD0YsZyX90VuHVOzbFpyIhzdpOZIkFXw2plZtKs8KArB60lDGU+duwpL5mGAC20v2FWomV8C8GzP8+sSSRI4vC2BQEjj63NYNNjkFhC3lXw29NTim6oMEHlYOn+TDi9VsPpjzyo0KRpYuG5a0VFsV3rpEPbnnWTb4BcNx6ysHqpJEEK8S0AKtbX2pGrFdZplICoMT13rPdWz1ZQ2qwIHXY3iM74fU3qYFrXxnJDr4/Bng/Zyihpri9zJGP9tP6frPKjDdNtQYwyVoi3tt1Ij8= X-MS-Exchange-CrossTenant-Network-Message-Id: 0d563226-522f-481e-6ffd-08d73cb2d9ae X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2019 03:38:34.9427 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kUyPCP2M8g46LPY5PM6SAgtZdhneb3KDwtEWGHbNJJbxTd4QBf3DBhMAaLaVZ/E/Lios5m3xxkDAT2Z6vFNH2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0646 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.70,1.0.8 definitions=2019-09-19_01:2019-09-18,2019-09-19 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 phishscore=0 clxscore=1015 mlxlogscore=999 suspectscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1909190030 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Gao, Liming [mailto:liming.gao@intel.com] > Sent: Tuesday, September 17, 2019 10:43 PM > To: devel@edk2.groups.io; leif.lindholm@linaro.org; Chang, Abner (HPS > SW/FW Technologist) > Cc: Kinney, Michael D ; Chen, Gilbert > > Subject: RE: [edk2-devel] [PATCH] MdePkg:Include: Update SmBios header > file >=20 > Abner: > I add my comments. >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Leif Lindholm > > Sent: Tuesday, September 17, 2019 9:34 PM > > To: Abner Chang > > Cc: devel@edk2.groups.io; Kinney, Michael D > > ; Gao, Liming ; > > Gilbert Chen > > Subject: Re: [edk2-devel] [PATCH] MdePkg:Include: Update SmBios header > > file > > > > On Tue, Sep 17, 2019 at 02:24:30PM +0800, Abner Chang wrote: > > > Update SmBios header file to conform with SMBIOS v3.3.0. > > > > Ah, I note SMBIOS 3.3 has not yet been released - so this can not be > > merged in edk2 master at this point. I did not realise this when I > > requested you send the patch. >=20 > Please submit BZ INVALID URI REMOVED > 3A__bugzilla.tianocore.org_&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2LFWg&r > =3D_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DHg_QWeYnS53nt > pt5iTV5XORHiCtdmH1WwCEMvog8Umk&s=3D9i2dIKluz1GytIz4gy4XCxpphhGm > sO4Rr5vn3dffLGA&e=3D for this update. This is a new feature. Done. ID: 2202 > > > > However, you can carry this in your edk2-staging branch, and once the > > specification gets released we can take it into edk2. > > > > (After code review, a couple of minor comments below.) > > > > > The major update is to add definitions of SMBIOS Type 44h record. > > > > > > Signed-off-by: Abner Chang > > > > > > Cc: Michael D Kinney > > > Cc: Liming Gao > > > Cc: Leif Lindholm > > > Cc: Gilbert Chen > > > > > > --- > > > MdePkg/Include/IndustryStandard/SmBios.h | 74 > > > +++++++++++++++++++++++++++++++- > > > 1 file changed, 72 insertions(+), 2 deletions(-) > > > > > > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h > > > b/MdePkg/Include/IndustryStandard/SmBios.h > > > index f3b6f18..ebf0ceb 100644 > > > --- a/MdePkg/Include/IndustryStandard/SmBios.h > > > +++ b/MdePkg/Include/IndustryStandard/SmBios.h > > > @@ -3,6 +3,7 @@ > > > > > > Copyright (c) 2006 - 2018, Intel Corporation. All rights > > > reserved.
> > > (C) Copyright 2015-2017 Hewlett Packard Enterprise Development > > > LP
> > > +(C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development > > > +LP
> > > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > File header should be updated. >=20 > Industry Standard Definitions of SMBIOS Table Specification v3.2.0. > =3D=3D> > Industry Standard Definitions of SMBIOS Table Specification v3.3.0. >=20 > And, please refer to INVALID URI REMOVED > 3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid- > 3D1099&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN6FZBN4Vgi4Ulks > kz6qU3NYRO03nHp9P7Z5q59A3E&m=3DHg_QWeYnS53ntpt5iTV5XORHiCtdmH1 > WwCEMvog8Umk&s=3DcygMqovZS9Qo_maugU8bx1lvpSIt0jn72VTQfVMtZNA > &e=3D for 3.2 update, prepare all changes for SmBios 3.3 update. >=20 PATCH v2 sent. Thanks Abner > Thanks > Liming > > > > > > **/ > > > @@ -46,7 +47,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > #define SMBIOS_3_0_TABLE_MAX_LENGTH 0xFFFFFFFF > > > > > > // > > > -// SMBIOS type macros which is according to SMBIOS 2.7 specificatio= n. > > > +// SMBIOS type macros which is according to SMBIOS 3.3.0 specificat= ion. > > > // > > > #define SMBIOS_TYPE_BIOS_INFORMATION 0 > > > #define SMBIOS_TYPE_SYSTEM_INFORMATION 1 > > > @@ -92,6 +93,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > #define SMBIOS_TYPE_ONBOARD_DEVICES_EXTENDED_INFORMATION > 41 #define > > > SMBIOS_TYPE_MANAGEMENT_CONTROLLER_HOST_INTERFACE 42 > > > #define SMBIOS_TYPE_TPM_DEVICE 43 > > > +#define SMBIOS_TYPE_PROCESSOR_ADDITIONAL_INFORMATION 44 > > > > > > /// > > > /// Inactive type is added from SMBIOS 2.2. Reference SMBIOS 2.6, > chapter 3.3.43. > > > @@ -727,7 +729,10 @@ typedef enum { > > > ProcessorFamilyMII =3D 0x012E, > > > ProcessorFamilyWinChip =3D 0x0140, > > > ProcessorFamilyDSP =3D 0x015E, > > > - ProcessorFamilyVideoProcessor =3D 0x01F4 > > > + ProcessorFamilyVideoProcessor =3D 0x01F4, > > > + ProcessorFamilyRiscvRV32 =3D 0x0200, ///< SMBIOS spe= c 3.3.0 > added > > > > Please drop the "///< SMBIOS spec 3.3.0 added" comment. Here and > below. > > > > > + ProcessorFamilyRiscVRV64 =3D 0x0201, ///< SMBIOS spe= c 3.3.0 > added > > > + ProcessorFamilyRiscVRV128 =3D 0x0202 ///< SMBIOS spe= c 3.3.0 > added > > > > No further comments from me (MdePkg maintainers may have some). > > > > / > > Leif > > > > > } PROCESSOR_FAMILY2_DATA; > > > > > > /// > > > @@ -857,6 +862,19 @@ typedef struct { } PROCESSOR_FEATURE_FLAGS; > > > > > > typedef struct { > > > + UINT32 ProcessorReserved1 :1; > > > + UINT32 ProcessorUnknown :1; > > > + UINT32 Processor64BitCapble :1; > > > + UINT32 ProcessorMultiCore :1; > > > + UINT32 ProcessorHardwareThread :1; > > > + UINT32 ProcessorExecuteProtection :1; > > > + UINT32 ProcessorEnhancedVirtulization :1; > > > + UINT32 ProcessorPowerPerformanceCtrl :1; > > > + UINT32 Processor128bitCapble :1; > > > + UINT32 ProcessorReserved2 :7; > > > +} PROCESSOR_CHARACTERISTIC_FLAGS; > > > + > > > +typedef struct { > > > PROCESSOR_SIGNATURE Signature; > > > PROCESSOR_FEATURE_FLAGS FeatureFlags; } PROCESSOR_ID_DATA; > @@ > > > -2508,6 +2526,57 @@ typedef struct { > > > UINT8 InterfaceTypeSpecificData[4]; = ///< This field has a > minimum of four bytes > > > } SMBIOS_TABLE_TYPE42; > > > > > > + > > > +/// > > > +/// Processor Specific Block - Processor Architecture Type /// > > > +typedef enum{ > > > + ProcessorSpecificBlockArchTypeReserved =3D 0x00, > > > + ProcessorSpecificBlockArchTypeIa32 =3D 0x01, > > > + ProcessorSpecificBlockArchTypeX64 =3D 0x02, > > > + ProcessorSpecificBlockArchTypeItanium =3D 0x03, > > > + ProcessorSpecificBlockArchTypeAarch32 =3D 0x04, > > > + ProcessorSpecificBlockArchTypeAarch64 =3D 0x05, > > > + ProcessorSpecificBlockArchTypeRiscVRV32 =3D 0x06, > > > + ProcessorSpecificBlockArchTypeRiscVRV64 =3D 0x07, > > > + ProcessorSpecificBlockArchTypeRiscVRV128 =3D 0x08 } > > > +PROCESSOR_SPECIFIC_BLOCK_ARCH_TYPE; > > > + > > > +/// > > > +/// Processor Specific Block is the standard container of processor= - > specific data. > > > +/// > > > +typedef struct { > > > + UINT8 Length; > > > + UINT8 ProcessorArchType; > > > + /// > > > + /// Below followed by Processor-specific data > > > + /// > > > + /// > > > +} PROCESSOR_SPECIFIC_BLOCK; > > > + > > > +/// > > > +/// Processor Additional Information(Type 44). > > > +/// > > > +/// The information in this structure defines the processor > > > +additional information in case /// SMBIOS type 4 is not sufficient = to > describe processor characteristics. > > > +/// The SMBIOS type 44 structure has a reference handle field to > > > +link back to the related /// SMBIOS type 4 structure. There may be > > > +multiple SMBIOS type 44 structures linked to the /// same SMBIOS > > > +type 4 structure. For example, when cores are not identical in a > processor, /// SMBIOS type 44 structures describe different core-specifi= c > information. > > > +/// > > > +/// SMBIOS type 44 defines the standard header for the > > > +processor-specific block, while the /// contents of > > > +processor-specific data are maintained by processor /// architectur= e > workgroups or vendors in separate documents. > > > +/// > > > +typedef struct { > > > + SMBIOS_STRUCTURE Hdr; > > > + SMBIOS_HANDLE RefHandle; ///<= This field refer to > associated SMBIOS type 4 > > > + /// > > > + /// Below followed by Processor-specific block > > > + /// > > > + PROCESSOR_SPECIFIC_BLOCK ProcessorSpecificBlock; > > > +} SMBIOS_TABLE_TYPE44; > > > + > > > /// > > > /// TPM Device (Type 43). > > > /// > > > @@ -2586,6 +2655,7 @@ typedef union { > > > SMBIOS_TABLE_TYPE41 *Type41; > > > SMBIOS_TABLE_TYPE42 *Type42; > > > SMBIOS_TABLE_TYPE43 *Type43; > > > + SMBIOS_TABLE_TYPE44 *Type44; > > > SMBIOS_TABLE_TYPE126 *Type126; > > > SMBIOS_TABLE_TYPE127 *Type127; > > > UINT8 *Raw; > > > -- > > > 2.7.4 > > > > > > >=20