From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=0184f6e87e=abner.chang@hpe.com) Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by groups.io with SMTP; Tue, 08 Oct 2019 01:37:10 -0700 Received: from pps.filterd (m0134423.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x988aMjr002553; Tue, 8 Oct 2019 08:37:09 GMT Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 2vggut5fq3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Oct 2019 08:37:08 +0000 Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id 794F37B; Tue, 8 Oct 2019 08:37:08 +0000 (UTC) Received: from G9W8676.americas.hpqcorp.net (16.220.49.23) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 8 Oct 2019 08:37:05 +0000 Received: from G4W10205.americas.hpqcorp.net (2002:10cf:520f::10cf:520f) by G9W8676.americas.hpqcorp.net (2002:10dc:3117::10dc:3117) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 8 Oct 2019 08:37:05 +0000 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (15.241.52.13) by G4W10205.americas.hpqcorp.net (16.207.82.15) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 8 Oct 2019 08:37:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nvP1j0jGNi6NDZxvF2DRn+7V7jDgh+jnemOoVGLLyrDjNtcUMQrSgKgTuzR92zwlLeLwYnBP434xuasNue+lCD6Cxg5BfCB/C4LfJB5ToyCDoXF5OGpxCGvT7x+8UWr3uzR2ArdLv5Q30h1mInW051N11bTDmPYis9jE9xKvMZd/XhPBOD2Xl/IlhqMBVoODAHCNsqHZzQFOEV4IXsjsyEPcf4ksu1th+9NnD3qv+qBeTrF8TQEZdwBiGsaaE5aiuzeD24T9BgDGgN0OjzgWcG9dfJ0PXIaVEYV5HaSWfjOqsJ7xVkiT0OlgBDOmwSYTLZchfQMVRsXnU5OrLUXf4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3V2auWYHtQjWzpYossKbYj2i9GnAMpXF0//UTy3g7tA=; b=k/PvWejWMzQ9DUMsMUk07TRPZTU6fej2jrQTDCXnSeLBwayskArExKKy9BGkVfWT/xWZ2ATMl4/M1WBHz8sGC01xFo+1rtRfVKJZrGKf8yxuMiRzpYxF9mW6wrUO21wcPy3M6pWGlRBLHMvZl1iRgXFmmBKfUkIwXL+bZPfTR9wRN1V/MqR6vXCnaI8FB/PzJklXXAPFbSW+p4P+2DEhAn7CrdpHRxL/iMunB4j9fGC+tCnE4aMB6mylUwH5y6oWDF7DxhOkfZhaDytO+LcaXz7KWnJLf42hPCzIAPg5cPn/2UeHMtWE9b51WuTIm/tmsI7Gvn2ZOZkAUIuU0g3Asg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM (10.169.12.151) by CS1PR8401MB0808.NAMPRD84.PROD.OUTLOOK.COM (10.169.16.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.25; Tue, 8 Oct 2019 08:37:03 +0000 Received: from CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4fb:84b9:76e6:1cde]) by CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4fb:84b9:76e6:1cde%8]) with mapi id 15.20.2327.025; Tue, 8 Oct 2019 08:37:03 +0000 From: "Abner Chang" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , Leif Lindholm , "Chen, Gilbert" Subject: Re: [edk2-devel] [PATCH v2] MdePkg:Include: Update SmBios header file Thread-Topic: [edk2-devel] [PATCH v2] MdePkg:Include: Update SmBios header file Thread-Index: AQHVbptL2HI/0u75b0el951G9t0oFqcyd0IAgBg1JcCABWHggIAAeyQQ Date: Tue, 8 Oct 2019 08:37:03 +0000 Message-ID: References: <1568862283-31624-1-git-send-email-abner.chang@hpe.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FE58E@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E510BE8@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E510BE8@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1f796cba-72ef-4e57-af33-08d74bcab1de x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: CS1PR8401MB0808: x-ms-exchange-purlcount: 1 x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:612; x-forefront-prvs: 01842C458A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6029001)(396003)(136003)(39860400002)(346002)(366004)(376002)(13464003)(189003)(199004)(7696005)(14454004)(71200400001)(71190400001)(99286004)(110136005)(54906003)(52536014)(74316002)(14444005)(966005)(25786009)(30864003)(26005)(102836004)(6506007)(186003)(53546011)(478600001)(76176011)(8676002)(5660300002)(81166006)(81156014)(316002)(2501003)(15650500001)(8936002)(55016002)(33656002)(446003)(11346002)(66556008)(476003)(486006)(64756008)(66066001)(6306002)(9686003)(7736002)(229853002)(4326008)(6246003)(66476007)(66446008)(6116002)(86362001)(305945005)(6436002)(3846002)(76116006)(2906002)(19627235002)(66946007)(256004)(579004)(44824005);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR8401MB0808;H:CS1PR8401MB1192.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gTbels6YQIrctTbkS5v43GV/bOw2uKgdUrehAEaJBgKXgoAw8YVwU55PzaQ0YGLeke7esF3u/jt3HZYJIGdMLPTJXT0nUvhB0pymqefMJ+78tem92Kl+X8tr8C8GyA6AiE/I3Xh008kFw8yj7TB1a/Lj9Au9W3L1HwLQeZY0Mm1yn3ENvqKTrFn3PshU34gRk7JVddmqpHgttaxUjOaqFoC3bRovDAZkrJkhoL7vZujpfovzi+IINlL2h6LKic/Fx96D0H7YT86wfqpKEhf/9eozJUfxgp17HH3x+jypvubL65+k8H/93PkvO6jJiYUaJRh3J/3fveQLFcgzVA6T4WYaKB1Th001dzOgVqPqsUHXOJfEUA4YPHbqlYADSg+C9myvbCxk+xbplX1ASUg9wJZGsYyHxbvRrgvJg4f0buZfr51PGVbN+6lCaKjE+uqNnu6gOIxGOcqSwi1SnyUx6Q== X-MS-Exchange-CrossTenant-Network-Message-Id: 1f796cba-72ef-4e57-af33-08d74bcab1de X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2019 08:37:03.4183 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lsuHK8KpkalI7q4QCK0SLW/nU3qlgED5IJJPJr3MwLONAPVs1pybEXg0AMXUgeZukXEAu0Dap9gD7SrBlE8ULw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR8401MB0808 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-08_03:2019-10-07,2019-10-08 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxlogscore=999 impostorscore=0 mlxscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 suspectscore=0 bulkscore=0 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1908290000 definitions=main-1910080087 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Liming, [PATCH v5] was sent. I added BZ link in commit message in each patch and reverted the changes o= n PcdSmbiosDocRev. Abner > -----Original Message----- > From: Gao, Liming [mailto:liming.gao@intel.com] > Sent: Tuesday, October 8, 2019 9:15 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Kinney, Michael D ; Leif Lindholm > ; Chen, Gilbert > Subject: RE: [edk2-devel] [PATCH v2] MdePkg:Include: Update SmBios > header file >=20 > Abner: > Thanks for your notice. I see the public SMBIOS 3.3.0. >=20 > For this patch set, I have two minor comments. For other part, Reviewe= d-by: > Liming Gao > 1) Please add BZ: INVALID URI REMOVED > 3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid- > 3D2202&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN6FZBN4Vgi4Ulks > kz6qU3NYRO03nHp9P7Z5q59A3E&m=3DgM5jfUqBhKlNrUmWsg_93sw45gXUq > WoAl7p2YtJ02tE&s=3Da2Q0nhgk7ms0Ik28D2zOF_GH9vpbZHsZzNHGChN0r7k&e > =3D in the commit message. > 2) The comment for gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev > is not required to be changed. > This field is in SMBIOS 3.0 spec. It is not new added one in SMBIOS 3.3. >=20 > Thanks > Liming > >-----Original Message----- > >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > >Abner Chang > >Sent: Friday, October 04, 2019 11:06 PM > >To: Gao, Liming ; devel@edk2.groups.io > >Cc: Kinney, Michael D ; Leif Lindholm > >; Chen, Gilbert > >Subject: Re: [edk2-devel] [PATCH v2] MdePkg:Include: Update SmBios > >header file > > > >Just aware that SMBIOS 3.3.0 is published on DMTF, > >INVALID URI REMOVED > 3A__www.dmtf.org_stand > >ards_smbios&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN6FZBN4V > gi4Ulkskz6qU3 > >NYRO03nHp9P7Z5q59A3E&m=3DgM5jfUqBhKlNrUmWsg_93sw45gXUqWoAl7 > p2YtJ02tE&s=3D0B > >MjpMouuP-2RINBiN0FS-YOe7mwBQp_2VdCMurVQW4&e=3D > > > >The latest version of patch set is PATCH v4, please review it and help > >to push to mainstream if no further comments. Thanks Abner > > > >> -----Original Message----- > >> From: Gao, Liming [mailto:liming.gao@intel.com] > >> Sent: Thursday, September 19, 2019 1:23 PM > >> To: Chang, Abner (HPS SW/FW Technologist) ; > >> devel@edk2.groups.io > >> Cc: Kinney, Michael D ; Leif Lindholm > >> ; Chen, Gilbert > >> Subject: RE: [PATCH v2] MdePkg:Include: Update SmBios header file > >> > >> Abner: > >> Please add BZ URL in the commit message, and separate this patch to > >> three changes. Each one is for each package of MdePkg, MdeModulePkg > >> and ShellPkg. > >> > >> As Leif say, SmBios 3.3 spec is not published. This patch will not > >> be pushed until SmBios 3.3 is published. > >> > >> >-----Original Message----- > >> >From: Abner Chang [mailto:abner.chang@hpe.com] > >> >Sent: Thursday, September 19, 2019 11:05 AM > >> >To: devel@edk2.groups.io > >> >Cc: abner.chang@hpe.com; Kinney, Michael D > >> >; Gao, Liming ; > >> >Leif Lindholm ; Gilbert Chen > >> > > >> >Subject: [PATCH v2] MdePkg:Include: Update SmBios header file > >> > > >> >Update SmBios header file to conform with SMBIOS v3.3.0. > >> >The major update is to add definitions of SMBIOS Type 44h record. > >> > > >> >Signed-off-by: Abner Chang > >> > > >> >Cc: Michael D Kinney > >> >Cc: Liming Gao > >> >Cc: Leif Lindholm > >> >Cc: Gilbert Chen > >> >--- > >> > MdeModulePkg/MdeModulePkg.dec | 6 +- > >> > MdePkg/Include/IndustryStandard/SmBios.h | 76 > >> >+++++++++++++++++++++- > >> > .../SmbiosView/PrintInfo.c | 23 ++++++- > >> > .../SmbiosView/PrintInfo.h | 13 +++- > >> > .../SmbiosView/QueryTable.c | 63 +++++++++++= ++++++- > >> > .../UefiShellDebug1CommandsLib.uni | 3 +- > >> > 6 files changed, 174 insertions(+), 10 deletions(-) > >> > > >> >diff --git a/MdeModulePkg/MdeModulePkg.dec > >> >b/MdeModulePkg/MdeModulePkg.dec index 19935c8..e3a65ab 100644 > >> >--- a/MdeModulePkg/MdeModulePkg.dec > >> >+++ b/MdeModulePkg/MdeModulePkg.dec > >> >@@ -1792,10 +1792,10 @@ > >> > > >> > ## SMBIOS version. > >> > # @Prompt SMBIOS version. > >> >- > >> > >gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0302|UINT16|0 > >> x0 > >> >0010055 > >> >+ > >> > >gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0303|UINT16|0 > >> x0 > >> >0010055 > >> > > >> >- ## SMBIOS Docrev field in SMBIOS 3.0 (64-bit) Entry Point Structu= re. > >> >- # @Prompt SMBIOS Docrev field in SMBIOS 3.0 (64-bit) Entry Point > >> Structure. > >> >+ ## SMBIOS Docrev field in SMBIOS 3.3 (64-bit) Entry Point Structu= re. > >> >+ # @Prompt SMBIOS Docrev field in SMBIOS 3.3 (64-bit) Entry Point > >> >Structure. > >> > > >> > >gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev|0x0|UINT8|0x000 > >1 > >> 00 > >> >6A > >> > > >> > ## SMBIOS produce method. > >> >diff --git a/MdePkg/Include/IndustryStandard/SmBios.h > >> >b/MdePkg/Include/IndustryStandard/SmBios.h > >> >index f3b6f18..f504cc8 100644 > >> >--- a/MdePkg/Include/IndustryStandard/SmBios.h > >> >+++ b/MdePkg/Include/IndustryStandard/SmBios.h > >> >@@ -1,8 +1,9 @@ > >> > /** @file > >> >- Industry Standard Definitions of SMBIOS Table Specification v3.2.= 0. > >> >+ Industry Standard Definitions of SMBIOS Table Specification v3.3.= 0. > >> > > >> > Copyright (c) 2006 - 2018, Intel Corporation. All rights > >> > reserved.
> >> > (C) Copyright 2015-2017 Hewlett Packard Enterprise Development > >> > LP
> >> >+(C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development > >> >+LP
> >> > SPDX-License-Identifier: BSD-2-Clause-Patent > >> > > >> > **/ > >> >@@ -46,7 +47,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > >#define > >> >SMBIOS_3_0_TABLE_MAX_LENGTH 0xFFFFFFFF > >> > > >> > // > >> >-// SMBIOS type macros which is according to SMBIOS 2.7 specificatio= n. > >> >+// SMBIOS type macros which is according to SMBIOS 3.3.0 specificat= ion. > >> > // > >> > #define SMBIOS_TYPE_BIOS_INFORMATION 0 > >> > #define SMBIOS_TYPE_SYSTEM_INFORMATION 1 > >> >@@ -92,6 +93,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > >#define > >> >SMBIOS_TYPE_ONBOARD_DEVICES_EXTENDED_INFORMATION 41 > >#define > >> >SMBIOS_TYPE_MANAGEMENT_CONTROLLER_HOST_INTERFACE 42 > >> > #define SMBIOS_TYPE_TPM_DEVICE 43 > >> >+#define SMBIOS_TYPE_PROCESSOR_ADDITIONAL_INFORMATION 44 > >> > > >> > /// > >> > /// Inactive type is added from SMBIOS 2.2. Reference SMBIOS 2.6, > >> >chapter 3.3.43. > >> >@@ -727,7 +729,10 @@ typedef enum { > >> > ProcessorFamilyMII =3D 0x012E, > >> > ProcessorFamilyWinChip =3D 0x0140, > >> > ProcessorFamilyDSP =3D 0x015E, > >> >- ProcessorFamilyVideoProcessor =3D 0x01F4 > >> >+ ProcessorFamilyVideoProcessor =3D 0x01F4, > >> >+ ProcessorFamilyRiscvRV32 =3D 0x0200, > >> >+ ProcessorFamilyRiscVRV64 =3D 0x0201, > >> >+ ProcessorFamilyRiscVRV128 =3D 0x0202 > >> > } PROCESSOR_FAMILY2_DATA; > >> > > >> > /// > >> >@@ -857,6 +862,19 @@ typedef struct { } PROCESSOR_FEATURE_FLAGS; > >> > > >> > typedef struct { > >> >+ UINT32 ProcessorReserved1 :1; > >> >+ UINT32 ProcessorUnknown :1; > >> >+ UINT32 Processor64BitCapble :1; > >> >+ UINT32 ProcessorMultiCore :1; > >> >+ UINT32 ProcessorHardwareThread :1; > >> >+ UINT32 ProcessorExecuteProtection :1; > >> >+ UINT32 ProcessorEnhancedVirtulization :1; > >> >+ UINT32 ProcessorPowerPerformanceCtrl :1; > >> >+ UINT32 Processor128bitCapble :1; > >> >+ UINT32 ProcessorReserved2 :7; > >> >+} PROCESSOR_CHARACTERISTIC_FLAGS; > >> >+ > >> >+typedef struct { > >> > PROCESSOR_SIGNATURE Signature; > >> > PROCESSOR_FEATURE_FLAGS FeatureFlags; } PROCESSOR_ID_DATA; > >@@ > >> >-2508,6 +2526,57 @@ typedef struct { > >> > UINT8 InterfaceTypeSpecificData[4]; = ///< This field has a > >> >minimum of four bytes > >> > } SMBIOS_TABLE_TYPE42; > >> > > >> >+ > >> >+/// > >> >+/// Processor Specific Block - Processor Architecture Type /// > >> >+typedef enum{ > >> >+ ProcessorSpecificBlockArchTypeReserved =3D 0x00, > >> >+ ProcessorSpecificBlockArchTypeIa32 =3D 0x01, > >> >+ ProcessorSpecificBlockArchTypeX64 =3D 0x02, > >> >+ ProcessorSpecificBlockArchTypeItanium =3D 0x03, > >> >+ ProcessorSpecificBlockArchTypeAarch32 =3D 0x04, > >> >+ ProcessorSpecificBlockArchTypeAarch64 =3D 0x05, > >> >+ ProcessorSpecificBlockArchTypeRiscVRV32 =3D 0x06, > >> >+ ProcessorSpecificBlockArchTypeRiscVRV64 =3D 0x07, > >> >+ ProcessorSpecificBlockArchTypeRiscVRV128 =3D 0x08 } > >> >+PROCESSOR_SPECIFIC_BLOCK_ARCH_TYPE; > >> >+ > >> >+/// > >> >+/// Processor Specific Block is the standard container of > >> >+processor-specific > >> >data. > >> >+/// > >> >+typedef struct { > >> >+ UINT8 Length; > >> >+ UINT8 ProcessorArchType; > >> >+ /// > >> >+ /// Below followed by Processor-specific data > >> >+ /// > >> >+ /// > >> >+} PROCESSOR_SPECIFIC_BLOCK; > >> >+ > >> >+/// > >> >+/// Processor Additional Information(Type 44). > >> >+/// > >> >+/// The information in this structure defines the processor > >> >+additional > >> >information in case > >> >+/// SMBIOS type 4 is not sufficient to describe processor character= istics. > >> >+/// The SMBIOS type 44 structure has a reference handle field to > >> >+link back to > >> >the related > >> >+/// SMBIOS type 4 structure. There may be multiple SMBIOS type 44 > >> >structures linked to the > >> >+/// same SMBIOS type 4 structure. For example, when cores are not > >> >+identical > >> >in a processor, > >> >+/// SMBIOS type 44 structures describe different core-specific > >information. > >> >+/// > >> >+/// SMBIOS type 44 defines the standard header for the > >> >+processor-specific > >> >block, while the > >> >+/// contents of processor-specific data are maintained by processor > >> >+/// architecture workgroups or vendors in separate documents. > >> >+/// > >> >+typedef struct { > >> >+ SMBIOS_STRUCTURE Hdr; > >> >+ SMBIOS_HANDLE RefHandle; ///<= This field refer to > >> >associated SMBIOS type 4 > >> >+ /// > >> >+ /// Below followed by Processor-specific block > >> >+ /// > >> >+ PROCESSOR_SPECIFIC_BLOCK ProcessorSpecificBlock; > >> >+} SMBIOS_TABLE_TYPE44; > >> >+ > >> > /// > >> > /// TPM Device (Type 43). > >> > /// > >> >@@ -2586,6 +2655,7 @@ typedef union { > >> > SMBIOS_TABLE_TYPE41 *Type41; > >> > SMBIOS_TABLE_TYPE42 *Type42; > >> > SMBIOS_TABLE_TYPE43 *Type43; > >> >+ SMBIOS_TABLE_TYPE44 *Type44; > >> > SMBIOS_TABLE_TYPE126 *Type126; > >> > SMBIOS_TABLE_TYPE127 *Type127; > >> > UINT8 *Raw; > >> >diff --git > >> > >a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > >> > >b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > >> >index cfd7a2b..ff0c1db 100644 > >> >--- > >> > >a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > >> >+++ > >> > >b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > >> >@@ -3,7 +3,7 @@ > >> > > >> > Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved= .
> >> > (C) Copyright 2014 Hewlett-Packard Development Company, L.P.
> >> >- (C) Copyright 2015-2017 Hewlett Packard Enterprise Development > >> >LP
> >> >+ (C) Copyright 2015-2019 Hewlett Packard Enterprise Development > >> >+ LP
> >> > SPDX-License-Identifier: BSD-2-Clause-Patent > >> > > >> > **/ > >> >@@ -1169,6 +1169,15 @@ SmbiosPrintStructure ( > >> > break; > >> > > >> > // > >> >+ // Processor Additional Information (Type 44) // case 44: > >> >+ PRINT_STRUCT_VALUE_H (Struct, Type44, RefHandle); > >> >+ PRINT_STRUCT_VALUE_H (Struct, Type44, > >> >ProcessorSpecificBlock.ProcessorArchType); > >> >+ ProcessorArchitectureType (Struct->Type44- > >> >>ProcessorSpecificBlock.ProcessorArchType, Option); > >> >+ break; > >> >+ > >> >+ // > >> > // Inactive (Type 126) > >> > // > >> > case 126: > >> >@@ -2350,6 +2359,18 @@ DisplayProcessorFamily2 ( > >> > Print (L"Video Processor\n"); > >> > break; > >> > > >> >+ case 0x200: > >> >+ Print (L"RISC-V RV32\n"); > >> >+ break; > >> >+ > >> >+ case 0x201: > >> >+ Print (L"RISC-V RV64\n"); > >> >+ break; > >> >+ > >> >+ case 0x202: > >> >+ Print (L"RISC-V RV128\n"); > >> >+ break; > >> >+ > >> > default: > >> > ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN > >> >(STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_PROC_FAMILY), > >> >gShellDebug1HiiHandle); > >> > } > >> >diff --git > >> > >a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo. > >h > >> > >b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo. > >h > >> >index a8c32ab..22f59d6 100644 > >> >--- > >> > >a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo. > >h > >> >+++ > >> > >b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo. > >h > >> >@@ -2,7 +2,7 @@ > >> > Module to clarify the element info of the smbios structure. > >> > > >> > Copyright (c) 2005 - 2015, Intel Corporation. All rights > >> >reserved.
> >> >- (C) Copyright 2017 Hewlett Packard Enterprise Development LP
> >> >+ (C) Copyright 2017 - 2019 Hewlett Packard Enterprise Development > >> >+ LP
> >> > SPDX-License-Identifier: BSD-2-Clause-Patent > >> > > >> > **/ > >> >@@ -427,4 +427,15 @@ DisplayTpmDeviceCharacteristics ( > >> > IN UINT8 Option > >> > ); > >> > > >> >+/** > >> >+ Display Processor Architecture Type (Type 44). > >> >+ > >> >+ @param[in] Type The key of the structure. > >> >+ @param[in] Option The optional information. > >> >+**/ > >> >+VOID > >> >+ProcessorArchitectureType ( > >> >+ IN UINT8 Type, > >> >+ IN UINT8 Option > >> >+ ); > >> > #endif > >> >diff --git > >> > >a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTabl > >> e.c > >> > >b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTabl > >> e.c > >> >index bfb7c3b..54e9a52 100644 > >> >--- > >> > >a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTabl > >> e.c > >> >+++ > >> > >b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTabl > >> e.c > >> >@@ -3,7 +3,7 @@ > >> > And give a interface of query a string out of a table. > >> > > >> > Copyright (c) 2005 - 2018, Intel Corporation. All rights > >> >reserved.
> >> >- (C) Copyright 2016-2017 Hewlett Packard Enterprise Development > >> >LP
> >> >+ (C) Copyright 2016-2019 Hewlett Packard Enterprise Development > >> >+ LP
> >> > SPDX-License-Identifier: BSD-2-Clause-Patent > >> > > >> > **/ > >> >@@ -620,6 +620,10 @@ TABLE_ITEM ProcessorCharacteristicsTable[] =3D= { > >> > { > >> > 7, > >> > L" Power/Performance Control" > >> >+ }, > >> >+ { > >> >+ 8, > >> >+ L" 128-bit Capable" > >> > } > >> > }; > >> > > >> >@@ -3268,6 +3272,44 @@ TABLE_ITEM MCHostInterfaceTypeTable[] =3D { > >> > }, > >> > }; > >> > > >> >+TABLE_ITEM ProcessorArchitectureTypesTable[] =3D { > >> >+ { > >> >+ 0, > >> >+ L" Reserved " > >> >+ }, > >> >+ { > >> >+ 1, > >> >+ L" IA32 (x86) " > >> >+ }, > >> >+ { > >> >+ 2, > >> >+ L" x64 (x86-64, intel64, AMD64, EM64T) " > >> >+ }, > >> >+ { > >> >+ 3, > >> >+ L" Intel Itanium architecture " > >> >+ }, > >> >+ { > >> >+ 4, > >> >+ L" 32-bit ARM (Aarch32) " > >> >+ }, > >> >+ { > >> >+ 5, > >> >+ L" 64-bit ARM (Aarch64) " > >> >+ }, > >> >+ { > >> >+ 6, > >> >+ L" 32-bit RISC-V (RV32) " > >> >+ }, > >> >+ { > >> >+ 7, > >> >+ L" 64-bit RISC-V (RV64) " > >> >+ }, > >> >+ { > >> >+ 8, > >> >+ L" 128-bit RISC-V (RV128) " > >> >+ } > >> >+}; > >> > > >> > TABLE_ITEM StructureTypeInfoTable[] =3D { > >> > { > >> >@@ -3447,6 +3489,10 @@ TABLE_ITEM StructureTypeInfoTable[] =3D { > >> > L" TPM Device" > >> > }, > >> > { > >> >+ 44, > >> >+ L" Processor Additional Information" > >> >+ }, > >> >+ { > >> > 0x7E, > >> > L" Inactive" > >> > }, > >> >@@ -4697,6 +4743,21 @@ DisplayMCHostInterfaceType ( } > >> > > >> > /** > >> >+ Display Processor Architecture Type (Type 44). > >> >+ > >> >+ @param[in] Type The key of the structure. > >> >+ @param[in] Option The optional information. > >> >+**/ > >> >+VOID > >> >+ProcessorArchitectureType ( > >> >+ IN UINT8 Type, > >> >+ IN UINT8 Option > >> >+ ) > >> >+{ > >> >+ PRINT_TABLE_ITEM (ProcessorArchitectureTypesTable, Type); } > >> >+ > >> >+/** > >> > Display the structure type information. > >> > > >> > @param[in] Key The key of the structure. > >> >diff --git > >> > >a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comm > >a > >> nd > >> >sLib.uni > >> > >b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comm > >a > >> n > >> >dsLib.uni > >> >index 42a9295..6693be2 100644 > >> >--- > >> > >a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comm > >a > >> nd > >> >sLib.uni > >> >+++ > >> > >b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comm > >a > >> n > >> >dsLib.uni > >> >@@ -2,7 +2,7 @@ > >> > // > >> > // Copyright (c) 2010 - 2018, Intel Corporation. All rights > >> >reserved.
// (C) Copyright 2013-2015 Hewlett-Packard > >> >Development Company, L.P.
-// (C) Copyright 2016 Hewlett Packard > >> >Enterprise Development LP
> >> >+// (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development > >> >+LP
> >> > // SPDX-License-Identifier: BSD-2-Clause-Patent // // Module Name= : > >> >@@ -976,6 +976,7 @@ > >> > " 41 - Onboard Devices Extended Information\r\n" > >> > " 42 - Management Controller Host Interface\r\n" > >> > " 43 - TPM Device\r\n" > >> >+" 44 - Processor Additional Information\r\n" > >> > " 2. Enter the SmbiosHandle parameter in hexadecimal format.\r\n" > >> > " Do not use the '0x' prefix format for hexadecimal values.\r\n= " > >> > " 3. Internal commands:\r\n" > >> >-- > >> >2.7.4 > > > > > >